CRWWebControllerNativeContentTest.NativeContentURL crashes with WKBasedNavigationManager |
|||
Issue descriptionThe crash is due to a nullptr access on navigationManager.GetLastCommittedItem() on line 672: https://cs.chromium.org/chromium/src/ios/web/web_state/ui/crw_web_controller_unittest.mm?l=672 The test loads a native URL on line 662. It should wait for the load to finish now because with WKBasedNavigationManager, native URL load is now asynchronous. This is very similar to crbug.com/775645 .
,
Oct 26 2017
Turns out this is not similar to crbug.com/775645 after all. The fix here is to wait for the navigation to finish and assert later.
,
Oct 30 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/449262de3deed2091f6f4a02768b45d126ba3d41 commit 449262de3deed2091f6f4a02768b45d126ba3d41 Author: Danyao Wang <danyao@chromium.org> Date: Mon Oct 30 16:50:44 2017 [Nav Experiment] Fix NativeContent unit test to wait after load. With WKBasedNavigationManager, native URLs are loaded asynchronously. Added WebStateObserver to wait for load to finish before asserting in tests. Bug: 776467 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I2d0da5770ea09988a57e9af3e3561d1dc5bd3ebf Reviewed-on: https://chromium-review.googlesource.com/740370 Commit-Queue: Danyao Wang <danyao@chromium.org> Reviewed-by: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#512519} [modify] https://crrev.com/449262de3deed2091f6f4a02768b45d126ba3d41/ios/web/web_state/ui/crw_web_controller_unittest.mm
,
Oct 30 2017
|
|||
►
Sign in to add a comment |
|||
Comment 1 by danyao@chromium.org
, Oct 26 2017Status: Assigned (was: Available)