The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/815b7fc66c967320153a74d447db77fbd6efceb7

commit 815b7fc66c967320153a74d447db77fbd6efceb7
Author: Wenzhao Zang <wzang@chromium.org>
Date: Tue Oct 24 01:30:19 2017

wallpaper refactor: Combine WallpaperManager and WallpaperManagerBase

Purely moving code, did not add/delete anything.

The next steps are:
1) Separate the client-facing functions into a Mojo interface. (They
are listed together and rank first in wallpaper_manager.h)

2) For non-chrome dependent functions, we could move them to
WallpaperController first, and start the refactoring from there.

3) For Chrome-dependent functions, we could break the logic into either
chrome or ash.

TBR=thestig@chromium.org

Bug:  776464 
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: Ic3cde20676a6cef80ba6bf97d9507e304b05b298
Reviewed-on: https://chromium-review.googlesource.com/727569
Reviewed-by: Wenzhao (Colin) Zang <wzang@chromium.org>
Reviewed-by: Xiaoqian Dai <xdai@chromium.org>
Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510991}
[modify] https://crrev.com/815b7fc66c967320153a74d447db77fbd6efceb7/ash/wallpaper/wallpaper_controller.cc
[modify] https://crrev.com/815b7fc66c967320153a74d447db77fbd6efceb7/chrome/browser/chromeos/arc/wallpaper/arc_wallpaper_service_unittest.cc
[modify] https://crrev.com/815b7fc66c967320153a74d447db77fbd6efceb7/chrome/browser/chromeos/chrome_browser_main_chromeos.cc
[modify] https://crrev.com/815b7fc66c967320153a74d447db77fbd6efceb7/chrome/browser/chromeos/extensions/wallpaper_api.cc
[modify] https://crrev.com/815b7fc66c967320153a74d447db77fbd6efceb7/chrome/browser/chromeos/extensions/wallpaper_private_api.cc
[modify] https://crrev.com/815b7fc66c967320153a74d447db77fbd6efceb7/chrome/browser/chromeos/login/users/wallpaper/wallpaper_manager.cc
[modify] https://crrev.com/815b7fc66c967320153a74d447db77fbd6efceb7/chrome/browser/chromeos/login/users/wallpaper/wallpaper_manager.h
[modify] https://crrev.com/815b7fc66c967320153a74d447db77fbd6efceb7/chrome/browser/chromeos/login/users/wallpaper/wallpaper_manager_browsertest.cc
[modify] https://crrev.com/815b7fc66c967320153a74d447db77fbd6efceb7/components/wallpaper/BUILD.gn
[modify] https://crrev.com/815b7fc66c967320153a74d447db77fbd6efceb7/components/wallpaper/DEPS
[delete] https://crrev.com/85243a8ce7a2916d0429fe37fe9a5801c590fb13/components/wallpaper/wallpaper_manager_base.cc
[delete] https://crrev.com/85243a8ce7a2916d0429fe37fe9a5801c590fb13/components/wallpaper/wallpaper_manager_base.h

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a94878fbc6ac534d837b493f3fcb8801214e2d8f

commit a94878fbc6ac534d837b493f3fcb8801214e2d8f
Author: Wenzhao Zang <wzang@chromium.org>
Date: Tue Feb 13 21:45:37 2018

wallpaper refactoring: Deprecate WallpaperManager

WallpaperManager only contains dead code at this point.

Also remove |wallpaper_manager_test_utils.h/cc|, and move the utility
functions to |customization_wallpaper_downloader_browsertest.cc|
because it's the only place using them.

|wallpaper_manager_policy_browsertest.cc| will be deprecated in another
CL.

TBR=sky@chromium.org

Bug:  776464 
Change-Id: I9bfc9007674bbc34e5736c6661656bddf3e41f5a
Reviewed-on: https://chromium-review.googlesource.com/851841
Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org>
Reviewed-by: Wenzhao (Colin) Zang <wzang@chromium.org>
Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Cr-Commit-Position: refs/heads/master@{#536491}
[modify] https://crrev.com/a94878fbc6ac534d837b493f3fcb8801214e2d8f/chrome/browser/chromeos/BUILD.gn
[modify] https://crrev.com/a94878fbc6ac534d837b493f3fcb8801214e2d8f/chrome/browser/chromeos/arc/arc_session_manager_unittest.cc
[modify] https://crrev.com/a94878fbc6ac534d837b493f3fcb8801214e2d8f/chrome/browser/chromeos/arc/arc_util_unittest.cc
[modify] https://crrev.com/a94878fbc6ac534d837b493f3fcb8801214e2d8f/chrome/browser/chromeos/arc/wallpaper/arc_wallpaper_service.cc
[modify] https://crrev.com/a94878fbc6ac534d837b493f3fcb8801214e2d8f/chrome/browser/chromeos/arc/wallpaper/arc_wallpaper_service_unittest.cc
[modify] https://crrev.com/a94878fbc6ac534d837b493f3fcb8801214e2d8f/chrome/browser/chromeos/background/ash_wallpaper_delegate.cc
[modify] https://crrev.com/a94878fbc6ac534d837b493f3fcb8801214e2d8f/chrome/browser/chromeos/chrome_browser_main_chromeos.cc
[modify] https://crrev.com/a94878fbc6ac534d837b493f3fcb8801214e2d8f/chrome/browser/chromeos/customization/customization_document.cc
[modify] https://crrev.com/a94878fbc6ac534d837b493f3fcb8801214e2d8f/chrome/browser/chromeos/customization/customization_wallpaper_downloader_browsertest.cc
[modify] https://crrev.com/a94878fbc6ac534d837b493f3fcb8801214e2d8f/chrome/browser/chromeos/extensions/wallpaper_api.cc
[modify] https://crrev.com/a94878fbc6ac534d837b493f3fcb8801214e2d8f/chrome/browser/chromeos/extensions/wallpaper_function_base.cc
[modify] https://crrev.com/a94878fbc6ac534d837b493f3fcb8801214e2d8f/chrome/browser/chromeos/extensions/wallpaper_function_base.h
[modify] https://crrev.com/a94878fbc6ac534d837b493f3fcb8801214e2d8f/chrome/browser/chromeos/extensions/wallpaper_private_api.cc
[modify] https://crrev.com/a94878fbc6ac534d837b493f3fcb8801214e2d8f/chrome/browser/chromeos/extensions/wallpaper_private_api.h
[modify] https://crrev.com/a94878fbc6ac534d837b493f3fcb8801214e2d8f/chrome/browser/chromeos/extensions/wallpaper_private_api_unittest.cc
[modify] https://crrev.com/a94878fbc6ac534d837b493f3fcb8801214e2d8f/chrome/browser/chromeos/login/users/user_manager_unittest.cc
[delete] https://crrev.com/8d28bd83396d22124b7c6d7b0b16e3df81410e35/chrome/browser/chromeos/login/users/wallpaper/wallpaper_manager.cc
[delete] https://crrev.com/8d28bd83396d22124b7c6d7b0b16e3df81410e35/chrome/browser/chromeos/login/users/wallpaper/wallpaper_manager.h
[modify] https://crrev.com/a94878fbc6ac534d837b493f3fcb8801214e2d8f/chrome/browser/chromeos/login/users/wallpaper/wallpaper_manager_policy_browsertest.cc
[delete] https://crrev.com/8d28bd83396d22124b7c6d7b0b16e3df81410e35/chrome/browser/chromeos/login/users/wallpaper/wallpaper_manager_test_utils.cc
[delete] https://crrev.com/8d28bd83396d22124b7c6d7b0b16e3df81410e35/chrome/browser/chromeos/login/users/wallpaper/wallpaper_manager_test_utils.h
[modify] https://crrev.com/a94878fbc6ac534d837b493f3fcb8801214e2d8f/chrome/browser/extensions/active_tab_unittest.cc
[modify] https://crrev.com/a94878fbc6ac534d837b493f3fcb8801214e2d8f/chrome/browser/media/webrtc/tab_desktop_media_list_unittest.cc
[modify] https://crrev.com/a94878fbc6ac534d837b493f3fcb8801214e2d8f/chrome/browser/prefs/browser_prefs.cc
[modify] https://crrev.com/a94878fbc6ac534d837b493f3fcb8801214e2d8f/chrome/browser/profiles/profile_manager_unittest.cc
[modify] https://crrev.com/a94878fbc6ac534d837b493f3fcb8801214e2d8f/chrome/browser/ui/ash/launcher/chrome_launcher_controller_unittest.cc
[modify] https://crrev.com/a94878fbc6ac534d837b493f3fcb8801214e2d8f/chrome/browser/ui/ash/multi_user/multi_user_window_manager_chromeos_unittest.cc
[modify] https://crrev.com/a94878fbc6ac534d837b493f3fcb8801214e2d8f/chrome/browser/ui/browser_finder_chromeos_unittest.cc
[modify] https://crrev.com/a94878fbc6ac534d837b493f3fcb8801214e2d8f/chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc
[modify] https://crrev.com/a94878fbc6ac534d837b493f3fcb8801214e2d8f/chrome/browser/ui/webui/chromeos/login/signin_userlist_unittest.cc
[modify] https://crrev.com/a94878fbc6ac534d837b493f3fcb8801214e2d8f/chrome/test/BUILD.gn

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b96897b4ce5a14d4a46ad0defe5068fcefae0df8

commit b96897b4ce5a14d4a46ad0defe5068fcefae0df8
Author: Wenzhao Zang <wzang@chromium.org>
Date: Thu Mar 22 19:30:15 2018

cros: Move //components/wallpaper to //ash/wallpaper/wallpaper_utils

After the refactoring, //components/wallpaper only contains utility
functions used by //ash/wallpaper, so it makes sense to move them under
//ash for code health.

In addition:
1) Create wallpaper_types.h under //ash/public. This file will be the
   only allowed wallpaper dependency in //chrome.
2) WallpaperFilesId class is exactly the same with a std::string, so
   it's deprecated.

Bug:  776464 
Change-Id: I8beb0cc94948d655a8eb5fe5a895647719aaaefc
Reviewed-on: https://chromium-review.googlesource.com/967867
Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org>
Reviewed-by: Will Harris <wfh@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Xiaoqian Dai <xdai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#545201}
[modify] https://crrev.com/b96897b4ce5a14d4a46ad0defe5068fcefae0df8/ash/BUILD.gn
[modify] https://crrev.com/b96897b4ce5a14d4a46ad0defe5068fcefae0df8/ash/accelerators/debug_commands.cc
[modify] https://crrev.com/b96897b4ce5a14d4a46ad0defe5068fcefae0df8/ash/public/cpp/BUILD.gn
[modify] https://crrev.com/b96897b4ce5a14d4a46ad0defe5068fcefae0df8/ash/public/cpp/wallpaper_struct_traits.h
[rename] https://crrev.com/b96897b4ce5a14d4a46ad0defe5068fcefae0df8/ash/public/cpp/wallpaper_types.h
[modify] https://crrev.com/b96897b4ce5a14d4a46ad0defe5068fcefae0df8/ash/public/interfaces/wallpaper.mojom
[modify] https://crrev.com/b96897b4ce5a14d4a46ad0defe5068fcefae0df8/ash/public/interfaces/wallpaper.typemap
[modify] https://crrev.com/b96897b4ce5a14d4a46ad0defe5068fcefae0df8/ash/wallpaper/DEPS
[modify] https://crrev.com/b96897b4ce5a14d4a46ad0defe5068fcefae0df8/ash/wallpaper/wallpaper_controller.cc
[modify] https://crrev.com/b96897b4ce5a14d4a46ad0defe5068fcefae0df8/ash/wallpaper/wallpaper_controller.h
[modify] https://crrev.com/b96897b4ce5a14d4a46ad0defe5068fcefae0df8/ash/wallpaper/wallpaper_controller_test_api.cc
[modify] https://crrev.com/b96897b4ce5a14d4a46ad0defe5068fcefae0df8/ash/wallpaper/wallpaper_controller_unittest.cc
[delete] https://crrev.com/827225bb7a05daa16d81e3d523cec30415281eb9/ash/wallpaper/wallpaper_decoder.h
[add] https://crrev.com/b96897b4ce5a14d4a46ad0defe5068fcefae0df8/ash/wallpaper/wallpaper_info.h
[rename] https://crrev.com/b96897b4ce5a14d4a46ad0defe5068fcefae0df8/ash/wallpaper/wallpaper_utils/wallpaper_color_calculator.cc
[rename] https://crrev.com/b96897b4ce5a14d4a46ad0defe5068fcefae0df8/ash/wallpaper/wallpaper_utils/wallpaper_color_calculator.h
[add] https://crrev.com/b96897b4ce5a14d4a46ad0defe5068fcefae0df8/ash/wallpaper/wallpaper_utils/wallpaper_color_calculator_observer.h
[rename] https://crrev.com/b96897b4ce5a14d4a46ad0defe5068fcefae0df8/ash/wallpaper/wallpaper_utils/wallpaper_color_calculator_unittest.cc
[rename] https://crrev.com/b96897b4ce5a14d4a46ad0defe5068fcefae0df8/ash/wallpaper/wallpaper_utils/wallpaper_color_extraction_result.h
[rename] https://crrev.com/b96897b4ce5a14d4a46ad0defe5068fcefae0df8/ash/wallpaper/wallpaper_utils/wallpaper_decoder.cc
[add] https://crrev.com/b96897b4ce5a14d4a46ad0defe5068fcefae0df8/ash/wallpaper/wallpaper_utils/wallpaper_decoder.h
[rename] https://crrev.com/b96897b4ce5a14d4a46ad0defe5068fcefae0df8/ash/wallpaper/wallpaper_utils/wallpaper_resizer.cc
[rename] https://crrev.com/b96897b4ce5a14d4a46ad0defe5068fcefae0df8/ash/wallpaper/wallpaper_utils/wallpaper_resizer.h
[add] https://crrev.com/b96897b4ce5a14d4a46ad0defe5068fcefae0df8/ash/wallpaper/wallpaper_utils/wallpaper_resizer_observer.h
[rename] https://crrev.com/b96897b4ce5a14d4a46ad0defe5068fcefae0df8/ash/wallpaper/wallpaper_utils/wallpaper_resizer_unittest.cc
[modify] https://crrev.com/b96897b4ce5a14d4a46ad0defe5068fcefae0df8/ash/wallpaper/wallpaper_view.cc
[modify] https://crrev.com/b96897b4ce5a14d4a46ad0defe5068fcefae0df8/build/check_gn_headers_whitelist.txt
[modify] https://crrev.com/b96897b4ce5a14d4a46ad0defe5068fcefae0df8/chrome/browser/chromeos/BUILD.gn
[modify] https://crrev.com/b96897b4ce5a14d4a46ad0defe5068fcefae0df8/chrome/browser/chromeos/DEPS
[modify] https://crrev.com/b96897b4ce5a14d4a46ad0defe5068fcefae0df8/chrome/browser/chromeos/arc/wallpaper/arc_wallpaper_service.cc
[modify] https://crrev.com/b96897b4ce5a14d4a46ad0defe5068fcefae0df8/chrome/browser/chromeos/customization/customization_wallpaper_util.cc
[modify] https://crrev.com/b96897b4ce5a14d4a46ad0defe5068fcefae0df8/chrome/browser/chromeos/extensions/DEPS
[modify] https://crrev.com/b96897b4ce5a14d4a46ad0defe5068fcefae0df8/chrome/browser/chromeos/extensions/wallpaper_api.cc
[modify] https://crrev.com/b96897b4ce5a14d4a46ad0defe5068fcefae0df8/chrome/browser/chromeos/extensions/wallpaper_api.h
[modify] https://crrev.com/b96897b4ce5a14d4a46ad0defe5068fcefae0df8/chrome/browser/chromeos/extensions/wallpaper_function_base.cc
[modify] https://crrev.com/b96897b4ce5a14d4a46ad0defe5068fcefae0df8/chrome/browser/chromeos/extensions/wallpaper_function_base.h
[modify] https://crrev.com/b96897b4ce5a14d4a46ad0defe5068fcefae0df8/chrome/browser/chromeos/extensions/wallpaper_private_api.cc
[modify] https://crrev.com/b96897b4ce5a14d4a46ad0defe5068fcefae0df8/chrome/browser/chromeos/extensions/wallpaper_private_api.h
[modify] https://crrev.com/b96897b4ce5a14d4a46ad0defe5068fcefae0df8/chrome/browser/chromeos/login/DEPS
[modify] https://crrev.com/b96897b4ce5a14d4a46ad0defe5068fcefae0df8/chrome/browser/chromeos/login/users/wallpaper/wallpaper_manager_policy_browsertest.cc
[modify] https://crrev.com/b96897b4ce5a14d4a46ad0defe5068fcefae0df8/chrome/browser/ui/ash/test_wallpaper_controller.cc
[modify] https://crrev.com/b96897b4ce5a14d4a46ad0defe5068fcefae0df8/chrome/browser/ui/ash/test_wallpaper_controller.h
[modify] https://crrev.com/b96897b4ce5a14d4a46ad0defe5068fcefae0df8/chrome/browser/ui/ash/wallpaper_controller_client.cc
[modify] https://crrev.com/b96897b4ce5a14d4a46ad0defe5068fcefae0df8/chrome/browser/ui/ash/wallpaper_controller_client.h
[modify] https://crrev.com/b96897b4ce5a14d4a46ad0defe5068fcefae0df8/components/BUILD.gn
[delete] https://crrev.com/827225bb7a05daa16d81e3d523cec30415281eb9/components/wallpaper/BUILD.gn
[delete] https://crrev.com/827225bb7a05daa16d81e3d523cec30415281eb9/components/wallpaper/DEPS
[delete] https://crrev.com/827225bb7a05daa16d81e3d523cec30415281eb9/components/wallpaper/OWNERS
[delete] https://crrev.com/827225bb7a05daa16d81e3d523cec30415281eb9/components/wallpaper/wallpaper_color_calculator_observer.h
[delete] https://crrev.com/827225bb7a05daa16d81e3d523cec30415281eb9/components/wallpaper/wallpaper_color_profile.h
[delete] https://crrev.com/827225bb7a05daa16d81e3d523cec30415281eb9/components/wallpaper/wallpaper_export.h
[delete] https://crrev.com/827225bb7a05daa16d81e3d523cec30415281eb9/components/wallpaper/wallpaper_files_id.cc
[delete] https://crrev.com/827225bb7a05daa16d81e3d523cec30415281eb9/components/wallpaper/wallpaper_files_id.h
[delete] https://crrev.com/827225bb7a05daa16d81e3d523cec30415281eb9/components/wallpaper/wallpaper_resizer_observer.h
[modify] https://crrev.com/b96897b4ce5a14d4a46ad0defe5068fcefae0df8/ui/app_list/BUILD.gn
[modify] https://crrev.com/b96897b4ce5a14d4a46ad0defe5068fcefae0df8/ui/app_list/DEPS
[modify] https://crrev.com/b96897b4ce5a14d4a46ad0defe5068fcefae0df8/ui/app_list/views/app_list_view.cc
[modify] https://crrev.com/b96897b4ce5a14d4a46ad0defe5068fcefae0df8/ui/app_list/views/search_box_view.cc

Update:
1) All wallpaper-related tasks in go/mustash-chrome-ash-progress are completed.
2) components/wallpaper/ is moved to //ash. //c/b/chromeos/login/users/wallpaper/ is removed.
3) All wallpaper delegates are removed.

So this can be closed with  issue 557405 .

FYI the following components remain in //chrome intentionally. Their //ash dependencies other than //ash/public are removed:

1) The wallpaper app.
2) The downloaders for device policy/customized default wallpapers.

There'll be some additional clean-up work but they are wallpaper implementation details and not related to mustash:

1) Clean up legacy code for old wallpaper picker after the new one is enabled by default.
2) Split wallpaper_controller.cc|h into smaller files.

Woo hoo! Thanks for making this happen!