New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 776451 link

Starred by 2 users

Issue metadata

Status: Assigned
Owner:
(OOO slow)
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug

Blocking:
issue 776156



Sign in to add a comment

[TTS] Experiment with suppressing Taps near the bottom of the screen

Project Member Reported by donnd@google.com, Oct 19 2017

Issue description

It looks like Taps in the very bottom of the screen have a higher CTR than expected.  We thought that this section would have low CTR, but Ranker model development suggests that it has a high CTR.  We think this is because gestures at the bottom of the screen might trigger the feature AND OPEN the panel (both accidentally).  This is problematic for our modeling, since we're trying to optimize CTR, and also for users.

One simple way to deal with this is to have an experiment that suppresses Tap (and maybe also Long-press gestures) at the very bottom of the screen.  

It's not clear if we can gather any meaningful metrics to base a full rollout decision.  Maybe we can look for an overall decline in Search activity that appears to be low-quality, or look at the duration of the panel being open.

Another option is to just suppress at the bottom as part of the rollout of Tap Suppression in general.
 

Comment 1 by donnd@google.com, Oct 19 2017

Labels: -Pri-3 Pri-2
This is taps that within the bottom 56dp of the screen? How much higher is the CTR?

For meaningful metrics, +1 to looking at duration of the panel being open. We could record a separate histogram for this when the tap is near the bottom of the screen and compare it to our overall histogram tracking this data. If the average time is significantly less, that would definitely point toward accidental opens.

Comment 3 by donnd@google.com, Nov 3 2017

Blocking: 776156
Project Member

Comment 4 by bugdroid1@chromium.org, Nov 8 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a29d177052a8a73d18c357333f1d791beee7bd01

commit a29d177052a8a73d18c357333f1d791beee7bd01
Author: Donn Denman <donnd@google.com>
Date: Wed Nov 08 21:58:20 2017

[TTS] Add duration histograms for bottom Taps.

Adds a histogram to record how long the panel was in view when the user
triggered it by tapping on the part of the screen where the Bar shows,
and a counterfactual histogram for the rest of the screen.

Updated ContextualSearchHeuristic#logResultsSeen to include the duration
that the panel was in view for heuristics wants to log that too.

Suppression of taps that overlap the Bar was already supported.

BUG=776451

Change-Id: I74286070b498ac069b96b29b45115aa8afa18604
Reviewed-on: https://chromium-review.googlesource.com/754325
Reviewed-by: Theresa <twellington@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Commit-Queue: Donn Denman <donnd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#514955}
[modify] https://crrev.com/a29d177052a8a73d18c357333f1d791beee7bd01/chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/contextualsearch/ContextualSearchPanelMetrics.java
[modify] https://crrev.com/a29d177052a8a73d18c357333f1d791beee7bd01/chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/BarOverlapTapSuppression.java
[modify] https://crrev.com/a29d177052a8a73d18c357333f1d791beee7bd01/chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchHeuristic.java
[modify] https://crrev.com/a29d177052a8a73d18c357333f1d791beee7bd01/chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchHeuristics.java
[modify] https://crrev.com/a29d177052a8a73d18c357333f1d791beee7bd01/chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchUma.java
[modify] https://crrev.com/a29d177052a8a73d18c357333f1d791beee7bd01/chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/TapSuppressionHeuristics.java
[modify] https://crrev.com/a29d177052a8a73d18c357333f1d791beee7bd01/tools/metrics/histograms/histograms.xml

Comment 5 by donnd@google.com, Dec 5 2017

Labels: -M-64 M-65
Project Member

Comment 6 by bugdroid1@chromium.org, Dec 20 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/458422feecd89c3633c17303a9584297f0f8921e

commit 458422feecd89c3633c17303a9584297f0f8921e
Author: Donn Denman <donnd@google.com>
Date: Wed Dec 20 21:35:16 2017

[TTS] Update fieldtrial config for IPH and ML.

Updates the fieldtrial_testing_config to reflect the latest IPH
and ML settings.  Specifically we remove the In-Product-Help
setting for OptIn (not supported by code) and update the params
for the other IPH scenarios to reflect our Dev config.

Enables suppression of any tap gesture at the bottom section of
the screen where it would overlap with the Bar.  This should help
with gathering training data for ML Tap Suppression.

BUG=776451

Change-Id: I7675cf664c6c95e0a86a234ea44ff9313a36cbc2
Reviewed-on: https://chromium-review.googlesource.com/834872
Reviewed-by: Mark Pearson <mpearson@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: Donn Denman <donnd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#525467}
[modify] https://crrev.com/458422feecd89c3633c17303a9584297f0f8921e/testing/variations/fieldtrial_testing_config.json

Project Member

Comment 7 by bugdroid1@chromium.org, Apr 18 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/022164a314058d61655a1aaafed9762c9cfd3a82

commit 022164a314058d61655a1aaafed9762c9cfd3a82
Author: Donn Denman <donnd@google.com>
Date: Wed Apr 18 22:16:42 2018

[TTS] Fix the naming of two uma histograms.

Fixes a mismatch in the names of two histograms and what we're
recording.  Introduced in CL
https://chromium-review.googlesource.com/c/chromium/src/+/754325.

BUG=776451

Change-Id: I3f2b50213f5b9360a6e5e2d57b8313db9cbe0f3f
Reviewed-on: https://chromium-review.googlesource.com/1017230
Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: Donn Denman <donnd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551848}
[modify] https://crrev.com/022164a314058d61655a1aaafed9762c9cfd3a82/chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchUma.java

Sign in to add a comment