CRWWebControllerTest.CurrentUrlWithTrustLevel fails with WKBasedNavigationManager |
||
Issue descriptionThis test calls |-webView:didCommitNavigation| explicitly on a mock web view that doesn't have back-forward history mocked out. [1085:1027:1019/135939.654366:1482881300712150:FATAL:wk_based_navigation_manager_impl.mm(38)] Check failed: wk_item. 0 ios_web_unittests 0x00000001099cf82d base::debug::StackTrace::StackTrace(unsigned long) + 157 1 ios_web_unittests 0x00000001099cf86d base::debug::StackTrace::StackTrace(unsigned long) + 29 2 ios_web_unittests 0x00000001099cdd8c base::debug::StackTrace::StackTrace() + 28 3 ios_web_unittests 0x0000000109a2891f logging::LogMessage::~LogMessage() + 479 4 ios_web_unittests 0x0000000109a26475 logging::LogMessage::~LogMessage() + 21 5 ios_web_unittests 0x000000010954fcc4 (anonymous namespace)::SetNavigationItemInWKItem(WKBackForwardListItem*, std::__1::unique_ptr<web::NavigationItemImpl, std::__1::default_delete<web::NavigationItemImpl> >) + 276 6 ios_web_unittests 0x00000001095504de web::WKBasedNavigationManagerImpl::CommitPendingItem() + 830 7 ios_web_unittests 0x00000001095d08a4 -[CRWWebController didStartLoadingURL:] + 196 8 ios_web_unittests 0x00000001095d068d -[CRWWebController webPageChanged] + 621 9 ios_web_unittests 0x00000001095e777d -[CRWWebController webView:didCommitNavigation:] + 3453 10 ios_web_unittests 0x00000001093795f2 web::CRWWebControllerTest_CurrentUrlWithTrustLevel_Test::TestBody() + 978
,
Oct 30 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f4cba3dd9985d02aa25c9553b58fe140f3d54205 commit f4cba3dd9985d02aa25c9553b58fe140f3d54205 Author: Danyao Wang <danyao@chromium.org> Date: Mon Oct 30 15:24:12 2017 [Nav Experiment] Fix mock to correctly simulate a page load. CRWWebControllerTest.CurrentUrlWithTrustLevel simulates a page load using mock_web_view_ by calling WKNavigationDelegate methods directly. New WKBasedNavigationManager expects the WKBackForwardList to have been updated when |-webView:didCommitNavigation:| is called. Added this missing setup fixes the broken test. Bug: 776450 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I01a13fc4c21a0a64a067a4e542f27b0a9492d02c Reviewed-on: https://chromium-review.googlesource.com/742126 Commit-Queue: Danyao Wang <danyao@chromium.org> Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#512499} [modify] https://crrev.com/f4cba3dd9985d02aa25c9553b58fe140f3d54205/ios/web/BUILD.gn [modify] https://crrev.com/f4cba3dd9985d02aa25c9553b58fe140f3d54205/ios/web/web_state/ui/crw_web_controller_unittest.mm
,
Oct 30 2017
|
||
►
Sign in to add a comment |
||
Comment 1 by danyao@chromium.org
, Oct 27 2017Status: Started (was: Available)