New issue
Advanced search Search tips

Issue 776432 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

No longer possible to see last 200 results on Milo pages for a perf bot

Project Member Reported by charliea@chromium.org, Oct 19 2017

Issue description

Steps to reproduce:

1) Go to a perf bot run page (e.g. https://luci-milo.appspot.com/buildbot/chromium.perf/Mac%20Retina%20Perf/)
2) At the bottom of the page, click Show > 200 to see the last 200 runs.

EXPECTED: You see a version of the page that you just saw, but with 200 runs instead of 25.

ACTUAL: You get a timeout (picture attached)
 
8L0EahjmjiZ.png
26.2 KB View Download
Labels: -Pri-3 Pri-1
Escalating to P1 because this is preventing us from identifying revision ranges for perf failures that we might otherwise be able to still bisect on.

Comment 2 by no...@chromium.org, Oct 19 2017

Owner: no...@chromium.org
Status: Started (was: Untriaged)
Labels: -Pri-1 Pri-2
Deprioritizing to P2 because I'm an idiot and we can just choose "50" and hit next a few times. Still annoying though.

Comment 4 by hinoka@chromium.org, Oct 19 2017

good news and bad news.  bad news is, this is a design issue and requires some architectural change to Milo to fix (Load build summaries instead of full builds on the builder page).  good news, we're already working on this, with ETAs in the coming weeks.
Project Member

Comment 5 by bugdroid1@chromium.org, Oct 19 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/luci/luci-go.git/+/25faa7dc553979a93d47ade0b62f79160758711a

commit 25faa7dc553979a93d47ade0b62f79160758711a
Author: Nodir Turakulov <nodir@google.com>
Date: Thu Oct 19 18:40:09 2017

[milo] add default request timeouts

Also delete some dead code.

Bug:  776432 
Change-Id: I270118b59c6a9469f5f95a2e8d5eccb86c3d3d6c
Reviewed-on: https://chromium-review.googlesource.com/728347
Commit-Queue: Nodir Turakulov <nodir@chromium.org>
Reviewed-by: Ryan Tseng <hinoka@chromium.org>

[modify] https://crrev.com/25faa7dc553979a93d47ade0b62f79160758711a/milo/frontend/middleware.go
[modify] https://crrev.com/25faa7dc553979a93d47ade0b62f79160758711a/milo/frontend/routes.go
[modify] https://crrev.com/25faa7dc553979a93d47ade0b62f79160758711a/server/middleware/middleware.go

Comment 6 by no...@chromium.org, Oct 20 2017

Components: -Infra>Platform>Milo Infra>Platform>Milo>Buildbot
Status: Fixed (was: Started)
possible now, but you have to wait more
this problem is specific to buildbot, we won't have it with LUCI

Sign in to add a comment