factory: Add reference implementation of ActivateRegCode |
||
Issue descriptionIn latest shopfloor service API, we have the ActivateRegCode implementation. This should be implemented by partner, but since the output was actually defined in CPFE ( https://www.google.com/chromeos/partner/fe/docs/factory/factoryregistrationguide.html ), we should have a reference implementation in Umpire and FactoryServer, so partners who forgot (or who thinks they don't need) doing it would still have some backup files on factory server. Additionally, we should add a shopfloor_service@ActivateRegCode call in GRT_Items reference test list.
,
Oct 20 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform/factory/+/a5e9d2b2f94eb4f3eafdb78c084e1a8414bb1790 commit a5e9d2b2f94eb4f3eafdb78c084e1a8414bb1790 Author: Wei-Han Chen <stimim@google.com> Date: Fri Oct 20 15:22:10 2017 test list: add ActivateRegCode to GRT station BUG= chromium:776425 TEST=manual Change-Id: I360d35b3ab9950fa662584d3eff8deb3396476aa Reviewed-on: https://chromium-review.googlesource.com/730030 Commit-Ready: Wei-Han Chen <stimim@chromium.org> Tested-by: Wei-Han Chen <stimim@chromium.org> Reviewed-by: Pi-Hsun Shih <pihsun@chromium.org> [modify] https://crrev.com/a5e9d2b2f94eb4f3eafdb78c084e1a8414bb1790/po/zh-CN.po [modify] https://crrev.com/a5e9d2b2f94eb4f3eafdb78c084e1a8414bb1790/py/test/test_lists/generic_common.test_list.json [modify] https://crrev.com/a5e9d2b2f94eb4f3eafdb78c084e1a8414bb1790/py/test/test_lists/generic_grt.test_list.json
,
Oct 25 2017
The following revision refers to this bug: https://chrome-internal.googlesource.com/chromeos/overlays/overlay-soraka-private/+/82f4f0e4d49baa62cec7682336a2b178b2b4d2da commit 82f4f0e4d49baa62cec7682336a2b178b2b4d2da Author: Chia-Hsiu Chang <chia-hsiu.chang@quantatw.com> Date: Wed Oct 25 08:38:45 2017
,
Oct 26 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform/factory/+/9d7d743ab93129491b06125847ba8f0b3416e26d commit 9d7d743ab93129491b06125847ba8f0b3416e26d Author: Hung-Te Lin <hungte@chromium.org> Date: Thu Oct 26 15:06:21 2017 test_lists: Move ActivateRegCode to GRTItems. The ActivateRegCode should be in GRTItems so partners may override it. BUG= chromium:776425 TEST=manual Change-Id: I58348661ab3c85d8bf7134fb90e1b88e743431e0 Reviewed-on: https://chromium-review.googlesource.com/737602 Commit-Ready: Hung-Te Lin <hungte@chromium.org> Tested-by: Hung-Te Lin <hungte@chromium.org> Reviewed-by: Wei-Han Chen <stimim@chromium.org> [modify] https://crrev.com/9d7d743ab93129491b06125847ba8f0b3416e26d/py/test/test_lists/generic_grt.test_list.json
,
Oct 30 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform/factory/+/65aa648b54d7032080f8ca4dca81f6e4fc934298 commit 65aa648b54d7032080f8ca4dca81f6e4fc934298 Author: Hung-Te Lin <hungte@chromium.org> Date: Mon Oct 30 08:31:34 2017 server: Add 'UploadCSVEntry' API for storing registration codes. Not all partners need to implement their own version of ActivateRegCode in shopfloor service. Since the format is fixed, we can put the implementation in factory servers (factory_server and Umpire). The new 'UploadCSVEntry' is a general function for storing data from device that should not be associated with device serial number, for example registration code. For factory_server, the CSV file will be created in `shopfloor_data` folder. For Umpire, the data is in `umpire_data/csv`. For backward compatibility, a pytest can invoke UploadCSVEntry('registration_code_log', [board, ubind, gbind, timestamp, hwid]) to get same results. If a partner needs to have regcode also sent to their real shopfloor backend, then they run `shopfloor_service` pytest using API ActivateRegCode. BUG= chromium:776425 TEST=make test; manual invoked XMLRPC API 'UploadCSVEntry' manually invoked pytest 'Upload Reg Codes' Change-Id: I80c0aa79120684b63ffd85cd077d83033c1d1704 Reviewed-on: https://chromium-review.googlesource.com/739682 Commit-Ready: Hung-Te Lin <hungte@chromium.org> Tested-by: Hung-Te Lin <hungte@chromium.org> Reviewed-by: Wei-Han Chen <stimim@chromium.org> [modify] https://crrev.com/65aa648b54d7032080f8ca4dca81f6e4fc934298/py/test/test_lists/generic_common.test_list.json [modify] https://crrev.com/65aa648b54d7032080f8ca4dca81f6e4fc934298/py/shopfloor/factory_server.py [modify] https://crrev.com/65aa648b54d7032080f8ca4dca81f6e4fc934298/py/umpire/server/rpc_dut.py [modify] https://crrev.com/65aa648b54d7032080f8ca4dca81f6e4fc934298/po/zh-CN.po [modify] https://crrev.com/65aa648b54d7032080f8ca4dca81f6e4fc934298/py/shopfloor/factory_server_unittest.py [modify] https://crrev.com/65aa648b54d7032080f8ca4dca81f6e4fc934298/py/shopfloor/shopfloor_service.py [modify] https://crrev.com/65aa648b54d7032080f8ca4dca81f6e4fc934298/py/test/pytests/sync_factory_server.py [modify] https://crrev.com/65aa648b54d7032080f8ca4dca81f6e4fc934298/py/test/test_lists/generic_grt.test_list.json
,
Aug 15
|
||
►
Sign in to add a comment |
||
Comment 1 by bugdroid1@chromium.org
, Oct 20 2017