New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 776416 link

Starred by 15 users

Issue metadata

Status: Started
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Feature

Blocked on:
issue 766068


Show other hotlists

Hotlists containing this issue:
Cpu-Throttling


Sign in to add a comment

throttle workers in background tabs

Project Member Reported by ojan@chromium.org, Oct 19 2017

Issue description

I know we've discussed this a bunch, but I believe we should throttle workers in background tabs the same way we do the main thread. A background tab shouldn't be allowed to use all my CPU/battery regardless of how it's doing so.

See issue 766068 for some extra motivation.
 

Comment 1 by kbr@chromium.org, Oct 20 2017

Cc: kbr@chromium.org

Comment 2 by kbr@chromium.org, Oct 20 2017

Blockedon: 766068
Blocking this on Issue 766068 so that the conversation isn't split between two bugs. Please refer to the other bug for the more general conversation about throttling high-CPU-usage JavaScript.

While I agree that we should stop background tabs from using all CPU, I believe that there are better way than throttling workers in the very same way we do throttle main thread. I'd suggest doing something aggressive when we see sustained load. Ojan, WDYT?

Comment 4 by ojan@chromium.org, Oct 21 2017

Why do you think we should throttle workers (in background tabs) differently than the main thread (in background tabs)?
@altimin 
That is actually a very bad idea. 
To get more concrete, what kind of throttling are we thinking of here? Budget-based throttling identical to timers feels like a good starting point -- I can't immediately think of a reason why we should do something different.
Components: Blink>PageLifecycle

Comment 8 by ojan@chromium.org, Oct 30 2017

I agree with comment 6.
Re #6: It's not budget-based throttling that I'm concerned about. It's unconditional 1Hz timer alignment that worries me - I don't have hard data, but I suspect that people have real-time expectations there (e.g. MDN recommends to use postMessage to work around throttling).

I think that we could start with budget-based throttling but without forcing 1Hz alignment.

Another concern of mine is what classes of work are prevalent in workers and which of them we can throttle. I expect that the load is very different from main page (e.g. timers won't be so popular).

Comment 10 by ojan@chromium.org, Nov 4 2017

I'm not sure why workers *in background tabs* would have more real-time expectations. I'd prefer we stick with consistency first and old consider different things if we prove it's needed for real world content. Having to explain to authors that timers are budget throttled and 1hz except if they're in a worker where they're only budget throttled just makes for a more confusing platform with more complexity to understand IMO.
Owner: altimin@chromium.org
Status: Assigned (was: Available)
Project Member

Comment 12 by bugdroid1@chromium.org, Jan 10 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9180259d341599b7291ed9b47ac678396657cf76

commit 9180259d341599b7291ed9b47ac678396657cf76
Author: Alexander Timin <altimin@chromium.org>
Date: Wed Jan 10 13:58:58 2018

[scheduler] Introduce MetricsHelper.

Introduce a MetricsHelper class to have a single place for implementation of metrics touching
different threads in the renderer process (main thread, compositor thread, worker threads).

The purpose is only code reuse, each thread is supposed to have its own MetricsHelper.

R=alexclarke@chromium.org
BUG=776416

Change-Id: I7bf79eae8f281d18fb0e95739eb529702b9da732
Reviewed-on: https://chromium-review.googlesource.com/859497
Commit-Queue: Alexander Timin <altimin@chromium.org>
Reviewed-by: Alex Clarke <alexclarke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#528298}
[modify] https://crrev.com/9180259d341599b7291ed9b47ac678396657cf76/third_party/WebKit/Source/platform/scheduler/BUILD.gn
[add] https://crrev.com/9180259d341599b7291ed9b47ac678396657cf76/third_party/WebKit/Source/platform/scheduler/child/compositor_metrics_helper.cc
[add] https://crrev.com/9180259d341599b7291ed9b47ac678396657cf76/third_party/WebKit/Source/platform/scheduler/child/compositor_metrics_helper.h
[add] https://crrev.com/9180259d341599b7291ed9b47ac678396657cf76/third_party/WebKit/Source/platform/scheduler/child/metrics_helper.cc
[add] https://crrev.com/9180259d341599b7291ed9b47ac678396657cf76/third_party/WebKit/Source/platform/scheduler/child/metrics_helper.h
[add] https://crrev.com/9180259d341599b7291ed9b47ac678396657cf76/third_party/WebKit/Source/platform/scheduler/child/worker_metrics_helper.cc
[add] https://crrev.com/9180259d341599b7291ed9b47ac678396657cf76/third_party/WebKit/Source/platform/scheduler/child/worker_metrics_helper.h
[modify] https://crrev.com/9180259d341599b7291ed9b47ac678396657cf76/third_party/WebKit/Source/platform/scheduler/renderer/renderer_metrics_helper.cc
[modify] https://crrev.com/9180259d341599b7291ed9b47ac678396657cf76/third_party/WebKit/Source/platform/scheduler/renderer/renderer_metrics_helper.h

Project Member

Comment 14 by bugdroid1@chromium.org, Jan 16 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/aee0eaab375950734845ec11428616d7ffa3a1de

commit aee0eaab375950734845ec11428616d7ffa3a1de
Author: Alexander Timin <altimin@chromium.org>
Date: Tue Jan 16 14:12:39 2018

[scheduler] Record the type of worker thread in metrics

Split per-thread metrics further based on the type of the worker thread.

R=haraken@chromium.org,kinuko@chromium.org
BUG=776416

Change-Id: Ifb572c616e222595489dc63bcdb003750258505c
Reviewed-on: https://chromium-review.googlesource.com/867372
Commit-Queue: Alexander Timin <altimin@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Cr-Commit-Position: refs/heads/master@{#529415}
[modify] https://crrev.com/aee0eaab375950734845ec11428616d7ffa3a1de/third_party/WebKit/Source/core/workers/DedicatedWorkerThread.h
[modify] https://crrev.com/aee0eaab375950734845ec11428616d7ffa3a1de/third_party/WebKit/Source/core/workers/SharedWorkerThread.h
[modify] https://crrev.com/aee0eaab375950734845ec11428616d7ffa3a1de/third_party/WebKit/Source/core/workers/ThreadedWorkletTest.cpp
[modify] https://crrev.com/aee0eaab375950734845ec11428616d7ffa3a1de/third_party/WebKit/Source/core/workers/WorkerThread.cpp
[modify] https://crrev.com/aee0eaab375950734845ec11428616d7ffa3a1de/third_party/WebKit/Source/core/workers/WorkerThread.h
[modify] https://crrev.com/aee0eaab375950734845ec11428616d7ffa3a1de/third_party/WebKit/Source/core/workers/WorkerThreadTestHelper.h
[modify] https://crrev.com/aee0eaab375950734845ec11428616d7ffa3a1de/third_party/WebKit/Source/modules/animationworklet/AnimationWorkletThread.h
[modify] https://crrev.com/aee0eaab375950734845ec11428616d7ffa3a1de/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerThread.h
[modify] https://crrev.com/aee0eaab375950734845ec11428616d7ffa3a1de/third_party/WebKit/Source/modules/webaudio/AudioWorkletThread.h
[modify] https://crrev.com/aee0eaab375950734845ec11428616d7ffa3a1de/third_party/WebKit/Source/platform/scheduler/child/compositor_worker_scheduler.cc
[modify] https://crrev.com/aee0eaab375950734845ec11428616d7ffa3a1de/third_party/WebKit/Source/platform/scheduler/child/compositor_worker_scheduler.h
[modify] https://crrev.com/aee0eaab375950734845ec11428616d7ffa3a1de/third_party/WebKit/Source/platform/scheduler/child/metrics_helper.cc
[modify] https://crrev.com/aee0eaab375950734845ec11428616d7ffa3a1de/third_party/WebKit/Source/platform/scheduler/child/metrics_helper.h
[modify] https://crrev.com/aee0eaab375950734845ec11428616d7ffa3a1de/third_party/WebKit/Source/platform/scheduler/child/worker_metrics_helper.cc
[modify] https://crrev.com/aee0eaab375950734845ec11428616d7ffa3a1de/third_party/WebKit/Source/platform/scheduler/child/worker_metrics_helper.h
[modify] https://crrev.com/aee0eaab375950734845ec11428616d7ffa3a1de/third_party/WebKit/Source/platform/scheduler/child/worker_scheduler.h
[modify] https://crrev.com/aee0eaab375950734845ec11428616d7ffa3a1de/third_party/WebKit/Source/platform/scheduler/child/worker_scheduler_impl.cc
[modify] https://crrev.com/aee0eaab375950734845ec11428616d7ffa3a1de/third_party/WebKit/Source/platform/scheduler/child/worker_scheduler_impl.h
[modify] https://crrev.com/aee0eaab375950734845ec11428616d7ffa3a1de/third_party/WebKit/Source/platform/scheduler/util/thread_type.h
[modify] https://crrev.com/aee0eaab375950734845ec11428616d7ffa3a1de/tools/metrics/histograms/enums.xml

Project Member

Comment 15 by bugdroid1@chromium.org, Jan 17 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/eb1a8a7abbbef7900afe9e8e4c35ad5409692390

commit eb1a8a7abbbef7900afe9e8e4c35ad5409692390
Author: Alexander Timin <altimin@chromium.org>
Date: Wed Jan 17 17:08:32 2018

[scheduler] Add per-thread CPU task duration metric

Add RendererScheduler.TaskCPUDurationPerThreadType to estimate how
much work is being done by the web workers.

Due to performance cost of measuring cpu time only every 1% of the
randomly sampled tasks have their cpu time duration measured.

R=alexclarke@chromium.org,rkaplow@chromium.org
BUG=776416

Change-Id: I628dd0645e59ba15136fcf10c323c499982fdd6f
Reviewed-on: https://chromium-review.googlesource.com/862122
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
Reviewed-by: Timothy Dresser <tdresser@chromium.org>
Commit-Queue: Alexander Timin <altimin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#529780}
[modify] https://crrev.com/eb1a8a7abbbef7900afe9e8e4c35ad5409692390/third_party/WebKit/Source/platform/scheduler/BUILD.gn
[modify] https://crrev.com/eb1a8a7abbbef7900afe9e8e4c35ad5409692390/third_party/WebKit/Source/platform/scheduler/base/task_queue_impl.cc
[modify] https://crrev.com/eb1a8a7abbbef7900afe9e8e4c35ad5409692390/third_party/WebKit/Source/platform/scheduler/base/task_queue_impl.h
[modify] https://crrev.com/eb1a8a7abbbef7900afe9e8e4c35ad5409692390/third_party/WebKit/Source/platform/scheduler/base/task_queue_manager.cc
[modify] https://crrev.com/eb1a8a7abbbef7900afe9e8e4c35ad5409692390/third_party/WebKit/Source/platform/scheduler/base/task_queue_manager.h
[modify] https://crrev.com/eb1a8a7abbbef7900afe9e8e4c35ad5409692390/third_party/WebKit/Source/platform/scheduler/base/task_queue_manager_unittest.cc
[modify] https://crrev.com/eb1a8a7abbbef7900afe9e8e4c35ad5409692390/third_party/WebKit/Source/platform/scheduler/child/compositor_metrics_helper.cc
[modify] https://crrev.com/eb1a8a7abbbef7900afe9e8e4c35ad5409692390/third_party/WebKit/Source/platform/scheduler/child/compositor_metrics_helper.h
[modify] https://crrev.com/eb1a8a7abbbef7900afe9e8e4c35ad5409692390/third_party/WebKit/Source/platform/scheduler/child/compositor_worker_scheduler.cc
[modify] https://crrev.com/eb1a8a7abbbef7900afe9e8e4c35ad5409692390/third_party/WebKit/Source/platform/scheduler/child/compositor_worker_scheduler.h
[modify] https://crrev.com/eb1a8a7abbbef7900afe9e8e4c35ad5409692390/third_party/WebKit/Source/platform/scheduler/child/idle_canceled_delayed_task_sweeper_unittest.cc
[modify] https://crrev.com/eb1a8a7abbbef7900afe9e8e4c35ad5409692390/third_party/WebKit/Source/platform/scheduler/child/idle_helper_unittest.cc
[modify] https://crrev.com/eb1a8a7abbbef7900afe9e8e4c35ad5409692390/third_party/WebKit/Source/platform/scheduler/child/metrics_helper.cc
[modify] https://crrev.com/eb1a8a7abbbef7900afe9e8e4c35ad5409692390/third_party/WebKit/Source/platform/scheduler/child/metrics_helper.h
[add] https://crrev.com/eb1a8a7abbbef7900afe9e8e4c35ad5409692390/third_party/WebKit/Source/platform/scheduler/child/metrics_helper_unittest.cc
[modify] https://crrev.com/eb1a8a7abbbef7900afe9e8e4c35ad5409692390/third_party/WebKit/Source/platform/scheduler/child/scheduler_helper_unittest.cc
[modify] https://crrev.com/eb1a8a7abbbef7900afe9e8e4c35ad5409692390/third_party/WebKit/Source/platform/scheduler/child/worker_global_scope_scheduler_unittest.cc
[modify] https://crrev.com/eb1a8a7abbbef7900afe9e8e4c35ad5409692390/third_party/WebKit/Source/platform/scheduler/child/worker_metrics_helper.cc
[modify] https://crrev.com/eb1a8a7abbbef7900afe9e8e4c35ad5409692390/third_party/WebKit/Source/platform/scheduler/child/worker_metrics_helper.h
[modify] https://crrev.com/eb1a8a7abbbef7900afe9e8e4c35ad5409692390/third_party/WebKit/Source/platform/scheduler/child/worker_scheduler.h
[modify] https://crrev.com/eb1a8a7abbbef7900afe9e8e4c35ad5409692390/third_party/WebKit/Source/platform/scheduler/child/worker_scheduler_impl.cc
[modify] https://crrev.com/eb1a8a7abbbef7900afe9e8e4c35ad5409692390/third_party/WebKit/Source/platform/scheduler/child/worker_scheduler_impl.h
[modify] https://crrev.com/eb1a8a7abbbef7900afe9e8e4c35ad5409692390/third_party/WebKit/Source/platform/scheduler/child/worker_scheduler_impl_unittest.cc
[modify] https://crrev.com/eb1a8a7abbbef7900afe9e8e4c35ad5409692390/third_party/WebKit/Source/platform/scheduler/child/worker_task_queue.cc
[modify] https://crrev.com/eb1a8a7abbbef7900afe9e8e4c35ad5409692390/third_party/WebKit/Source/platform/scheduler/child/worker_task_queue.h
[modify] https://crrev.com/eb1a8a7abbbef7900afe9e8e4c35ad5409692390/third_party/WebKit/Source/platform/scheduler/renderer/auto_advancing_virtual_time_domain_unittest.cc
[modify] https://crrev.com/eb1a8a7abbbef7900afe9e8e4c35ad5409692390/third_party/WebKit/Source/platform/scheduler/renderer/budget_pool_unittest.cc
[modify] https://crrev.com/eb1a8a7abbbef7900afe9e8e4c35ad5409692390/third_party/WebKit/Source/platform/scheduler/renderer/idle_time_estimator_unittest.cc
[modify] https://crrev.com/eb1a8a7abbbef7900afe9e8e4c35ad5409692390/third_party/WebKit/Source/platform/scheduler/renderer/main_thread_task_queue.cc
[modify] https://crrev.com/eb1a8a7abbbef7900afe9e8e4c35ad5409692390/third_party/WebKit/Source/platform/scheduler/renderer/main_thread_task_queue.h
[modify] https://crrev.com/eb1a8a7abbbef7900afe9e8e4c35ad5409692390/third_party/WebKit/Source/platform/scheduler/renderer/renderer_metrics_helper.cc
[modify] https://crrev.com/eb1a8a7abbbef7900afe9e8e4c35ad5409692390/third_party/WebKit/Source/platform/scheduler/renderer/renderer_metrics_helper.h
[modify] https://crrev.com/eb1a8a7abbbef7900afe9e8e4c35ad5409692390/third_party/WebKit/Source/platform/scheduler/renderer/renderer_metrics_helper_unittest.cc
[modify] https://crrev.com/eb1a8a7abbbef7900afe9e8e4c35ad5409692390/third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl.cc
[modify] https://crrev.com/eb1a8a7abbbef7900afe9e8e4c35ad5409692390/third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl.h
[modify] https://crrev.com/eb1a8a7abbbef7900afe9e8e4c35ad5409692390/third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl_unittest.cc
[modify] https://crrev.com/eb1a8a7abbbef7900afe9e8e4c35ad5409692390/third_party/WebKit/Source/platform/scheduler/renderer/task_queue_throttler_unittest.cc
[modify] https://crrev.com/eb1a8a7abbbef7900afe9e8e4c35ad5409692390/third_party/WebKit/Source/platform/scheduler/renderer/web_frame_scheduler_impl_unittest.cc
[modify] https://crrev.com/eb1a8a7abbbef7900afe9e8e4c35ad5409692390/third_party/WebKit/Source/platform/scheduler/renderer/web_view_scheduler_impl_unittest.cc
[modify] https://crrev.com/eb1a8a7abbbef7900afe9e8e4c35ad5409692390/third_party/WebKit/Source/platform/scheduler/renderer/webthread_impl_for_renderer_scheduler_unittest.cc
[modify] https://crrev.com/eb1a8a7abbbef7900afe9e8e4c35ad5409692390/third_party/WebKit/Source/platform/scheduler/test/create_task_queue_manager_for_test.cc
[modify] https://crrev.com/eb1a8a7abbbef7900afe9e8e4c35ad5409692390/third_party/WebKit/Source/platform/scheduler/test/create_task_queue_manager_for_test.h
[modify] https://crrev.com/eb1a8a7abbbef7900afe9e8e4c35ad5409692390/third_party/WebKit/Source/platform/testing/TestingPlatformSupportWithMockScheduler.cpp
[modify] https://crrev.com/eb1a8a7abbbef7900afe9e8e4c35ad5409692390/tools/metrics/histograms/histograms.xml

Project Member

Comment 16 by bugdroid1@chromium.org, Jan 22 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b98cd81dd455dddc575baf19eb957aebf23aecf0

commit b98cd81dd455dddc575baf19eb957aebf23aecf0
Author: Alexander Timin <altimin@chromium.org>
Date: Mon Jan 22 16:45:33 2018

[scheduler] Split per-thread task duration by process visibility

Add following metrics to understand impact of web workers on background
tabs:

* RendererScheduler.TaskDurationPerThreadType.Foreground
* RendererScheduler.TaskDurationPerThreadType.Background
* RendererScheduler.TaskCPUDurationPerThreadType.Foreground
* RendererScheduler.TaskCPUDurationPerThreadType.Background

R=skyostil@chromium.org, rkaplow@chromium.org
BUG=776416

Change-Id: I94430c0efcc6d82a96085b0150022a2574e14f40
Reviewed-on: https://chromium-review.googlesource.com/875924
Reviewed-by: Alex Clarke <alexclarke@chromium.org>
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Commit-Queue: Alexander Timin <altimin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#530881}
[modify] https://crrev.com/b98cd81dd455dddc575baf19eb957aebf23aecf0/third_party/WebKit/Source/platform/scheduler/BUILD.gn
[modify] https://crrev.com/b98cd81dd455dddc575baf19eb957aebf23aecf0/third_party/WebKit/Source/platform/scheduler/child/metrics_helper.cc
[modify] https://crrev.com/b98cd81dd455dddc575baf19eb957aebf23aecf0/third_party/WebKit/Source/platform/scheduler/child/metrics_helper.h
[add] https://crrev.com/b98cd81dd455dddc575baf19eb957aebf23aecf0/third_party/WebKit/Source/platform/scheduler/child/process_state.cc
[add] https://crrev.com/b98cd81dd455dddc575baf19eb957aebf23aecf0/third_party/WebKit/Source/platform/scheduler/child/process_state.h
[modify] https://crrev.com/b98cd81dd455dddc575baf19eb957aebf23aecf0/third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl.cc
[modify] https://crrev.com/b98cd81dd455dddc575baf19eb957aebf23aecf0/tools/metrics/histograms/histograms.xml

Project Member

Comment 17 by bugdroid1@chromium.org, Jan 22 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7c4b3264bcaae06fd1811b9dac5919920c7de41e

commit 7c4b3264bcaae06fd1811b9dac5919920c7de41e
Author: Alexander Timin <altimin@chromium.org>
Date: Mon Jan 22 17:15:09 2018

[blink] Introduce WebThreadCreationParams.

Add a special struct for web thread params and use it in
Platform::CreateThread and elsewhere.

This will allow easier plumbing for the future thread params (e.g.
whether thread can be throttled or not).

R=haraken@chromium.org
BUG=776416

Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I91885dea744b7055dce23e42c9b6d51946a80e07
Reviewed-on: https://chromium-review.googlesource.com/878641
Commit-Queue: Alexander Timin <altimin@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#530899}
[modify] https://crrev.com/7c4b3264bcaae06fd1811b9dac5919920c7de41e/content/child/blink_platform_impl.cc
[modify] https://crrev.com/7c4b3264bcaae06fd1811b9dac5919920c7de41e/content/child/blink_platform_impl.h
[modify] https://crrev.com/7c4b3264bcaae06fd1811b9dac5919920c7de41e/third_party/WebKit/Source/bindings/core/v8/DOMWrapperWorldTest.cpp
[modify] https://crrev.com/7c4b3264bcaae06fd1811b9dac5919920c7de41e/third_party/WebKit/Source/bindings/core/v8/ScriptStreamerThread.cpp
[modify] https://crrev.com/7c4b3264bcaae06fd1811b9dac5919920c7de41e/third_party/WebKit/Source/core/css/threaded/MultiThreadedTestUtil.h
[modify] https://crrev.com/7c4b3264bcaae06fd1811b9dac5919920c7de41e/third_party/WebKit/Source/core/fetch/DataConsumerHandleTestUtil.cpp
[modify] https://crrev.com/7c4b3264bcaae06fd1811b9dac5919920c7de41e/third_party/WebKit/Source/core/workers/DedicatedWorkerTest.cpp
[modify] https://crrev.com/7c4b3264bcaae06fd1811b9dac5919920c7de41e/third_party/WebKit/Source/core/workers/DedicatedWorkerThread.cpp
[modify] https://crrev.com/7c4b3264bcaae06fd1811b9dac5919920c7de41e/third_party/WebKit/Source/core/workers/SharedWorkerThread.cpp
[modify] https://crrev.com/7c4b3264bcaae06fd1811b9dac5919920c7de41e/third_party/WebKit/Source/core/workers/ThreadedWorkletTest.cpp
[modify] https://crrev.com/7c4b3264bcaae06fd1811b9dac5919920c7de41e/third_party/WebKit/Source/core/workers/WorkerBackingThread.cpp
[modify] https://crrev.com/7c4b3264bcaae06fd1811b9dac5919920c7de41e/third_party/WebKit/Source/core/workers/WorkerBackingThread.h
[modify] https://crrev.com/7c4b3264bcaae06fd1811b9dac5919920c7de41e/third_party/WebKit/Source/core/workers/WorkerThreadTestHelper.h
[modify] https://crrev.com/7c4b3264bcaae06fd1811b9dac5919920c7de41e/third_party/WebKit/Source/core/workers/WorkletThreadHolder.h
[modify] https://crrev.com/7c4b3264bcaae06fd1811b9dac5919920c7de41e/third_party/WebKit/Source/modules/animationworklet/AnimationWorkletThreadTest.cpp
[modify] https://crrev.com/7c4b3264bcaae06fd1811b9dac5919920c7de41e/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerThread.cpp
[modify] https://crrev.com/7c4b3264bcaae06fd1811b9dac5919920c7de41e/third_party/WebKit/Source/modules/webaudio/AudioContextTest.cpp
[modify] https://crrev.com/7c4b3264bcaae06fd1811b9dac5919920c7de41e/third_party/WebKit/Source/modules/webaudio/BaseAudioContextTest.cpp
[modify] https://crrev.com/7c4b3264bcaae06fd1811b9dac5919920c7de41e/third_party/WebKit/Source/modules/webaudio/OfflineAudioDestinationNode.cpp
[modify] https://crrev.com/7c4b3264bcaae06fd1811b9dac5919920c7de41e/third_party/WebKit/Source/modules/webdatabase/DatabaseThread.cpp
[modify] https://crrev.com/7c4b3264bcaae06fd1811b9dac5919920c7de41e/third_party/WebKit/Source/platform/WebThread.cpp
[modify] https://crrev.com/7c4b3264bcaae06fd1811b9dac5919920c7de41e/third_party/WebKit/Source/platform/WebThreadSupportingGC.cpp
[modify] https://crrev.com/7c4b3264bcaae06fd1811b9dac5919920c7de41e/third_party/WebKit/Source/platform/WebThreadSupportingGC.h
[modify] https://crrev.com/7c4b3264bcaae06fd1811b9dac5919920c7de41e/third_party/WebKit/Source/platform/audio/HRTFDatabaseLoader.cpp
[modify] https://crrev.com/7c4b3264bcaae06fd1811b9dac5919920c7de41e/third_party/WebKit/Source/platform/audio/PushPullFIFOMultithreadTest.cpp
[modify] https://crrev.com/7c4b3264bcaae06fd1811b9dac5919920c7de41e/third_party/WebKit/Source/platform/audio/ReverbConvolver.cpp
[modify] https://crrev.com/7c4b3264bcaae06fd1811b9dac5919920c7de41e/third_party/WebKit/Source/platform/exported/Platform.cpp
[modify] https://crrev.com/7c4b3264bcaae06fd1811b9dac5919920c7de41e/third_party/WebKit/Source/platform/graphics/DeferredImageDecoderTest.cpp
[modify] https://crrev.com/7c4b3264bcaae06fd1811b9dac5919920c7de41e/third_party/WebKit/Source/platform/graphics/ImageFrameGeneratorTest.cpp
[modify] https://crrev.com/7c4b3264bcaae06fd1811b9dac5919920c7de41e/third_party/WebKit/Source/platform/heap/HeapTest.cpp
[modify] https://crrev.com/7c4b3264bcaae06fd1811b9dac5919920c7de41e/third_party/WebKit/Source/platform/loader/fetch/ResourceResponseTest.cpp
[modify] https://crrev.com/7c4b3264bcaae06fd1811b9dac5919920c7de41e/third_party/WebKit/Source/platform/testing/TestingPlatformSupportWithMockScheduler.cpp
[modify] https://crrev.com/7c4b3264bcaae06fd1811b9dac5919920c7de41e/third_party/WebKit/Source/platform/testing/TestingPlatformSupportWithMockScheduler.h
[modify] https://crrev.com/7c4b3264bcaae06fd1811b9dac5919920c7de41e/third_party/WebKit/public/platform/Platform.h
[modify] https://crrev.com/7c4b3264bcaae06fd1811b9dac5919920c7de41e/third_party/WebKit/public/platform/WebThread.h

Project Member

Comment 18 by bugdroid1@chromium.org, Jan 22 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d22cf74642935e640aaecf2e790260dbfb2450b8

commit d22cf74642935e640aaecf2e790260dbfb2450b8
Author: Mostyn Bramley-Moore <mostynb@vewd.com>
Date: Mon Jan 22 20:24:19 2018

[jumbo] add missing header guards in process_state.h

This breaks jumbo builds, if the header is included twice in the same
jumbo unit.

BUG=776416
TBR=alexclarke@chromium.org

Change-Id: I3a44cb0014b39800c643241624d13af662ef267f
Reviewed-on: https://chromium-review.googlesource.com/879143
Commit-Queue: Mostyn Bramley-Moore <mostynb@vewd.com>
Reviewed-by: Mostyn Bramley-Moore <mostynb@vewd.com>
Cr-Commit-Position: refs/heads/master@{#530971}
[modify] https://crrev.com/d22cf74642935e640aaecf2e790260dbfb2450b8/third_party/WebKit/Source/platform/scheduler/child/process_state.h

Project Member

Comment 19 by bugdroid1@chromium.org, Jan 23 2018

Components: Blink>Workers
One tricky part is handling the case where the worker is in a background tab but is being used by a foreground tab. This can happen for shared workers and service workers.
Re #21: Only dedicated workers are in the scope for this intervention. Shared workers and service workers run only 1% of the tasks of dedicated workers (as measured by thread time).
Project Member

Comment 23 by bugdroid1@chromium.org, Jan 30 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ba60a6c8aa3d0ad6d4d99615b7c3053e724aee04

commit ba60a6c8aa3d0ad6d4d99615b7c3053e724aee04
Author: Alexander Timin <altimin@chromium.org>
Date: Tue Jan 30 23:15:45 2018

[blink] enum class WebThreadType

Require an enum to be passed to Platform::CreateThread specifying the
type of thread which is requested to be created.

This allows recording metrics around thread cpu usage.

R=haraken@chromium.org,hajimehoshi@chromium.org,nhiroki@chromium.org
BUG=776416

Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: Ie1855c52ab2259738fdc91ad3af89c476904c7bf
Reviewed-on: https://chromium-review.googlesource.com/888920
Commit-Queue: Alexander Timin <altimin@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Cr-Commit-Position: refs/heads/master@{#533070}
[modify] https://crrev.com/ba60a6c8aa3d0ad6d4d99615b7c3053e724aee04/third_party/WebKit/Source/bindings/core/v8/DOMWrapperWorldTest.cpp
[modify] https://crrev.com/ba60a6c8aa3d0ad6d4d99615b7c3053e724aee04/third_party/WebKit/Source/bindings/core/v8/ScriptStreamerThread.cpp
[modify] https://crrev.com/ba60a6c8aa3d0ad6d4d99615b7c3053e724aee04/third_party/WebKit/Source/core/css/threaded/MultiThreadedTestUtil.h
[modify] https://crrev.com/ba60a6c8aa3d0ad6d4d99615b7c3053e724aee04/third_party/WebKit/Source/core/fetch/DataConsumerHandleTestUtil.cpp
[modify] https://crrev.com/ba60a6c8aa3d0ad6d4d99615b7c3053e724aee04/third_party/WebKit/Source/core/fetch/DataConsumerHandleTestUtil.h
[modify] https://crrev.com/ba60a6c8aa3d0ad6d4d99615b7c3053e724aee04/third_party/WebKit/Source/core/workers/DedicatedWorkerTest.cpp
[modify] https://crrev.com/ba60a6c8aa3d0ad6d4d99615b7c3053e724aee04/third_party/WebKit/Source/core/workers/DedicatedWorkerThread.cpp
[modify] https://crrev.com/ba60a6c8aa3d0ad6d4d99615b7c3053e724aee04/third_party/WebKit/Source/core/workers/DedicatedWorkerThread.h
[modify] https://crrev.com/ba60a6c8aa3d0ad6d4d99615b7c3053e724aee04/third_party/WebKit/Source/core/workers/SharedWorkerThread.cpp
[modify] https://crrev.com/ba60a6c8aa3d0ad6d4d99615b7c3053e724aee04/third_party/WebKit/Source/core/workers/SharedWorkerThread.h
[modify] https://crrev.com/ba60a6c8aa3d0ad6d4d99615b7c3053e724aee04/third_party/WebKit/Source/core/workers/ThreadedWorkletTest.cpp
[modify] https://crrev.com/ba60a6c8aa3d0ad6d4d99615b7c3053e724aee04/third_party/WebKit/Source/core/workers/WorkerThread.h
[modify] https://crrev.com/ba60a6c8aa3d0ad6d4d99615b7c3053e724aee04/third_party/WebKit/Source/core/workers/WorkerThreadTestHelper.h
[modify] https://crrev.com/ba60a6c8aa3d0ad6d4d99615b7c3053e724aee04/third_party/WebKit/Source/core/workers/WorkletThreadHolder.h
[modify] https://crrev.com/ba60a6c8aa3d0ad6d4d99615b7c3053e724aee04/third_party/WebKit/Source/modules/animationworklet/AnimationWorkletThread.h
[modify] https://crrev.com/ba60a6c8aa3d0ad6d4d99615b7c3053e724aee04/third_party/WebKit/Source/modules/animationworklet/AnimationWorkletThreadTest.cpp
[modify] https://crrev.com/ba60a6c8aa3d0ad6d4d99615b7c3053e724aee04/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerThread.cpp
[modify] https://crrev.com/ba60a6c8aa3d0ad6d4d99615b7c3053e724aee04/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerThread.h
[modify] https://crrev.com/ba60a6c8aa3d0ad6d4d99615b7c3053e724aee04/third_party/WebKit/Source/modules/webaudio/AudioWorkletThread.h
[modify] https://crrev.com/ba60a6c8aa3d0ad6d4d99615b7c3053e724aee04/third_party/WebKit/Source/modules/webaudio/OfflineAudioDestinationNode.cpp
[modify] https://crrev.com/ba60a6c8aa3d0ad6d4d99615b7c3053e724aee04/third_party/WebKit/Source/modules/webdatabase/DatabaseThread.cpp
[modify] https://crrev.com/ba60a6c8aa3d0ad6d4d99615b7c3053e724aee04/third_party/WebKit/Source/platform/BUILD.gn
[modify] https://crrev.com/ba60a6c8aa3d0ad6d4d99615b7c3053e724aee04/third_party/WebKit/Source/platform/DEPS
[modify] https://crrev.com/ba60a6c8aa3d0ad6d4d99615b7c3053e724aee04/third_party/WebKit/Source/platform/WebThread.cpp
[modify] https://crrev.com/ba60a6c8aa3d0ad6d4d99615b7c3053e724aee04/third_party/WebKit/Source/platform/WebThreadSupportingGC.cpp
[modify] https://crrev.com/ba60a6c8aa3d0ad6d4d99615b7c3053e724aee04/third_party/WebKit/Source/platform/WebThreadSupportingGC.h
[add] https://crrev.com/ba60a6c8aa3d0ad6d4d99615b7c3053e724aee04/third_party/WebKit/Source/platform/WebThreadType.cpp
[modify] https://crrev.com/ba60a6c8aa3d0ad6d4d99615b7c3053e724aee04/third_party/WebKit/Source/platform/audio/HRTFDatabaseLoader.cpp
[modify] https://crrev.com/ba60a6c8aa3d0ad6d4d99615b7c3053e724aee04/third_party/WebKit/Source/platform/audio/PushPullFIFOMultithreadTest.cpp
[modify] https://crrev.com/ba60a6c8aa3d0ad6d4d99615b7c3053e724aee04/third_party/WebKit/Source/platform/audio/ReverbConvolver.cpp
[modify] https://crrev.com/ba60a6c8aa3d0ad6d4d99615b7c3053e724aee04/third_party/WebKit/Source/platform/exported/Platform.cpp
[modify] https://crrev.com/ba60a6c8aa3d0ad6d4d99615b7c3053e724aee04/third_party/WebKit/Source/platform/graphics/DeferredImageDecoderTest.cpp
[modify] https://crrev.com/ba60a6c8aa3d0ad6d4d99615b7c3053e724aee04/third_party/WebKit/Source/platform/graphics/ImageFrameGeneratorTest.cpp
[modify] https://crrev.com/ba60a6c8aa3d0ad6d4d99615b7c3053e724aee04/third_party/WebKit/Source/platform/heap/HeapTest.cpp
[modify] https://crrev.com/ba60a6c8aa3d0ad6d4d99615b7c3053e724aee04/third_party/WebKit/Source/platform/loader/fetch/ResourceResponseTest.cpp
[modify] https://crrev.com/ba60a6c8aa3d0ad6d4d99615b7c3053e724aee04/third_party/WebKit/Source/platform/scheduler/child/compositor_metrics_helper.cc
[modify] https://crrev.com/ba60a6c8aa3d0ad6d4d99615b7c3053e724aee04/third_party/WebKit/Source/platform/scheduler/child/compositor_worker_scheduler.cc
[modify] https://crrev.com/ba60a6c8aa3d0ad6d4d99615b7c3053e724aee04/third_party/WebKit/Source/platform/scheduler/child/compositor_worker_scheduler.h
[modify] https://crrev.com/ba60a6c8aa3d0ad6d4d99615b7c3053e724aee04/third_party/WebKit/Source/platform/scheduler/child/metrics_helper.cc
[modify] https://crrev.com/ba60a6c8aa3d0ad6d4d99615b7c3053e724aee04/third_party/WebKit/Source/platform/scheduler/child/metrics_helper.h
[modify] https://crrev.com/ba60a6c8aa3d0ad6d4d99615b7c3053e724aee04/third_party/WebKit/Source/platform/scheduler/child/metrics_helper_unittest.cc
[modify] https://crrev.com/ba60a6c8aa3d0ad6d4d99615b7c3053e724aee04/third_party/WebKit/Source/platform/scheduler/child/worker_metrics_helper.cc
[modify] https://crrev.com/ba60a6c8aa3d0ad6d4d99615b7c3053e724aee04/third_party/WebKit/Source/platform/scheduler/child/worker_scheduler.h
[modify] https://crrev.com/ba60a6c8aa3d0ad6d4d99615b7c3053e724aee04/third_party/WebKit/Source/platform/scheduler/child/worker_scheduler_impl.cc
[modify] https://crrev.com/ba60a6c8aa3d0ad6d4d99615b7c3053e724aee04/third_party/WebKit/Source/platform/scheduler/child/worker_scheduler_impl.h
[modify] https://crrev.com/ba60a6c8aa3d0ad6d4d99615b7c3053e724aee04/third_party/WebKit/Source/platform/scheduler/renderer/renderer_metrics_helper.cc
[modify] https://crrev.com/ba60a6c8aa3d0ad6d4d99615b7c3053e724aee04/third_party/WebKit/Source/platform/scheduler/renderer/renderer_metrics_helper.h
[delete] https://crrev.com/477a9c21852a80e1e2b54e2e6ca9b23012ffbce7/third_party/WebKit/Source/platform/scheduler/util/thread_type.h
[modify] https://crrev.com/ba60a6c8aa3d0ad6d4d99615b7c3053e724aee04/third_party/WebKit/public/platform/WebThread.h
[add] https://crrev.com/ba60a6c8aa3d0ad6d4d99615b7c3053e724aee04/third_party/WebKit/public/platform/WebThreadType.h

Project Member

Comment 24 by bugdroid1@chromium.org, Feb 22 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ab2d0dd4de8432b02b091e1cba87f5eddcbe966c

commit ab2d0dd4de8432b02b091e1cba87f5eddcbe966c
Author: Alexander Timin <altimin@chromium.org>
Date: Thu Feb 22 00:43:26 2018

[scheduler] Use RAII handle for throttling observers.

Introduce RAII handle for unregistering throttling observers. RAII
handle is implemented using weak pointers, which allows for easier
lifetime management as frame scheduler may be destroyed before the
observer.

This patch is a prerequisite for observer-based WorkerSchedulerProxy.

R=alexclarke@chromium.org,kinuko@chromium.org
BUG=776416

Change-Id: I1afc1888d633a017f942bc613a39c31b8b72a5f5
Reviewed-on: https://chromium-review.googlesource.com/929062
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Alexander Timin <altimin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#538283}
[modify] https://crrev.com/ab2d0dd4de8432b02b091e1cba87f5eddcbe966c/third_party/WebKit/Source/core/loader/EmptyClients.cpp
[modify] https://crrev.com/ab2d0dd4de8432b02b091e1cba87f5eddcbe966c/third_party/WebKit/Source/platform/WebFrameScheduler.h
[modify] https://crrev.com/ab2d0dd4de8432b02b091e1cba87f5eddcbe966c/third_party/WebKit/Source/platform/loader/fetch/ResourceLoadScheduler.cpp
[modify] https://crrev.com/ab2d0dd4de8432b02b091e1cba87f5eddcbe966c/third_party/WebKit/Source/platform/loader/fetch/ResourceLoadScheduler.h
[modify] https://crrev.com/ab2d0dd4de8432b02b091e1cba87f5eddcbe966c/third_party/WebKit/Source/platform/scheduler/renderer/web_frame_scheduler_impl.cc
[modify] https://crrev.com/ab2d0dd4de8432b02b091e1cba87f5eddcbe966c/third_party/WebKit/Source/platform/scheduler/renderer/web_frame_scheduler_impl.h
[modify] https://crrev.com/ab2d0dd4de8432b02b091e1cba87f5eddcbe966c/third_party/WebKit/Source/platform/scheduler/renderer/web_frame_scheduler_impl_unittest.cc
[modify] https://crrev.com/ab2d0dd4de8432b02b091e1cba87f5eddcbe966c/third_party/WebKit/Source/platform/scheduler/test/fake_web_frame_scheduler.h

Project Member

Comment 25 by bugdroid1@chromium.org, Feb 26 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0c1a888a3660e7e3a05df32b13836108825c29a6

commit 0c1a888a3660e7e3a05df32b13836108825c29a6
Author: Alexander Timin <altimin@chromium.org>
Date: Mon Feb 26 12:40:03 2018

[scheduler] WorkerSchedulerProxy.

Introduce a WorkerSchedulerProxy to allow WebFrameSchedulerImpl and
WorkerSchedulerImpl to communicate, in particular allow to notify
WorkerScheduler about page visibility changes.

WorkerSchedulerProxy will be owned by DedicatedWorkerThread all will be
guaranteed to outlive WorkerScheduler.

R=skyostil@chromium.org,alexclarke@chromium.org,haraken@chromium.org,nhiroki@chromium.org
BUG=776416

Change-Id: I40e1431990e2d114cdb7fe918e1db83d91583a8a
Reviewed-on: https://chromium-review.googlesource.com/886364
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
Commit-Queue: Alexander Timin <altimin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539112}
[modify] https://crrev.com/0c1a888a3660e7e3a05df32b13836108825c29a6/third_party/WebKit/Source/core/loader/EmptyClients.cpp
[modify] https://crrev.com/0c1a888a3660e7e3a05df32b13836108825c29a6/third_party/WebKit/Source/platform/WebFrameScheduler.h
[modify] https://crrev.com/0c1a888a3660e7e3a05df32b13836108825c29a6/third_party/WebKit/Source/platform/scheduler/BUILD.gn
[add] https://crrev.com/0c1a888a3660e7e3a05df32b13836108825c29a6/third_party/WebKit/Source/platform/scheduler/child/default_params.h
[add] https://crrev.com/0c1a888a3660e7e3a05df32b13836108825c29a6/third_party/WebKit/Source/platform/scheduler/child/page_visibility_state.h
[modify] https://crrev.com/0c1a888a3660e7e3a05df32b13836108825c29a6/third_party/WebKit/Source/platform/scheduler/child/worker_global_scope_scheduler_unittest.cc
[modify] https://crrev.com/0c1a888a3660e7e3a05df32b13836108825c29a6/third_party/WebKit/Source/platform/scheduler/child/worker_scheduler.cc
[modify] https://crrev.com/0c1a888a3660e7e3a05df32b13836108825c29a6/third_party/WebKit/Source/platform/scheduler/child/worker_scheduler_impl.cc
[modify] https://crrev.com/0c1a888a3660e7e3a05df32b13836108825c29a6/third_party/WebKit/Source/platform/scheduler/child/worker_scheduler_impl.h
[modify] https://crrev.com/0c1a888a3660e7e3a05df32b13836108825c29a6/third_party/WebKit/Source/platform/scheduler/child/worker_scheduler_impl_unittest.cc
[add] https://crrev.com/0c1a888a3660e7e3a05df32b13836108825c29a6/third_party/WebKit/Source/platform/scheduler/child/worker_scheduler_proxy.cc
[add] https://crrev.com/0c1a888a3660e7e3a05df32b13836108825c29a6/third_party/WebKit/Source/platform/scheduler/child/worker_scheduler_proxy.h
[add] https://crrev.com/0c1a888a3660e7e3a05df32b13836108825c29a6/third_party/WebKit/Source/platform/scheduler/child/worker_scheduler_proxy_unittest.cc
[modify] https://crrev.com/0c1a888a3660e7e3a05df32b13836108825c29a6/third_party/WebKit/Source/platform/scheduler/renderer/web_frame_scheduler_impl.cc
[modify] https://crrev.com/0c1a888a3660e7e3a05df32b13836108825c29a6/third_party/WebKit/Source/platform/scheduler/renderer/web_frame_scheduler_impl.h
[modify] https://crrev.com/0c1a888a3660e7e3a05df32b13836108825c29a6/third_party/WebKit/Source/platform/scheduler/renderer/web_view_scheduler_impl.cc
[modify] https://crrev.com/0c1a888a3660e7e3a05df32b13836108825c29a6/third_party/WebKit/Source/platform/scheduler/renderer/web_view_scheduler_impl.h
[modify] https://crrev.com/0c1a888a3660e7e3a05df32b13836108825c29a6/third_party/WebKit/Source/platform/scheduler/test/fake_web_frame_scheduler.h

Project Member

Comment 26 by bugdroid1@chromium.org, Feb 28 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/174f7bec8837d3ad39b945ba517ee9a69d4f5ee1

commit 174f7bec8837d3ad39b945ba517ee9a69d4f5ee1
Author: Alexander Timin <altimin@chromium.org>
Date: Wed Feb 28 14:41:18 2018

[scheduler] Address after-commit comments in patch 886364.

- Added TODO to move PageVisibilityState into core/.
- Pass weakptr in OnWorkerSchedulerCreated instead of adding a method to
  get a weakptr.
- Remove some leftover code.

R=haraken@chromium.org,dcheng@chromium.org
BUG=776416

Change-Id: I1d6705fe59d878f316809cf73ce6f61c8bfe77b6
Reviewed-on: https://chromium-review.googlesource.com/939469
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Alexander Timin <altimin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539821}
[modify] https://crrev.com/174f7bec8837d3ad39b945ba517ee9a69d4f5ee1/third_party/WebKit/Source/platform/scheduler/BUILD.gn
[add] https://crrev.com/174f7bec8837d3ad39b945ba517ee9a69d4f5ee1/third_party/WebKit/Source/platform/scheduler/child/page_visibility_state.cc
[modify] https://crrev.com/174f7bec8837d3ad39b945ba517ee9a69d4f5ee1/third_party/WebKit/Source/platform/scheduler/child/page_visibility_state.h
[modify] https://crrev.com/174f7bec8837d3ad39b945ba517ee9a69d4f5ee1/third_party/WebKit/Source/platform/scheduler/child/worker_scheduler_impl.cc
[modify] https://crrev.com/174f7bec8837d3ad39b945ba517ee9a69d4f5ee1/third_party/WebKit/Source/platform/scheduler/child/worker_scheduler_impl.h
[modify] https://crrev.com/174f7bec8837d3ad39b945ba517ee9a69d4f5ee1/third_party/WebKit/Source/platform/scheduler/child/worker_scheduler_proxy.cc
[modify] https://crrev.com/174f7bec8837d3ad39b945ba517ee9a69d4f5ee1/third_party/WebKit/Source/platform/scheduler/child/worker_scheduler_proxy.h
[modify] https://crrev.com/174f7bec8837d3ad39b945ba517ee9a69d4f5ee1/third_party/WebKit/Source/platform/scheduler/renderer/web_frame_scheduler_impl.cc
[modify] https://crrev.com/174f7bec8837d3ad39b945ba517ee9a69d4f5ee1/third_party/WebKit/Source/platform/scheduler/renderer/web_frame_scheduler_impl.h
[modify] https://crrev.com/174f7bec8837d3ad39b945ba517ee9a69d4f5ee1/third_party/WebKit/Source/platform/scheduler/renderer/web_view_scheduler_impl.cc
[modify] https://crrev.com/174f7bec8837d3ad39b945ba517ee9a69d4f5ee1/third_party/WebKit/Source/platform/scheduler/renderer/web_view_scheduler_impl.h

Project Member

Comment 27 by bugdroid1@chromium.org, Mar 15 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/053b619cf7ac1dd0ed6504e6e65da0e45d0a9d4e

commit 053b619cf7ac1dd0ed6504e6e65da0e45d0a9d4e
Author: Alexander Timin <altimin@chromium.org>
Date: Thu Mar 15 14:13:34 2018

[scheduler] Use WorkerSchedulerProxy in DedicatedWorkerThread.

Create newly-introduced WorkerSchedulerProxy in DedicatedWorkerThread
and plumb it to WorkerScheduler via WebThreadCreationParams.

BUG=776416
R=kinuko@chromium.org, haraken@chromium.org

Change-Id: I48de4ee3986b1c53dd22c3b9da82ac7bb9a3ee54
Reviewed-on: https://chromium-review.googlesource.com/957046
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Alexander Timin <altimin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543362}
[modify] https://crrev.com/053b619cf7ac1dd0ed6504e6e65da0e45d0a9d4e/content/child/blink_platform_impl.cc
[modify] https://crrev.com/053b619cf7ac1dd0ed6504e6e65da0e45d0a9d4e/content/renderer/render_thread_impl.cc
[modify] https://crrev.com/053b619cf7ac1dd0ed6504e6e65da0e45d0a9d4e/third_party/WebKit/Source/core/workers/DedicatedWorkerThread.cpp
[modify] https://crrev.com/053b619cf7ac1dd0ed6504e6e65da0e45d0a9d4e/third_party/WebKit/Source/platform/WebThread.cpp
[modify] https://crrev.com/053b619cf7ac1dd0ed6504e6e65da0e45d0a9d4e/third_party/WebKit/Source/platform/scheduler/child/webthread_base.cc
[modify] https://crrev.com/053b619cf7ac1dd0ed6504e6e65da0e45d0a9d4e/third_party/WebKit/Source/platform/scheduler/child/webthread_impl_for_worker_scheduler.cc
[modify] https://crrev.com/053b619cf7ac1dd0ed6504e6e65da0e45d0a9d4e/third_party/WebKit/Source/platform/scheduler/child/webthread_impl_for_worker_scheduler.h
[modify] https://crrev.com/053b619cf7ac1dd0ed6504e6e65da0e45d0a9d4e/third_party/WebKit/Source/platform/scheduler/child/webthread_impl_for_worker_scheduler_unittest.cc
[modify] https://crrev.com/053b619cf7ac1dd0ed6504e6e65da0e45d0a9d4e/third_party/WebKit/Source/platform/scheduler/child/worker_scheduler.cc
[modify] https://crrev.com/053b619cf7ac1dd0ed6504e6e65da0e45d0a9d4e/third_party/WebKit/Source/platform/scheduler/child/worker_scheduler.h
[modify] https://crrev.com/053b619cf7ac1dd0ed6504e6e65da0e45d0a9d4e/third_party/WebKit/Source/platform/scheduler/child/worker_scheduler_proxy_unittest.cc
[modify] https://crrev.com/053b619cf7ac1dd0ed6504e6e65da0e45d0a9d4e/third_party/WebKit/Source/platform/testing/TestingPlatformSupportWithMockScheduler.cpp
[modify] https://crrev.com/053b619cf7ac1dd0ed6504e6e65da0e45d0a9d4e/third_party/WebKit/public/platform/DEPS
[modify] https://crrev.com/053b619cf7ac1dd0ed6504e6e65da0e45d0a9d4e/third_party/WebKit/public/platform/WebThread.h
[modify] https://crrev.com/053b619cf7ac1dd0ed6504e6e65da0e45d0a9d4e/third_party/WebKit/public/platform/scheduler/child/webthread_base.h

Project Member

Comment 28 by bugdroid1@chromium.org, Mar 19 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cf65cc9710e5b240d6cc63d625422e2851db95bb

commit cf65cc9710e5b240d6cc63d625422e2851db95bb
Author: Alexander Timin <altimin@chromium.org>
Date: Mon Mar 19 13:26:08 2018

[scheduler] Move throttling logic to scheduler/common.

Move throttling code to scheduler/common/ as a preparation to enable
throttling for worker threads.

R=alexclarke@chromium.org
BUG=776416

Change-Id: I78e4e249bcacf7ccc0c6feae48cd44a534c36a56
Reviewed-on: https://chromium-review.googlesource.com/966621
Commit-Queue: Alexander Timin <altimin@chromium.org>
Reviewed-by: Alex Clarke <alexclarke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544017}
[modify] https://crrev.com/cf65cc9710e5b240d6cc63d625422e2851db95bb/third_party/WebKit/Source/platform/scheduler/BUILD.gn
[add] https://crrev.com/cf65cc9710e5b240d6cc63d625422e2851db95bb/third_party/WebKit/Source/platform/scheduler/common/DEPS
[rename] https://crrev.com/cf65cc9710e5b240d6cc63d625422e2851db95bb/third_party/WebKit/Source/platform/scheduler/common/throttling/budget_pool.cc
[rename] https://crrev.com/cf65cc9710e5b240d6cc63d625422e2851db95bb/third_party/WebKit/Source/platform/scheduler/common/throttling/budget_pool.h
[rename] https://crrev.com/cf65cc9710e5b240d6cc63d625422e2851db95bb/third_party/WebKit/Source/platform/scheduler/common/throttling/budget_pool_unittest.cc
[rename] https://crrev.com/cf65cc9710e5b240d6cc63d625422e2851db95bb/third_party/WebKit/Source/platform/scheduler/common/throttling/cpu_time_budget_pool.cc
[rename] https://crrev.com/cf65cc9710e5b240d6cc63d625422e2851db95bb/third_party/WebKit/Source/platform/scheduler/common/throttling/cpu_time_budget_pool.h
[rename] https://crrev.com/cf65cc9710e5b240d6cc63d625422e2851db95bb/third_party/WebKit/Source/platform/scheduler/common/throttling/task_queue_throttler.cc
[rename] https://crrev.com/cf65cc9710e5b240d6cc63d625422e2851db95bb/third_party/WebKit/Source/platform/scheduler/common/throttling/task_queue_throttler.h
[rename] https://crrev.com/cf65cc9710e5b240d6cc63d625422e2851db95bb/third_party/WebKit/Source/platform/scheduler/common/throttling/task_queue_throttler_unittest.cc
[rename] https://crrev.com/cf65cc9710e5b240d6cc63d625422e2851db95bb/third_party/WebKit/Source/platform/scheduler/common/throttling/throttled_time_domain.cc
[rename] https://crrev.com/cf65cc9710e5b240d6cc63d625422e2851db95bb/third_party/WebKit/Source/platform/scheduler/common/throttling/throttled_time_domain.h
[rename] https://crrev.com/cf65cc9710e5b240d6cc63d625422e2851db95bb/third_party/WebKit/Source/platform/scheduler/common/throttling/wake_up_budget_pool.cc
[rename] https://crrev.com/cf65cc9710e5b240d6cc63d625422e2851db95bb/third_party/WebKit/Source/platform/scheduler/common/throttling/wake_up_budget_pool.h
[modify] https://crrev.com/cf65cc9710e5b240d6cc63d625422e2851db95bb/third_party/WebKit/Source/platform/scheduler/renderer/page_scheduler_impl.cc
[modify] https://crrev.com/cf65cc9710e5b240d6cc63d625422e2851db95bb/third_party/WebKit/Source/platform/scheduler/renderer/page_scheduler_impl.h
[modify] https://crrev.com/cf65cc9710e5b240d6cc63d625422e2851db95bb/third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl.cc
[modify] https://crrev.com/cf65cc9710e5b240d6cc63d625422e2851db95bb/third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl_unittest.cc
[modify] https://crrev.com/cf65cc9710e5b240d6cc63d625422e2851db95bb/third_party/WebKit/Source/platform/scheduler/renderer/web_frame_scheduler_impl.cc

Project Member

Comment 29 by bugdroid1@chromium.org, May 16 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/82e5626cfb82b16a96f37f4b54e58ffaca985522

commit 82e5626cfb82b16a96f37f4b54e58ffaca985522
Author: Alexander Timin <altimin@chromium.org>
Date: Wed May 16 10:44:25 2018

[scheduler] Split kThrottled into kHidden and kThrottled

Split FrameScheduler::ThrottlingState::kThrottled into kHidden (first 10
seconds after backgrounding) and kThrottled (after 10 seconds in
background, after full-scale throttling applies).

BUG=776416
R=alexclarke@chromium.org,haraken@chromium.org,kinuko@chromium.org

Change-Id: I5692bfbcbf19cca10a89678f4ab0a9c77c9162d0
Reviewed-on: https://chromium-review.googlesource.com/1059553
Reviewed-by: Alex Clarke <alexclarke@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Alexander Timin <altimin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#559032}
[modify] https://crrev.com/82e5626cfb82b16a96f37f4b54e58ffaca985522/third_party/blink/renderer/platform/loader/fetch/resource_load_scheduler.cc
[modify] https://crrev.com/82e5626cfb82b16a96f37f4b54e58ffaca985522/third_party/blink/renderer/platform/scheduler/child/worker_scheduler_proxy_unittest.cc
[modify] https://crrev.com/82e5626cfb82b16a96f37f4b54e58ffaca985522/third_party/blink/renderer/platform/scheduler/main_thread/frame_scheduler_impl.cc
[modify] https://crrev.com/82e5626cfb82b16a96f37f4b54e58ffaca985522/third_party/blink/renderer/platform/scheduler/main_thread/frame_scheduler_impl_unittest.cc
[modify] https://crrev.com/82e5626cfb82b16a96f37f4b54e58ffaca985522/third_party/blink/renderer/platform/scheduler/main_thread/page_scheduler_impl.cc
[modify] https://crrev.com/82e5626cfb82b16a96f37f4b54e58ffaca985522/third_party/blink/renderer/platform/scheduler/main_thread/page_scheduler_impl.h
[modify] https://crrev.com/82e5626cfb82b16a96f37f4b54e58ffaca985522/third_party/blink/renderer/platform/scheduler/main_thread/page_scheduler_impl_unittest.cc
[modify] https://crrev.com/82e5626cfb82b16a96f37f4b54e58ffaca985522/third_party/blink/renderer/platform/scheduler/public/frame_scheduler.h

Project Member

Comment 30 by bugdroid1@chromium.org, May 16 2018

Project Member

Comment 31 by bugdroid1@chromium.org, May 17 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/eca639d887341139b87660df775ef9dfe6871318

commit eca639d887341139b87660df775ef9dfe6871318
Author: Alexander Timin <altimin@chromium.org>
Date: Thu May 17 23:57:36 2018

[scheduler] Split worker task queue into default and throttleable.

Split throttleable tasks (timers and postMessages) into a separate task
queue in preparation for throttling them.

R=alexclarke@chromium.org
BUG=776416

Change-Id: Ibf3488d1e1a45cf54a51dd1fd31a667052f971fb
Reviewed-on: https://chromium-review.googlesource.com/1059781
Commit-Queue: Alexander Timin <altimin@chromium.org>
Reviewed-by: Alex Clarke <alexclarke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#559740}
[modify] https://crrev.com/eca639d887341139b87660df775ef9dfe6871318/third_party/blink/renderer/platform/scheduler/child/worker_scheduler.cc
[modify] https://crrev.com/eca639d887341139b87660df775ef9dfe6871318/third_party/blink/renderer/platform/scheduler/child/worker_scheduler.h

Project Member

Comment 32 by bugdroid1@chromium.org, May 23 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fda179ab357760462e8ca54a8097c48b76a13bfe

commit fda179ab357760462e8ca54a8097c48b76a13bfe
Author: Alexander Timin <altimin@chromium.org>
Date: Wed May 23 15:21:48 2018

[scheduler] Remove main thread dependency from throttling code.

Introduce ThreadSchedulerImpl as a base for MainThreadSchedulerImpl
and NonMainThreadSchedulerImpl and use it in TaskQueueThrottler.

In the future, when ThreadScheduler will be split into ThreadScheduler
and MainThreadScheduler and NonMainThreadScheduler will be split into
NonMainThreadScheduler and NonMainThreadSchedulerImpl it will mean
that ThreadScheduler appears twice in the inheritance tree, requiring
virtual inheritance (which is fine provided that it's an interface).

R=alexclarke@chromium.org,haraken@chromium.org,yutak@chromium.org
BUG=776416

Change-Id: Id242562aa9e69429b1b6391ef8b75828045b068d
Reviewed-on: https://chromium-review.googlesource.com/1065736
Commit-Queue: Alexander Timin <altimin@chromium.org>
Reviewed-by: Alex Clarke <alexclarke@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561092}
[modify] https://crrev.com/fda179ab357760462e8ca54a8097c48b76a13bfe/third_party/blink/public/platform/scheduler/web_main_thread_scheduler.h
[modify] https://crrev.com/fda179ab357760462e8ca54a8097c48b76a13bfe/third_party/blink/public/platform/scheduler/web_thread_scheduler.h
[modify] https://crrev.com/fda179ab357760462e8ca54a8097c48b76a13bfe/third_party/blink/renderer/core/dom/idle_deadline_test.cc
[modify] https://crrev.com/fda179ab357760462e8ca54a8097c48b76a13bfe/third_party/blink/renderer/core/dom/scripted_idle_task_controller_test.cc
[modify] https://crrev.com/fda179ab357760462e8ca54a8097c48b76a13bfe/third_party/blink/renderer/platform/scheduler/BUILD.gn
[add] https://crrev.com/fda179ab357760462e8ca54a8097c48b76a13bfe/third_party/blink/renderer/platform/scheduler/common/thread_scheduler_impl.h
[modify] https://crrev.com/fda179ab357760462e8ca54a8097c48b76a13bfe/third_party/blink/renderer/platform/scheduler/common/throttling/task_queue_throttler.cc
[modify] https://crrev.com/fda179ab357760462e8ca54a8097c48b76a13bfe/third_party/blink/renderer/platform/scheduler/common/throttling/task_queue_throttler.h
[modify] https://crrev.com/fda179ab357760462e8ca54a8097c48b76a13bfe/third_party/blink/renderer/platform/scheduler/common/throttling/task_queue_throttler_unittest.cc
[add] https://crrev.com/fda179ab357760462e8ca54a8097c48b76a13bfe/third_party/blink/renderer/platform/scheduler/common/web_thread_scheduler.cc
[modify] https://crrev.com/fda179ab357760462e8ca54a8097c48b76a13bfe/third_party/blink/renderer/platform/scheduler/main_thread/frame_scheduler_impl.cc
[modify] https://crrev.com/fda179ab357760462e8ca54a8097c48b76a13bfe/third_party/blink/renderer/platform/scheduler/main_thread/frame_scheduler_impl.h
[modify] https://crrev.com/fda179ab357760462e8ca54a8097c48b76a13bfe/third_party/blink/renderer/platform/scheduler/main_thread/main_thread_scheduler_impl.cc
[modify] https://crrev.com/fda179ab357760462e8ca54a8097c48b76a13bfe/third_party/blink/renderer/platform/scheduler/main_thread/main_thread_scheduler_impl.h
[modify] https://crrev.com/fda179ab357760462e8ca54a8097c48b76a13bfe/third_party/blink/renderer/platform/scheduler/main_thread/main_thread_scheduler_impl_unittest.cc
[modify] https://crrev.com/fda179ab357760462e8ca54a8097c48b76a13bfe/third_party/blink/renderer/platform/scheduler/main_thread/page_scheduler_impl.cc
[modify] https://crrev.com/fda179ab357760462e8ca54a8097c48b76a13bfe/third_party/blink/renderer/platform/scheduler/public/non_main_thread_scheduler.h
[modify] https://crrev.com/fda179ab357760462e8ca54a8097c48b76a13bfe/third_party/blink/renderer/platform/scheduler/public/thread_scheduler.h
[modify] https://crrev.com/fda179ab357760462e8ca54a8097c48b76a13bfe/third_party/blink/renderer/platform/scheduler/renderer/webthread_impl_for_renderer_scheduler_unittest.cc
[modify] https://crrev.com/fda179ab357760462e8ca54a8097c48b76a13bfe/third_party/blink/renderer/platform/scheduler/worker/non_main_thread_scheduler.cc
[modify] https://crrev.com/fda179ab357760462e8ca54a8097c48b76a13bfe/third_party/blink/renderer/platform/timer_test.cc

Cc: nhiroki@chromium.org haraken@chromium.org altimin@chromium.org alexclarke@chromium.org kinuko@chromium.org falken@chromium.org yuryu@chromium.org skyos...@chromium.org
 Issue 670534  has been merged into this issue.
Project Member

Comment 34 by bugdroid1@chromium.org, May 24 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f7369df04d3aabf9fe776098fbc92c5d4627a81c

commit f7369df04d3aabf9fe776098fbc92c5d4627a81c
Author: Alexander Timin <altimin@chromium.org>
Date: Thu May 24 19:02:27 2018

[scheduler] Create TaskQueueThrottler for worker thread

Add behind-a-feature-flag functionality to throttle tasks on the worker
thread to 1Hz.

R=alexclarke@chromium.org
BUG=776416

Change-Id: I1698aea8788f8688027e01af4d5e72405e2c1a23
Reviewed-on: https://chromium-review.googlesource.com/1070983
Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
Reviewed-by: Alex Clarke <alexclarke@chromium.org>
Commit-Queue: Alexander Timin <altimin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561578}
[modify] https://crrev.com/f7369df04d3aabf9fe776098fbc92c5d4627a81c/third_party/blink/renderer/platform/scheduler/child/features.h
[modify] https://crrev.com/f7369df04d3aabf9fe776098fbc92c5d4627a81c/third_party/blink/renderer/platform/scheduler/child/worker_scheduler.cc
[modify] https://crrev.com/f7369df04d3aabf9fe776098fbc92c5d4627a81c/third_party/blink/renderer/platform/scheduler/child/worker_scheduler.h
[modify] https://crrev.com/f7369df04d3aabf9fe776098fbc92c5d4627a81c/third_party/blink/renderer/platform/scheduler/child/worker_scheduler_unittest.cc
[modify] https://crrev.com/f7369df04d3aabf9fe776098fbc92c5d4627a81c/third_party/blink/renderer/platform/scheduler/common/throttling/task_queue_throttler.cc
[modify] https://crrev.com/f7369df04d3aabf9fe776098fbc92c5d4627a81c/third_party/blink/renderer/platform/scheduler/public/frame_scheduler.h
[modify] https://crrev.com/f7369df04d3aabf9fe776098fbc92c5d4627a81c/third_party/blink/renderer/platform/scheduler/public/non_main_thread_scheduler.h
[modify] https://crrev.com/f7369df04d3aabf9fe776098fbc92c5d4627a81c/third_party/blink/renderer/platform/scheduler/worker/non_main_thread_scheduler.cc
[modify] https://crrev.com/f7369df04d3aabf9fe776098fbc92c5d4627a81c/third_party/blink/renderer/platform/scheduler/worker/worker_thread_scheduler.cc
[modify] https://crrev.com/f7369df04d3aabf9fe776098fbc92c5d4627a81c/third_party/blink/renderer/platform/scheduler/worker/worker_thread_scheduler.h

Project Member

Comment 35 by bugdroid1@chromium.org, May 30 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2c0e08dd9c40fd1b66b6a596d5f268e2cd612861

commit 2c0e08dd9c40fd1b66b6a596d5f268e2cd612861
Author: Alexander Timin <altimin@chromium.org>
Date: Wed May 30 15:55:55 2018

[scheduler] Add finch control for enabling worker throttling

Allow triggering throttling and controlling throttling aggressiveness
via Finch.

R=alexclarke@chromium.org,skyostil@chromium.org
BUG=776416

Change-Id: Id1d4cbc9ed220490bb011d801a965ca9a0c884a5
Reviewed-on: https://chromium-review.googlesource.com/1073422
Commit-Queue: Alexander Timin <altimin@chromium.org>
Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
Cr-Commit-Position: refs/heads/master@{#562854}
[modify] https://crrev.com/2c0e08dd9c40fd1b66b6a596d5f268e2cd612861/third_party/blink/renderer/platform/scheduler/child/worker_scheduler.cc
[modify] https://crrev.com/2c0e08dd9c40fd1b66b6a596d5f268e2cd612861/third_party/blink/renderer/platform/scheduler/child/worker_scheduler.h
[modify] https://crrev.com/2c0e08dd9c40fd1b66b6a596d5f268e2cd612861/third_party/blink/renderer/platform/scheduler/child/worker_scheduler_unittest.cc
[modify] https://crrev.com/2c0e08dd9c40fd1b66b6a596d5f268e2cd612861/third_party/blink/renderer/platform/scheduler/public/non_main_thread_scheduler.h
[modify] https://crrev.com/2c0e08dd9c40fd1b66b6a596d5f268e2cd612861/third_party/blink/renderer/platform/scheduler/worker/worker_thread_scheduler.cc
[modify] https://crrev.com/2c0e08dd9c40fd1b66b6a596d5f268e2cd612861/third_party/blink/renderer/platform/scheduler/worker/worker_thread_scheduler.h

Project Member

Comment 36 by bugdroid1@chromium.org, May 31 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/62c5e2f7834013df7e138fe1536dee67bf686e52

commit 62c5e2f7834013df7e138fe1536dee67bf686e52
Author: Alexander Timin <altimin@chromium.org>
Date: Thu May 31 17:56:43 2018

[scheduler] Enable dedicated worker throttling on the waterfall

R=rkaplow@chromium.org
BUG=776416

Change-Id: I966c5119ee23bc0741a3339510d52f74848a6c34
Reviewed-on: https://chromium-review.googlesource.com/1080628
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Commit-Queue: Alexander Timin <altimin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#563311}
[modify] https://crrev.com/62c5e2f7834013df7e138fe1536dee67bf686e52/testing/variations/fieldtrial_testing_config.json
[modify] https://crrev.com/62c5e2f7834013df7e138fe1536dee67bf686e52/third_party/blink/renderer/platform/scheduler/child/features.h

Status: Started (was: Assigned)
Labels: -Type-Bug Type-Feature
Project Member

Comment 39 by bugdroid1@chromium.org, Oct 17

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ff9c31436aa211d1e05b1fb303b27554adf96cf1

commit ff9c31436aa211d1e05b1fb303b27554adf96cf1
Author: Daniel Bratell <bratell@opera.com>
Date: Wed Oct 17 17:39:21 2018

Removed reference to deleted scheduler/util/thread_type.h

scheduler/util/thread_type.h was deleted in January but the
reference to it in BUILD.gn remained. Now that seems to make
the isolate step in trybots sad.

Bug: 776416
Change-Id: Iff685c54def879a8c5a53c9893f1c7eef4c9c13c
Reviewed-on: https://chromium-review.googlesource.com/c/1286851
Commit-Queue: Daniel Bratell <bratell@opera.com>
Commit-Queue: Alexander Timin <altimin@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600455}
[modify] https://crrev.com/ff9c31436aa211d1e05b1fb303b27554adf96cf1/third_party/blink/renderer/platform/scheduler/BUILD.gn

Sign in to add a comment