New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 776393 link

Starred by 1 user

Issue metadata

Status: Duplicate
Merged: issue 774544
Owner: ----
Closed: Oct 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

1.5% regression in memory.top_10_mobile at 508622:508671

Project Member Reported by chiniforooshan@chromium.org, Oct 19 2017

Issue description

See the link to graphs below.
 
Project Member

Comment 1 by 42576172...@developer.gserviceaccount.com, Oct 19 2017

All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=776393

(For debugging:) Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?sid=b143b5e60a7c83cfa3eed066e222572aff5df5723b8611b4a8ecfda9e8c190c0


Bot(s) for this bug's original alert(s):

android-nexus5X
Project Member

Comment 3 by 42576172...@developer.gserviceaccount.com, Oct 19 2017

Cc: marian...@google.com
Owner: marian...@google.com
Status: Assigned (was: Untriaged)

=== Auto-CCing suspected CL author mariannet@google.com ===

Hi mariannet@google.com, the bisect results pointed to your CL, please take a look at the
results.


=== BISECT JOB RESULTS ===
Perf regression found with culprit

Suspected Commit
  Author : mariannet
  Commit : 711ce10ff9c70eff63caaba0db11ea038ffbaa5b
  Date   : Fri Oct 13 07:29:00 2017
  Subject: Allow images to take up more space.

Bisect Details
  Configuration: android_nexus5X_perf_bisect
  Benchmark    : memory.top_10_mobile
  Metric       : memory:chrome:all_processes:reported_by_os:system_memory:native_heap:proportional_resident_size_avg/background/after_http_m_youtube_com_results_q_science
  Change       : 1.30% | 40364317.7778 -> 40887126.6667

Revision             Result                   N
chromium@508621      40364318 +- 846308       9       good
chromium@508634      40253100 +- 1623948      14      good
chromium@508635      41000620 +- 1012231      6       bad       <--
chromium@508637      40600602 +- 2064743      14      bad
chromium@508640      40786775 +- 887855       9       bad
chromium@508646      40731966 +- 931730       14      bad
chromium@508671      40887127 +- 756911       9       bad

Please refer to the following doc on diagnosing memory regressions:
  https://chromium.googlesource.com/chromium/src/+/master/docs/memory-infra/memory_benchmarks.md

To Run This Test
  src/tools/perf/run_benchmark -v --browser=android-chromium --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests --story-filter=http.m.youtube.com.results.q.science memory.top_10_mobile

More information on addressing performance regressions:
  http://g.co/ChromePerformanceRegressions

Debug information about this bisect:
  https://chromeperf.appspot.com/buildbucket_job_status/8965292202468773312


For feedback, file a bug with component Speed>Bisection
Hi, I have two concerns about this bug.

* I'm on ChromeOS and only touched code relating to the FilesApp which is only used on Chromebooks, so I'm not sure how that correlates to android devices.
* The CL only touched a single file which is a CSS file, so even if for some reason ChromeOS-only code would affect android devices, I don't see how that would cause any memory leaks

I'm still new to both the team (started about 2 months ago) and CSS (I never wrote CSS before joining this team), so there might be something I'm missing here, I'm mainly just very confused about this whole thing :)
Cc: perezju@chromium.org simonhatch@chromium.org
Owner: ----
Status: (was: Assigned)
mariannet: Thanks for the clear overview of your CL. It does look like something went strangely with the bisect; I'm going to try re-running.

+perezju, owner of this test, to see if he has any ideas what could have happened here, and +simonhatch, isn't there a script somewhere which could show us the output of the bisect in run order? It kinda looks like maybe this just increased on each run?
Re-kicked the bisect, and tried a wider range because the graph climbs slowly.
Project Member

Comment 8 by 42576172...@developer.gserviceaccount.com, Oct 20 2017

Mergedinto: 774544
Status: Duplicate

=== BISECT JOB RESULTS ===
Perf regression found with culprit

Suspected Commit
  Author : Stephen Chenney
  Commit : 8ff2371257ac4f24d77da4a62569840a53c49b47
  Date   : Thu Oct 12 13:11:52 2017
  Subject: Prevent squashing of border-radius layers

Bisect Details
  Configuration: android_nexus5X_perf_bisect
  Benchmark    : memory.top_10_mobile
  Metric       : memory:chrome:all_processes:reported_by_os:system_memory:native_heap:proportional_resident_size_avg/background/after_http_m_youtube_com_results_q_science
  Change       : 2.13% | 39565654.6667 -> 40409942.6667

Revision             Result                   N
chromium@508272      39565655 +- 649105       6       good
chromium@508314      39859486 +- 895748       9       good
chromium@508325      40141923 +- 779392       14      good
chromium@508328      40179226 +- 1396056      14      good
chromium@508329      40582243 +- 802655       14      bad       <--
chromium@508330      40783930 +- 640242       9       bad
chromium@508335      40571052 +- 779535       9       bad
chromium@508355      40597335 +- 882785       6       bad
chromium@508438      40516097 +- 417126       6       bad
chromium@508603      40226533 +- 985090       9       bad
chromium@508934      40409943 +- 696347       6       bad

Please refer to the following doc on diagnosing memory regressions:
  https://chromium.googlesource.com/chromium/src/+/master/docs/memory-infra/memory_benchmarks.md

To Run This Test
  src/tools/perf/run_benchmark -v --browser=android-chromium --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests --story-filter=http.m.youtube.com.results.q.science memory.top_10_mobile

More information on addressing performance regressions:
  http://g.co/ChromePerformanceRegressions

Debug information about this bisect:
  https://chromeperf.appspot.com/buildbucket_job_status/8965209427321036592


For feedback, file a bug with component Speed>Bisection

Sign in to add a comment