New issue
Advanced search Search tips

Issue 776385 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Dec 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

arc-setup: blocked syscall 273

Project Member Reported by groeck@chromium.org, Oct 19 2017

Issue description

This is seen in the kernel log with recent 3.18 and 4.4 kernels:

"[3191] arc-setup: blocked syscall 273"

syscall appears to be

arch/x86/syscalls/syscall_64.tbl:273    64  set_robust_list     sys_set_robust_list

I didn't research when exactly the problem started.

Additional info from yusukes@:

"Starting M63-10032.0.0 (built Oct 13 pm PT), arc-setup sometimes forks and executes a new minijail'ed process to run Android's /system/bin/dex2oat host-side (https://chrome-internal-review.googlesource.com/c/chromeos/cheets-scripts/+/474652 ), which might be related to the message."

 

Comment 2 by vapier@chromium.org, Oct 19 2017

if we want to whitelist the syscall, update security/chromiumos/alt-syscall.c in the kernel to add the syscall to the android tables

Comment 3 by groeck@chromium.org, Oct 19 2017

... and don't forget to export the syscall symbol.

Comment 4 by groeck@chromium.org, Nov 18 2017

Labels: Kernel-4.14
Still seen with chromeos-4.14.

Comment 5 by xzhou@chromium.org, Nov 20 2017

This is caused by running patchoat that relocates Android boot.art file. I attached a strace log when running patchoat.

Do I need a security review before white listing the syscall?
strace_art_container.txt
241 KB View Download

Comment 6 by dgreid@chromium.org, Nov 20 2017

We can add that to the white list. It could be needed by other apps too.
set_robust_list is probably OK to be added.
Status: Assigned (was: Untriaged)
comment #5
Does this mean that the patchoat container is not working properly?
Project Member

Comment 9 by bugdroid1@chromium.org, Nov 30 2017

Labels: merge-merged-chromeos-3.18
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/kernel/+/2a9570c6b88c653090a6449b0b3610c7f4878dca

commit 2a9570c6b88c653090a6449b0b3610c7f4878dca
Author: Xiaoyong Zhou <xzhou@chromium.org>
Date: Thu Nov 30 02:05:05 2017

CHROMIUM: Whitelist set_robust_list

ARC need to call android patchoat to relocate boot.art images
and patchoat needs set_robust_list.

Signed-off-by: Xiaoyong Zhou <xzhou@chromium.org>

BUG= chromium:776385 
TEST=start ARC and 'dmesg | grep blocked'

Change-Id: I9161d1a4d87802f13355279edc1d3baec2bb5b85
Reviewed-on: https://chromium-review.googlesource.com/794898
Commit-Ready: Xiaoyong Zhou <xzhou@chromium.org>
Tested-by: Xiaoyong Zhou <xzhou@chromium.org>
Reviewed-by: Yusuke Sato <yusukes@chromium.org>
Reviewed-by: Guenter Roeck <groeck@chromium.org>

[modify] https://crrev.com/2a9570c6b88c653090a6449b0b3610c7f4878dca/security/chromiumos/alt-syscall.c
[modify] https://crrev.com/2a9570c6b88c653090a6449b0b3610c7f4878dca/kernel/futex.c

Project Member

Comment 10 by bugdroid1@chromium.org, Dec 1 2017

Labels: merge-merged-chromeos-3.14
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/kernel/+/9b27c40e7e998c701b4a72b3a744c5dc3a1ed548

commit 9b27c40e7e998c701b4a72b3a744c5dc3a1ed548
Author: Xiaoyong Zhou <xzhou@chromium.org>
Date: Fri Dec 01 04:30:22 2017

CHROMIUM: Whitelist set_robust_list

ARC need to call android patchoat to relocate boot.art images
and patchoat needs set_robust_list.

Signed-off-by: Xiaoyong Zhou <xzhou@chromium.org>

BUG= chromium:776385 
TEST=start ARC and 'dmesg | grep blocked'

Change-Id: I9161d1a4d87802f13355279edc1d3baec2bb5b85
Reviewed-on: https://chromium-review.googlesource.com/794898
Commit-Ready: Xiaoyong Zhou <xzhou@chromium.org>
Tested-by: Xiaoyong Zhou <xzhou@chromium.org>
Reviewed-by: Yusuke Sato <yusukes@chromium.org>
Reviewed-by: Guenter Roeck <groeck@chromium.org>
(cherry picked from commit 2a9570c6b88c653090a6449b0b3610c7f4878dca)
Reviewed-on: https://chromium-review.googlesource.com/802250
Commit-Ready: Guenter Roeck <groeck@chromium.org>
Tested-by: Guenter Roeck <groeck@chromium.org>
Reviewed-by: Xiaoyong Zhou <xzhou@chromium.org>
Reviewed-by: Dylan Reid <dgreid@chromium.org>

[modify] https://crrev.com/9b27c40e7e998c701b4a72b3a744c5dc3a1ed548/security/chromiumos/alt-syscall.c
[modify] https://crrev.com/9b27c40e7e998c701b4a72b3a744c5dc3a1ed548/kernel/futex.c

Project Member

Comment 11 by bugdroid1@chromium.org, Dec 1 2017

Labels: merge-merged-chromeos-4.14
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/kernel/+/1f7b2f1595470255686c5246a7232d5155ed8244

commit 1f7b2f1595470255686c5246a7232d5155ed8244
Author: Xiaoyong Zhou <xzhou@chromium.org>
Date: Fri Dec 01 04:30:21 2017

CHROMIUM: Whitelist set_robust_list

ARC need to call android patchoat to relocate boot.art images
and patchoat needs set_robust_list.

Signed-off-by: Xiaoyong Zhou <xzhou@chromium.org>

BUG= chromium:776385 
TEST=start ARC and 'dmesg | grep blocked'

Change-Id: I9161d1a4d87802f13355279edc1d3baec2bb5b85
Reviewed-on: https://chromium-review.googlesource.com/794898
Commit-Ready: Xiaoyong Zhou <xzhou@chromium.org>
Tested-by: Xiaoyong Zhou <xzhou@chromium.org>
Reviewed-by: Yusuke Sato <yusukes@chromium.org>
Reviewed-by: Guenter Roeck <groeck@chromium.org>
(cherry picked from commit 2a9570c6b88c653090a6449b0b3610c7f4878dca)
Reviewed-on: https://chromium-review.googlesource.com/801254
Commit-Ready: Guenter Roeck <groeck@chromium.org>
Tested-by: Guenter Roeck <groeck@chromium.org>
Reviewed-by: Xiaoyong Zhou <xzhou@chromium.org>
Reviewed-by: Dylan Reid <dgreid@chromium.org>

[modify] https://crrev.com/1f7b2f1595470255686c5246a7232d5155ed8244/security/chromiumos/alt-syscall.c
[modify] https://crrev.com/1f7b2f1595470255686c5246a7232d5155ed8244/kernel/futex.c

Project Member

Comment 12 by bugdroid1@chromium.org, Dec 1 2017

Labels: merge-merged-chromeos-4.4
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/kernel/+/aa8bc0aca8ab62d9efb5eaaa63096a3d4c17a364

commit aa8bc0aca8ab62d9efb5eaaa63096a3d4c17a364
Author: Xiaoyong Zhou <xzhou@chromium.org>
Date: Fri Dec 01 04:30:19 2017

CHROMIUM: Whitelist set_robust_list

ARC need to call android patchoat to relocate boot.art images
and patchoat needs set_robust_list.

Signed-off-by: Xiaoyong Zhou <xzhou@chromium.org>

BUG= chromium:776385 
TEST=start ARC and 'dmesg | grep blocked'

Change-Id: I9161d1a4d87802f13355279edc1d3baec2bb5b85
Reviewed-on: https://chromium-review.googlesource.com/794898
Commit-Ready: Xiaoyong Zhou <xzhou@chromium.org>
Tested-by: Xiaoyong Zhou <xzhou@chromium.org>
Reviewed-by: Yusuke Sato <yusukes@chromium.org>
Reviewed-by: Guenter Roeck <groeck@chromium.org>
(cherry picked from commit 2a9570c6b88c653090a6449b0b3610c7f4878dca)
Reviewed-on: https://chromium-review.googlesource.com/801105
Commit-Ready: Guenter Roeck <groeck@chromium.org>
Tested-by: Guenter Roeck <groeck@chromium.org>
Reviewed-by: Xiaoyong Zhou <xzhou@chromium.org>
Reviewed-by: Dylan Reid <dgreid@chromium.org>

[modify] https://crrev.com/aa8bc0aca8ab62d9efb5eaaa63096a3d4c17a364/security/chromiumos/alt-syscall.c
[modify] https://crrev.com/aa8bc0aca8ab62d9efb5eaaa63096a3d4c17a364/kernel/futex.c

Status: Fixed (was: Assigned)
Patched.

Sign in to add a comment