Issue metadata
Sign in to add a comment
|
63.4% regression in system_health.memory_mobile at 509708:509759 |
||||||||||||||||||||
Issue descriptionSee the link to graphs below.
,
Oct 19 2017
Started bisect job https://chromeperf.appspot.com/buildbucket_job_status/8965293436857349376
,
Oct 20 2017
=== Auto-CCing suspected CL author ksakamoto@chromium.org === Hi ksakamoto@chromium.org, the bisect results pointed to your CL, please take a look at the results. === BISECT JOB RESULTS === Perf regression found with culprit Suspected Commit Author : Kunihiko Sakamoto Commit : 07ec68095dc07849019a7362ba6cc67625c95c0b Date : Wed Oct 18 10:35:41 2017 Subject: Simplify CSSFontFaceSource a bit Bisect Details Configuration: android_webview_arm64_aosp_perf_bisect Benchmark : system_health.memory_mobile Metric : memory:webview:all_processes:reported_by_chrome:cc:effective_size_avg/load_news/load_news_cnn Change : 63.42% | 16469668.0 -> 26914468.0 Revision Result N chromium@509707 16469668 +- 0.0 6 good chromium@509720 16469668 +- 0.0 6 good chromium@509727 16469668 +- 0.0 6 good chromium@509729 16469668 +- 0.0 6 good chromium@509730 29003428 +- 0.0 6 bad <-- chromium@509733 26914468 +- 11441705 6 bad chromium@509759 26914468 +- 11441705 6 bad Please refer to the following doc on diagnosing memory regressions: https://chromium.googlesource.com/chromium/src/+/master/docs/memory-infra/memory_benchmarks.md To Run This Test src/tools/perf/run_benchmark -v --browser=android-webview --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests --story-filter=load.news.cnn system_health.memory_mobile More information on addressing performance regressions: http://g.co/ChromePerformanceRegressions Debug information about this bisect: https://chromeperf.appspot.com/buildbucket_job_status/8965293436857349376 For feedback, file a bug with component Speed>Bisection
,
Oct 20 2017
My patch might have caused over-triggering of font invalidation. I'll make a fix.
,
Oct 20 2017
,
Oct 21 2017
Issue 776926 has been merged into this issue.
,
Oct 21 2017
Issue 776791 has been merged into this issue.
,
Oct 23 2017
,
Oct 23 2017
,
Oct 23 2017
Issue 777403 has been merged into this issue.
,
Oct 24 2017
,
Oct 24 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/cdca7f33c3b9d7796a105a94b0cb5ad63d43af19 commit cdca7f33c3b9d7796a105a94b0cb5ad63d43af19 Author: Kunihiko Sakamoto <ksakamoto@chromium.org> Date: Tue Oct 24 03:08:15 2017 Prevent over-triggering of font invalidation FontSelector::FontFaceInvalidated() is expensive since it causes full style recalculation. This patch lets RemoteFontFaceSource not to call it when unnecessary (e.g. in the middle of FontFace construction). This will hopefully fix memory regression by https://crrev.com/c/722141. Bug: 776384 Change-Id: I86a9b27be2fd65f51cc6057a7c897f588c4897ce Reviewed-on: https://chromium-review.googlesource.com/730032 Reviewed-by: Takashi Toyoshima <toyoshim@chromium.org> Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#511024} [modify] https://crrev.com/cdca7f33c3b9d7796a105a94b0cb5ad63d43af19/third_party/WebKit/Source/core/css/CSSFontFace.cpp [modify] https://crrev.com/cdca7f33c3b9d7796a105a94b0cb5ad63d43af19/third_party/WebKit/Source/core/css/CSSFontFace.h [modify] https://crrev.com/cdca7f33c3b9d7796a105a94b0cb5ad63d43af19/third_party/WebKit/Source/core/css/RemoteFontFaceSource.cpp
,
Oct 26 2017
OK, regressions recovered. |
|||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||
Comment 1 by 42576172...@developer.gserviceaccount.com
, Oct 19 2017