New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 776366 link

Starred by 2 users

Issue metadata

Status: WontFix
Owner: ----
Closed: Nov 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 2
Type: Bug



Sign in to add a comment

Stack-overflow in blink::PrePaintTreeWalk::Walk

Project Member Reported by ClusterFuzz, Oct 19 2017

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=6741825858830336

Fuzzer: ochang_domfuzzer
Job Type: linux_asan_chrome_mp
Platform Id: linux

Crash Type: Stack-overflow
Crash Address: 0x7ffc812e8898
Crash State:
  blink::PrePaintTreeWalk::Walk
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=linux_asan_chrome_mp&range=461467:461491

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=6741825858830336

Issue filed automatically.

See https://github.com/google/clusterfuzz-tools for more information.
 
Project Member

Comment 1 by ClusterFuzz, Oct 19 2017

Components: Blink>Paint
Labels: Test-Predator-AutoComponents
Automatically applying components based on crash stacktrace and information from OWNERS files.

If this is incorrect, please apply the Test-Predator-Wrong-Components label.
Project Member

Comment 2 by ClusterFuzz, Oct 19 2017

Labels: Test-Predator-AutoOwner
Owner: chrishtr@chromium.org
Status: Assigned (was: Untriaged)
Automatically assigning owner based on suspected regression changelist https://chromium.googlesource.com/chromium/src/+/ca2623e17b5c45400485a2ceb08545baa9f09c4f (Optimize ClipRects in the PrePaintTreeWalk.).

If this is incorrect, please remove the owner and apply the Test-Predator-Wrong-CLs label.
Labels: -Pri-1 Pri-2
Not clear that we need to support 3000 level deep nested elements. I'd be happy WontFix on this.
Status: WontFix (was: Assigned)
Project Member

Comment 5 by ClusterFuzz, Nov 2 2017

Labels: Needs-Feedback
ClusterFuzz testcase 6741825858830336 is still reproducing on tip-of-tree build (trunk).

If this testcase was not reproducible locally or unworkable, ignore this notification and we will file another bug soon with hopefully a better and workable testcase.

Otherwise, if this is not intended to be fixed (e.g. this is an intentional crash), please add ClusterFuzz-Ignore label to prevent future bug filing with similar crash stacktrace.
Labels: ClusterFuzz-Ignore

Comment 7 by brat...@opera.com, Nov 3 2017

Cc: gmia...@opera.com brat...@opera.com
Labels: -Pri-2 Pri-1
Status: Untriaged (was: WontFix)
This is a common crash in real world (top blink crash by far), judging from Opera crash reports. Some 370 nested calls to blink::PrePaintTreeWalk::Walk(blink::LayoutObject const&, blink::PrePaintTreeWalkContext const&) ending with a crash. 

Crash Reason	EXCEPTION_STACK_OVERFLOW

Something needs to not be recursive or use much less stack if it is recursive. Example of a common url triggering it: https://clients5.google.com/pagead/drt/dn/
Status: Assigned (was: Untriaged)
Updating the status to 'Assigned'.

Comment 9 by brat...@opera.com, Nov 3 2017

A note, what I said above was for Chromium 61. I can't see a similar crash in top 10 for 62 and 63 in Opera so maybe it used to be worse than it is now, and now is ok?
Labels: -Pri-1 Pri-2
Owner: ----
Status: Available (was: Assigned)
Nevertheless I WontFixed this bug as this is not a security issue.

Comment 11 by brat...@opera.com, Nov 6 2017

Status: WontFix (was: Available)
This is tracked in bug 781301 so closing this one again.
Labels: -Test-Predator-AutoComponents Test-Predator-Auto-Components
Labels: -Test-Predator-AutoOwner Test-Predator-Auto-Owner
Project Member

Comment 14 by ClusterFuzz, Nov 18 2017

ClusterFuzz has detected this issue as fixed in range 514498:517698.

Detailed report: https://clusterfuzz.com/testcase?key=6741825858830336

Fuzzer: ochang_domfuzzer
Job Type: linux_asan_chrome_mp
Platform Id: linux

Crash Type: Stack-overflow
Crash Address: 0x7ffc812e8898
Crash State:
  blink::PrePaintTreeWalk::Walk
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=linux_asan_chrome_mp&range=461467:461491
Fixed: https://clusterfuzz.com/revisions?job=linux_asan_chrome_mp&range=514498:517698

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=6741825858830336

See https://github.com/google/clusterfuzz-tools for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.

Sign in to add a comment