New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 776362 link

Starred by 1 user
Status: Duplicate
Merged: issue 773552
Owner:
akes...@chromium.org
Closed: Oct 2017
Cc:
akes...@chromium.org
█ davidjames@chromium.org
█ nxia@chromium.org
tandrii@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Co-dependent changes failed to be committed with "not eligible" message

Project Member Reported by derat@chromium.org, Oct 19 2017 
I'm trying to commit these two changes:

https://crrev.com/c/707180
https://crrev.com/c/707181

Each has a CQ-DEPEND line depending on the other.

At Oct 18 20:53:56, 707180 failed to be applied with "CL:707180 depends on CL:707181, which is not marked Commit-Queue>=+1."

At Oct 18 19:25:19, 707181 failed to be applied with "CL:707181 depends on CL:707180, which was not eligible (wrong manifest branch, wrong labels, or otherwise filtered from eligible set)."

What happened here? I don't see any reason why both of these changes couldn't be applied together. I think they both became eligible to be committed at around the same time. Can the second message be made more descriptive?

Comment 1 by akes...@chromium.org, Oct 19 2017

Cc: nxia@chromium.org
Owner: akes...@chromium.org
The "otherwise filtered" message is the message of last resort after a long and convoluted logic chain, which I added a while back because various CLs were failing with something even more cryptic. Agreed it should be more descriptive.

I've seen this confusion before, I'll take a look.

Comment 2 by derat@chromium.org, Oct 19 2017 

These changes seem like they're still in a weird state:

07:36: CQ picks up 707180 and 707181
10:09: CQ rejects 707180: "CL:707180 depends on CL:707181, which was rejected by the CQ."
10:10: CQ announces failure on 707181 due to infra issues
10:22: CQ boots 707181: "CL:707181 depends on CL:707180, which is not marked Commit-Queue>=+1."

I don't understand the message at 10:09. 707181 doesn't look like it was rejected by the CQ.

Comment 3 by nxia@chromium.org, Oct 19 2017 

CL:707180 was verified with ['strategy:cq-submit-partial-pool-builds-passed' but CL:707181 wasn't. They depend on each other, so CQ can't submit them. This should be long standing bug. 


10:09:18: INFO: Change CL:707180 is verified with reasons ['strategy:cq-submit-partial-pool-builds-passed'], choose the final reason strategy:cq-submit-partial-pool-builds-passed.

10:09:18: INFO: Failed to verify change CL:707181: relevant build veyron_minnie-paladin failed with not ignorable failures in current run and didn't pass in history

Comment 4 by nxia@chromium.org, Oct 19 2017

Mergedinto: 773552
Status: Duplicate (was: Untriaged)
►

Sign in to add a comment