New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 776348 link

Starred by 10 users

Issue metadata

Status: WontFix
Owner: ----
Closed: May 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

enable_webrtc=false build broken after Fuchsia-related commits

Project Member Reported by raphael....@intel.com, Oct 19 2017

Issue description

Even though the enable_webrtc=false build configuration isn't normally tested by the regular bots, it tends to be well-maintained on a best-effort basis.

I was trying to build master here (this is a regular desktop Linux build) and noticed a few hiccups.

* Commit 3e22361a675c05a9e878be2396e220d97cc3378f (https://chromium-review.googlesource.com/605067) causes a link error:

/data/src/chromium/src/out/Release-nowebrtc/../../third_party/llvm-build/Release+Asserts/bin/ld.lld: error: undefined symbol: content::CreateDesktopCaptureOptions()
>>> referenced by desktop_capture_base.cc
>>>               desktop_capture_base.o:(extensions::DesktopCaptureChooseDesktopMediaFunctionBase::Execute(std::__1::vector<extensions::api::desktop_capture::DesktopCaptureSourceType, std::__1::allocator<extensions::api::desktop_capture::DesktopCaptureSourceType> > const&, content::WebContents*, GURL const&, std::__1::basic_string<unsigned short, base::string16_internals::string16_char_traits, std::__1::allocator<unsigned short> >)) in archive obj/chrome/browser/extensions/libextensions.a

/data/src/chromium/src/out/Release-nowebrtc/../../third_party/llvm-build/Release+Asserts/bin/ld.lld: error: undefined symbol: content::CreateDesktopCaptureOptions()
>>> referenced by desktop_capture_base.cc
>>>               desktop_capture_base.o:(extensions::DesktopCaptureChooseDesktopMediaFunctionBase::Execute(std::__1::vector<extensions::api::desktop_capture::DesktopCaptureSourceType, std::__1::allocator<extensions::api::desktop_capture::DesktopCaptureSourceType> > const&, content::WebContents*, GURL const&, std::__1::basic_string<unsigned short, base::string16_internals::string16_char_traits, std::__1::allocator<unsigned short> >)) in archive obj/chrome/browser/extensions/libextensions.a

* Commit 9db4b1582e7bac38d95f0b22e6904d4fa0cf07eb (https://chromium-review.googlesource.com/714121) causes build errors:

In file included from ../../chrome/browser/media/webrtc/window_icon_util_x11.cc:5:
In file included from ../../chrome/browser/media/webrtc/window_icon_util.h:9:
../../third_party/webrtc/modules/desktop_capture/desktop_capture_options.h:13:10: fatal error: 'rtc_base/constructormagic.h' file not found
#include "rtc_base/constructormagic.h"

In file included from ../../chrome/browser/media/webrtc/desktop_capture_access_handler.cc:37:
../../third_party/webrtc/modules/desktop_capture/desktop_capture_types.h:16:10: fatal error: 'typedefs.h' file not found
#include "typedefs.h"  // NOLINT(build/include)

In file included from ../../chrome/browser/media/webrtc/native_desktop_media_list.cc:16:
../../third_party/webrtc/modules/desktop_capture/desktop_capturer.h:22:10: fatal error: 'modules/desktop_capture/desktop_frame.h' file not found
#include "modules/desktop_capture/desktop_frame.h"

 
Cc: viswatej...@techmahindra.com sc00335...@techmahindra.com
 Issue 797522  has been merged into this issue.

Comment 2 by gd...@iragan.org, Dec 31 2017

Attaching patch provided in  issue 797522  to fix build (tested for target_os=android)
chromium-allow-build-without-webrtc.patch
14.9 KB Download
Can you send the patch above via Gerrit?
doesnt work for linux

Comment 6 by gd...@iragan.org, Jan 5 2018

@raphael I tried, spent a few hours on it. I am giving up, sorry.
@juanka85 it is not tested for Linux-only builds, it was mentioned in  issue 797522 . It should not be too much work to add support for that, feel free to add it.

Comment 7 by w...@chromium.org, May 21 2018

Cc: phoglund@chromium.org
Status: WontFix (was: Available)
Obsolete, since the |enable_webrtc| build argument is now gone.

Sign in to add a comment