New issue
Advanced search Search tips

Issue 776340 link

Starred by 2 users
Status: Verified
Owner:
gambard@chromium.org
Closed: Oct 2017
Cc:
ios-bugs-priority@chromium.org
ios-bugs@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 1
Type: Bug



Sign in to add a comment

Toolbar controls do not respect safe area on iPhone X

Project Member Reported by gambard@chromium.org, Oct 19 2017 
Chrome Version: 64
OS: iOS 11
iPhone X

What steps will reproduce the problem?
(1) Launch the app in landscape
(2) Open any page

What is the expected result?
The toolbar should respect the safe area.

What happens instead?
The back and toolmenu controls are outside of the safe area.

Screenshot: https://drive.google.com/file/d/0By4O1f2IQqQ_SXhzRDVGdW56OWc/view
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 19 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bf38224605234c859e7d73b9f5883180bf116524

commit bf38224605234c859e7d73b9f5883180bf116524
Author: Gauthier Ambard <gambard@chromium.org>
Date: Thu Oct 19 14:51:28 2017

Toolbar content respects safe area

The content of the toolbar needs to respect the safe area. This CL
fixes the content displayed outside of the safe area by creating a
contentView respecting the safe area boundaries.
The content is added to this view instead of the ToolbarView.

This also makes the back menu dropdown to be displayed inside the safe
area.
It also dismisses it during device rotation.

Bug:  765304 ,  776340 ,  764877 
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: Ia4f5b8499644b0b406a94a723bde1a6d80928cd0
Reviewed-on: https://chromium-review.googlesource.com/727890
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Reviewed-by: Rohit Rao (ping after 24h) <rohitrao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510083}
[modify] https://crrev.com/bf38224605234c859e7d73b9f5883180bf116524/ios/chrome/browser/ui/browser_view_controller.mm
[modify] https://crrev.com/bf38224605234c859e7d73b9f5883180bf116524/ios/chrome/browser/ui/ntp/new_tab_page_toolbar_controller.mm
[modify] https://crrev.com/bf38224605234c859e7d73b9f5883180bf116524/ios/chrome/browser/ui/stack_view/stack_view_toolbar_controller.mm
[modify] https://crrev.com/bf38224605234c859e7d73b9f5883180bf116524/ios/chrome/browser/ui/toolbar/toolbar_controller.h
[modify] https://crrev.com/bf38224605234c859e7d73b9f5883180bf116524/ios/chrome/browser/ui/toolbar/toolbar_controller.mm
[modify] https://crrev.com/bf38224605234c859e7d73b9f5883180bf116524/ios/chrome/browser/ui/toolbar/web_toolbar_controller.mm
[modify] https://crrev.com/bf38224605234c859e7d73b9f5883180bf116524/ios/chrome/browser/ui/tools_menu/tools_popup_controller.mm

Comment 2 by gambard@chromium.org, Oct 19 2017

Status: Fixed (was: Assigned)
Project Member

Comment 3 by bugdroid1@chromium.org, Oct 23 2017

Labels: merge-merged-3239
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/13b3c197c20a787abb76e7069db77c80a486bea0

commit 13b3c197c20a787abb76e7069db77c80a486bea0
Author: Gauthier Ambard <gambard@chromium.org>
Date: Mon Oct 23 06:30:16 2017

Toolbar content respects safe area

The content of the toolbar needs to respect the safe area. This CL
fixes the content displayed outside of the safe area by creating a
contentView respecting the safe area boundaries.
The content is added to this view instead of the ToolbarView.

This also makes the back menu dropdown to be displayed inside the safe
area.
It also dismisses it during device rotation.

Bug:  765304 ,  776340 ,  764877 
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: Ia4f5b8499644b0b406a94a723bde1a6d80928cd0
Reviewed-on: https://chromium-review.googlesource.com/727890
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Reviewed-by: Rohit Rao (ping after 24h) <rohitrao@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#510083}(cherry picked from commit bf38224605234c859e7d73b9f5883180bf116524)
Reviewed-on: https://chromium-review.googlesource.com/732817
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/branch-heads/3239@{#146}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}
[modify] https://crrev.com/13b3c197c20a787abb76e7069db77c80a486bea0/ios/chrome/browser/ui/browser_view_controller.mm
[modify] https://crrev.com/13b3c197c20a787abb76e7069db77c80a486bea0/ios/chrome/browser/ui/ntp/new_tab_page_toolbar_controller.mm
[modify] https://crrev.com/13b3c197c20a787abb76e7069db77c80a486bea0/ios/chrome/browser/ui/stack_view/stack_view_toolbar_controller.mm
[modify] https://crrev.com/13b3c197c20a787abb76e7069db77c80a486bea0/ios/chrome/browser/ui/toolbar/toolbar_controller.h
[modify] https://crrev.com/13b3c197c20a787abb76e7069db77c80a486bea0/ios/chrome/browser/ui/toolbar/toolbar_controller.mm
[modify] https://crrev.com/13b3c197c20a787abb76e7069db77c80a486bea0/ios/chrome/browser/ui/toolbar/web_toolbar_controller.mm
[modify] https://crrev.com/13b3c197c20a787abb76e7069db77c80a486bea0/ios/chrome/browser/ui/tools_menu/tools_popup_controller.mm

Comment 4 by srikanthg@chromium.org, Oct 24 2017

Status: Verified (was: Fixed)
Verified on 64.0.3249.0 canary
iPhoneX Simulator.
Screenshot: https://drive.google.com/file/d/16hEX2jsolpxpG2mrIm7lVDB9LzKuUddE/view

Comment 5 by srikanthg@chromium.org, Oct 26 2017 

Verified in M63.0.3239.19 beta
iPhoneX Simulator

Comment 6 by justincohen@chromium.org, Nov 30 2017 

Issue 789596 has been merged into this issue.

Comment 7 by justincohen@chromium.org, Nov 30 2017 

Issue 789595 has been merged into this issue.
►

Sign in to add a comment