WebTestWithWebState::WaitForBackgroundTasks does not sync on CRWCertVerificationController |
||||
Issue description
if
CRWCertVerificationController verifyTrust:completionHandler is called, there is a sequence of tasks that is
base::PostTaskWithTraits(
FROM_HERE, {base::TaskShutdownBehavior::BLOCK_SHUTDOWN},
->
dispatch_async
TestWebThreadBundle::WaitForBackgroundTasks fail to sync on that.
This result is the test thread bundle can be deleted befor the dispatch_async block is executed, and a DCHECK_CURRENTLY_ON(web::WebThread::UI); will fail in
[CRWCertVerificationController decideLoadPolicyForTrust:host:completionHandler:]
Link to failing tests
https://uberchromegw.corp.google.com/i/internal.bling.main/builders/smoke/builds/18420/steps/ios_chrome_unittests%20%28iPhone%205s%20iOS%2011.0%29%20on%20Mac/logs/stdio
,
Feb 14 2018
Is this still an issue? Can we close it?
,
Feb 14 2018
I think this is still an issue.
,
Feb 14 2018
Thanks Olivier. Do you remember which tests are affected? dispatch_async is used on purpose in CRWCertVerificationController to ensure that callbacks are called on shutdown (otherwise WKWebView throws an exception). So I don't know how to fundamentally fix the problem, but we should be able to workaround specific tests.
,
Sep 21
,
Sep 21
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7d3db0782df81a200c1b8cac9db265727efa82c1 commit 7d3db0782df81a200c1b8cac9db265727efa82c1 Author: Eugene But <eugenebut@google.com> Date: Fri Sep 21 15:59:12 2018 Remove spinning runloop workaround from FormStructureBrowserTest. Underlying issue was fixed here: https://chromium-review.googlesource.com/1226195 Bug: 776330 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I3b1bbffd84e5bdc315c0ca32c1f8ff89747d5abc Reviewed-on: https://chromium-review.googlesource.com/1238379 Reviewed-by: Olivier Robin <olivierrobin@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#593203} [modify] https://crrev.com/7d3db0782df81a200c1b8cac9db265727efa82c1/ios/chrome/browser/autofill/form_structure_browsertest.mm
,
Sep 21
|
||||
►
Sign in to add a comment |
||||
Comment 1 by baxley@chromium.org
, Feb 14 2018Components: -Test>iOS Tests
Owner: ----
Status: Available (was: Assigned)