Add descriptions to notification channels |
|||
Issue descriptionApparently there is now a 'description' field we can fill out for notification channels on Android O. We should tell teams about this. Let's add a note to the README at https://cs.chromium.org/chromium/src/chrome/android/java/src/org/chromium/chrome/browser/notifications/channels/README.md calling out the description as something that can be optionally set (just doesn't happen to be set for any so far).
,
Jan 8 2018
Taking this on. I had an offline chat with awdf@ and peter@ about this. Since there are no requests for these descriptions, we've decided not to add them yet. Adding a channel description is a good idea though, so I'll update the README here (//src/chrome/android/java/src/org/chromium/chrome/browser/notifications/channels/README.md) to suggest all new channels include one.
,
Jan 9 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c0b8c30be56495e1926caaee2e56b35e2d042729 commit c0b8c30be56495e1926caaee2e56b35e2d042729 Author: Mugdha Lakhani <nator@chromium.org> Date: Tue Jan 09 16:01:49 2018 Update README for notification channels. This change adds a suggestion to write descriptions for new notification channels. Bug: 776317 Change-Id: Iea5ddcba52a104f21cbfa5d6a0dab52a4d578d35 Reviewed-on: https://chromium-review.googlesource.com/854172 Commit-Queue: Mugdha Lakhani <nator@chromium.org> Reviewed-by: Anita Woodruff <awdf@chromium.org> Cr-Commit-Position: refs/heads/master@{#528006} [modify] https://crrev.com/c0b8c30be56495e1926caaee2e56b35e2d042729/chrome/android/java/src/org/chromium/chrome/browser/notifications/channels/README.md
,
Jan 9 2018
|
|||
►
Sign in to add a comment |
|||
Comment 1 by awdf@chromium.org
, Jan 5 2018