New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 776314 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 1
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Feature

Blocked on:
issue 783131

Blocking:
issue 830577



Sign in to add a comment

migrate existing bisect-kit code to public repository

Project Member Reported by kcwu@chromium.org, Oct 19 2017

Issue description

bisect-kit is a set of general purpose bisect scripts, which target chromeos/chrome/android regression bisection.

Location of public repository.
https://chromium.googlesource.com/chromiumos/platform/bisect-kit/

This issue tracks progress of migration from my local code to public repo, including the efforts of code refactoring/refinement and code review.

 
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 25 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/bisect-kit/+/385279d88c04b1053ab19726612edb816a66975e

commit 385279d88c04b1053ab19726612edb816a66975e
Author: Kuang-che Wu <kcwu@chromium.org>
Date: Tue Oct 24 13:41:20 2017

bisect-kit: support config file and plugins

Besides command line arguments and environment variables, users can set
common options in config file.

The main purpose of plugin hook mechanism is for patching functions by
private implementations. For example, fetching build artifacts from
internal servers. This feature is necessary for my latter commits of
android bisector.

BUG= chromium:776314 

Change-Id: I81e47398cfee591c5c810479d4824857599f5d53

[add] https://crrev.com/385279d88c04b1053ab19726612edb816a66975e/bisect_kit/configure_test.py
[modify] https://crrev.com/385279d88c04b1053ab19726612edb816a66975e/bisect_kit/cli.py
[modify] https://crrev.com/385279d88c04b1053ab19726612edb816a66975e/runner.py
[modify] https://crrev.com/385279d88c04b1053ab19726612edb816a66975e/switch_git.py
[add] https://crrev.com/385279d88c04b1053ab19726612edb816a66975e/bisect_kit.json.sample
[add] https://crrev.com/385279d88c04b1053ab19726612edb816a66975e/bisect_kit/configure.py
[modify] https://crrev.com/385279d88c04b1053ab19726612edb816a66975e/bisect_kit/common.py
[modify] https://crrev.com/385279d88c04b1053ab19726612edb816a66975e/bisect_kit/util.py

Comment 2 by kcwu@chromium.org, Nov 9 2017

Blockedon: 783131
Project Member

Comment 3 by bugdroid1@chromium.org, Nov 15 2017

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chromeos/manifest-internal/+/6f479e947e0360d16edbb05266abfe71e3d63c52

commit 6f479e947e0360d16edbb05266abfe71e3d63c52
Author: Kuang-che Wu <kcwu@chromium.org>
Date: Wed Nov 15 08:39:52 2017

Project Member

Comment 4 by bugdroid1@chromium.org, Nov 15 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/manifest/+/ca9cf3aaed227f87af1a32d070d9d7401fdf14ec

commit ca9cf3aaed227f87af1a32d070d9d7401fdf14ec
Author: Kuang-che Wu <kcwu@chromium.org>
Date: Wed Nov 15 08:39:52 2017

Add bisect-kit repo to the manifest

CQ-DEPEND=CL:*502944
BUG= chromium:776314 
TEST=repo sync

Change-Id: Ie0035b5d7eee0262f2c3e6e37ce80cf23760a356
Reviewed-on: https://chromium-review.googlesource.com/765750
Commit-Ready: Kuang-che Wu <kcwu@chromium.org>
Tested-by: Kuang-che Wu <kcwu@chromium.org>
Reviewed-by: Wu-Cheng Li <wuchengli@chromium.org>

[modify] https://crrev.com/ca9cf3aaed227f87af1a32d070d9d7401fdf14ec/full.xml

Project Member

Comment 5 by bugdroid1@chromium.org, Nov 16 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/bisect-kit/+/e2fe6c3f4f2fa179ae0b89e0db170b73f16ec91b

commit e2fe6c3f4f2fa179ae0b89e0db170b73f16ec91b
Author: Kuang-che Wu <kcwu@chromium.org>
Date: Thu Nov 16 14:27:49 2017

bisect-kit: add unittest for bisect_kit.common module

BUG= chromium:776314 
TEST=run the unittest

Change-Id: I03ad3d57d8d830a63a62a3c1cf553683ca1325db
Reviewed-on: https://chromium-review.googlesource.com/768472
Commit-Ready: Kuang-che Wu <kcwu@chromium.org>
Tested-by: Kuang-che Wu <kcwu@chromium.org>
Reviewed-by: Owen Lin <owenlin@chromium.org>

[add] https://crrev.com/e2fe6c3f4f2fa179ae0b89e0db170b73f16ec91b/bisect_kit/common_test.py

Project Member

Comment 6 by bugdroid1@chromium.org, Nov 16 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/bisect-kit/+/ab694e685f55753b8dc7a9a9431c0fe77567ded7

commit ab694e685f55753b8dc7a9a9431c0fe77567ded7
Author: Kuang-che Wu <kcwu@chromium.org>
Date: Thu Nov 16 14:27:49 2017

bisect-kit: fix exception for command 'view --more'

BUG= chromium:776314 
TEST=run bisector with 'view --more'

Change-Id: I4c1a3dd3e7e7af1a13573bf55efdbf5fae1e0853
Reviewed-on: https://chromium-review.googlesource.com/768582
Commit-Ready: Kuang-che Wu <kcwu@chromium.org>
Tested-by: Kuang-che Wu <kcwu@chromium.org>
Reviewed-by: Owen Lin <owenlin@chromium.org>

[modify] https://crrev.com/ab694e685f55753b8dc7a9a9431c0fe77567ded7/bisect_kit/strategy.py

Project Member

Comment 7 by bugdroid1@chromium.org, Nov 16 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/bisect-kit/+/2dbbf4e7cfc26bb036bd11791567e033e6937d81

commit 2dbbf4e7cfc26bb036bd11791567e033e6937d81
Author: Kuang-che Wu <kcwu@chromium.org>
Date: Thu Nov 16 14:27:48 2017

bisect-kit: remove duplicated command line argument

'--config' was forgotten to be renamed in last commit. Also move the
argument definition from cli.py to common.py.

BUG= chromium:776314 
TEST=none

Change-Id: I47ebb0477956ba57b27585d3c750e5468366c623
Reviewed-on: https://chromium-review.googlesource.com/774000
Commit-Ready: Kuang-che Wu <kcwu@chromium.org>
Tested-by: Kuang-che Wu <kcwu@chromium.org>
Reviewed-by: Owen Lin <owenlin@chromium.org>

[modify] https://crrev.com/2dbbf4e7cfc26bb036bd11791567e033e6937d81/bisect_kit/common.py
[modify] https://crrev.com/2dbbf4e7cfc26bb036bd11791567e033e6937d81/bisect_kit/cli.py

Project Member

Comment 8 by bugdroid1@chromium.org, Nov 27 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/bisect-kit/+/b237626c70d005e496b562915dc7984eb3923900

commit b237626c70d005e496b562915dc7984eb3923900
Author: Kuang-che Wu <kcwu@chromium.org>
Date: Mon Nov 27 17:05:15 2017

bisect-kit: show bisector's file docstring as command line help

BUG= chromium:776314 
TEST=./bisect_git.py --help

Change-Id: I472c61e3aa0d11b882b770b68707b56831ee274e
Reviewed-on: https://chromium-review.googlesource.com/778682
Commit-Ready: Kuang-che Wu <kcwu@chromium.org>
Tested-by: Kuang-che Wu <kcwu@chromium.org>
Reviewed-by: Owen Lin <owenlin@chromium.org>

[modify] https://crrev.com/b237626c70d005e496b562915dc7984eb3923900/bisect_kit/core.py
[modify] https://crrev.com/b237626c70d005e496b562915dc7984eb3923900/bisect_kit/cli.py
[modify] https://crrev.com/b237626c70d005e496b562915dc7984eb3923900/bisect_git.py

Project Member

Comment 9 by bugdroid1@chromium.org, Nov 29 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/bisect-kit/+/455c734fc7b86ccc2131ff92f56cd8266a235aad

commit 455c734fc7b86ccc2131ff92f56cd8266a235aad
Author: Kuang-che Wu <kcwu@chromium.org>
Date: Wed Nov 29 04:17:03 2017

bisect-kit: fix psutil api usage

psutil.Process.get_children() has been deprecated since 2.0.0 and
removed since 3.0.0. Use children() instead.

BUG= chromium:776314 
TEST=unittest pass with psutil 3+

Change-Id: Ia3792897b5f892ee1a35887f6ffe91ca3e9ef110
Reviewed-on: https://chromium-review.googlesource.com/792890
Commit-Ready: Kuang-che Wu <kcwu@chromium.org>
Tested-by: Kuang-che Wu <kcwu@chromium.org>
Reviewed-by: Owen Lin <owenlin@chromium.org>

[modify] https://crrev.com/455c734fc7b86ccc2131ff92f56cd8266a235aad/bisect_kit/util.py

Project Member

Comment 10 by bugdroid1@chromium.org, Dec 11 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/bisect-kit/+/2ea804fc793ec1c9d739c6c1bc32e7ce5f72622a

commit 2ea804fc793ec1c9d739c6c1bc32e7ce5f72622a
Author: Kuang-che Wu <kcwu@chromium.org>
Date: Mon Dec 11 15:56:31 2017

bisect-kit: add chromeos prebuilt bisector and helper scripts

bisector: bisect_cros_version.py
switcher: switch_cros_prebuilt.py
and cros_helper.py, which is helpful for writting eval scripts

BUG= chromium:776314 
TEST=unittest and following commands

Find which version switched arc container, the heavy way
$ ./bisect_cros_version.py init --old 9400.0.0 --new 10100.0.0 --dut $DUT
$ ./bisect_cros_version.py config switch ./switch_cros_prebuilt.py
$ ./bisect_cros_version.py config eval ssh $DUT grep CHROMEOS_ARC_ANDROID_SDK_VERSION=23 /etc/lsb-release
$ ./bisect_cros_version.py run

Change-Id: I6db1ead6236a597cce304af0272924f95bc9fa96
Reviewed-on: https://chromium-review.googlesource.com/792735
Commit-Ready: Kuang-che Wu <kcwu@chromium.org>
Tested-by: Kuang-che Wu <kcwu@chromium.org>
Reviewed-by: Owen Lin <owenlin@chromium.org>

[add] https://crrev.com/2ea804fc793ec1c9d739c6c1bc32e7ce5f72622a/.presubmitignore
[add] https://crrev.com/2ea804fc793ec1c9d739c6c1bc32e7ce5f72622a/switch_cros_prebuilt.py
[add] https://crrev.com/2ea804fc793ec1c9d739c6c1bc32e7ce5f72622a/testdata/partial-metadata.json
[add] https://crrev.com/2ea804fc793ec1c9d739c6c1bc32e7ce5f72622a/testdata/README
[add] https://crrev.com/2ea804fc793ec1c9d739c6c1bc32e7ce5f72622a/bisect_cros_version.py
[add] https://crrev.com/2ea804fc793ec1c9d739c6c1bc32e7ce5f72622a/cros_helper.py
[add] https://crrev.com/2ea804fc793ec1c9d739c6c1bc32e7ce5f72622a/bisect_kit/cros_util_test.py
[add] https://crrev.com/2ea804fc793ec1c9d739c6c1bc32e7ce5f72622a/bisect_kit/cros_util.py
[add] https://crrev.com/2ea804fc793ec1c9d739c6c1bc32e7ce5f72622a/bisect_kit/testing.py
[add] https://crrev.com/2ea804fc793ec1c9d739c6c1bc32e7ce5f72622a/testdata/lsb-release

Project Member

Comment 11 by bugdroid1@chromium.org, Jan 19 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/bisect-kit/+/42551ddfdbc6fc6a658ca24c1ab5ee2bd0f65c6c

commit 42551ddfdbc6fc6a658ca24c1ab5ee2bd0f65c6c
Author: Kuang-che Wu <kcwu@chromium.org>
Date: Fri Jan 19 01:40:40 2018

bisect-kit: revise output messages for non-noisy case

Classic (non-noisy) bisection is special case of noisy bisection.
Although the more general messages apply to non-noisy case, they make
users confused. This CL improves output messages for non-noisy case.

BUG= chromium:776314 
TEST=None

Change-Id: I34f1d8e54c5f37b5464dbbc9f1cfb9dc448c8662
Reviewed-on: https://chromium-review.googlesource.com/867802
Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com>
Tested-by: Kuang-che Wu <kcwu@chromium.org>
Reviewed-by: Owen Lin <owenlin@chromium.org>

[modify] https://crrev.com/42551ddfdbc6fc6a658ca24c1ab5ee2bd0f65c6c/bisect_kit/cli.py
[modify] https://crrev.com/42551ddfdbc6fc6a658ca24c1ab5ee2bd0f65c6c/bisect_kit/strategy.py

Project Member

Comment 12 by bugdroid1@chromium.org, Jan 19 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/bisect-kit/+/ab72da7f242583033e66dca11f6e56deab3bdc13

commit ab72da7f242583033e66dca11f6e56deab3bdc13
Author: Kuang-che Wu <kcwu@chromium.org>
Date: Fri Jan 19 01:40:29 2018

bisect-kit: fix config loading and syntax error in sample config

BUG= chromium:776314 
TEST=unittest

Change-Id: I44fca1f9bb2445aa1e4dc0e443d425bb2d934b4b
Reviewed-on: https://chromium-review.googlesource.com/867826
Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com>
Tested-by: Kuang-che Wu <kcwu@chromium.org>
Reviewed-by: Owen Lin <owenlin@chromium.org>

[modify] https://crrev.com/ab72da7f242583033e66dca11f6e56deab3bdc13/bisect_kit/configure_test.py
[modify] https://crrev.com/ab72da7f242583033e66dca11f6e56deab3bdc13/bisect_kit.json.sample
[modify] https://crrev.com/ab72da7f242583033e66dca11f6e56deab3bdc13/bisect_kit/configure.py

Project Member

Comment 13 by bugdroid1@chromium.org, Jan 20 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/bisect-kit/+/e2563ea28f712c8331b3381fca09494906c7d595

commit e2563ea28f712c8331b3381fca09494906c7d595
Author: Kuang-che Wu <kcwu@chromium.org>
Date: Sat Jan 20 01:18:07 2018

bisect-kit: add chrome master localbuild bisector and helper scripts

bisector: bisect_cr_localbuild_master.py
switcher: switch_cros_cr_localbuild_master.py

BUG= chromium:776314 
TEST=unittest and following commands

(Search the first version of R65, the stupid way)
$ ./bisect_cr_localbuild_master.py init --old 64.0.3280.0 --new 65.0.3299.0 \
      --chrome_root ~/chromium
$ ./bisect_cr_localbuild_master.py config switch \
      ./switch_cros_cr_localbuild_master.py $DUT
$ ./bisect_cr_localbuild_master.py config eval bash -c \
      "ssh $DUT /opt/google/chrome/chrome --version | grep 'Chrome 64'"
$ ./bisect_cr_localbuild_master.py run

Change-Id: I0d9f925932094c8a176e6ce50e875b9c8ddd39aa
Reviewed-on: https://chromium-review.googlesource.com/853817
Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com>
Tested-by: Kuang-che Wu <kcwu@chromium.org>
Reviewed-by: Kuang-che Wu <kcwu@chromium.org>

[modify] https://crrev.com/e2563ea28f712c8331b3381fca09494906c7d595/bisect_kit/git_util_test.py
[modify] https://crrev.com/e2563ea28f712c8331b3381fca09494906c7d595/testdata/README
[add] https://crrev.com/e2563ea28f712c8331b3381fca09494906c7d595/build_and_deploy_chrome_helper.sh
[add] https://crrev.com/e2563ea28f712c8331b3381fca09494906c7d595/testdata/chrome_commit_log/e4940332
[add] https://crrev.com/e2563ea28f712c8331b3381fca09494906c7d595/testdata/chrome_commit_log/44f159f6
[modify] https://crrev.com/e2563ea28f712c8331b3381fca09494906c7d595/bisect_kit/git_util.py
[add] https://crrev.com/e2563ea28f712c8331b3381fca09494906c7d595/bisect_cr_localbuild_master_test.py
[add] https://crrev.com/e2563ea28f712c8331b3381fca09494906c7d595/testdata/chrome_commit_log/27101da1
[add] https://crrev.com/e2563ea28f712c8331b3381fca09494906c7d595/bisect_cr_localbuild_master.py
[add] https://crrev.com/e2563ea28f712c8331b3381fca09494906c7d595/bisect_kit/cr_util.py
[modify] https://crrev.com/e2563ea28f712c8331b3381fca09494906c7d595/bisect_kit/testing.py
[add] https://crrev.com/e2563ea28f712c8331b3381fca09494906c7d595/testdata/chrome_commit_log/3fe30a09
[add] https://crrev.com/e2563ea28f712c8331b3381fca09494906c7d595/bisect_kit/cr_util_test.py
[add] https://crrev.com/e2563ea28f712c8331b3381fca09494906c7d595/switch_cros_cr_localbuild_master.py

Project Member

Comment 14 by bugdroid1@chromium.org, Feb 2 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/bisect-kit/+/848b1afe6fde210c9c42d268086f4daafebf7c2a

commit 848b1afe6fde210c9c42d268086f4daafebf7c2a
Author: Kuang-che Wu <kcwu@chromium.org>
Date: Fri Feb 02 15:03:21 2018

bisect-kit: fix bisect_cr_localbuild_master

1. two functions were missed in last commit.
2. fix starting rev when opts.old is chromeos or chrome version.

BUG= chromium:776314 
TEST=manually performed a chrome master bisection

Change-Id: Ia1e23dc9ecc1ce86b4f1198738eb5879d14a8e5b
Reviewed-on: https://chromium-review.googlesource.com/896668
Commit-Ready: Kuang-che Wu <kcwu@chromium.org>
Tested-by: Kuang-che Wu <kcwu@chromium.org>
Reviewed-by: Owen Lin <owenlin@chromium.org>

[modify] https://crrev.com/848b1afe6fde210c9c42d268086f4daafebf7c2a/bisect_cr_localbuild_master.py
[modify] https://crrev.com/848b1afe6fde210c9c42d268086f4daafebf7c2a/bisect_kit/cr_util.py
[modify] https://crrev.com/848b1afe6fde210c9c42d268086f4daafebf7c2a/bisect_kit/cros_util.py

Project Member

Comment 15 by bugdroid1@chromium.org, Mar 29 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/bisect-kit/+/7f816b774652cef038e087a128464fc64646c10d

commit 7f816b774652cef038e087a128464fc64646c10d
Author: Kuang-che Wu <kcwu@chromium.org>
Date: Thu Mar 29 17:25:17 2018

bisect-kit: remove unused import

The scripts were broken since e2563ea2 because the unused import module
file hasn't git added.

BUG= chromium:776314 
TEST=unittest

Change-Id: Iafc6d50a809b7837813486d410ade96b0c0e2ddd
Reviewed-on: https://chromium-review.googlesource.com/983613
Commit-Ready: Kuang-che Wu <kcwu@chromium.org>
Tested-by: Kuang-che Wu <kcwu@chromium.org>
Reviewed-by: Chung-yih Wang <cywang@chromium.org>

[modify] https://crrev.com/7f816b774652cef038e087a128464fc64646c10d/bisect_kit/cr_util.py

Project Member

Comment 16 by bugdroid1@chromium.org, Mar 30 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/bisect-kit/+/65e419a5eb1d8b3ac9d1e66624c0e9da9542b0d2

commit 65e419a5eb1d8b3ac9d1e66624c0e9da9542b0d2
Author: Kuang-che Wu <kcwu@chromium.org>
Date: Fri Mar 30 10:09:24 2018

bisect-kit: add COMMIT-QUEUE.ini to bypass CQ

bisect-kit won't break anything of ChromeOS, and we don't have
tests in CQ dedicated to bisect-kit yet. So bypass CQ in the meantime to
improve my productivity.

BUG= chromium:776314 
TEST=none

Change-Id: I8956cd8e72ced1e1a605d6634a00e69b7ae884fe
Reviewed-on: https://chromium-review.googlesource.com/986313
Commit-Ready: Kuang-che Wu <kcwu@chromium.org>
Tested-by: Kuang-che Wu <kcwu@chromium.org>
Reviewed-by: Kuang-che Wu <kcwu@chromium.org>

[add] https://crrev.com/65e419a5eb1d8b3ac9d1e66624c0e9da9542b0d2/COMMIT-QUEUE.ini

Project Member

Comment 17 by bugdroid1@chromium.org, Mar 30 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/bisect-kit/+/68db08ab1a686da4bfea191f6b7730b757e70b55

commit 68db08ab1a686da4bfea191f6b7730b757e70b55
Author: Kuang-che Wu <kcwu@chromium.org>
Date: Fri Mar 30 18:36:44 2018

bisect-kit: fix pylint errors

Besides normal fixes, BisectorCommandLineInterface is renamed to
BisectorCommandLine. Although new version of pylint no longer complain
interface-not-implemented (instead, saying the disable option is
undefined), chromite and depot_tools still use the old one. Renaming is
easier to avoid the annoyingness.

BUG= chromium:776314 
TEST=cros lint *.py bisect_kit/*.py

Change-Id: I4cf3f63ee950d913a6b3f5b6a7a7b59810066963
Reviewed-on: https://chromium-review.googlesource.com/987660
Commit-Ready: Kuang-che Wu <kcwu@chromium.org>
Tested-by: Kuang-che Wu <kcwu@chromium.org>
Reviewed-by: Kuang-che Wu <kcwu@chromium.org>

[modify] https://crrev.com/68db08ab1a686da4bfea191f6b7730b757e70b55/bisect_kit/cros_util_test.py
[modify] https://crrev.com/68db08ab1a686da4bfea191f6b7730b757e70b55/bisect_kit/cli_test.py
[modify] https://crrev.com/68db08ab1a686da4bfea191f6b7730b757e70b55/bisect_kit/cli.py
[modify] https://crrev.com/68db08ab1a686da4bfea191f6b7730b757e70b55/switch_git.py
[modify] https://crrev.com/68db08ab1a686da4bfea191f6b7730b757e70b55/bisect_list.py
[modify] https://crrev.com/68db08ab1a686da4bfea191f6b7730b757e70b55/bisect_git.py
[modify] https://crrev.com/68db08ab1a686da4bfea191f6b7730b757e70b55/bisect_list_test.py
[modify] https://crrev.com/68db08ab1a686da4bfea191f6b7730b757e70b55/bisect_cros_version.py
[modify] https://crrev.com/68db08ab1a686da4bfea191f6b7730b757e70b55/bisect_kit/cros_util.py
[modify] https://crrev.com/68db08ab1a686da4bfea191f6b7730b757e70b55/bisect_cr_localbuild_master_test.py
[modify] https://crrev.com/68db08ab1a686da4bfea191f6b7730b757e70b55/cros_helper.py
[modify] https://crrev.com/68db08ab1a686da4bfea191f6b7730b757e70b55/bisect_cr_localbuild_master.py
[modify] https://crrev.com/68db08ab1a686da4bfea191f6b7730b757e70b55/bisect_kit/cr_util_test.py
[modify] https://crrev.com/68db08ab1a686da4bfea191f6b7730b757e70b55/bisect_kit/cr_util.py
[modify] https://crrev.com/68db08ab1a686da4bfea191f6b7730b757e70b55/bisect_git_test.py
[modify] https://crrev.com/68db08ab1a686da4bfea191f6b7730b757e70b55/bisect_kit/git_util.py
[modify] https://crrev.com/68db08ab1a686da4bfea191f6b7730b757e70b55/bisect_kit/common.py
[modify] https://crrev.com/68db08ab1a686da4bfea191f6b7730b757e70b55/bisect_kit/util.py

Project Member

Comment 18 by bugdroid1@chromium.org, Apr 3 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/bisect-kit/+/e1b329e0e7b0b3270e8692165bc14ad9db42fdd5

commit e1b329e0e7b0b3270e8692165bc14ad9db42fdd5
Author: Kuang-che Wu <kcwu@chromium.org>
Date: Tue Apr 03 09:31:16 2018

bisect-kit: fix unittest with side effects

Some tests will parse config and keep the result globally. This may make
tests order-dependent or failures. This CL resets the side effect
properly.

This could be reproduced by 'pytest --forked' or run tests individually.

BUG= chromium:776314 
TEST=pytest --forked

Change-Id: I0479b503203887466975ddd5f3eacac72f2a766c
Reviewed-on: https://chromium-review.googlesource.com/989354
Commit-Ready: Kuang-che Wu <kcwu@chromium.org>
Tested-by: Kuang-che Wu <kcwu@chromium.org>
Reviewed-by: Chung-yih Wang <cywang@chromium.org>

[modify] https://crrev.com/e1b329e0e7b0b3270e8692165bc14ad9db42fdd5/bisect_kit/cli_test.py
[modify] https://crrev.com/e1b329e0e7b0b3270e8692165bc14ad9db42fdd5/bisect_kit/configure.py
[modify] https://crrev.com/e1b329e0e7b0b3270e8692165bc14ad9db42fdd5/runner_test.py
[modify] https://crrev.com/e1b329e0e7b0b3270e8692165bc14ad9db42fdd5/bisect_kit/common_test.py

Comment 19 by kcwu@chromium.org, Apr 10 2018

Blocking: 830577
Project Member

Comment 20 by bugdroid1@chromium.org, Apr 12 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/bisect-kit/+/708310ba431a8a19805880b000a5d2a5a26d8cdc

commit 708310ba431a8a19805880b000a5d2a5a26d8cdc
Author: Kuang-che Wu <kcwu@chromium.org>
Date: Thu Apr 12 03:49:45 2018

bisect-kit: add android prebuilt bisector (for chromeos arc)

bisector: bisect_android_build_id.py
switcher: switch_arc_prebuilt.py

BUG= chromium:776314 
TEST=unittest and following commands

(Stupid example, to find the first version not begining with 466)
$ ./bisect_android_build_id.py init --old 4667159 --new 4678458 --dut samus-dut
$ ./bisect_android_build_id.py config switch ./switch_arc_prebuilt.py
$ ./bisect_android_build_id.py config eval bash -c \
      "ssh $DUT cat /etc/lsb-release | grep ARC_VERSION=.*_466"
$ ./bisect_android_build_id.py run

Change-Id: Ib06a21a85e05ebae573ab815661f7129baef099e
Reviewed-on: https://chromium-review.googlesource.com/983652
Commit-Ready: Kuang-che Wu <kcwu@chromium.org>
Tested-by: Kuang-che Wu <kcwu@chromium.org>
Reviewed-by: Chung-yih Wang <cywang@chromium.org>

[add] https://crrev.com/708310ba431a8a19805880b000a5d2a5a26d8cdc/android_lunch_helper.sh
[add] https://crrev.com/708310ba431a8a19805880b000a5d2a5a26d8cdc/switch_arc_prebuilt.py
[add] https://crrev.com/708310ba431a8a19805880b000a5d2a5a26d8cdc/bisect_android_build_id.py
[add] https://crrev.com/708310ba431a8a19805880b000a5d2a5a26d8cdc/testdata/android-build-status-4683364.json
[modify] https://crrev.com/708310ba431a8a19805880b000a5d2a5a26d8cdc/bisect_kit/cros_util.py
[add] https://crrev.com/708310ba431a8a19805880b000a5d2a5a26d8cdc/bisect_kit/android_util.py
[add] https://crrev.com/708310ba431a8a19805880b000a5d2a5a26d8cdc/bisect_kit/android_util_test.py
[add] https://crrev.com/708310ba431a8a19805880b000a5d2a5a26d8cdc/switch_arc_prebuilt_test.py
[modify] https://crrev.com/708310ba431a8a19805880b000a5d2a5a26d8cdc/testdata/README
[add] https://crrev.com/708310ba431a8a19805880b000a5d2a5a26d8cdc/bisect_kit/arc_util.py

Project Member

Comment 21 by bugdroid1@chromium.org, May 9 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/bisect-kit/+/acb6efd5d9db5903b462aea03fde2e8391068cf9

commit acb6efd5d9db5903b462aea03fde2e8391068cf9
Author: Kuang-che Wu <kcwu@chromium.org>
Date: Wed May 09 06:15:10 2018

bisect-kit: add android (for chromeos) local build bisector

bisector: bisect_android_repo.py
switcher: switch_arc_localbuild.py

BUG= chromium:776314 
TEST=unittest and following commands

(Stupid example, to find the commit of ndk_translation uprev)
$ ./bisect_android_repo.py init --old 4667159 --new 4678458 --dut $DUT --android_root $ANDROID_ROOT
$ ./bisect_android_repo.py config switch ./switch_arc_localbuild.py
$ ./bisect_android_repo.py config eval bash -c \
      'ssh $DUT grep ro.ndk_translation.version=0.1.19 /opt/google/containers/android/rootfs/root/system/build.prop''
$ ./bisect_android_repo.py run

Change-Id: Id3c78acf2428b62835b58c1ba3b5d34ba5293900
Reviewed-on: https://chromium-review.googlesource.com/1027560
Commit-Ready: Kuang-che Wu <kcwu@chromium.org>
Tested-by: Kuang-che Wu <kcwu@chromium.org>
Reviewed-by: Chung-yih Wang <cywang@chromium.org>

[add] https://crrev.com/acb6efd5d9db5903b462aea03fde2e8391068cf9/bisect_android_repo.py
[modify] https://crrev.com/acb6efd5d9db5903b462aea03fde2e8391068cf9/switch_arc_prebuilt.py
[modify] https://crrev.com/acb6efd5d9db5903b462aea03fde2e8391068cf9/bisect_android_build_id.py
[add] https://crrev.com/acb6efd5d9db5903b462aea03fde2e8391068cf9/switch_arc_localbuild.py
[modify] https://crrev.com/acb6efd5d9db5903b462aea03fde2e8391068cf9/bisect_kit/cros_util_test.py
[modify] https://crrev.com/acb6efd5d9db5903b462aea03fde2e8391068cf9/bisect_kit/cros_util.py
[modify] https://crrev.com/acb6efd5d9db5903b462aea03fde2e8391068cf9/bisect_kit/android_util.py
[modify] https://crrev.com/acb6efd5d9db5903b462aea03fde2e8391068cf9/bisect_kit/arc_util.py

Project Member

Comment 22 by bugdroid1@chromium.org, Jun 21 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/bisect-kit/+/3eb6b50864c52d862ee33150657bc6985894b3d0

commit 3eb6b50864c52d862ee33150657bc6985894b3d0
Author: Kuang-che Wu <kcwu@chromium.org>
Date: Thu Jun 21 10:23:19 2018

bisect-kit: add chrome local build bisector for branched version

bisector: bisect_cr_localbuild_internal.py
switcher: switch_cros_cr_localbuild_internal.py

This is partial patch of bigger work. Some tasks will be addressed by
later CLs:
 - Existing bisectors will be migrated to use codechange module
 - This bisector can only deal with branches before 3406 because it
   cannot support gclient recursedeps yet
 - Add more unit tests

BUG= chromium:776314 ,chromium:850443
TEST=unittest and following commands

(Stupid example, to find the commit to change branch number to 3396)
$ ./bisect_cr_localbuild_internal.py init --old 67.0.3392.0 --new 67.0.3396.17 \
    --chrome_root $CHROME_ROOT \
    --gclient_cache_dir $GCLIENT_CACHE_DIR \
    --dut $DUT
$ ./bisect_cr_localbuild_internal.py config switch ./switch_cros_cr_localbuild_internal.py
$ ./bisect_cr_localbuild_internal.py config eval bash -c \
      "ssh $DUT /opt/google/chrome/chrome --version | grep -v 3396"
$ ./bisect_cr_localbuild_internal.py run

Change-Id: I9b974a19d0c6f6fd045988fde603699282aef32f
Reviewed-on: https://chromium-review.googlesource.com/1088541
Commit-Ready: Kuang-che Wu <kcwu@chromium.org>
Tested-by: Kuang-che Wu <kcwu@chromium.org>
Reviewed-by: Chung-yih Wang <cywang@chromium.org>

[add] https://crrev.com/3eb6b50864c52d862ee33150657bc6985894b3d0/switch_cros_cr_localbuild_internal.py
[modify] https://crrev.com/3eb6b50864c52d862ee33150657bc6985894b3d0/build_and_deploy_chrome_helper.sh
[modify] https://crrev.com/3eb6b50864c52d862ee33150657bc6985894b3d0/bisect_kit/git_util.py
[modify] https://crrev.com/3eb6b50864c52d862ee33150657bc6985894b3d0/bisect_kit/cr_util.py
[add] https://crrev.com/3eb6b50864c52d862ee33150657bc6985894b3d0/bisect_kit/codechange.py
[add] https://crrev.com/3eb6b50864c52d862ee33150657bc6985894b3d0/bisect_cr_localbuild_internal.py
[modify] https://crrev.com/3eb6b50864c52d862ee33150657bc6985894b3d0/bisect_kit/cros_util.py
[modify] https://crrev.com/3eb6b50864c52d862ee33150657bc6985894b3d0/switch_cros_cr_localbuild_master.py
[add] https://crrev.com/3eb6b50864c52d862ee33150657bc6985894b3d0/bisect_kit/gclient_util.py

Project Member

Comment 23 by bugdroid1@chromium.org, Jul 6

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/bisect-kit/+/b9705bd7bb39e0195700232bd50bf1bbe12d1e3e

commit b9705bd7bb39e0195700232bd50bf1bbe12d1e3e
Author: Kuang-che Wu <kcwu@chromium.org>
Date: Fri Jul 06 11:58:13 2018

bisect-kit: scripts to switch and eval chromeos autotest

Example command line:

$ ./switch_autotest_prebuilt.py \
    --chromeos_root ~/chromiumos \
    --test_name video_VideoDecodeAccelerator.h264 \
    --board caroline \
    10774.0.0

$ ./eval_cros_autotest.py \
    --chromeos_root ~/chromiumos \
    --test_name video_VideoDecodeAccelerator.h264 \
    --prebuilt --reinstall \
    caroline-dut

BUG= chromium:776314 ,chromium:830577
TEST=unittest and above sample command

Change-Id: I39cce247b855145a773029dfe199b505023d7773
Reviewed-on: https://chromium-review.googlesource.com/1118198
Commit-Ready: Kuang-che Wu <kcwu@chromium.org>
Tested-by: Kuang-che Wu <kcwu@chromium.org>
Reviewed-by: Chung-yih Wang <cywang@chromium.org>

[modify] https://crrev.com/b9705bd7bb39e0195700232bd50bf1bbe12d1e3e/build_and_deploy_chrome_helper.sh
[add] https://crrev.com/b9705bd7bb39e0195700232bd50bf1bbe12d1e3e/testdata/test_report.log
[add] https://crrev.com/b9705bd7bb39e0195700232bd50bf1bbe12d1e3e/switch_autotest_prebuilt.py
[add] https://crrev.com/b9705bd7bb39e0195700232bd50bf1bbe12d1e3e/bisect_kit/cros_lab_util_test.py
[modify] https://crrev.com/b9705bd7bb39e0195700232bd50bf1bbe12d1e3e/bisect_kit/cros_util.py
[add] https://crrev.com/b9705bd7bb39e0195700232bd50bf1bbe12d1e3e/eval_cros_autotest.py
[add] https://crrev.com/b9705bd7bb39e0195700232bd50bf1bbe12d1e3e/eval_cros_autotest_test.py
[add] https://crrev.com/b9705bd7bb39e0195700232bd50bf1bbe12d1e3e/bisect_kit/cros_lab_util.py

Cc: -bccheng@chromium.org -chromeos-video@google.com -deanliao@chromium.org cywang@chromium.org
Components: -OS>Kernel>Video
Cc: cn...@chromium.org
Current status:

CL under review:
  https://chromium-review.googlesource.com/c/chromiumos/platform/bisect-kit/+/1128672

Remain work:
  diagnose-arc.py. This is easy since it is similar to diagnose_cros_autotest.py (1128672)
  After that, this issue could be closed.

Not merged:
  switch-cros-kernel.py: This is rarely used, so I would like skip it.
per comment 26, this issue is done.

Status: Fixed (was: Started)

Sign in to add a comment