New issue
Advanced search Search tips

Issue 776308 link

Starred by 3 users

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: ----
Team-Accessibility

Blocking:
issue 773866



Sign in to add a comment

interactive_ui_tests TestAsNormalAndGuestUser/SpokenFeedbackTest.NavigateSystemTray/0 failing on ChromeOS

Project Member Reported by mastiz@chromium.org, Oct 19 2017

Issue description

interactive_ui_tests failing on multiple builders

Builders failed on: 
- Linux ChromiumOS Tests (dbg)(1): 
  https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%28dbg%29%281%29



 

Comment 1 by mastiz@chromium.org, Oct 19 2017

Owner: mastiz@chromium.org
Status: Started (was: Available)
Project Member

Comment 2 by bugdroid1@chromium.org, Oct 19 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/db2ec9cea81c4d70a06199bafa898032249da2ac

commit db2ec9cea81c4d70a06199bafa898032249da2ac
Author: Mikel Astiz <mastiz@chromium.org>
Date: Thu Oct 19 09:45:01 2017

Revert "Fire focus if needed in automation api"

This reverts commit 9af30c037704f53ac9f9a9f4d1aee30023cf6ef0.

Reason for revert: breaks Linux ChromiumOS Tests.

Bug: 776308

Original change's description:
> Fire focus if needed in automation api
> 
> Bug:  773866 
> 
> Change-Id: I4e7295137141fa4f1605247cafb3bc4d40a09a59
> Reviewed-on: https://chromium-review.googlesource.com/723606
> Commit-Queue: David Tseng <dtseng@chromium.org>
> Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#509911}

TBR=dmazzoni@chromium.org,dtseng@chromium.org

Change-Id: Ifb8e4267a85f573aae5891bc9916c8a2c6e33a7c
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  773866 
Reviewed-on: https://chromium-review.googlesource.com/727982
Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Commit-Queue: Mikel Astiz <mastiz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510044}
[modify] https://crrev.com/db2ec9cea81c4d70a06199bafa898032249da2ac/chrome/renderer/resources/extensions/automation_custom_bindings.js

Comment 3 by mastiz@chromium.org, Oct 19 2017

Seems like I reverted the wrong patch, since the reland CL was different from the one I reverted above, sorry for the mess. I'll undo my own mess first (revert the revert) and then repeat my original intent, which was to revert https://chromium-review.googlesource.com/727122.
Project Member

Comment 4 by bugdroid1@chromium.org, Oct 19 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/499282a044a1760a55e8dbe768415e05dbb0cd43

commit 499282a044a1760a55e8dbe768415e05dbb0cd43
Author: Mikel Astiz <mastiz@chromium.org>
Date: Thu Oct 19 11:03:44 2017

Revert "Revert "Fire focus if needed in automation api""

This reverts commit db2ec9cea81c4d70a06199bafa898032249da2ac.

Reason for revert: I reverted the wrong patch, sorry for the mess. It should have been the reland patch, https://chromium-review.googlesource.com/727122

Original change's description:
> Revert "Fire focus if needed in automation api"
> 
> This reverts commit 9af30c037704f53ac9f9a9f4d1aee30023cf6ef0.
> 
> Reason for revert: breaks Linux ChromiumOS Tests.
> 
> Bug: 776308
> 
> Original change's description:
> > Fire focus if needed in automation api
> > 
> > Bug:  773866 
> > 
> > Change-Id: I4e7295137141fa4f1605247cafb3bc4d40a09a59
> > Reviewed-on: https://chromium-review.googlesource.com/723606
> > Commit-Queue: David Tseng <dtseng@chromium.org>
> > Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#509911}
> 
> TBR=dmazzoni@chromium.org,dtseng@chromium.org
> 
> Change-Id: Ifb8e4267a85f573aae5891bc9916c8a2c6e33a7c
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug:  773866 
> Reviewed-on: https://chromium-review.googlesource.com/727982
> Reviewed-by: Mikel Astiz <mastiz@chromium.org>
> Commit-Queue: Mikel Astiz <mastiz@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#510044}

TBR=dmazzoni@chromium.org,dtseng@chromium.org,mastiz@chromium.org

Change-Id: Iaa74032a25ec60545cf7be951b0dd0c7cf731afb
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 776308,  773866 
Reviewed-on: https://chromium-review.googlesource.com/727901
Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Commit-Queue: Mikel Astiz <mastiz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510051}
[modify] https://crrev.com/499282a044a1760a55e8dbe768415e05dbb0cd43/chrome/renderer/resources/extensions/automation_custom_bindings.js

Comment 5 by mastiz@chromium.org, Oct 19 2017

Cc: dtseng@chromium.org
Project Member

Comment 6 by bugdroid1@chromium.org, Oct 19 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c0ff2f1d7296167cd72e4ec9a3c52f68359ade04

commit c0ff2f1d7296167cd72e4ec9a3c52f68359ade04
Author: Mikel Astiz <mastiz@chromium.org>
Date: Thu Oct 19 12:53:41 2017

Revert "Reland: Fire focus if needed in automation api"

This reverts commit 0b78994873aeebee7ea93602a916a10facdd0848.

Reason for revert: breaks Linux ChromiumOS Tests.

Bug: 776308

Original change's description:
> Reland: Fire focus if needed in automation api
> 
> TBR=dtseng@chromium.org
> Bug:  773866 
> 
> Original change
> 
> Reviewed-on: https://chromium-review.googlesource.com/723606
> Commit-Queue: David Tseng <dtseng@chromium.org>
> Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
> Cr-Original-Commit-Position: refs/heads/master@{#509911}
> Change-Id: I74c39f7d8372b623a827dff89cc20b25f6485a2f
> Reviewed-on: https://chromium-review.googlesource.com/727122
> Reviewed-by: David Tseng <dtseng@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#510006}

TBR=dmazzoni@chromium.org,dtseng@chromium.org

Change-Id: I9025ec011491530ec70cf0c1a0e33bdfec32c512
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  773866 
Reviewed-on: https://chromium-review.googlesource.com/728160
Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Commit-Queue: Mikel Astiz <mastiz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510066}
[modify] https://crrev.com/c0ff2f1d7296167cd72e4ec9a3c52f68359ade04/chrome/browser/chromeos/accessibility/spoken_feedback_browsertest.cc
[modify] https://crrev.com/c0ff2f1d7296167cd72e4ec9a3c52f68359ade04/chrome/renderer/resources/extensions/automation_custom_bindings.js

Comment 7 by mastiz@chromium.org, Oct 19 2017

Status: Fixed (was: Started)

Comment 8 by tapted@chromium.org, Oct 20 2017

Blocking: 773866
Cc: -dtseng@chromium.org mastiz@chromium.org
Components: UI>Accessibility>ChromeVox
Owner: dtseng@chromium.org
Status: Assigned (was: Fixed)
This has come back with "reland2" in r510131, for the most recent 3 build cycles:

https://build.chromium.org/p/chromium.memory/builders/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29

 - https://build.chromium.org/p/chromium.memory/builders/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/builds/24262
 - https://build.chromium.org/p/chromium.memory/builders/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/builds/24261
 - https://build.chromium.org/p/chromium.memory/builders/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/builds/24260

error is

Tracer caught signal 11: addr=0x7f2ff2ea0000 pc=0x578020 sp=0x7f2fef5f3d50
==22778==LeakSanitizer has encountered a fatal error.
==22778==HINT: For debugging, try setting environment variable LSAN_OPTIONS=verbosity=1:log_threads=1
==22778==HINT: LeakSanitizer does not work under ptrace (strace, gdb, etc)
[1019/141604.588082:ERROR:nacl_helper_linux.cc(310)] NaCl helper process running without a sandbox!
Most likely you need to configure your SUID sandbox correctly
-----------------------------------------------------
Suppressions used:
  count      bytes template
      2        288 libfontconfig
-----------------------------------------------------
[22715:22715:1019/141605.778147:FATAL:bluetooth_adapter_bluez.cc(1377)] Check failed: IsDiscovering().


Comment 9 by tapted@chromium.org, Oct 20 2017

Summary: interactive_ui_tests TestAsNormalAndGuestUser/SpokenFeedbackTest.NavigateSystemTray/0 failing on ChromeOS (was: interactive_ui_tests failing on multiple builders)
Project Member

Comment 10 by bugdroid1@chromium.org, Oct 20 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0e77d96e161f842ea234fc13113d79d3c3779a4b

commit 0e77d96e161f842ea234fc13113d79d3c3779a4b
Author: Trent Apted <tapted@chromium.org>
Date: Fri Oct 20 03:16:37 2017

Disable CrOS TestAsNormalAndGuestUser/SpokenFeedbackTest.NavigateSystemTray/0 on Asan

Regressed most recently in r510131. Disabling the test since it's only
failing on Asan builds (and seemingly not with a memory error).

TBR=dtseng@chromium.org

Bug:  773866 , 776308
Change-Id: I786300a1924a1921dc8d796c9129acca25252ae4
Reviewed-on: https://chromium-review.googlesource.com/729608
Reviewed-by: Trent Apted <tapted@chromium.org>
Commit-Queue: Trent Apted <tapted@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510316}
[modify] https://crrev.com/0e77d96e161f842ea234fc13113d79d3c3779a4b/chrome/browser/chromeos/accessibility/spoken_feedback_browsertest.cc

Labels: -Pri-1 -Sheriff-Chromium Pri-3
Builder green, leaving up open in case dtseng@ wants to take a look at the issue with asan. Removing sheriffs.
Project Member

Comment 12 by bugdroid1@chromium.org, Nov 16 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ac7d91f7709404b3d1bdcc477926aff95cc50edd

commit ac7d91f7709404b3d1bdcc477926aff95cc50edd
Author: David Tseng <dtseng@chromium.org>
Date: Thu Nov 16 21:58:08 2017

Revert "Revert "Reland2: Fire focus if needed in automation api""

This reverts commit 9cb0482ff046272f0c3d0fba2808524ff2492017.

Reason for revert: <INSERT REASONING HERE>
A subsequent change stops the failing test from being run on asan but went through after this revert. Seee bug 776308

Original change's description:
> Revert "Reland2: Fire focus if needed in automation api"
>
> This reverts commit 66698953a9c3cafd55955f7422d1f86491668839.
>
> Reason for revert: So sorry to do this! But that same test is failing consistently post this reland:
> https://uberchromegw.corp.google.com/i/chromium.memory/builders/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/builds/24261
> https://logs.chromium.org/v/?s=chromium%2Fbb%2Fchromium.memory%2FLinux_Chromium_OS_ASan_LSan_Tests__1_%2F24261%2F%2B%2Frecipes%2Fsteps%2Finteractive_ui_tests%2F0%2Flogs%2FTestAsNormalAndGuestUser__x2f_SpokenFeedbackTest.NavigateSystemTray__x2f_0%2F0
>
> Original change's description:
> > Reland2: Fire focus if needed in automation api
> >
> > TBR=dtseng@chromium.org
> > Bug:  773866 
> >
> > Original change
> >
> > Reviewed-on: https://chromium-review.googlesource.com/723606
> > Commit-Queue: David Tseng <dtseng@chromium.org>
> > Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
> > Cr-Original-Commit-Position: refs/heads/master@{#509911}
> > Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
> > Change-Id: I1a1be30f3e430f2417ab3ff4b9733de1b8004077
> > Reviewed-on: https://chromium-review.googlesource.com/728302
> > Reviewed-by: David Tseng <dtseng@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#510131}
>
> TBR=dmazzoni@chromium.org,dtseng@chromium.org
>
> Change-Id: Id0bc77906aee42b7449e72c71bc2c533ed7ddcb9
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug:  773866 
> Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
> Reviewed-on: https://chromium-review.googlesource.com/729720
> Reviewed-by: Alice Boxhall <aboxhall@chromium.org>
> Commit-Queue: Alice Boxhall <aboxhall@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#510305}

TBR=dmazzoni@chromium.org,dtseng@chromium.org,aboxhall@chromium.org
Bug: 776308,  773866 


# Not skipping CQ checks because original CL landed > 1 day ago.


Change-Id: Ia67d7681b56c6475f4824c82f434f0c1f0a820f8
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Reviewed-on: https://chromium-review.googlesource.com/775618
Reviewed-by: David Tseng <dtseng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517203}
[modify] https://crrev.com/ac7d91f7709404b3d1bdcc477926aff95cc50edd/chrome/browser/resources/chromeos/chromevox/cvox2/background/desktop_automation_handler.js
[modify] https://crrev.com/ac7d91f7709404b3d1bdcc477926aff95cc50edd/chrome/renderer/resources/extensions/automation_custom_bindings.js

Comment 14 by se...@chromium.org, Dec 13 2017

Cc: kathrelk...@chromium.org
 Issue 794595  has been merged into this issue.
Project Member

Comment 15 by bugdroid1@chromium.org, Dec 13 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6aee1571c2225050a5166a7d3af9d0c19faadb8d

commit 6aee1571c2225050a5166a7d3af9d0c19faadb8d
Author: sebsg <sebsg@chromium.org>
Date: Wed Dec 13 17:35:44 2017

Disable flaky SpokenFeedbackTest.NavigateSystemTray test on CrOS.

Bug: 776308
Change-Id: Ief862b6566f4534468b9ef2228911fff6c0efc10
Tbr: dmazzoni@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/824962
Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523805}
[modify] https://crrev.com/6aee1571c2225050a5166a7d3af9d0c19faadb8d/chrome/browser/chromeos/accessibility/spoken_feedback_browsertest.cc

Sign in to add a comment