New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 776295 link

Starred by 1 user
Status: Fixed
Owner:
calamity@chromium.org
Closed: Dec 2017
Cc:
█ tsergeant@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

[MD Bookmarks] Drop indicator not cleared correctly during native drag

Project Member Reported by tsergeant@chromium.org, Oct 19 2017 
Steps to reproduce:

1. Click and hold on a bookmarks item
2. Drag out of the web contents so that the drag becomes a native drag
3. Return drag into the web contents
4. Drag bookmark over itself

Expected behavior:

Drop indicator should clear from other bookmarks when hovering over the dragged bookmark

Actual behavior:

Drop indicator will remain on the last hovered bookmark.


This issue is a bit difficult to explain, let me know if you can't figure it out and I'll record a video
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 24 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/508268d87d3826b4e0ccfe1d38915e9e422942c0

commit 508268d87d3826b4e0ccfe1d38915e9e422942c0
Author: Christopher Lam <calamity@chromium.org>
Date: Tue Oct 24 02:49:03 2017

[MD Bookmarks] Fix drag indicator not clearing on Mac.

This CL makes the drag indicator clear at 100ms rather than reset to
100ms every drag event. This fixes an issue where drag events on Mac
which fire every 50ms would prevent the indicator clearing task from
ever firing.

Bug:  776295 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Ifd32d89d395086fafe4e0cdd9506753686398751
Reviewed-on: https://chromium-review.googlesource.com/729610
Reviewed-by: Tim Sergeant <tsergeant@chromium.org>
Commit-Queue: calamity <calamity@chromium.org>
Cr-Commit-Position: refs/heads/master@{#511017}
[modify] https://crrev.com/508268d87d3826b4e0ccfe1d38915e9e422942c0/chrome/browser/resources/md_bookmarks/dnd_manager.js

Comment 2 by calamity@chromium.org, Dec 7 2017

Status: Fixed (was: Assigned)
►

Sign in to add a comment