New issue
Advanced search Search tips

Issue 776279 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug

Blocking:
issue 751852



Sign in to add a comment

cargo-0.20.0: build failure

Project Member Reported by vapier@chromium.org, Oct 19 2017

Issue description

can't add a package to the SDK that doesn't build ;)

https://uberchromegw.corp.google.com/i/chromiumos.tryserver/builders/chromiumos-sdk/builds/2630/steps/SDKBuildToolchains/logs/stdio

>>> Emerging (1 of 1) dev-util/cargo-0.20.0::portage-stable
error: variable does not need to be mutable
    --> src/cargo/core/resolver/mod.rs:1095:17
     |
1095 |             let mut set = self.resolve_features.entry(pkgid.clone())
     |                 ^^^^^^^
     |
note: lint level defined here
    --> src/cargo/lib.rs:1:9
     |
1    | #![deny(unused)]
     |         ^^^^^^
     = note: #[deny(unused_mut)] implied by #[deny(unused)]

error: variable does not need to be mutable
  --> src/cargo/util/read2.rs:15:18
   |
15 |                  mut data: &mut FnMut(bool, &mut Vec<u8>, bool)) -> io::Result<()> {
   |                  ^^^^^^^^

error: aborting due to 2 previous errors

error: Could not compile `cargo`.
 

Comment 1 by za...@chromium.org, Oct 19 2017

Status: Started (was: Unconfirmed)
Sorry about that. It looks like when I upgraded Rust in the chroot, new warnings were added and cargo compiles with warnings as errors. A cargo upgrade (which I'm doing this minute) should fix it up.
Project Member

Comment 2 by bugdroid1@chromium.org, Oct 20 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/portage-stable/+/8ca08e4b580292ba615bf03025d0f252791d42c5

commit 8ca08e4b580292ba615bf03025d0f252791d42c5
Author: Zach Reizner <zachr@google.com>
Date: Fri Oct 20 02:06:10 2017

dev-util/cargo: upgrade to 0.21.0

Similar things were done to the ebuild as in 0.21.0. The cargo.eclass
also needed to be updated to handle RC dependencies.

BUG= chromium:776279 
TEST=sudo emerge cargo

Change-Id: I82945881601943c022d037f308b3c2e6784c1305
Reviewed-on: https://chromium-review.googlesource.com/728728
Commit-Ready: Zach Reizner <zachr@chromium.org>
Tested-by: Zach Reizner <zachr@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[add] https://crrev.com/8ca08e4b580292ba615bf03025d0f252791d42c5/dev-util/cargo/files/0.21.0-openssl-0.9.15.patch
[modify] https://crrev.com/8ca08e4b580292ba615bf03025d0f252791d42c5/dev-util/cargo/Manifest
[modify] https://crrev.com/8ca08e4b580292ba615bf03025d0f252791d42c5/eclass/cargo.eclass
[rename] https://crrev.com/8ca08e4b580292ba615bf03025d0f252791d42c5/dev-util/cargo/cargo-0.21.0.ebuild

Comment 3 by vapier@chromium.org, Oct 20 2017

Status: Fixed (was: Started)

Comment 4 by dchan@chromium.org, Jan 22 2018

Status: archived (was: Fixed)

Comment 5 by dchan@chromium.org, Jan 23 2018

Status: Fixed (was: Archived)
Components: OS>Systems>Containers

Sign in to add a comment