New issue
Advanced search Search tips

Issue 776265 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 3
Type: Bug



Sign in to add a comment

`browser_tests --gtest_filter=BrowserDialogTest.Invoke --dialog=... --interactive` CHECKs with failure

Project Member Reported by tapted@chromium.org, Oct 19 2017

Issue description

Chrome Version       : 63.0.3236.0
OS Version: OS X 10.12.6

It goes

$ [56595:775:1019/151313.940742:538202686826498:FATAL:test_suite.cc(241)] Check failed: printer_->Initialize(output_path).
0   libbase.dylib                       0x00000001204569de base::debug::StackTrace::StackTrace(unsigned long) + 174
1   libbase.dylib                       0x0000000120456a9d base::debug::StackTrace::StackTrace(unsigned long) + 29
2   libbase.dylib                       0x0000000120454d4c base::debug::StackTrace::StackTrace() + 28
3   libbase.dylib                       0x00000001204edf7f logging::LogMessage::~LogMessage() + 479
4   libbase.dylib                       0x00000001204eb8e5 logging::LogMessage::~LogMessage() + 21
5   browser_tests                       0x0000000107728c1f base::TestSuite::AddTestLauncherResultPrinter() + 623
6   browser_tests                       0x00000001077299d9 base::TestSuite::Initialize() + 2393
7   browser_tests                       0x00000001092648d5 content::ContentTestSuiteBase::Initialize() + 21
8   browser_tests                       0x00000001076a1846 ChromeTestSuite::Initialize() + 150
9   browser_tests                       0x0000000107727f4a base::TestSuite::Run() + 74
10  browser_tests                       0x000000010769fee2 ChromeTestSuiteRunner::RunTestSuite(int, char**) + 82
11  browser_tests                       0x00000001076a0059 ChromeTestLauncherDelegate::RunTestSuite(int, char**) + 57
12  browser_tests                       0x000000010933d9ae content::LaunchTests(content::TestLauncherDelegate*, unsigned long, int, char**) + 734
13  browser_tests                       0x00000001076a0f92 LaunchChromeTests(unsigned long, content::TestLauncherDelegate*, int, char**) + 114
14  browser_tests                       0x000000010769fda9 main + 153
15  libdyld.dylib                       0x00007fffc330d235 start + 1
16  ???                                 0x000000000000000c 0x0 + 12

Fix -> https://chromium-review.googlesource.com/#/c/chromium/src/+/727680
 
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 19 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/edd1ebe02489c766ec7d5fad106b57f7395a1be3

commit edd1ebe02489c766ec7d5fad106b57f7395a1be3
Author: Trent Apted <tapted@chromium.org>
Date: Thu Oct 19 23:51:30 2017

Fix TestBrowserDialog --interactive.

It started failing in r482709 since more robust checks were added for
checking for test result output files.

To fix, remove switches::kTestLauncherOutput from the subprocess
command line so it doesn't try to create test result output.

Bug:  776265 
Change-Id: Ib0406b77fb7aa90cddf712331342526fa555491b
Reviewed-on: https://chromium-review.googlesource.com/727680
Commit-Queue: Trent Apted <tapted@chromium.org>
Reviewed-by: Bret Sepulveda <bsep@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510254}
[modify] https://crrev.com/edd1ebe02489c766ec7d5fad106b57f7395a1be3/chrome/browser/ui/test/browser_dialog_browsertest.cc

Comment 2 by tapted@chromium.org, Oct 19 2017

Status: Fixed (was: Started)

Sign in to add a comment