This is a cover bug for the implementation of the floating keyboard from the dev side.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/20bca7f52528d17cc612d8ced3820c6b7188441d commit 20bca7f52528d17cc612d8ced3820c6b7188441d Author: Blake O'Hare <blakeo@chromium.org> Date: Fri Oct 20 06:21:36 2017 Move KeyboardLayoutManager bounds-setting logic to ContainerBehavior Also add unit test for ContainerFullWidthBehavior. Bug: 776260 Change-Id: I77d1f01ca0ec6dd5459a47b1158cbfc01eba0799 Reviewed-on: https://chromium-review.googlesource.com/725022 Commit-Queue: Blake O'Hare <blakeo@chromium.org> Reviewed-by: Yuichiro Hanada <yhanada@chromium.org> Cr-Commit-Position: refs/heads/master@{#510357} [modify] https://crrev.com/20bca7f52528d17cc612d8ced3820c6b7188441d/ui/keyboard/BUILD.gn [modify] https://crrev.com/20bca7f52528d17cc612d8ced3820c6b7188441d/ui/keyboard/container_behavior.h [modify] https://crrev.com/20bca7f52528d17cc612d8ced3820c6b7188441d/ui/keyboard/container_full_width_behavior.cc [modify] https://crrev.com/20bca7f52528d17cc612d8ced3820c6b7188441d/ui/keyboard/container_full_width_behavior.h [add] https://crrev.com/20bca7f52528d17cc612d8ced3820c6b7188441d/ui/keyboard/container_full_width_behavior_unittest.cc [modify] https://crrev.com/20bca7f52528d17cc612d8ced3820c6b7188441d/ui/keyboard/keyboard_controller.cc [modify] https://crrev.com/20bca7f52528d17cc612d8ced3820c6b7188441d/ui/keyboard/keyboard_controller.h [modify] https://crrev.com/20bca7f52528d17cc612d8ced3820c6b7188441d/ui/keyboard/keyboard_layout_manager.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fffd46591868037840bbabb7baa7c94c51cc5536 commit fffd46591868037840bbabb7baa7c94c51cc5536 Author: Blake O'Hare <blakeo@chromium.org> Date: Fri Oct 20 08:54:42 2017 Refactor overscroll check into ContainerBehavior. This will allow the future floating container behavior to disable overscroll independent of locking. In general, it should be up to the behavior to determine whether overscroll is enabled and not up to the various calling sites to interpret what a locked keyboard actually means. Bug: 776260 Change-Id: I0a0ce38a704343658d3ac8c656f993f980d6ab3c Reviewed-on: https://chromium-review.googlesource.com/730035 Reviewed-by: Yuichiro Hanada <yhanada@chromium.org> Commit-Queue: Blake O'Hare <blakeo@chromium.org> Cr-Commit-Position: refs/heads/master@{#510381} [modify] https://crrev.com/fffd46591868037840bbabb7baa7c94c51cc5536/ui/keyboard/container_behavior.h [modify] https://crrev.com/fffd46591868037840bbabb7baa7c94c51cc5536/ui/keyboard/container_full_width_behavior.cc [modify] https://crrev.com/fffd46591868037840bbabb7baa7c94c51cc5536/ui/keyboard/container_full_width_behavior.h [modify] https://crrev.com/fffd46591868037840bbabb7baa7c94c51cc5536/ui/keyboard/keyboard_controller.cc [modify] https://crrev.com/fffd46591868037840bbabb7baa7c94c51cc5536/ui/keyboard/keyboard_controller.h [modify] https://crrev.com/fffd46591868037840bbabb7baa7c94c51cc5536/ui/keyboard/keyboard_ui.cc [modify] https://crrev.com/fffd46591868037840bbabb7baa7c94c51cc5536/ui/keyboard/keyboard_util.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/bfa00e890077e86da600bdb50ca3cc0a765a2957 commit bfa00e890077e86da600bdb50ca3cc0a765a2957 Author: Blake O'Hare <blakeo@chromium.org> Date: Mon Oct 23 13:27:25 2017 Implement the basics of the floating keyboard This is currently not accessible functionality, but is (somewhat) unit-tested. Once a few changes have landed in the extension (namely horizontal scaling to content container) this will be configured to the enable-floating-virtual-keyboard flag. Bug: 776260 Change-Id: I456a4ba56b6f0842ade2b27abe39cb1d66886c09 Reviewed-on: https://chromium-review.googlesource.com/732001 Commit-Queue: Blake O'Hare <blakeo@chromium.org> Reviewed-by: Yuichiro Hanada <yhanada@chromium.org> Cr-Commit-Position: refs/heads/master@{#510778} [modify] https://crrev.com/bfa00e890077e86da600bdb50ca3cc0a765a2957/ui/keyboard/BUILD.gn [add] https://crrev.com/bfa00e890077e86da600bdb50ca3cc0a765a2957/ui/keyboard/container_floating_behavior.cc [add] https://crrev.com/bfa00e890077e86da600bdb50ca3cc0a765a2957/ui/keyboard/container_floating_behavior.h [add] https://crrev.com/bfa00e890077e86da600bdb50ca3cc0a765a2957/ui/keyboard/container_floating_behavior_unittest.cc [modify] https://crrev.com/bfa00e890077e86da600bdb50ca3cc0a765a2957/ui/keyboard/container_full_width_behavior_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9e9317b2a124ece591fcc2f23cb96127775b76a6 commit 9e9317b2a124ece591fcc2f23cb96127775b76a6 Author: Blake O'Hare <blakeo@chromium.org> Date: Tue Oct 24 02:49:35 2017 Add enable-floating-virtual-keyboard flag definition This will be used to hide away ongoing floating virtual keyboard work. Bug: 776260 Change-Id: I05820216a36b6a55609c9091b70266b931d7a59a Reviewed-on: https://chromium-review.googlesource.com/727321 Commit-Queue: Blake O'Hare <blakeo@chromium.org> Reviewed-by: Yuichiro Hanada <yhanada@chromium.org> Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#511018} [modify] https://crrev.com/9e9317b2a124ece591fcc2f23cb96127775b76a6/chrome/browser/about_flags.cc [modify] https://crrev.com/9e9317b2a124ece591fcc2f23cb96127775b76a6/chrome/browser/flag_descriptions.cc [modify] https://crrev.com/9e9317b2a124ece591fcc2f23cb96127775b76a6/chrome/browser/flag_descriptions.h [modify] https://crrev.com/9e9317b2a124ece591fcc2f23cb96127775b76a6/tools/metrics/histograms/enums.xml [modify] https://crrev.com/9e9317b2a124ece591fcc2f23cb96127775b76a6/ui/base/ui_base_switches.cc [modify] https://crrev.com/9e9317b2a124ece591fcc2f23cb96127775b76a6/ui/base/ui_base_switches.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2e5f540f41c05ff0cbef6e056bd45e8087c3a3ae commit 2e5f540f41c05ff0cbef6e056bd45e8087c3a3ae Author: Blake O'Hare <blakeo@chromium.org> Date: Tue Oct 24 08:52:43 2017 Floating keyboard starting location Floating keyboard should start in the bottom right of the screen with some aesthetic margins. This is not final UX, but is more reasonable than the current behavior of using the top left corner. When the user moves the keyboard, the new location should be remembered and used next time the keyboard is shown. The unfortunate consequence of this is that the behavior becomes stateful (not terrible, but open to alternate suggestions). Keyboard movement is not implemented in master and will be checked in in a separate CL. Bug: 776260 Change-Id: I4b369aca456da57896878271d4e1a64aa4df109a Reviewed-on: https://chromium-review.googlesource.com/735200 Reviewed-by: Yuichiro Hanada <yhanada@chromium.org> Commit-Queue: Blake O'Hare <blakeo@chromium.org> Cr-Commit-Position: refs/heads/master@{#511061} [modify] https://crrev.com/2e5f540f41c05ff0cbef6e056bd45e8087c3a3ae/ui/keyboard/container_behavior.h [modify] https://crrev.com/2e5f540f41c05ff0cbef6e056bd45e8087c3a3ae/ui/keyboard/container_floating_behavior.cc [modify] https://crrev.com/2e5f540f41c05ff0cbef6e056bd45e8087c3a3ae/ui/keyboard/container_floating_behavior.h [modify] https://crrev.com/2e5f540f41c05ff0cbef6e056bd45e8087c3a3ae/ui/keyboard/container_floating_behavior_unittest.cc [modify] https://crrev.com/2e5f540f41c05ff0cbef6e056bd45e8087c3a3ae/ui/keyboard/container_full_width_behavior.cc [modify] https://crrev.com/2e5f540f41c05ff0cbef6e056bd45e8087c3a3ae/ui/keyboard/container_full_width_behavior.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/00599592f22943aea681f2a428a44b1693fd4430 commit 00599592f22943aea681f2a428a44b1693fd4430 Author: Blake O'Hare <blakeo@chromium.org> Date: Wed Oct 25 10:05:35 2017 Add click-and-drag support for the Floating Keyboard This adds two handlers to event_filter: OnMouseEvent and OnTouchEvent Additionally, there is now a new field on KeyboardController called drag_descriptor_ whose lifetime is tied to a user's click and drag motion. Once the user lifts the mouse/finger, the DragDescriptor is removed. Because the extension has no visual location for drag handles yet, the top left corner of the keyboard (60x60 square) is temporarily being used as an implicit drag handle. Rather than using heuristics to calculate whether a bounds change was user-driven, simply trigger the location-saving from the drag handling code itself which is definitive. This simplified some of the AdjustSetBoundsRequest code in ContainerFloatingBehavior. Bug: 776260 Change-Id: Ic98dce38a8f2c6919c0dd1ba73fde62f686268d1 Reviewed-on: https://chromium-review.googlesource.com/737489 Commit-Queue: Blake O'Hare <blakeo@chromium.org> Reviewed-by: Yuichiro Hanada <yhanada@chromium.org> Cr-Commit-Position: refs/heads/master@{#511411} [modify] https://crrev.com/00599592f22943aea681f2a428a44b1693fd4430/ui/keyboard/BUILD.gn [modify] https://crrev.com/00599592f22943aea681f2a428a44b1693fd4430/ui/keyboard/container_behavior.h [modify] https://crrev.com/00599592f22943aea681f2a428a44b1693fd4430/ui/keyboard/container_floating_behavior.cc [modify] https://crrev.com/00599592f22943aea681f2a428a44b1693fd4430/ui/keyboard/container_floating_behavior.h [modify] https://crrev.com/00599592f22943aea681f2a428a44b1693fd4430/ui/keyboard/container_floating_behavior_unittest.cc [modify] https://crrev.com/00599592f22943aea681f2a428a44b1693fd4430/ui/keyboard/container_full_width_behavior.cc [modify] https://crrev.com/00599592f22943aea681f2a428a44b1693fd4430/ui/keyboard/container_full_width_behavior.h [add] https://crrev.com/00599592f22943aea681f2a428a44b1693fd4430/ui/keyboard/drag_descriptor.cc [add] https://crrev.com/00599592f22943aea681f2a428a44b1693fd4430/ui/keyboard/drag_descriptor.h [modify] https://crrev.com/00599592f22943aea681f2a428a44b1693fd4430/ui/keyboard/keyboard_controller.cc [modify] https://crrev.com/00599592f22943aea681f2a428a44b1693fd4430/ui/keyboard/keyboard_controller.h [modify] https://crrev.com/00599592f22943aea681f2a428a44b1693fd4430/ui/keyboard/keyboard_event_filter.cc [modify] https://crrev.com/00599592f22943aea681f2a428a44b1693fd4430/ui/keyboard/keyboard_event_filter.h [modify] https://crrev.com/00599592f22943aea681f2a428a44b1693fd4430/ui/keyboard/keyboard_layout_manager.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5510a395e8f3e4f16c2d869a5f64eb2d652af88a commit 5510a395e8f3e4f16c2d869a5f64eb2d652af88a Author: Blake O'Hare <blakeo@chromium.org> Date: Fri Oct 27 08:20:07 2017 Add plumbing to change the keyboard's ContainerBehavior. This will allow the keyboard to swap containers while still running. There is currently no UI to switch to floating keyboard, but this was tested using a hack to simulate such UI. Bug: 776260 Change-Id: I5fe779db8dafcf104b9e46973313c55d9263248b Reviewed-on: https://chromium-review.googlesource.com/737727 Commit-Queue: Blake O'Hare <blakeo@chromium.org> Reviewed-by: Yuichiro Hanada <yhanada@chromium.org> Cr-Commit-Position: refs/heads/master@{#512123} [modify] https://crrev.com/5510a395e8f3e4f16c2d869a5f64eb2d652af88a/ui/keyboard/container_behavior.h [modify] https://crrev.com/5510a395e8f3e4f16c2d869a5f64eb2d652af88a/ui/keyboard/container_floating_behavior.cc [modify] https://crrev.com/5510a395e8f3e4f16c2d869a5f64eb2d652af88a/ui/keyboard/container_floating_behavior.h [modify] https://crrev.com/5510a395e8f3e4f16c2d869a5f64eb2d652af88a/ui/keyboard/container_full_width_behavior.cc [modify] https://crrev.com/5510a395e8f3e4f16c2d869a5f64eb2d652af88a/ui/keyboard/container_full_width_behavior.h [add] https://crrev.com/5510a395e8f3e4f16c2d869a5f64eb2d652af88a/ui/keyboard/container_type.h [modify] https://crrev.com/5510a395e8f3e4f16c2d869a5f64eb2d652af88a/ui/keyboard/keyboard_controller.cc [modify] https://crrev.com/5510a395e8f3e4f16c2d869a5f64eb2d652af88a/ui/keyboard/keyboard_controller.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/14f0c1158645c488ace6760de3351227f1ec551c commit 14f0c1158645c488ace6760de3351227f1ec551c Author: Blake O'Hare <blakeo@chromium.org> Date: Mon Oct 30 20:21:36 2017 Use a new flag to relay floating VK status to the extension. This introduces a new flag to the extension called 'floatingkeyboard' as opposed to the old flag which was 'floatingvirtualkeyboard'. The old flag is still referenced by a helper method which is used to activate legacy floating keyboard code. Due to the semi-tandem nature of the extension, this is just the first step to relaying the flag. The extension needs to be updated to remove references to the old flag and the different name here will prevent accidental collisions or showing the old keyboard. Bug: 776260 Change-Id: I38b5f5275b2b493e5eea5c87b7ad509a018741cc Reviewed-on: https://chromium-review.googlesource.com/741426 Commit-Queue: Blake O'Hare <blakeo@chromium.org> Reviewed-by: Yuichiro Hanada <yhanada@chromium.org> Cr-Commit-Position: refs/heads/master@{#512599} [modify] https://crrev.com/14f0c1158645c488ace6760de3351227f1ec551c/chrome/browser/extensions/api/virtual_keyboard_private/chrome_virtual_keyboard_delegate.cc [modify] https://crrev.com/14f0c1158645c488ace6760de3351227f1ec551c/ui/keyboard/keyboard_util.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f9184bc63112e6930a3fecfaafd09253f86579da commit f9184bc63112e6930a3fecfaafd09253f86579da Author: Blake O'Hare <blakeo@chromium.org> Date: Fri Nov 03 20:17:11 2017 Add KeyboardController reference to ContainerBehavior KeyboardController::GetInstance() is meant as an external accessor and shouldn't be needed for a class whose lifetime is managed by the KeyboardController itself (and thus GetInstance isn't always realiably updated in unit tests). Bug: 776260 Change-Id: Id9f219a1e651c8eb1733f4cd7f07896c19f45bc7 Reviewed-on: https://chromium-review.googlesource.com/745083 Commit-Queue: Blake O'Hare <blakeo@chromium.org> Reviewed-by: Yuichiro Hanada <yhanada@chromium.org> Cr-Commit-Position: refs/heads/master@{#513891} [modify] https://crrev.com/f9184bc63112e6930a3fecfaafd09253f86579da/ui/keyboard/container_floating_behavior.cc [modify] https://crrev.com/f9184bc63112e6930a3fecfaafd09253f86579da/ui/keyboard/container_floating_behavior.h [modify] https://crrev.com/f9184bc63112e6930a3fecfaafd09253f86579da/ui/keyboard/container_floating_behavior_unittest.cc [modify] https://crrev.com/f9184bc63112e6930a3fecfaafd09253f86579da/ui/keyboard/container_full_width_behavior.cc [modify] https://crrev.com/f9184bc63112e6930a3fecfaafd09253f86579da/ui/keyboard/container_full_width_behavior.h [modify] https://crrev.com/f9184bc63112e6930a3fecfaafd09253f86579da/ui/keyboard/container_full_width_behavior_unittest.cc [modify] https://crrev.com/f9184bc63112e6930a3fecfaafd09253f86579da/ui/keyboard/keyboard_controller.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/86308d557aceb5a946fca71ee2ecc5a29274aaea commit 86308d557aceb5a946fca71ee2ecc5a29274aaea Author: Blake O'Hare <blakeo@chromium.org> Date: Wed Nov 15 03:05:32 2017 Refactor keyboard controller observer method for bounds changes There are basically 3 scenarios that consumers of this method check for: 1. Is the keyboard available? They do this by checking if the bounds are empty 2. Is the keyboard affecting the workspace layout? This is the key motivation for this refactor. The floating keyboard will not affect the layout. Usually consumers of this method integrate a check with locked keyboard as well. With this CL, this locked check will be handled by keyboard code, and send empty bounds instead in those situations, so that the caller doesn't have to do this check themselves. 3. Where is the keyboard on the screen? There is an accessibility use case for touch exploration. I could have potentially used the old method but I would slightly prefer to rename it so that it's a little more clear that the bounds change for visual purposes vs bounds change for workspace layout purposes are clearly different scenarios. This also ensures that there is a clear audit of current use cases to change to one of the other methods. I will send out follow-up CL's to update implementers of the KeyboardControllerObserver grouped by OWNERS. Bug: 776260 Change-Id: I46eea0ad9954147ada51fbf488b85cfcce0ff306 Reviewed-on: https://chromium-review.googlesource.com/768310 Commit-Queue: Blake O'Hare <blakeo@chromium.org> Reviewed-by: Yuichiro Hanada <yhanada@chromium.org> Cr-Commit-Position: refs/heads/master@{#516575} [modify] https://crrev.com/86308d557aceb5a946fca71ee2ecc5a29274aaea/ui/keyboard/container_behavior.h [modify] https://crrev.com/86308d557aceb5a946fca71ee2ecc5a29274aaea/ui/keyboard/container_floating_behavior.cc [modify] https://crrev.com/86308d557aceb5a946fca71ee2ecc5a29274aaea/ui/keyboard/container_floating_behavior.h [modify] https://crrev.com/86308d557aceb5a946fca71ee2ecc5a29274aaea/ui/keyboard/container_full_width_behavior.cc [modify] https://crrev.com/86308d557aceb5a946fca71ee2ecc5a29274aaea/ui/keyboard/container_full_width_behavior.h [modify] https://crrev.com/86308d557aceb5a946fca71ee2ecc5a29274aaea/ui/keyboard/keyboard_controller.cc [modify] https://crrev.com/86308d557aceb5a946fca71ee2ecc5a29274aaea/ui/keyboard/keyboard_controller_observer.h [modify] https://crrev.com/86308d557aceb5a946fca71ee2ecc5a29274aaea/ui/keyboard/keyboard_controller_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/27d0bbf499f010ce35f30d3348bd59cbddb0dfd3 commit 27d0bbf499f010ce35f30d3348bd59cbddb0dfd3 Author: Yingbing Wu <wuyingbing@chromium.org> Date: Thu Nov 30 01:10:25 2017 Implements virtualKeyboard.setDraggableArea API. * API usage. When user switch virtual keyboard to floating mode by call virtualKeyboard.setMode. Google Input Tool extension can util the API to decide "when/how/where" to allow user to drag the virtual keyboard. Sets the draggable area to zero {left:x, top:x, width: 0, height: 0} to disable the drag feature. The current implementation only allow to set draggable area after switching to floating mode. The follow CL will decouple these two APIs. Allows to set draggable area in any time. Then when keyboard in floating mode, user can drag. In full widthd mode, user can't drag. Bug: 771466, 776260 Change-Id: If998e16d9f0b31e97474b23710ebd246e5e9c9db Reviewed-on: https://chromium-review.googlesource.com/788310 Reviewed-by: Toni Barzic <tbarzic@chromium.org> Reviewed-by: Michael Giuffrida <michaelpg@chromium.org> Reviewed-by: Ilya Sherman <isherman@chromium.org> Reviewed-by: Shu Chen <shuchen@chromium.org> Reviewed-by: Yuichiro Hanada <yhanada@chromium.org> Commit-Queue: Yingbing Wu <wuyingbing@chromium.org> Cr-Commit-Position: refs/heads/master@{#520363} [modify] https://crrev.com/27d0bbf499f010ce35f30d3348bd59cbddb0dfd3/chrome/browser/extensions/api/virtual_keyboard_private/chrome_virtual_keyboard_delegate.cc [modify] https://crrev.com/27d0bbf499f010ce35f30d3348bd59cbddb0dfd3/chrome/browser/extensions/api/virtual_keyboard_private/chrome_virtual_keyboard_delegate.h [modify] https://crrev.com/27d0bbf499f010ce35f30d3348bd59cbddb0dfd3/extensions/browser/api/virtual_keyboard_private/virtual_keyboard_delegate.h [modify] https://crrev.com/27d0bbf499f010ce35f30d3348bd59cbddb0dfd3/extensions/browser/api/virtual_keyboard_private/virtual_keyboard_private_api.cc [modify] https://crrev.com/27d0bbf499f010ce35f30d3348bd59cbddb0dfd3/extensions/browser/api/virtual_keyboard_private/virtual_keyboard_private_api.h [modify] https://crrev.com/27d0bbf499f010ce35f30d3348bd59cbddb0dfd3/extensions/browser/extension_function_histogram_value.h [modify] https://crrev.com/27d0bbf499f010ce35f30d3348bd59cbddb0dfd3/extensions/common/api/virtual_keyboard_private.json [modify] https://crrev.com/27d0bbf499f010ce35f30d3348bd59cbddb0dfd3/extensions/shell/browser/shell_virtual_keyboard_delegate.cc [modify] https://crrev.com/27d0bbf499f010ce35f30d3348bd59cbddb0dfd3/extensions/shell/browser/shell_virtual_keyboard_delegate.h [modify] https://crrev.com/27d0bbf499f010ce35f30d3348bd59cbddb0dfd3/tools/metrics/histograms/enums.xml [modify] https://crrev.com/27d0bbf499f010ce35f30d3348bd59cbddb0dfd3/ui/keyboard/container_behavior.h [modify] https://crrev.com/27d0bbf499f010ce35f30d3348bd59cbddb0dfd3/ui/keyboard/container_floating_behavior.cc [modify] https://crrev.com/27d0bbf499f010ce35f30d3348bd59cbddb0dfd3/ui/keyboard/container_floating_behavior.h [modify] https://crrev.com/27d0bbf499f010ce35f30d3348bd59cbddb0dfd3/ui/keyboard/container_floating_behavior_unittest.cc [modify] https://crrev.com/27d0bbf499f010ce35f30d3348bd59cbddb0dfd3/ui/keyboard/container_full_width_behavior.cc [modify] https://crrev.com/27d0bbf499f010ce35f30d3348bd59cbddb0dfd3/ui/keyboard/container_full_width_behavior.h [modify] https://crrev.com/27d0bbf499f010ce35f30d3348bd59cbddb0dfd3/ui/keyboard/keyboard_controller.cc [modify] https://crrev.com/27d0bbf499f010ce35f30d3348bd59cbddb0dfd3/ui/keyboard/keyboard_controller.h
Are there any unresolved issues?
Have you fixed the sizing of the keyboard? It's still really big when I try to use it.
Omri: We need your input on the sizing issue :) crbug.com/817206
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3d9e780509db47ba99d0caf0a82a074b5e2e18d0 commit 3d9e780509db47ba99d0caf0a82a074b5e2e18d0 Author: Yuichiro Hanada <yhanada@chromium.org> Date: Fri Mar 09 01:17:36 2018 Enable 'enable-floating-virtual-keyboard' by default. Bug: 771466, 776260 Test: Confirm that floating VK is enabled after setting the flag to 'Default'. Change-Id: I2e4a26ee05dbaba16cd78f0768e6fae3d079bcc4 Reviewed-on: https://chromium-review.googlesource.com/954804 Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Yuichiro Hanada <yhanada@chromium.org> Cr-Commit-Position: refs/heads/master@{#541976} [modify] https://crrev.com/3d9e780509db47ba99d0caf0a82a074b5e2e18d0/ui/base/ui_base_features.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c972bfd116979ea534a77401fe6da19fdfcf9e5f commit c972bfd116979ea534a77401fe6da19fdfcf9e5f Author: Yuichiro Hanada <yhanada@chromium.org> Date: Sat Mar 17 00:11:10 2018 Add new method, virtualKeyboardPrivate.setContainerBehavior(). virtualKeyboardPrivate.setMode() lacks 'bounds' parameter to set the virtual keyboard bounds after changing mode. The new method will replace setMode() with an ability to set bounds of the virtual keyboard container after changing mode. It's needed to prevent flashing when changing virtual keyboard mode. We want to change the window bounds before starting showing animation. Bug: 776260 , 802991 Test: Manual. Change-Id: Iacf9977d06e05ac4dd3c66175cae7ba87d5fa0c6 Reviewed-on: https://chromium-review.googlesource.com/942281 Reviewed-by: Devlin <rdevlin.cronin@chromium.org> Reviewed-by: Ilya Sherman <isherman@chromium.org> Reviewed-by: Robert Flack <flackr@chromium.org> Reviewed-by: Toni Barzic <tbarzic@chromium.org> Reviewed-by: Blake O'Hare <blakeo@chromium.org> Commit-Queue: Yuichiro Hanada <yhanada@chromium.org> Cr-Commit-Position: refs/heads/master@{#543878} [modify] https://crrev.com/c972bfd116979ea534a77401fe6da19fdfcf9e5f/ash/wm/lock_layout_manager_unittest.cc [modify] https://crrev.com/c972bfd116979ea534a77401fe6da19fdfcf9e5f/chrome/browser/extensions/api/virtual_keyboard_private/chrome_virtual_keyboard_delegate.cc [modify] https://crrev.com/c972bfd116979ea534a77401fe6da19fdfcf9e5f/chrome/browser/extensions/api/virtual_keyboard_private/chrome_virtual_keyboard_delegate.h [modify] https://crrev.com/c972bfd116979ea534a77401fe6da19fdfcf9e5f/extensions/browser/api/virtual_keyboard_private/virtual_keyboard_delegate.h [modify] https://crrev.com/c972bfd116979ea534a77401fe6da19fdfcf9e5f/extensions/browser/api/virtual_keyboard_private/virtual_keyboard_private_api.cc [modify] https://crrev.com/c972bfd116979ea534a77401fe6da19fdfcf9e5f/extensions/browser/api/virtual_keyboard_private/virtual_keyboard_private_api.h [modify] https://crrev.com/c972bfd116979ea534a77401fe6da19fdfcf9e5f/extensions/browser/extension_function_histogram_value.h [modify] https://crrev.com/c972bfd116979ea534a77401fe6da19fdfcf9e5f/extensions/common/api/virtual_keyboard_private.json [modify] https://crrev.com/c972bfd116979ea534a77401fe6da19fdfcf9e5f/extensions/shell/browser/shell_virtual_keyboard_delegate.cc [modify] https://crrev.com/c972bfd116979ea534a77401fe6da19fdfcf9e5f/extensions/shell/browser/shell_virtual_keyboard_delegate.h [modify] https://crrev.com/c972bfd116979ea534a77401fe6da19fdfcf9e5f/tools/metrics/histograms/enums.xml [modify] https://crrev.com/c972bfd116979ea534a77401fe6da19fdfcf9e5f/ui/keyboard/keyboard_controller.cc [modify] https://crrev.com/c972bfd116979ea534a77401fe6da19fdfcf9e5f/ui/keyboard/keyboard_controller.h [modify] https://crrev.com/c972bfd116979ea534a77401fe6da19fdfcf9e5f/ui/keyboard/keyboard_controller_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a23fc1891ea7addc6ce3c704734bd844cc38264f commit a23fc1891ea7addc6ce3c704734bd844cc38264f Author: Yuichiro Hanada <yhanada@chromium.org> Date: Tue May 29 03:27:13 2018 Set enable-floating-virtual-keyboard feature to disabled by default. I've set up a finch field trial for this feature. We don't have to modify this value manually anymore. Bug: 776260 , 846996 Change-Id: I6d4f5428c90393cfaf509bd5ae00dedb235f18f7 Reviewed-on: https://chromium-review.googlesource.com/1074627 Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Yuichiro Hanada <yhanada@chromium.org> Cr-Commit-Position: refs/heads/master@{#562329} [modify] https://crrev.com/a23fc1891ea7addc6ce3c704734bd844cc38264f/ui/base/ui_base_features.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e049bd00df301d5d5e1594e667b81f4c227cafd6 commit e049bd00df301d5d5e1594e667b81f4c227cafd6 Author: Yuichiro Hanada <yhanada@chromium.org> Date: Fri Jun 01 05:34:51 2018 Set enable-floating-virtual-keyboard feature to disabled by default. I've set up a finch field trial for this feature. We don't have to modify this value manually anymore. Bug: 776260 , 846996 Change-Id: I6d4f5428c90393cfaf509bd5ae00dedb235f18f7 Reviewed-on: https://chromium-review.googlesource.com/1074627 Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Yuichiro Hanada <yhanada@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#562329}(cherry picked from commit a23fc1891ea7addc6ce3c704734bd844cc38264f) Reviewed-on: https://chromium-review.googlesource.com/1082131 Reviewed-by: Yuichiro Hanada <yhanada@chromium.org> Cr-Commit-Position: refs/branch-heads/3440@{#82} Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733} [modify] https://crrev.com/e049bd00df301d5d5e1594e667b81f4c227cafd6/ui/base/ui_base_features.cc
This bug has a target milestone that has passed. Please help bug cleanup: mark it closed or update/remove the milestone target.
Comment 1 by blakeo@chromium.org
, Oct 19 2017