New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 776242 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Fuchsia
Pri: 1
Type: Bug-Regression

Blocking:
issue 738275



Sign in to add a comment

ipc_tests and mojo_system_unittests broken on Fuchsia

Project Member Reported by scottmg@chromium.org, Oct 19 2017

Issue description

Started at https://build.chromium.org/p/chromium.fyi/builders/Fuchsia/builds/10314

mojo_system_unittests:
PipeCount/MultiprocessMessagePipeTestWithPipeCount.PlatformHandlePassing/1
PipeCount/MultiprocessMessagePipeTestWithPipeCount.PlatformHandlePassing/0
PlatformWrapperTest.WrapPlatformHandle

ipc_tests:
IPCChannelMojoTest.SendPlatformFileAndMessagePipe
IPCChannelMojoTest.SendPlatformFile
IPCSendFdsTest.DescriptorTest

which makes me suspect https://chromium-review.googlesource.com/727121.


 

Comment 1 by w...@chromium.org, Oct 19 2017

Labels: -Type-Bug -Pri-3 M-64 Pri-1 Type-Bug-Regression
Owner: w...@chromium.org
Status: Assigned (was: Available)
Project Member

Comment 2 by bugdroid1@chromium.org, Oct 19 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e905d43e899d51df20ce94df28e9c34ee3b72de5

commit e905d43e899d51df20ce94df28e9c34ee3b72de5
Author: Wez <wez@chromium.org>
Date: Thu Oct 19 03:54:44 2017

Revert "[fuchsia][mojo/edk] Clone FD if transfer fails"

This reverts commit c2a865c7451560887659cce5b27c8d5f363e0051.

Reason for revert: This causes some IPC and Mojo tests to start failing (see  crbug.com/776242 ).

Original change's description:
> [fuchsia][mojo/edk] Clone FD if transfer fails
> 
> When trying to send a platform handle represented as a file descriptor
> cross-process on Fuchsia, we attempt to transfer the FD in-place which
> is more efficient than the usual clone + send + close pattern. In some
> cases the transfer operation fails, however, so we have to make a fresh
> clone to transfer.
> 
> Bug:  776163 
> Change-Id: I6d25e19ee7fef194261f5d1e624a4d8de291d6b3
> Reviewed-on: https://chromium-review.googlesource.com/727121
> Commit-Queue: Wez <wez@chromium.org>
> Reviewed-by: Wez <wez@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#509951}

TBR=wez@chromium.org,jamesr@chromium.org

Change-Id: Icd42bdf3e3d7438b486fd24d4aee5b7d25be32b9
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  776163 ,  776242 
Reviewed-on: https://chromium-review.googlesource.com/727027
Reviewed-by: Wez <wez@chromium.org>
Commit-Queue: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#509992}
[modify] https://crrev.com/e905d43e899d51df20ce94df28e9c34ee3b72de5/mojo/edk/system/channel_fuchsia.cc

Comment 3 by w...@chromium.org, Oct 19 2017

Status: Fixed (was: Assigned)
Project Member

Comment 4 by bugdroid1@chromium.org, Oct 19 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/160e435e49268b4b62441d01a5266951eeb5c9d2

commit 160e435e49268b4b62441d01a5266951eeb5c9d2
Author: Wez <wez@chromium.org>
Date: Thu Oct 19 16:53:11 2017

[fuchsia][mojo/edk] Clone FD if transfer fails

When trying to send a platform handle represented as a file descriptor
cross-process on Fuchsia, we attempt to transfer the FD in-place which
is more efficient than the usual clone + send + close pattern. In some
cases the transfer operation fails, however, so we have to make a fresh
clone to transfer.

This is a re-land of jamesr@'s original fix (
https://chromium-review.googlesource.com/c/chromium/src/+/727027) with
a correction to the checking of the transfer() & clone() results.

Bug:  776163 ,  776242 
Change-Id: Ie06a8e2e9d914b74fbc0002b32ab4fbfaa936f48
Reviewed-on: https://chromium-review.googlesource.com/727257
Reviewed-by: Scott Graham <scottmg@chromium.org>
Commit-Queue: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510110}
[modify] https://crrev.com/160e435e49268b4b62441d01a5266951eeb5c9d2/mojo/edk/system/channel_fuchsia.cc

Sign in to add a comment