New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 776205 link

Starred by 3 users
Status: Fixed
Owner:
est...@chromium.org
Closed: Mar 2018
Cc:
ajha@chromium.org
tetsui@chromium.org
█ brajkumar@chromium.org
█ megumihattori@google.com
█ yoshiki@chromium.org
steve...@chromium.org
sgabr...@chromium.org
peter@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome
Pri: 3
Type: Bug

Blocking:
issue 755413
issue 820923


Participants' hotlists:
NotificationTOK


Sign in to add a comment

lots of NotificationDelegates listen for Click but don't mark themselves as clickable

Project Member Reported by est...@chromium.org, Oct 19 2017 
lots of notifications aren't marked clickable and their delegates don't override HasClickedListener (the latter is deprecated). This means that while they may be clicked, there's no special UI (hand pointer) to indicate they can be clicked. We may decide to remove that special UI anyway, but if we keep it we should be more consistent.

Comment 1 by yoshiki@chromium.org, Mar 15 2018

Blocking: 820923
Cc: yoshiki@chromium.org tetsui@chromium.org sgabr...@chromium.org
Sebastien, do you have any idea or suggestion from UI/UX perspective?

The initial design of notification was that "notifications-with-click-handler show a hands pointer, the others show an arrow pointer". But now, through many changes and several years, that design was almost forgotten and notifications have been inconsistent: many clickable notifications are showing an arrow pointer (for example, ARC notifications always show an arrow pointer regardless of clickable-ness).

Comment 2 by sgabr...@chromium.org, Mar 15 2018 

Just chatted with Jenn.
We should always display the arrow pointer, regardless of notification type and state.

Comment 3 by est...@chromium.org, Mar 15 2018 

thanks both of you.
Project Member

Comment 4 by bugdroid1@chromium.org, Mar 20 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b9a9d6459cdc0d1dfb56704d82475050d55cf88c

commit b9a9d6459cdc0d1dfb56704d82475050d55cf88c
Author: Evan Stade <estade@chromium.org>
Date: Tue Mar 20 00:30:40 2018

Remove hand cursor from Message Center notifications.

Bug:  776205 
Change-Id: Ibdc3d5c8e7ada356afc68b2a111874bfc6af9684
Reviewed-on: https://chromium-review.googlesource.com/965605
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Oliver Chang <ochang@chromium.org>
Reviewed-by: Yoshiki Iguchi <yoshiki@chromium.org>
Commit-Queue: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#544230}
[modify] https://crrev.com/b9a9d6459cdc0d1dfb56704d82475050d55cf88c/ash/accelerators/accelerator_controller.cc
[modify] https://crrev.com/b9a9d6459cdc0d1dfb56704d82475050d55cf88c/ash/display/resolution_notification_controller.cc
[modify] https://crrev.com/b9a9d6459cdc0d1dfb56704d82475050d55cf88c/ash/system/locale/locale_notification_controller.cc
[modify] https://crrev.com/b9a9d6459cdc0d1dfb56704d82475050d55cf88c/ash/system/screen_layout_observer.cc
[modify] https://crrev.com/b9a9d6459cdc0d1dfb56704d82475050d55cf88c/chrome/browser/background/background_contents_service.cc
[modify] https://crrev.com/b9a9d6459cdc0d1dfb56704d82475050d55cf88c/chrome/browser/chromeos/printing/cups_print_job_notification.cc
[modify] https://crrev.com/b9a9d6459cdc0d1dfb56704d82475050d55cf88c/chrome/browser/download/notification/download_item_notification.cc
[modify] https://crrev.com/b9a9d6459cdc0d1dfb56704d82475050d55cf88c/chrome/browser/extensions/api/notifications/notifications_api.cc
[modify] https://crrev.com/b9a9d6459cdc0d1dfb56704d82475050d55cf88c/chrome/browser/notifications/platform_notification_service_impl.cc
[modify] https://crrev.com/b9a9d6459cdc0d1dfb56704d82475050d55cf88c/chrome/browser/signin/signin_error_notifier_ash.cc
[modify] https://crrev.com/b9a9d6459cdc0d1dfb56704d82475050d55cf88c/chrome/browser/sync/sync_error_notifier_ash.cc
[modify] https://crrev.com/b9a9d6459cdc0d1dfb56704d82475050d55cf88c/chrome/browser/ui/ash/chrome_screenshot_grabber.cc
[modify] https://crrev.com/b9a9d6459cdc0d1dfb56704d82475050d55cf88c/chrome/browser/ui/ash/network/data_promo_notification.cc
[modify] https://crrev.com/b9a9d6459cdc0d1dfb56704d82475050d55cf88c/chrome/common/extensions/api/notifications.idl
[modify] https://crrev.com/b9a9d6459cdc0d1dfb56704d82475050d55cf88c/chrome/common/extensions/docs/examples/extensions/calendar/javascript/background.js
[modify] https://crrev.com/b9a9d6459cdc0d1dfb56704d82475050d55cf88c/chrome/test/data/extensions/api_test/notifications/api/basic_usage/background.js
[modify] https://crrev.com/b9a9d6459cdc0d1dfb56704d82475050d55cf88c/ui/message_center/public/cpp/notification.cc
[modify] https://crrev.com/b9a9d6459cdc0d1dfb56704d82475050d55cf88c/ui/message_center/public/cpp/notification.h
[modify] https://crrev.com/b9a9d6459cdc0d1dfb56704d82475050d55cf88c/ui/message_center/public/mojo/notification.mojom
[modify] https://crrev.com/b9a9d6459cdc0d1dfb56704d82475050d55cf88c/ui/message_center/public/mojo/notification_struct_traits.cc
[modify] https://crrev.com/b9a9d6459cdc0d1dfb56704d82475050d55cf88c/ui/message_center/public/mojo/notification_struct_traits.h
[modify] https://crrev.com/b9a9d6459cdc0d1dfb56704d82475050d55cf88c/ui/message_center/public/mojo/struct_traits_unittest.cc
[modify] https://crrev.com/b9a9d6459cdc0d1dfb56704d82475050d55cf88c/ui/message_center/views/notification_view.cc
[modify] https://crrev.com/b9a9d6459cdc0d1dfb56704d82475050d55cf88c/ui/message_center/views/notification_view.h
[modify] https://crrev.com/b9a9d6459cdc0d1dfb56704d82475050d55cf88c/ui/message_center/views/notification_view_md.cc
[modify] https://crrev.com/b9a9d6459cdc0d1dfb56704d82475050d55cf88c/ui/message_center/views/notification_view_md.h

Comment 5 by est...@chromium.org, Mar 20 2018

Status: Fixed (was: Assigned)

Comment 6 by yoshiki@chromium.org, Mar 22 2018

Cc: ajha@chromium.org steve...@chromium.org megumihattori@google.com brajkumar@chromium.org
 Issue 820923  has been merged into this issue.
Project Member

Comment 7 by bugdroid1@chromium.org, Apr 4 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e0921095b83f1e63d0b2cdde9d7f76a71c6d046a

commit e0921095b83f1e63d0b2cdde9d7f76a71c6d046a
Author: Evan Stade <estade@chromium.org>
Date: Wed Apr 04 21:13:09 2018

Message center/notifications clean ups

- Some interfaces had separate functions for click and button click, while
  some used parameters to distinguish. Consolidate on shared functions.
- Update some notifications to use HandleClickNotificationDelegate or
  ThunkNotificationDelegate.

BUG= 776205 , 755413 

Change-Id: Ib133bdf93277c84c99311256c47a250d2b8e571f
Reviewed-on: https://chromium-review.googlesource.com/963619
Commit-Queue: Evan Stade <estade@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Yoshiki Iguchi <yoshiki@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548198}
[modify] https://crrev.com/e0921095b83f1e63d0b2cdde9d7f76a71c6d046a/ash/accelerators/accelerator_controller.cc
[modify] https://crrev.com/e0921095b83f1e63d0b2cdde9d7f76a71c6d046a/ash/display/display_util.cc
[modify] https://crrev.com/e0921095b83f1e63d0b2cdde9d7f76a71c6d046a/ash/display/resolution_notification_controller.cc
[modify] https://crrev.com/e0921095b83f1e63d0b2cdde9d7f76a71c6d046a/ash/display/resolution_notification_controller.h
[modify] https://crrev.com/e0921095b83f1e63d0b2cdde9d7f76a71c6d046a/ash/message_center/message_center_controller.cc
[modify] https://crrev.com/e0921095b83f1e63d0b2cdde9d7f76a71c6d046a/ash/system/bluetooth/bluetooth_notification_controller.cc
[modify] https://crrev.com/e0921095b83f1e63d0b2cdde9d7f76a71c6d046a/ash/system/locale/locale_notification_controller.cc
[modify] https://crrev.com/e0921095b83f1e63d0b2cdde9d7f76a71c6d046a/ash/system/power/dual_role_notification.cc
[modify] https://crrev.com/e0921095b83f1e63d0b2cdde9d7f76a71c6d046a/ash/system/screen_layout_observer_unittest.cc
[modify] https://crrev.com/e0921095b83f1e63d0b2cdde9d7f76a71c6d046a/ash/system/screen_security/screen_security_notification_controller.cc
[modify] https://crrev.com/e0921095b83f1e63d0b2cdde9d7f76a71c6d046a/chrome/browser/background/background_contents_service.cc
[modify] https://crrev.com/e0921095b83f1e63d0b2cdde9d7f76a71c6d046a/chrome/browser/chromeos/arc/arc_migration_guide_notification.cc
[modify] https://crrev.com/e0921095b83f1e63d0b2cdde9d7f76a71c6d046a/chrome/browser/chromeos/authpolicy/auth_policy_credentials_manager.cc
[modify] https://crrev.com/e0921095b83f1e63d0b2cdde9d7f76a71c6d046a/chrome/browser/chromeos/eol_notification.cc
[modify] https://crrev.com/e0921095b83f1e63d0b2cdde9d7f76a71c6d046a/chrome/browser/chromeos/extensions/file_system_provider/file_system_provider_apitest.cc
[modify] https://crrev.com/e0921095b83f1e63d0b2cdde9d7f76a71c6d046a/chrome/browser/chromeos/file_system_provider/notification_manager.cc
[modify] https://crrev.com/e0921095b83f1e63d0b2cdde9d7f76a71c6d046a/chrome/browser/chromeos/file_system_provider/notification_manager.h
[modify] https://crrev.com/e0921095b83f1e63d0b2cdde9d7f76a71c6d046a/chrome/browser/chromeos/first_run/drive_first_run_controller.cc
[modify] https://crrev.com/e0921095b83f1e63d0b2cdde9d7f76a71c6d046a/chrome/browser/chromeos/hats/hats_notification_controller.cc
[modify] https://crrev.com/e0921095b83f1e63d0b2cdde9d7f76a71c6d046a/chrome/browser/chromeos/hats/hats_notification_controller.h
[modify] https://crrev.com/e0921095b83f1e63d0b2cdde9d7f76a71c6d046a/chrome/browser/chromeos/login/easy_unlock/easy_unlock_notification_controller.cc
[modify] https://crrev.com/e0921095b83f1e63d0b2cdde9d7f76a71c6d046a/chrome/browser/chromeos/login/easy_unlock/easy_unlock_notification_controller.h
[modify] https://crrev.com/e0921095b83f1e63d0b2cdde9d7f76a71c6d046a/chrome/browser/chromeos/login/easy_unlock/easy_unlock_notification_controller_chromeos_unittest.cc
[modify] https://crrev.com/e0921095b83f1e63d0b2cdde9d7f76a71c6d046a/chrome/browser/chromeos/login/quick_unlock/quick_unlock_notification_controller.cc
[modify] https://crrev.com/e0921095b83f1e63d0b2cdde9d7f76a71c6d046a/chrome/browser/chromeos/login/quick_unlock/quick_unlock_notification_controller.h
[modify] https://crrev.com/e0921095b83f1e63d0b2cdde9d7f76a71c6d046a/chrome/browser/chromeos/net/network_portal_detector_impl_browsertest.cc
[modify] https://crrev.com/e0921095b83f1e63d0b2cdde9d7f76a71c6d046a/chrome/browser/chromeos/net/network_portal_notification_controller.cc
[modify] https://crrev.com/e0921095b83f1e63d0b2cdde9d7f76a71c6d046a/chrome/browser/chromeos/printing/cups_print_job_notification.cc
[modify] https://crrev.com/e0921095b83f1e63d0b2cdde9d7f76a71c6d046a/chrome/browser/chromeos/printing/cups_print_job_notification.h
[modify] https://crrev.com/e0921095b83f1e63d0b2cdde9d7f76a71c6d046a/chrome/browser/download/notification/download_item_notification.cc
[modify] https://crrev.com/e0921095b83f1e63d0b2cdde9d7f76a71c6d046a/chrome/browser/download/notification/download_item_notification.h
[modify] https://crrev.com/e0921095b83f1e63d0b2cdde9d7f76a71c6d046a/chrome/browser/download/notification/download_item_notification_unittest.cc
[modify] https://crrev.com/e0921095b83f1e63d0b2cdde9d7f76a71c6d046a/chrome/browser/extensions/api/networking_config_chromeos_apitest_chromeos.cc
[modify] https://crrev.com/e0921095b83f1e63d0b2cdde9d7f76a71c6d046a/chrome/browser/extensions/extension_storage_monitor_browsertest.cc
[modify] https://crrev.com/e0921095b83f1e63d0b2cdde9d7f76a71c6d046a/chrome/browser/notifications/message_center_notifications_browsertest.cc
[modify] https://crrev.com/e0921095b83f1e63d0b2cdde9d7f76a71c6d046a/chrome/browser/notifications/notification_interactive_uitest_support.cc
[modify] https://crrev.com/e0921095b83f1e63d0b2cdde9d7f76a71c6d046a/chrome/browser/notifications/notification_platform_bridge_chromeos.cc
[modify] https://crrev.com/e0921095b83f1e63d0b2cdde9d7f76a71c6d046a/chrome/browser/notifications/notification_platform_bridge_message_center.cc
[modify] https://crrev.com/e0921095b83f1e63d0b2cdde9d7f76a71c6d046a/chrome/browser/notifications/stub_notification_display_service.cc
[modify] https://crrev.com/e0921095b83f1e63d0b2cdde9d7f76a71c6d046a/chrome/browser/printing/cloud_print/privet_notifications.cc
[modify] https://crrev.com/e0921095b83f1e63d0b2cdde9d7f76a71c6d046a/chrome/browser/printing/cloud_print/privet_notifications.h
[modify] https://crrev.com/e0921095b83f1e63d0b2cdde9d7f76a71c6d046a/chrome/browser/sync/sync_error_notifier_ash.cc
[modify] https://crrev.com/e0921095b83f1e63d0b2cdde9d7f76a71c6d046a/chrome/browser/ui/ash/chrome_screenshot_grabber.cc
[modify] https://crrev.com/e0921095b83f1e63d0b2cdde9d7f76a71c6d046a/chrome/browser/ui/ash/network/tether_notification_presenter_unittest.cc
[modify] https://crrev.com/e0921095b83f1e63d0b2cdde9d7f76a71c6d046a/chrome/browser/ui/cocoa/apps/quit_with_apps_controller_mac.cc
[modify] https://crrev.com/e0921095b83f1e63d0b2cdde9d7f76a71c6d046a/chrome/browser/ui/cocoa/apps/quit_with_apps_controller_mac.h
[modify] https://crrev.com/e0921095b83f1e63d0b2cdde9d7f76a71c6d046a/chrome/browser/ui/extensions/extension_installed_notification.cc
[modify] https://crrev.com/e0921095b83f1e63d0b2cdde9d7f76a71c6d046a/chrome/browser/ui/extensions/extension_installed_notification.h
[modify] https://crrev.com/e0921095b83f1e63d0b2cdde9d7f76a71c6d046a/chrome/browser/usb/web_usb_detector.cc
[modify] https://crrev.com/e0921095b83f1e63d0b2cdde9d7f76a71c6d046a/chrome/browser/usb/web_usb_detector_unittest.cc
[modify] https://crrev.com/e0921095b83f1e63d0b2cdde9d7f76a71c6d046a/ui/arc/notification/arc_notification_delegate.cc
[modify] https://crrev.com/e0921095b83f1e63d0b2cdde9d7f76a71c6d046a/ui/arc/notification/arc_notification_delegate.h
[modify] https://crrev.com/e0921095b83f1e63d0b2cdde9d7f76a71c6d046a/ui/message_center/message_center_impl.cc
[modify] https://crrev.com/e0921095b83f1e63d0b2cdde9d7f76a71c6d046a/ui/message_center/message_center_observer.h
[modify] https://crrev.com/e0921095b83f1e63d0b2cdde9d7f76a71c6d046a/ui/message_center/message_center_stats_collector.cc
[modify] https://crrev.com/e0921095b83f1e63d0b2cdde9d7f76a71c6d046a/ui/message_center/message_center_stats_collector.h
[modify] https://crrev.com/e0921095b83f1e63d0b2cdde9d7f76a71c6d046a/ui/message_center/public/cpp/notification.h
[modify] https://crrev.com/e0921095b83f1e63d0b2cdde9d7f76a71c6d046a/ui/message_center/public/cpp/notification_delegate.cc
[modify] https://crrev.com/e0921095b83f1e63d0b2cdde9d7f76a71c6d046a/ui/message_center/public/cpp/notification_delegate.h
[modify] https://crrev.com/e0921095b83f1e63d0b2cdde9d7f76a71c6d046a/ui/message_center/public/cpp/notification_delegate_unittest.cc
[modify] https://crrev.com/e0921095b83f1e63d0b2cdde9d7f76a71c6d046a/ui/message_center/ui_controller.cc
[modify] https://crrev.com/e0921095b83f1e63d0b2cdde9d7f76a71c6d046a/ui/message_center/ui_controller.h
[modify] https://crrev.com/e0921095b83f1e63d0b2cdde9d7f76a71c6d046a/ui/message_center/views/notification_view_md_unittest.cc
►

Sign in to add a comment