Browser Interception request URL contains # |
|||||||
Issue descriptionBrowser interception events contain the # of a request and pattern match based on requests with #.
,
Oct 26 2017
We presented Puppeteer (https://github.com/GoogleChrome/puppeteer/) on Chrome DevSummit and now working on its final release. This fix is crucially important for Puppeteer 1.0 launch. It got landed after the branch point; however, it seems to be safe enough to be merged back to 63.
,
Oct 26 2017
The bug is marked as P3 or Feature. It should not be merged as M63 is in beta. Please contact the approriate milestone owner if you have questions. Owners: cmasso@(Android), cmasso@(iOS), gkihumba@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Oct 27 2017
Approving merge to M63 branch 3239 based on comment #2 and per update in - https://bugs.chromium.org/p/chromium/issues/detail?id=767683#c10.
,
Oct 27 2017
,
Oct 27 2017
Pls also apply appropriate OSs label. Thank you.
,
Oct 27 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c661f01af43a9ee9d4bdeefd8a41ce1764cbb418 commit c661f01af43a9ee9d4bdeefd8a41ce1764cbb418 Author: Nathan Bruer <allada@chromium.org> Date: Fri Oct 27 21:28:59 2017 [Devtools] Removes 'ref' (#) from url before browser protocol event Removes the ref from a url of a browser Network.Request object. R=​dgozman,pfeldman BUG= 776194 Change-Id: I1238f61adcea093c949746b7cafaefb6e58ab531 Reviewed-on: https://chromium-review.googlesource.com/726822 Commit-Queue: Blaise Bruer <allada@chromium.org> Reviewed-by: Pavel Feldman <pfeldman@chromium.org> Reviewed-by: Dmitry Gozman <dgozman@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#510386}(cherry picked from commit 5818fa1c113533a8eabaaa7311b2ffec3c446d2e) Reviewed-on: https://chromium-review.googlesource.com/742363 Reviewed-by: Andrey Lushnikov <lushnikov@chromium.org> Cr-Commit-Position: refs/branch-heads/3239@{#277} Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578} [modify] https://crrev.com/c661f01af43a9ee9d4bdeefd8a41ce1764cbb418/content/browser/devtools/devtools_url_request_interceptor.cc [modify] https://crrev.com/c661f01af43a9ee9d4bdeefd8a41ce1764cbb418/content/browser/devtools/protocol/network_handler.cc [modify] https://crrev.com/c661f01af43a9ee9d4bdeefd8a41ce1764cbb418/content/browser/devtools/protocol/network_handler.h [add] https://crrev.com/c661f01af43a9ee9d4bdeefd8a41ce1764cbb418/third_party/WebKit/LayoutTests/http/tests/inspector-protocol/network/basic-request-interception-ignores-hash-expected.txt [add] https://crrev.com/c661f01af43a9ee9d4bdeefd8a41ce1764cbb418/third_party/WebKit/LayoutTests/http/tests/inspector-protocol/network/basic-request-interception-ignores-hash.js
,
Oct 27 2017
Thanks, this is merged now. |
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by bugdroid1@chromium.org
, Oct 20 2017