New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 776190 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Oct 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 1
Type: Bug



Sign in to add a comment

[MD settings] add loading message when updating cookies/local data list

Project Member Reported by dschuyler@chromium.org, Oct 18 2017

Issue description

in chrome://settings/siteData it can take a bit of time to get the list of cookies and local data. Let's present a message about loading while this is happening.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 19 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/34eeae65c51a2e8c545daef878a74e1efc6c81ef

commit 34eeae65c51a2e8c545daef878a74e1efc6c81ef
Author: Dave Schuyler <dschuyler@chromium.org>
Date: Thu Oct 19 01:18:07 2017

[MD settings] cleanup display local data

This CL removes the start/count parameters from getDisplayList for local data (which is not used)
and adds a loading message during the data transfer (from C++ to JS).

Bug:  730777 ,  776190 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I75d1728a84cc262b040e4ed3959a46914b48a040
Reviewed-on: https://chromium-review.googlesource.com/683467
Commit-Queue: Dave Schuyler <dschuyler@chromium.org>
Reviewed-by: Hector Carmona <hcarmona@chromium.org>
Cr-Commit-Position: refs/heads/master@{#509957}
[modify] https://crrev.com/34eeae65c51a2e8c545daef878a74e1efc6c81ef/chrome/app/settings_strings.grdp
[modify] https://crrev.com/34eeae65c51a2e8c545daef878a74e1efc6c81ef/chrome/browser/resources/settings/site_settings/local_data_browser_proxy.js
[modify] https://crrev.com/34eeae65c51a2e8c545daef878a74e1efc6c81ef/chrome/browser/resources/settings/site_settings/site_data.html
[modify] https://crrev.com/34eeae65c51a2e8c545daef878a74e1efc6c81ef/chrome/browser/resources/settings/site_settings/site_data.js
[modify] https://crrev.com/34eeae65c51a2e8c545daef878a74e1efc6c81ef/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc
[modify] https://crrev.com/34eeae65c51a2e8c545daef878a74e1efc6c81ef/chrome/browser/ui/webui/settings/settings_cookies_view_handler.cc
[modify] https://crrev.com/34eeae65c51a2e8c545daef878a74e1efc6c81ef/chrome/browser/ui/webui/settings/settings_cookies_view_handler.h
[modify] https://crrev.com/34eeae65c51a2e8c545daef878a74e1efc6c81ef/chrome/test/data/webui/settings/test_local_data_browser_proxy.js

Labels: Merge-Request-63
About Merge request:

If we have the bandwidth, it will be nice to let the user we're loading data (that make take a few seconds). If the m-63 branch is swamped with merge requests, we can wait on this change; but if we have bandwidth, this will make a nicer experience for some (less than 1% of) users.
Project Member

Comment 3 by sheriffbot@chromium.org, Oct 20 2017

Labels: -Merge-Request-63 Merge-Review-63 Hotlist-Merge-Review
This bug requires manual review: There is .grd file changes and we are only 45 days from stable.
Please contact the milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), gkihumba@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 4 by gov...@chromium.org, Oct 20 2017

Labels: -Merge-Review-63 Merge-Rejected-63
Feature freeze/string freeze for M63 was on 09/29. Change listed at #1 indicates .grd file change, so it is too late to take this merge in. Rejecting merge to M63. Please let me know ASAP if there is any concern here.  
Status: Fixed (was: Started)

Sign in to add a comment