New issue
Advanced search Search tips

Issue 776185 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Feature



Sign in to add a comment

Revert cros_config_host and replace with Python versoin

Project Member Reported by sjg@chromium.org, Oct 18 2017

Issue description

We should remove all C++ code in cros_config_host.

Instead, cros_config_host_py should be renamed to cros_config_host, and things should use that.
 
I'll do this alongside  crbug.com/774492 . Seems like a good time to do renaming stuff.
Project Member

Comment 2 by bugdroid1@chromium.org, Oct 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/1aa8d93d5442e64c19bf84563e6ee257f24547c9

commit 1aa8d93d5442e64c19bf84563e6ee257f24547c9
Author: Alec Thilenius <athilenius@chromium.org>
Date: Sat Oct 21 16:53:43 2017

chromeos-config-tools: Don't install cros_config_host tools

The C++ version of cros_config_host is being removed.

BUG= chromium:776185 
TEST=FEATURES=test sudo -E emerge  chromeos-config-tools

Change-Id: I923cf078106e65a5196491ec978b31872cbdce33
Reviewed-on: https://chromium-review.googlesource.com/731039
Commit-Ready: Simon Glass <sjg@chromium.org>
Tested-by: Simon Glass <sjg@chromium.org>
Reviewed-by: Simon Glass <sjg@chromium.org>

[modify] https://crrev.com/1aa8d93d5442e64c19bf84563e6ee257f24547c9/chromeos-base/chromeos-config-tools/chromeos-config-tools-9999.ebuild

Project Member

Comment 3 by bugdroid1@chromium.org, Oct 22 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/f3b6ea89cb33a1480ad131ebc0fc31d0c3f8f7ae

commit f3b6ea89cb33a1480ad131ebc0fc31d0c3f8f7ae
Author: Alec Thilenius <athilenius@chromium.org>
Date: Sun Oct 22 00:25:49 2017

chromeos-config: Remove cros_config_host (C++) code and unittests

Remove all C++ cros_config_host code (switching to cros_config_host_py
which will be renamed cros_config_host). This is the first commit of
many needed for this change.

BUG= chromium:776185 
TEST=FEATURES=test sudo -E emerge  chromeos-config-tools
CQ-DEPEND=CL:731039

Change-Id: I790c6f8420be029ab8d6588353fcddc946a0886f
Reviewed-on: https://chromium-review.googlesource.com/731037
Commit-Ready: Simon Glass <sjg@chromium.org>
Tested-by: Alec Thilenius <athilenius@chromium.org>
Reviewed-by: Simon Glass <sjg@chromium.org>

[modify] https://crrev.com/f3b6ea89cb33a1480ad131ebc0fc31d0c3f8f7ae/chromeos-config/libcros_config/cros_config.cc
[modify] https://crrev.com/f3b6ea89cb33a1480ad131ebc0fc31d0c3f8f7ae/chromeos-config/libcros_config/fake_cros_config.cc
[modify] https://crrev.com/f3b6ea89cb33a1480ad131ebc0fc31d0c3f8f7ae/chromeos-config/libcros_config/fake_cros_config.h
[modify] https://crrev.com/f3b6ea89cb33a1480ad131ebc0fc31d0c3f8f7ae/chromeos-config/libcros_config/cros_config_interface.h
[modify] https://crrev.com/f3b6ea89cb33a1480ad131ebc0fc31d0c3f8f7ae/chromeos-config/libcros_config/cros_config_unittest.cc
[delete] https://crrev.com/a561c4b3c8c0255cd9edc68253dca4a797616b5d/chromeos-config/cros_config_host_main_unittest.cc
[modify] https://crrev.com/f3b6ea89cb33a1480ad131ebc0fc31d0c3f8f7ae/chromeos-config/chromeos-config.gyp
[modify] https://crrev.com/f3b6ea89cb33a1480ad131ebc0fc31d0c3f8f7ae/chromeos-config/libcros_config/cros_config.h
[delete] https://crrev.com/a561c4b3c8c0255cd9edc68253dca4a797616b5d/chromeos-config/cros_config_host_main.cc

Status: Fixed (was: Untriaged)

Sign in to add a comment