New issue
Advanced search Search tips

Issue 776179 link

Starred by 1 user
Status: Fixed
Owner:
mek@chromium.org
Closed: Oct 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug
Proj-Servicification

Blocking:
issue 611935
issue 776166



Sign in to add a comment

[mojo-blobs] Mark GetBlobFromUUID as sync, and instrument its usage

Project Member Reported by mek@chromium.org, Oct 18 2017 
This way all the existing hacks to ensure blob lifetime should remain functional, allowing us to turn on mojo blobs without exhaustively getting rid of old/bad code paths. The entire method is only supposed to be a transitional stop-gap method anyway, and as long as most of the common places have been migrated to properly transfer blob handles the performance hit shouldn't be too much (but should probably log to make sure of that).
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 23 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8835be5768ec75308c43eecc59526a96f89c5e07

commit 8835be5768ec75308c43eecc59526a96f89c5e07
Author: Marijn Kruisselbrink <mek@chromium.org>
Date: Mon Oct 23 20:07:34 2017

Mark BlobRegistry.GetBlobFromUUID as sync.

This way old tricks used to keep blobs alive during IPC should keep
working even after switching on mojo blobs. Ultimately this whole method
will be removed, but this way we don't have to block shipping mojo blobs
on fixing all usage of this method.

Bug:  776179 
Change-Id: I277c99e10f3322f999e218240d0de744fae6bb48
Reviewed-on: https://chromium-review.googlesource.com/727191
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Mark Pearson <mpearson@chromium.org>
Reviewed-by: Daniel Murphy <dmurph@chromium.org>
Commit-Queue: Marijn Kruisselbrink <mek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510888}
[modify] https://crrev.com/8835be5768ec75308c43eecc59526a96f89c5e07/storage/browser/blob/blob_registry_impl.cc
[modify] https://crrev.com/8835be5768ec75308c43eecc59526a96f89c5e07/storage/browser/blob/blob_registry_impl.h
[modify] https://crrev.com/8835be5768ec75308c43eecc59526a96f89c5e07/third_party/WebKit/Source/platform/blob/BlobData.cpp
[modify] https://crrev.com/8835be5768ec75308c43eecc59526a96f89c5e07/third_party/WebKit/Source/platform/blob/BlobDataTest.cpp
[modify] https://crrev.com/8835be5768ec75308c43eecc59526a96f89c5e07/third_party/WebKit/common/blob/blob_registry.mojom
[modify] https://crrev.com/8835be5768ec75308c43eecc59526a96f89c5e07/tools/metrics/histograms/histograms.xml

Comment 2 by mek@chromium.org, Oct 23 2017

Status: Fixed (was: Started)

Comment 3 by laforge@google.com, Nov 7 2017

Components: Internals>Network>Service

Comment 4 by laforge@google.com, Nov 7 2017

Components: -Internals>Network>Service Internals>Services>Network
Apologies, applied the wrong component in bulk.

Comment 5 by laforge@google.com, Nov 8 2017

Components: Internals>Services>Storage
Setting Internals>Services>Storage to all children of issue 611935
►

Sign in to add a comment