New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 776167 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
OOO until 4th Feb
Closed: Oct 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 1
Type: Bug



Sign in to add a comment

Add a deprecation warning for Pepper Mic/Camera usage when disabled by FP

Project Member Reported by raymes@chromium.org, Oct 18 2017

Issue description

We would like to deprecate mic/camera usage from pepper when it's disabled by feature policy, in the same was as mic/camera usage via getUserMedia (see  issue 689802 )
 
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 19 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b82e8b119b85a6c9e364a24624735b2c5c6e39da

commit b82e8b119b85a6c9e364a24624735b2c5c6e39da
Author: Raymes Khoury <raymes@chromium.org>
Date: Thu Oct 19 00:01:23 2017

Add a deprecation warning for Pepper Mic/Camera usage when disabled by FP

If microphone/camera usage are disabled by feature policy, this will
also impact usage by Pepper. Currently we only log a deprecation warning
for getUserMedia usage, but also log one for Flash explicitly.

Bug:  689802 ,  776167 
Change-Id: If8144099909cfbdb40582d360f4f1eb3265db918
Reviewed-on: https://chromium-review.googlesource.com/720583
Commit-Queue: Raymes Khoury <raymes@chromium.org>
Reviewed-by: Timothy Loh <timloh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#509933}
[modify] https://crrev.com/b82e8b119b85a6c9e364a24624735b2c5c6e39da/chrome/browser/media/webrtc/media_stream_devices_controller.cc

Comment 2 by raymes@chromium.org, Oct 19 2017

Labels: Merge-Request-63 M-63
Project Member

Comment 3 by sheriffbot@chromium.org, Oct 20 2017

Labels: -Merge-Request-63 Hotlist-Merge-Approved Merge-Approved-63
Your change meets the bar and is auto-approved for M63. Please go ahead and merge the CL to branch 3239 manually. Please contact milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), gkihumba@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 4 by bugdroid1@chromium.org, Oct 20 2017

Labels: -merge-approved-63 merge-merged-3239
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/816f296181b8d82d69e5ba26fa669a83146d711d

commit 816f296181b8d82d69e5ba26fa669a83146d711d
Author: Raymes Khoury <raymes@chromium.org>
Date: Fri Oct 20 02:50:15 2017

Add a deprecation warning for Pepper Mic/Camera usage when disabled by FP

If microphone/camera usage are disabled by feature policy, this will
also impact usage by Pepper. Currently we only log a deprecation warning
for getUserMedia usage, but also log one for Flash explicitly.

TBR=raymes@chromium.org

(cherry picked from commit b82e8b119b85a6c9e364a24624735b2c5c6e39da)

Bug:  689802 ,  776167 
Change-Id: If8144099909cfbdb40582d360f4f1eb3265db918
Reviewed-on: https://chromium-review.googlesource.com/720583
Commit-Queue: Raymes Khoury <raymes@chromium.org>
Reviewed-by: Timothy Loh <timloh@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#509933}
Reviewed-on: https://chromium-review.googlesource.com/729609
Reviewed-by: Raymes Khoury <raymes@chromium.org>
Cr-Commit-Position: refs/branch-heads/3239@{#103}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}
[modify] https://crrev.com/816f296181b8d82d69e5ba26fa669a83146d711d/chrome/browser/media/webrtc/media_stream_devices_controller.cc

Comment 5 by raymes@chromium.org, Oct 22 2017

Status: Fixed (was: Assigned)

Sign in to add a comment