New issue
Advanced search Search tips

Issue 776166 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Dec 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Feature
Proj-Servicification

Blocked on:
issue 740592
issue 776179
issue 776909
issue 779495
issue 779798
issue 780126
issue 784052

Blocking:
issue 611935



Sign in to add a comment

[mojo-blobs] Tracking bug for work that needs to be done before enabling mojo blobs

Project Member Reported by mek@chromium.org, Oct 18 2017

Issue description

611935 is the overall tracking bug for blob service related work, but a lot of the work doesn't need to be done before enabling the mojo blob codepath by default. This bug is meant to track just the work necessary to flip the switch.

 

Comment 1 by mek@chromium.org, Oct 18 2017

Summary: [mojo-blobs] Tracking bug for work that needs to be done before enabling mojo blobs (was: Tracking bug for work that needs to be done before enabling mojo blobs)

Comment 2 by mek@chromium.org, Oct 18 2017

Blockedon: 776179

Comment 3 by mek@chromium.org, Oct 18 2017

Blockedon: -740744

Comment 4 by mek@chromium.org, Oct 20 2017

Blockedon: 776909
Project Member

Comment 5 by bugdroid1@chromium.org, Oct 23 2017

Project Member

Comment 6 by bugdroid1@chromium.org, Oct 26 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/df51989616e170eef04e72779d0d7e5c3ee5980a

commit df51989616e170eef04e72779d0d7e5c3ee5980a
Author: Marijn Kruisselbrink <mek@chromium.org>
Date: Thu Oct 26 19:52:57 2017

Turn mojo blobs on by default.

This makes the mojo code path for creating blobs the default. Blob
URL creation/revocation is still done over IPC, as migrating that has
its own set of issues. At least this starts paving the way towards
getting rid of old codepaths.

Also forces mojo blobs off for blob_dispatcher_host_unittest (since it
only tests the old IPC blob interface anyway), and updates some cache
storage unit tests to work with mojo blobs enabled.

Bug: 611935,  776166 ,  351753 
Change-Id: Icff60abaadfca04a0db99269ad1abb9d7cc3ee77
Reviewed-on: https://chromium-review.googlesource.com/734304
Commit-Queue: Marijn Kruisselbrink <mek@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Daniel Murphy <dmurph@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#511929}
[modify] https://crrev.com/df51989616e170eef04e72779d0d7e5c3ee5980a/content/browser/blob_storage/blob_dispatcher_host_unittest.cc
[modify] https://crrev.com/df51989616e170eef04e72779d0d7e5c3ee5980a/content/browser/cache_storage/cache_storage_cache_unittest.cc
[modify] https://crrev.com/df51989616e170eef04e72779d0d7e5c3ee5980a/content/browser/cache_storage/cache_storage_manager_unittest.cc
[modify] https://crrev.com/df51989616e170eef04e72779d0d7e5c3ee5980a/content/public/common/content_features.cc
[modify] https://crrev.com/df51989616e170eef04e72779d0d7e5c3ee5980a/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/df51989616e170eef04e72779d0d7e5c3ee5980a/third_party/WebKit/LayoutTests/VirtualTestSuites

Comment 7 by mek@chromium.org, Oct 31 2017

Blockedon: 779798

Comment 8 by mek@chromium.org, Oct 31 2017

Blockedon: 779495

Comment 9 by mek@chromium.org, Oct 31 2017

Blockedon: 780126
Components: Internals>Network>Service
Components: -Internals>Network>Service Internals>Services>Network
Apologies, applied the wrong component in bulk.
Components: Internals>Services>Storage
Setting Internals>Services>Storage to all children of issue 611935

Comment 13 by mek@chromium.org, Nov 11 2017

Blockedon: 784052

Comment 14 by mek@chromium.org, Dec 4 2017

Status: Fixed (was: Assigned)

Sign in to add a comment