New issue
Advanced search Search tips

Issue 776157 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug


Participants' hotlists:
Fixing-touch


Sign in to add a comment

Switching between tablet <> clamshell mode quickly can leave the dual display mirrored.

Project Member Reported by osh...@chromium.org, Oct 18 2017

Issue description

Found the cause. Will send a fix shortly.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 20 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fc6246bf77d83c9f91026169a12eba987ed7a4c4

commit fc6246bf77d83c9f91026169a12eba987ed7a4c4
Author: Mitsuru Oshima <oshima@chromium.org>
Date: Fri Oct 20 22:45:32 2017

Do not update the layout mirror mode in forced mirror mode.

We shouldn't store even in memory if the mirror mode
was forced because it may be used when the display change event
is sent.

BUG= 776157 
TEST=covered by unit test. Tested manually on kevin/caroline.

Change-Id: I5063a88760ec4bc2cb25c28f248082a78f95e1fd
Reviewed-on: https://chromium-review.googlesource.com/727280
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510591}
[modify] https://crrev.com/fc6246bf77d83c9f91026169a12eba987ed7a4c4/ash/display/display_manager_unittest.cc
[modify] https://crrev.com/fc6246bf77d83c9f91026169a12eba987ed7a4c4/ui/display/manager/display_layout_store.cc

Comment 2 by osh...@chromium.org, Oct 20 2017

Labels: Merge-Request-63
Project Member

Comment 3 by sheriffbot@chromium.org, Oct 21 2017

Labels: -Merge-Request-63 Hotlist-Merge-Approved Merge-Approved-63
Your change meets the bar and is auto-approved for M63. Please go ahead and merge the CL to branch 3239 manually. Please contact milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), gkihumba@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 4 by osh...@chromium.org, Oct 23 2017

Status: Fixed (was: Started)
Project Member

Comment 5 by bugdroid1@chromium.org, Oct 23 2017

Labels: -merge-approved-63 merge-merged-3239
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9bb4b7132de770dce7aaea8b48a257e14a728b48

commit 9bb4b7132de770dce7aaea8b48a257e14a728b48
Author: Mitsuru Oshima <oshima@chromium.org>
Date: Mon Oct 23 20:17:26 2017

Do not update the layout mirror mode in forced mirror mode.

We shouldn't store even in memory if the mirror mode
was forced because it may be used when the display change event
is sent.

BUG= 776157 
TEST=covered by unit test. Tested manually on kevin/caroline.

Change-Id: I5063a88760ec4bc2cb25c28f248082a78f95e1fd
Reviewed-on: https://chromium-review.googlesource.com/727280
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#510591}(cherry picked from commit fc6246bf77d83c9f91026169a12eba987ed7a4c4)
Reviewed-on: https://chromium-review.googlesource.com/733948
Cr-Commit-Position: refs/branch-heads/3239@{#163}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}
[modify] https://crrev.com/9bb4b7132de770dce7aaea8b48a257e14a728b48/ash/display/display_manager_unittest.cc
[modify] https://crrev.com/9bb4b7132de770dce7aaea8b48a257e14a728b48/ui/display/manager/display_layout_store.cc

Sign in to add a comment