New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 776148 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

32bit Swarming bots install 64bit cipd packages

Project Member Reported by vadimsh@chromium.org, Oct 18 2017

Issue description

For example this build: https://ci.chromium.org/swarming/task/394855b63f194410?server=chromium-swarm.appspot.com

Corresponds to https://chromium-swarm.appspot.com/task?id=394855b63f194410&refresh=10&show_raw=1&wide_logs=true

Bot dimensions: "cpu: x86 x86-32 x86-32-E5-2670"

Yet if you look at "CIPD packages" section, all of them are linux-amd64, including the cipd client itself.

64-bit client then trips infra gclient runhooks to install 64-bit stuff everywhere. Eventually go toolset bootstrap also picks up 64-bit version of Go and builds 64-bit binaries. 

It should all be 32 bit. If bot reports it is 32 bit, it must act like it >_<
 
Owner: vadimsh@chromium.org
Status: Assigned (was: Untriaged)
Project Member

Comment 3 by bugdroid1@chromium.org, Oct 19 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/luci/luci-py.git/+/8cb44723092049097c791a39d62215c11cfa364f

commit 8cb44723092049097c791a39d62215c11cfa364f
Author: Vadim Shtayura <vadimsh@chromium.org>
Date: Thu Oct 19 02:26:58 2017

Fix ${platform} detection on x86_64 hosts with 32-bit userland.

Also remove ${os_ver} while at it. It is not used and doesn't exist as a concept
anymore.

R=iannucci@chromium.org
BUG= 776148 

Change-Id: If5e663963891d59e4318c06f8c17f25187fec961
Reviewed-on: https://chromium-review.googlesource.com/727402
Commit-Queue: Vadim Shtayura <vadimsh@chromium.org>
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>

[modify] https://crrev.com/8cb44723092049097c791a39d62215c11cfa364f/client/cipd.py

Project Member

Comment 4 by bugdroid1@chromium.org, Oct 19 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/luci/luci-py.git/+/5eed6e08e920f0b718de91ae189eb7814ba2b6e8

commit 5eed6e08e920f0b718de91ae189eb7814ba2b6e8
Author: Vadim Shtayura <vadimsh@chromium.org>
Date: Thu Oct 19 18:49:35 2017

Include rendered cipd client package name in instance ID cache key.

Some bots recently where "converted" from linux-amd64 and linux-386 (via bug
fix), but they still use cached linux-amd64 version of the client. This CL
should make them realize they are doing it wrong.

R=iannucci@chromium.org
BUG= 776148 

Change-Id: I422eaaba786b8aa126a2ef0a2b373cd502a2c683
Reviewed-on: https://chromium-review.googlesource.com/728355
Commit-Queue: Vadim Shtayura <vadimsh@chromium.org>
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>

[modify] https://crrev.com/5eed6e08e920f0b718de91ae189eb7814ba2b6e8/client/cipd.py
[modify] https://crrev.com/5eed6e08e920f0b718de91ae189eb7814ba2b6e8/client/tests/run_isolated_test.py

Status: Fixed (was: Assigned)
Project Member

Comment 6 by bugdroid1@chromium.org, Oct 19 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/luci/luci-py.git/+/757c6c0d25979bfcdce194eaa79ec907c868f7c7

commit 757c6c0d25979bfcdce194eaa79ec907c868f7c7
Author: Vadim Shtayura <vadimsh@chromium.org>
Date: Thu Oct 19 21:34:56 2017

Fix ${platform} detection on 32-bit Windows.

Windows uses x86 instead of i386 to indicate 32bit Intel architecture.

R=iannucci@chromium.org
BUG= 776148 

Change-Id: I002a4153501177e797ebc0d83fc6a4ca2dbe9c77
Reviewed-on: https://chromium-review.googlesource.com/728945
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>

[modify] https://crrev.com/757c6c0d25979bfcdce194eaa79ec907c868f7c7/client/cipd.py

Sign in to add a comment