New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 776145 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 3
Type: Bug
Team-Security-UX



Sign in to add a comment

Show audio icon in omnibox when site is muted

Project Member Reported by steimel@chromium.org, Oct 18 2017

Issue description

Need to add a ContentSettingImageModel for the sound content setting. This will be displayed in the omnibox when sound is played on a muted site.
 

Comment 1 by raymes@chromium.org, Oct 19 2017

Components: -UI>Browser>SiteSettings UI>Browser>Permissions>Indicators
Project Member

Comment 2 by bugdroid1@chromium.org, Oct 23 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0cafb39dcf12fdd92433482e856cf8132994e64b

commit 0cafb39dcf12fdd92433482e856cf8132994e64b
Author: Tommy Steimel <steimel@chromium.org>
Date: Mon Oct 23 22:19:08 2017

Show blocked audio icon in omnibox when sound is muted

This CL adds a ContentSettingImageModel for the sound content setting
that displays in the omnibox whenever sound is played on a muted site.
In order to get the necessary info into TabSpecificContentSettings, this
CL adds a new WebContentsObserver method that fires when the audible
state of the WebContents changes.

Bug:  776145 
Change-Id: Iddadb9993138d9728c6e5c72a3efd3e9e7865709
Reviewed-on: https://chromium-review.googlesource.com/727460
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Raymes Khoury <raymes@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Commit-Queue: Tommy Steimel <steimel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510940}
[modify] https://crrev.com/0cafb39dcf12fdd92433482e856cf8132994e64b/chrome/app/generated_resources.grd
[modify] https://crrev.com/0cafb39dcf12fdd92433482e856cf8132994e64b/chrome/browser/content_settings/tab_specific_content_settings.cc
[modify] https://crrev.com/0cafb39dcf12fdd92433482e856cf8132994e64b/chrome/browser/content_settings/tab_specific_content_settings.h
[modify] https://crrev.com/0cafb39dcf12fdd92433482e856cf8132994e64b/chrome/browser/content_settings/tab_specific_content_settings_unittest.cc
[modify] https://crrev.com/0cafb39dcf12fdd92433482e856cf8132994e64b/chrome/browser/ui/browser.cc
[modify] https://crrev.com/0cafb39dcf12fdd92433482e856cf8132994e64b/chrome/browser/ui/browser.h
[modify] https://crrev.com/0cafb39dcf12fdd92433482e856cf8132994e64b/chrome/browser/ui/cocoa/content_settings/content_setting_bubble_cocoa.mm
[modify] https://crrev.com/0cafb39dcf12fdd92433482e856cf8132994e64b/chrome/browser/ui/content_settings/content_setting_bubble_model.cc
[modify] https://crrev.com/0cafb39dcf12fdd92433482e856cf8132994e64b/chrome/browser/ui/content_settings/content_setting_image_model.cc
[modify] https://crrev.com/0cafb39dcf12fdd92433482e856cf8132994e64b/content/browser/media/audio_stream_monitor.h
[modify] https://crrev.com/0cafb39dcf12fdd92433482e856cf8132994e64b/content/browser/web_contents/web_contents_impl.cc
[modify] https://crrev.com/0cafb39dcf12fdd92433482e856cf8132994e64b/content/public/browser/web_contents_delegate.h
[modify] https://crrev.com/0cafb39dcf12fdd92433482e856cf8132994e64b/content/public/test/web_contents_tester.h
[modify] https://crrev.com/0cafb39dcf12fdd92433482e856cf8132994e64b/content/test/test_web_contents.cc
[modify] https://crrev.com/0cafb39dcf12fdd92433482e856cf8132994e64b/content/test/test_web_contents.h
[modify] https://crrev.com/0cafb39dcf12fdd92433482e856cf8132994e64b/extensions/browser/guest_view/web_view/web_view_guest.cc
[modify] https://crrev.com/0cafb39dcf12fdd92433482e856cf8132994e64b/extensions/browser/guest_view/web_view/web_view_guest.h

Status: Fixed (was: Started)

Sign in to add a comment