New issue
Advanced search Search tips

Issue 776122 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Dec 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug



Sign in to add a comment

Add auto tests for HW H264 encoding/decoding on Android

Project Member Reported by braveyao@chromium.org, Oct 18 2017

Issue description

HW H264 encoder was enabled on Android for a while, lacking of auto test cases though. The recent regression,  issue761336 , raises an alert now.

Short term proposal: extend media_codec_bridge_impl_unittest to make sure the format of IDR/Keyframe meet WebRTC requirement.

Long term proposal: add a browser test to perform a H264 loopback call.

 
Cc: liber...@chromium.org
Labels: M-64
Project Member

Comment 2 by bugdroid1@chromium.org, Nov 8 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6e87b46d145eec1dfef7ee0b57fbf23884f54a80

commit 6e87b46d145eec1dfef7ee0b57fbf23884f54a80
Author: Weiyong Yao <braveyao@chromium.org>
Date: Wed Nov 08 02:42:42 2017

[Android]: add unittest case for HW H264 encoder

HW H264 encoder has been enabled on Android for a while, lacking of auto
test cases all the time.
This cl is to extend media_codec_bridge_impl_unittests to make sure HW
H264 can encode normally on supported devices and validate the format
of IDR/Keyframe.

Bug:  776122 
Change-Id: Ic8cabfe850f7a24ac0bad53f1a1df5c1411ef89b
Reviewed-on: https://chromium-review.googlesource.com/757061
Commit-Queue: Weiyong Yao <braveyao@chromium.org>
Reviewed-by: Frank Liberato <liberato@chromium.org>
Cr-Commit-Position: refs/heads/master@{#514719}
[modify] https://crrev.com/6e87b46d145eec1dfef7ee0b57fbf23884f54a80/media/base/android/BUILD.gn
[modify] https://crrev.com/6e87b46d145eec1dfef7ee0b57fbf23884f54a80/media/base/android/media_codec_bridge_impl_unittest.cc

Project Member

Comment 3 by bugdroid1@chromium.org, Dec 11 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/95534df7ca0e5c8cfe4c81c97cb7bb8c9325e9b9

commit 95534df7ca0e5c8cfe4c81c97cb7bb8c9325e9b9
Author: Weiyong Yao <braveyao@chromium.org>
Date: Mon Dec 11 20:23:53 2017

[Android] add browsertest for HW H264 codec

HW H264 encoder was enabled on Android for a while, lacking of auto test
cases though. There are several regressions recently, which broke the
intercommunication with H264 between Android and other WebRTC ends since
there is no SW H264 fallback available on Android.

This cl is to add a content browser test case to promote H264 on Android
devices which support HW H264 and verify the H264 call works normally.

PS: During developing this cl, it can catch a very recent regression,
as in https://chromium-review.googlesource.com/c/chromium/src/+/810429
So it can really do its job.

Bug:  776122 
Change-Id: Ibf5d428a546a99e5af955005642446acca77fa91
Reviewed-on: https://chromium-review.googlesource.com/817699
Commit-Queue: Weiyong Yao <braveyao@chromium.org>
Reviewed-by: Patrik Höglund <phoglund@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523187}
[modify] https://crrev.com/95534df7ca0e5c8cfe4c81c97cb7bb8c9325e9b9/content/browser/webrtc/webrtc_browsertest.cc
[modify] https://crrev.com/95534df7ca0e5c8cfe4c81c97cb7bb8c9325e9b9/content/test/data/media/peerconnection-call.html
[add] https://crrev.com/95534df7ca0e5c8cfe4c81c97cb7bb8c9325e9b9/content/test/data/media/webrtc_codec_utils.js

Status: Fixed (was: Assigned)

Sign in to add a comment