New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 776119 link

Starred by 1 user
Status: Archived
Owner:
█ eholk@chromium.org
Last visit > 30 days ago
Closed: Dec 12
Cc:
machenb...@chromium.org
gdeepti@chromium.org
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

GCStress on waterfall still runs with --wasm-trap-handler

Project Member Reported by mlippautz@chromium.org, Oct 18 2017 
See the log at 

https://build.chromium.org/p/client.v8/builders/V8%20Linux64%20GC%20Stress%20-%20custom%20snapshot/builds/15668/steps/Mjsunit/logs/instance-memory-gc-st..

Please suggest a temporary solution. Should we disable the test or remove --wasm-trap-handler for now from the bots?

Enabling the flag on the bots tests is blocked by  issue 775047 .

Context: I'd like to reland the ArrayBufferTracker fixes tomorrow which will make GCStress using --wasm-trap-handler red.

Comment 1 by eholk@chromium.org, Oct 18 2017 

I just sent out https://crrev.com/c/726820, which disables the wasm_traps variant mjsunit tests during GC stress.

This is just a temporary solution. Obviously we will need these tests before we can ship trap handlers. This should get the bots green again though.
Project Member

Comment 2 by bugdroid1@chromium.org, Oct 19 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/0c4595a39ebc53b901143a5ea05fbbfff5b0d9d4

commit 0c4595a39ebc53b901143a5ea05fbbfff5b0d9d4
Author: Eric Holk <eholk@chromium.org>
Date: Thu Oct 19 01:30:32 2017

[wasm] temporarily disable gc stress tests in wasm_traps variant

Bug:  chromium:776119 
Change-Id: Id4839fc3313c020945cd308abff54360f20007c2
Reviewed-on: https://chromium-review.googlesource.com/726820
Reviewed-by: Deepti Gandluri <gdeepti@chromium.org>
Commit-Queue: Eric Holk <eholk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#48710}
[modify] https://crrev.com/0c4595a39ebc53b901143a5ea05fbbfff5b0d9d4/test/mjsunit/mjsunit.status

Comment 3 by adamk@chromium.org, Dec 12

Status: Archived (was: Assigned)
►

Sign in to add a comment