UMA for Resource Coordinator IPCs per second |
|||
Issue descriptionRecently, we noticed a memory issue due to sending too many IPCs after a wake up. ( crbug.com/776013 ) which resulted in OOM in some cases. In general, since the resource coordinator system rely heavily on communicating with all components in chrome, we want to make sure that the communication overhead is within reason. We proposal to maintain a running average per X seconds and report it to UMA. The need for UMA stems from the fact that this issue was not observed in the lab, we only noticed that we have an extra task on the IO thread per second, which was within reason, and was marked as WontFix. ( crbug.com/758579 )
,
Dec 7 2017
,
Dec 11 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/93b9f9ceeeae60e97105de9e4cacc809b06d08ab commit 93b9f9ceeeae60e97105de9e4cacc809b06d08ab Author: Peiyong Lin <lpy@chromium.org> Date: Mon Dec 11 23:32:38 2017 [GRC] Add IPC volume report. It's very important to understand how much IPC volume GRC needs to handle. This patch adds an IPCVolumeReporter to report IPC count for frame, page and process every minute. The histogram uses a maximum count of 100 with 10 buckets. BUG= 776118 , 790680 Change-Id: Id11ffa4480f7d066f140cf6daba1dedc744e311e Reviewed-on: https://chromium-review.googlesource.com/815280 Reviewed-by: Zhen Wang <zhenw@chromium.org> Reviewed-by: Steven Holte <holte@chromium.org> Commit-Queue: lpy <lpy@chromium.org> Cr-Commit-Position: refs/heads/master@{#523249} [modify] https://crrev.com/93b9f9ceeeae60e97105de9e4cacc809b06d08ab/services/resource_coordinator/BUILD.gn [modify] https://crrev.com/93b9f9ceeeae60e97105de9e4cacc809b06d08ab/services/resource_coordinator/observers/background_metrics_reporter.h [modify] https://crrev.com/93b9f9ceeeae60e97105de9e4cacc809b06d08ab/services/resource_coordinator/observers/coordination_unit_graph_observer.h [add] https://crrev.com/93b9f9ceeeae60e97105de9e4cacc809b06d08ab/services/resource_coordinator/observers/ipc_volume_reporter.cc [add] https://crrev.com/93b9f9ceeeae60e97105de9e4cacc809b06d08ab/services/resource_coordinator/observers/ipc_volume_reporter.h [add] https://crrev.com/93b9f9ceeeae60e97105de9e4cacc809b06d08ab/services/resource_coordinator/observers/ipc_volume_reporter_unittest.cc [modify] https://crrev.com/93b9f9ceeeae60e97105de9e4cacc809b06d08ab/services/resource_coordinator/resource_coordinator_service.cc [modify] https://crrev.com/93b9f9ceeeae60e97105de9e4cacc809b06d08ab/tools/metrics/histograms/histograms.xml
,
Dec 12 2017
I am closing this bug as fixed. And please refer to crbug.com/790680 for further work relates to IPC volume. |
|||
►
Sign in to add a comment |
|||
Comment 1 by dtapu...@chromium.org
, Nov 9 2017