New issue
Advanced search Search tips

Issue 776117 link

Starred by 3 users
Status: Fixed
Owner:
charliea@chromium.org
Closed: Apr 2018
Cc:
charliea@chromium.org
vhang@chromium.org
crouleau@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

BattOr occasionally fails due to clock sync error

Project Member Reported by charliea@google.com, Oct 18 2017 
Example failure: https://chromium-swarm.appspot.com/task?id=394878fe37f7cb10&refresh=10&show_raw=1

Link to trace file: https://console.developers.google.com/m/cloudstorage/b/chrome-telemetry-output/o/load_tools_weather_2017-10-18_09-48-39_8488.html

When I use Catapult's html2trace to actually crack open the trace files, it appears that the BattOr file does indeed have no clock sync marker in it. I suspect that there could be two reasons for this:

1) When the BattOr tells us what sample # we're on in order to clock sync, it's possible that sample # is corrupted.
2) We might not be waiting long enough after requesting the sample to ensure that frame eventually gets included in the trace. 

I'm going to add a little bit of logging into the BattOr agent to check if the sync sample is within the bounds of the samples we're given and, if not, log some additional info in the serial log.
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 18 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ccf365ce3fa5e388be435c6797a07bd60107ac80

commit ccf365ce3fa5e388be435c6797a07bd60107ac80
Author: Charlie Andrews <charliea@chromium.org>
Date: Wed Oct 18 23:43:10 2017

Add additional logging for clock syncs not in the result

This logging is to try and track down a bug in which clock syncs are
occassionally not being included in the BattOr trace.

TBR=rnephew@chromium.org

Bug:  776117 
Change-Id: Id8f6d2fd07829db889a883f5474b268e20730628
Reviewed-on: https://chromium-review.googlesource.com/726883
Reviewed-by: Charlie Andrews <charliea@chromium.org>
Reviewed-by: rnephew <rnephew@chromium.org>
Commit-Queue: Charlie Andrews <charliea@chromium.org>
Cr-Commit-Position: refs/heads/master@{#509931}
[modify] https://crrev.com/ccf365ce3fa5e388be435c6797a07bd60107ac80/tools/battor_agent/battor_agent.cc
Project Member

Comment 2 by bugdroid1@chromium.org, Oct 20 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/catapult/+/5a229d42c11d1af05a868847d5b8662fe9637969

commit 5a229d42c11d1af05a868847d5b8662fe9637969
Author: Charlie Andrews <charliea@chromium.org>
Date: Fri Oct 20 20:22:00 2017

Roll the BattOr agent version to ToT

TBR=rnephew@chromium.org
Bug:  chromium:776117 
Change-Id: Ibb9cc46e84b13343c851c3b0a75a6e6f129640dc
Reviewed-on: https://chromium-review.googlesource.com/728381
Commit-Queue: Charlie Andrews <charliea@chromium.org>
Reviewed-by: rnephew <rnephew@chromium.org>
Reviewed-by: Charlie Andrews <charliea@chromium.org>

[modify] https://crrev.com/5a229d42c11d1af05a868847d5b8662fe9637969/common/battor/battor/battor_binary_dependencies.json

Comment 3 by charliea@chromium.org, Nov 1 2017

Cc: charliea@chromium.org vhang@chromium.org crouleau@chromium.org
 Issue 753759  has been merged into this issue.

Comment 4 by charliea@chromium.org, Apr 2 2018

Status: Fixed (was: Assigned)
►

Sign in to add a comment