NavigationCallbacksTest.NativeContentReload fails with WKBasedNavigationManager |
||
Issue descriptionThis is failing because in VerifyReloadStartedContext, web_state->GetNavigationManager()->GetPendingItem() is non-null (but expected to be null). However, there's a TODO (referring to issue 676129) about that expectation suggesting that reload *should* be creating a pending item (see https://cs.chromium.org/chromium/src/ios/web/web_state/navigation_callbacks_inttest.mm?rcl=0c4fbe1c51a85b136fa74e1068fbc9ab7bb0f264&l=249). So this looks like a case where we can just update the expectation.
,
Oct 26 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9d35c57f686553323d9b0d2df27b8f6f7223d563 commit 9d35c57f686553323d9b0d2df27b8f6f7223d563 Author: Ali Juma <ajuma@chromium.org> Date: Thu Oct 26 18:23:55 2017 [Nav Experiment] Update expectations for NavigationCallbackTests When using WKBasedNavigationManager, reload creates a pending item (fixing a bug in LegacyNavigationMangerImpl). This CL updates expectations in NavigationCallbackTests that were assuming LegacyNavigationManagerImpl's buggy behavior. Bug: 776112 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I0ea1707155fbdcfbbfe348f489853c83c372827b Reviewed-on: https://chromium-review.googlesource.com/739759 Commit-Queue: Ali Juma <ajuma@chromium.org> Commit-Queue: Danyao Wang <danyao@chromium.org> Reviewed-by: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#511888} [modify] https://crrev.com/9d35c57f686553323d9b0d2df27b8f6f7223d563/ios/web/web_state/navigation_callbacks_inttest.mm
,
Oct 26 2017
|
||
►
Sign in to add a comment |
||
Comment 1 by ajuma@chromium.org
, Oct 19 2017