New issue
Advanced search Search tips

Issue 776110 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Split WAV creation stuff out from audit-util.js

Project Member Reported by rtoy@chromium.org, Oct 18 2017

Issue description

To coordinate better with webaudio WPT tests, move all of the code
dealing with creating WAV files out from audit-util.js to another
file.  And update tests to load up this file.

 
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 31 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/649bf91032ef0afd019ce3351e99cb2276ccadc9

commit 649bf91032ef0afd019ce3351e99cb2276ccadc9
Author: Raymond Toy <rtoy@chromium.org>
Date: Tue Oct 31 21:13:09 2017

Move WAV creation utilities to separate file

Everything related to creating a WAV file from an AudioBuffer is moved
from audit-util.js to a new file.

Every test depending on these utilities now needs to import this
script.

No functional changes.

Bug:  776110 
Change-Id: Ib3d4ddd4bc3fe5e743dd5c3f7b758b6f57940e7d
Reviewed-on: https://chromium-review.googlesource.com/726947
Reviewed-by: Hongchan Choi <hongchan@chromium.org>
Commit-Queue: Raymond Toy <rtoy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#512954}
[modify] https://crrev.com/649bf91032ef0afd019ce3351e99cb2276ccadc9/third_party/WebKit/LayoutTests/webaudio/AudioBufferSource/audiobuffersource-detune-modulation.html
[modify] https://crrev.com/649bf91032ef0afd019ce3351e99cb2276ccadc9/third_party/WebKit/LayoutTests/webaudio/AudioBufferSource/audiobuffersource-playbackrate-modulation.html
[modify] https://crrev.com/649bf91032ef0afd019ce3351e99cb2276ccadc9/third_party/WebKit/LayoutTests/webaudio/Oscillator/osc-sweep-snr-custom.html
[modify] https://crrev.com/649bf91032ef0afd019ce3351e99cb2276ccadc9/third_party/WebKit/LayoutTests/webaudio/Oscillator/osc-sweep-snr-sawtooth.html
[modify] https://crrev.com/649bf91032ef0afd019ce3351e99cb2276ccadc9/third_party/WebKit/LayoutTests/webaudio/Oscillator/osc-sweep-snr-sine.html
[modify] https://crrev.com/649bf91032ef0afd019ce3351e99cb2276ccadc9/third_party/WebKit/LayoutTests/webaudio/Oscillator/osc-sweep-snr-square.html
[modify] https://crrev.com/649bf91032ef0afd019ce3351e99cb2276ccadc9/third_party/WebKit/LayoutTests/webaudio/Oscillator/osc-sweep-snr-triangle.html
[modify] https://crrev.com/649bf91032ef0afd019ce3351e99cb2276ccadc9/third_party/WebKit/LayoutTests/webaudio/PeriodicWave/periodicwave-contexts.html
[modify] https://crrev.com/649bf91032ef0afd019ce3351e99cb2276ccadc9/third_party/WebKit/LayoutTests/webaudio/codec-tests/aac/m4a-short-duration-44khz.html
[modify] https://crrev.com/649bf91032ef0afd019ce3351e99cb2276ccadc9/third_party/WebKit/LayoutTests/webaudio/codec-tests/aac/vbr-128kbps-44khz.html
[modify] https://crrev.com/649bf91032ef0afd019ce3351e99cb2276ccadc9/third_party/WebKit/LayoutTests/webaudio/codec-tests/flac/flac-decode.html
[modify] https://crrev.com/649bf91032ef0afd019ce3351e99cb2276ccadc9/third_party/WebKit/LayoutTests/webaudio/codec-tests/mp3/128kbps-44khz.html
[modify] https://crrev.com/649bf91032ef0afd019ce3351e99cb2276ccadc9/third_party/WebKit/LayoutTests/webaudio/codec-tests/opus/opus-decode.html
[modify] https://crrev.com/649bf91032ef0afd019ce3351e99cb2276ccadc9/third_party/WebKit/LayoutTests/webaudio/codec-tests/vorbis/vbr-128kbps-44khz.html
[modify] https://crrev.com/649bf91032ef0afd019ce3351e99cb2276ccadc9/third_party/WebKit/LayoutTests/webaudio/codec-tests/vorbis/vbr-70kbps-44khz.html
[modify] https://crrev.com/649bf91032ef0afd019ce3351e99cb2276ccadc9/third_party/WebKit/LayoutTests/webaudio/codec-tests/vorbis/vbr-96kbps-44khz.html
[modify] https://crrev.com/649bf91032ef0afd019ce3351e99cb2276ccadc9/third_party/WebKit/LayoutTests/webaudio/codec-tests/wav/24bit-22khz-resample.html
[modify] https://crrev.com/649bf91032ef0afd019ce3351e99cb2276ccadc9/third_party/WebKit/LayoutTests/webaudio/codec-tests/wav/24bit-44khz.html
[modify] https://crrev.com/649bf91032ef0afd019ce3351e99cb2276ccadc9/third_party/WebKit/LayoutTests/webaudio/codec-tests/wav/f32-44khz.html
[modify] https://crrev.com/649bf91032ef0afd019ce3351e99cb2276ccadc9/third_party/WebKit/LayoutTests/webaudio/codec-tests/webm/webm-decode.html
[modify] https://crrev.com/649bf91032ef0afd019ce3351e99cb2276ccadc9/third_party/WebKit/LayoutTests/webaudio/internals/audiobuffersource.html
[add] https://crrev.com/649bf91032ef0afd019ce3351e99cb2276ccadc9/third_party/WebKit/LayoutTests/webaudio/resources/audio-file-utils.js
[modify] https://crrev.com/649bf91032ef0afd019ce3351e99cb2276ccadc9/third_party/WebKit/LayoutTests/webaudio/resources/audit-util.js
[modify] https://crrev.com/649bf91032ef0afd019ce3351e99cb2276ccadc9/third_party/WebKit/LayoutTests/webaudio/test-basic.html

Comment 2 by rtoy@chromium.org, Nov 1 2017

Owner: rtoy@chromium.org
Status: Fixed (was: Available)

Sign in to add a comment