New issue
Advanced search Search tips

Issue 776107 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: ----
Type: ----



Sign in to add a comment

webkit_layout_tests failing on chromium.webkit/WebKit Linux Trusty (dbg)

Project Member Reported by jonr...@chromium.org, Oct 18 2017

Issue description

webkit_layout_tests failing on chromium.webkit/WebKit Linux Trusty (dbg)

Builders failed on: 
- WebKit Linux Trusty (dbg): 
  https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20Trusty%20%28dbg%29

media/controls/captions-menu-always-visible.html is flaky

Example failing run: https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Linux%20Trusty%20%28dbg%29/builds/6167

A suspected range: https://chromium.googlesource.com/chromium/src/+log/89f9ca6ed88f89bd0602fd61add1504b4a87b1db%5E..14793ef03f559240724976e50affadaf6fcf1e30?pretty=fuller&n=

mlarmouri@ could you help triage this?

 
Status: Started (was: Assigned)

Comment 2 by yutak@chromium.org, Oct 23 2017

Cc: yutak@chromium.org
Components: Blink>Media>Controls
mlamouri, is there any news?

This test seems flaky on any platforms as you can see below:

https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=webkit_tests&tests=media%2Fcontrols%2Fcaptions-menu-always-visible.html

I'm going to mark this test as flaky. If there's any issue, please let me know.
Project Member

Comment 3 by bugdroid1@chromium.org, Oct 23 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c1d9de6a8a92efed7b8719802b12574695068230

commit c1d9de6a8a92efed7b8719802b12574695068230
Author: Yuta Kitamura <yutak@chromium.org>
Date: Mon Oct 23 09:19:13 2017

Layout test captions-menu-always-visible.html is flaky.

TBR=battre@chromium.org

Bug:  776107 ,  769323 
Change-Id: Ib0ee750a8415af498fc403eb218a96214b4d233c
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/732868
Reviewed-by: Yuta Kitamura <yutak@chromium.org>
Commit-Queue: Yuta Kitamura <yutak@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510744}
[modify] https://crrev.com/c1d9de6a8a92efed7b8719802b12574695068230/third_party/WebKit/LayoutTests/TestExpectations

Comment 4 by battre@chromium.org, Oct 23 2017

Cc: mlamouri@chromium.org
 Issue 777324  has been merged into this issue.

Comment 5 by battre@chromium.org, Oct 23 2017

I have duped 777324 into this. The visual diff is interesting (see  crbug.com/777324 ), seems to be an issue of a mouseover effect.
I actually have a fix for this but it didn't land yet. I will have to remove the flakyness entry now :)
Project Member

Comment 7 by bugdroid1@chromium.org, Oct 23 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4e2127f5b969f54e31f4e81fd414949cf7833ad9

commit 4e2127f5b969f54e31f4e81fd414949cf7833ad9
Author: Dominic Battre <battre@chromium.org>
Date: Mon Oct 23 10:24:28 2017

Layout test media/controls/overflow-menu-always-visible.html is flaky

TBR=yutak@chromium.org

Bug:  776107 ,  769323 
Change-Id: I9eead8bb9b927a68bfc90aa3332d3217f1d60aff
Reviewed-on: https://chromium-review.googlesource.com/732658
Reviewed-by: Dominic Battré <battre@chromium.org>
Reviewed-by: Yuta Kitamura <yutak@chromium.org>
Commit-Queue: Dominic Battré <battre@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510751}
[modify] https://crrev.com/4e2127f5b969f54e31f4e81fd414949cf7833ad9/third_party/WebKit/LayoutTests/TestExpectations

Comment 8 by battre@chromium.org, Oct 23 2017

Labels: -Sheriff-Chromium
Project Member

Comment 9 by bugdroid1@chromium.org, Oct 23 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2e9451814cc0329083e6a3eeac30cfb67ab75c46

commit 2e9451814cc0329083e6a3eeac30cfb67ab75c46
Author: Mounir Lamouri <mlamouri@chromium.org>
Date: Mon Oct 23 14:00:10 2017

Media Controls: fix flakyness when testing if menu is always on top.

This is fixed by disabling pointer events on the text track and
overflow menus. The :hover effect would otherwise apply randomly,
breaking the pixel comparison tests.

Bug:  776107 ,  769323 
Change-Id: I6aded9a5bf21af062ee3c0cff7770189f63d2cca
Reviewed-on: https://chromium-review.googlesource.com/728219
Commit-Queue: Mounir Lamouri <mlamouri@chromium.org>
Reviewed-by: Becca Hughes <beccahughes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#510782}
[modify] https://crrev.com/2e9451814cc0329083e6a3eeac30cfb67ab75c46/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/2e9451814cc0329083e6a3eeac30cfb67ab75c46/third_party/WebKit/LayoutTests/media/controls/captions-menu-always-visible-expected.html
[modify] https://crrev.com/2e9451814cc0329083e6a3eeac30cfb67ab75c46/third_party/WebKit/LayoutTests/media/controls/captions-menu-always-visible.html
[modify] https://crrev.com/2e9451814cc0329083e6a3eeac30cfb67ab75c46/third_party/WebKit/LayoutTests/media/controls/overflow-menu-always-visible-expected.html
[modify] https://crrev.com/2e9451814cc0329083e6a3eeac30cfb67ab75c46/third_party/WebKit/LayoutTests/media/controls/overflow-menu-always-visible.html
[modify] https://crrev.com/2e9451814cc0329083e6a3eeac30cfb67ab75c46/third_party/WebKit/LayoutTests/media/media-controls.js

Status: Fixed (was: Started)

Sign in to add a comment