New issue
Advanced search Search tips

Issue 776098 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jan 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Feature



Sign in to add a comment

Remove SurfaceObserver::OnSurfaceSubtreeDamaged

Project Member Reported by samans@chromium.org, Oct 18 2017

Issue description

SurfaceObserver::OnSurfaceSubtreeDamaged is only used in tests, and I believe we can just use AggregatedDamageCallback for the same effect. We should remove it.
 

Comment 1 by samans@chromium.org, Oct 18 2017

Description: Show this description
Components: Internals>Compositing

Comment 3 by ericrk@chromium.org, Oct 27 2017

Labels: -Type-Bug Type-Feature
Status: Available (was: Untriaged)
Owner: rijubrat...@intel.com
Status: Started (was: Available)
Project Member

Comment 5 by bugdroid1@chromium.org, Jan 12 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/782680c6cff03fd1eb72aa8c2a3f7775bfe8f0c6

commit 782680c6cff03fd1eb72aa8c2a3f7775bfe8f0c6
Author: Rijubrata Bhaumik <rijubrata.bhaumik@intel.com>
Date: Fri Jan 12 06:47:01 2018

[viz] Remove SurfaceObserver::OnSurfaceSubtreeDamaged.

SurfaceObserver::OnSurfaceSubtreeDamaged is only used in tests.
AggregatedDamageCallback can be used for the same effect.

BUG= 776098 

Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel
Change-Id: I3c9546ee90aed63065fa7100f4d33f3dd616b787
Reviewed-on: https://chromium-review.googlesource.com/831449
Reviewed-by: kylechar <kylechar@chromium.org>
Reviewed-by: Saman Sami <samans@chromium.org>
Commit-Queue: Rijubrata Bhaumik <rijubrata.bhaumik@intel.com>
Cr-Commit-Position: refs/heads/master@{#528897}
[modify] https://crrev.com/782680c6cff03fd1eb72aa8c2a3f7775bfe8f0c6/components/viz/service/display/display_scheduler.cc
[modify] https://crrev.com/782680c6cff03fd1eb72aa8c2a3f7775bfe8f0c6/components/viz/service/display/display_scheduler.h
[modify] https://crrev.com/782680c6cff03fd1eb72aa8c2a3f7775bfe8f0c6/components/viz/service/display/surface_aggregator.cc
[modify] https://crrev.com/782680c6cff03fd1eb72aa8c2a3f7775bfe8f0c6/components/viz/service/display/surface_aggregator_unittest.cc
[modify] https://crrev.com/782680c6cff03fd1eb72aa8c2a3f7775bfe8f0c6/components/viz/service/frame_sinks/frame_sink_manager_impl.cc
[modify] https://crrev.com/782680c6cff03fd1eb72aa8c2a3f7775bfe8f0c6/components/viz/service/frame_sinks/frame_sink_manager_impl.h
[modify] https://crrev.com/782680c6cff03fd1eb72aa8c2a3f7775bfe8f0c6/components/viz/service/frame_sinks/video_detector.h
[modify] https://crrev.com/782680c6cff03fd1eb72aa8c2a3f7775bfe8f0c6/components/viz/service/hit_test/hit_test_manager.h
[modify] https://crrev.com/782680c6cff03fd1eb72aa8c2a3f7775bfe8f0c6/components/viz/service/surfaces/surface_manager.cc
[modify] https://crrev.com/782680c6cff03fd1eb72aa8c2a3f7775bfe8f0c6/components/viz/service/surfaces/surface_manager.h
[modify] https://crrev.com/782680c6cff03fd1eb72aa8c2a3f7775bfe8f0c6/components/viz/service/surfaces/surface_observer.h
[modify] https://crrev.com/782680c6cff03fd1eb72aa8c2a3f7775bfe8f0c6/components/viz/test/fake_surface_observer.cc
[modify] https://crrev.com/782680c6cff03fd1eb72aa8c2a3f7775bfe8f0c6/components/viz/test/fake_surface_observer.h

Status: Fixed (was: Started)

Sign in to add a comment