New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 776078 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Feb 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

Chrome OS: Migrate tests to use ShillProxy instead of legacy Flimflam

Project Member Reported by benchan@chromium.org, Oct 18 2017

Issue description

There are a few places in network3g tests that use FlimFlam (provided by shill/test-scripts/flimflam.py) to interact with shill over D-Bus. These usages should be migrated to use the ShillProxy (provided by autotest/files/client/cros/networking/shill_proxy.py).
 
Status: Started (was: Assigned)
Project Member

Comment 2 by bugdroid1@chromium.org, Oct 20 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/f71c0f44f68f6fa597a03b6f26da538a3930a441

commit f71c0f44f68f6fa597a03b6f26da538a3930a441
Author: Ben Chan <benchan@chromium.org>
Date: Fri Oct 20 04:15:24 2017

cellular: gather info of the modem under test in network_3GSmokeTest

network_3GSmokeTest gathers information about all modems present in the
system before and after running each connection test. That's undesired
as the test should only focus on the modem under test and not be
affected by any other modem. That's also unnecessary as
network_3GSmokeTest runs the test under a CellularTestEnvironment
context manager, which allows only one modem on a system.

BUG= chromium:776078 
TEST=Run network_3GSmokeTest on a few DUTs with a modem.

Change-Id: If40245d1a8a83c05e159eca39cd71cb826fddbd7
Reviewed-on: https://chromium-review.googlesource.com/726184
Commit-Ready: Ben Chan <benchan@chromium.org>
Tested-by: Ben Chan <benchan@chromium.org>
Reviewed-by: Eric Caruso <ejcaruso@chromium.org>

[modify] https://crrev.com/f71c0f44f68f6fa597a03b6f26da538a3930a441/client/site_tests/network_3GSmokeTest/network_3GSmokeTest.py

Project Member

Comment 3 by bugdroid1@chromium.org, Oct 20 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/a8aa97304b72b439723c0de2d7851ae3f77fb0dc

commit a8aa97304b72b439723c0de2d7851ae3f77fb0dc
Author: Ben Chan <benchan@chromium.org>
Date: Fri Oct 20 04:15:24 2017

cellular: ensure autoconnect disabled when running network_3GSmokeTest

network_3GSmokeTest performs a few iterations of explicitly connecting
and disconnecting the cellular device under test to a cellular network.
It's better to temporarily disable the autoconnect property on the
cellular device during the test run.

BUG= chromium:776078 
TEST=Run network_3GSmokeTest on a few DUTs with a modem.

Change-Id: Ifbf2780e037cd5c4325c505ada0ffdcbe30e3cec
Reviewed-on: https://chromium-review.googlesource.com/726185
Commit-Ready: Ben Chan <benchan@chromium.org>
Tested-by: Ben Chan <benchan@chromium.org>
Reviewed-by: Eric Caruso <ejcaruso@chromium.org>

[modify] https://crrev.com/a8aa97304b72b439723c0de2d7851ae3f77fb0dc/client/site_tests/network_3GSmokeTest/network_3GSmokeTest.py

Project Member

Comment 4 by bugdroid1@chromium.org, Oct 20 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/4aa1cebb122513cba36040cf253ecc6400c8dd19

commit 4aa1cebb122513cba36040cf253ecc6400c8dd19
Author: Ben Chan <benchan@chromium.org>
Date: Fri Oct 20 04:15:24 2017

cellular: migrate network_3GSmokeTest to use ShillProxy

This CL migrates network_3GSmokeTest to use ShillProxy (provided by
autotest/files/client/cros/networking/shill_proxy.py) instead of the
deprecated Flimflam (provided by shill/test-scripts/flimflam.py).

BUG= chromium:776078 
TEST=Run network_3GSmokeTest on a few DUTs with a modem.

Change-Id: Ifc2694ffb32b983d486e99f757bcfb9c20e0155e
Reviewed-on: https://chromium-review.googlesource.com/726186
Commit-Ready: Ben Chan <benchan@chromium.org>
Tested-by: Ben Chan <benchan@chromium.org>
Reviewed-by: Eric Caruso <ejcaruso@chromium.org>

[modify] https://crrev.com/4aa1cebb122513cba36040cf253ecc6400c8dd19/client/site_tests/network_3GSmokeTest/network_3GSmokeTest.py

Project Member

Comment 5 by bugdroid1@chromium.org, Nov 29 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/11a736dfc198d677eee7dd39ce98680db10a3d68

commit 11a736dfc198d677eee7dd39ce98680db10a3d68
Author: Ben Chan <benchan@chromium.org>
Date: Wed Nov 29 04:17:10 2017

cellular: migrate network_3GModemControl to use ServiceAutoConnectContext

This CL migrates network_3GModemControl to use
shill_context.ServiceAutoConnectContext instead of cell_tool.AutoConnectContext
as the latter depends on the deprecated Flimflam (provided by
shill/test-scripts/flimflam.py).

BUG= chromium:776078 
TEST=Run network_3GModemControl on a few DUTs with a modem.

Change-Id: Iae7ee13f2b22fbbc536f582bd490c032e040354a
Reviewed-on: https://chromium-review.googlesource.com/791944
Commit-Ready: Ben Chan <benchan@chromium.org>
Tested-by: Ben Chan <benchan@chromium.org>
Reviewed-by: Eric Caruso <ejcaruso@chromium.org>

[modify] https://crrev.com/11a736dfc198d677eee7dd39ce98680db10a3d68/client/site_tests/network_3GModemControl/network_3GModemControl.py

Project Member

Comment 6 by bugdroid1@chromium.org, Nov 30 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/78b82f31fc347258638212eb23e95a5f2f7bbb1f

commit 78b82f31fc347258638212eb23e95a5f2f7bbb1f
Author: Ben Chan <benchan@chromium.org>
Date: Thu Nov 30 02:04:30 2017

cellular: remove deprecated Flimflam object from CellularTestEnvironment

All network3g tests using CellularTestEnvironment have been migrated to
use ShillProxy instead of the deprecated Flimflam. This CL removes the
Flimflam object from CellularTestEnvironment, which is no longer needed.

BUG= chromium:776078 
TEST=Run network3g tests on a few DUTs with a modem.

Change-Id: I07a3a450b0015721bc3bb3eef8584dc66776db6f
Reviewed-on: https://chromium-review.googlesource.com/795372
Commit-Ready: Ben Chan <benchan@chromium.org>
Tested-by: Ben Chan <benchan@chromium.org>
Reviewed-by: Eric Caruso <ejcaruso@chromium.org>

[modify] https://crrev.com/78b82f31fc347258638212eb23e95a5f2f7bbb1f/client/cros/cellular/test_environment.py

Project Member

Comment 7 by bugdroid1@chromium.org, Jan 19 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/adbe8cfec590c9bc7a7d757396e81b30ebdb630a

commit adbe8cfec590c9bc7a7d757396e81b30ebdb630a
Author: Ben Chan <benchan@chromium.org>
Date: Fri Jan 19 01:40:33 2018

cellular: remove obsolete cell_tools.AutoConnectContext

cell_tools.AutoConnectContext is superseded by
shill_context.ServiceAutoConnectContext.

BUG= chromium:776078 
TEST=Remote trybot runs.
TEST=Run network3g tests.

Change-Id: Id87447e7c5d15190d5a90d98e5b22ede69dbb8ad
Reviewed-on: https://chromium-review.googlesource.com/865974
Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com>
Tested-by: Ben Chan <benchan@chromium.org>
Reviewed-by: Harpreet Grewal <harpreet@chromium.org>

[modify] https://crrev.com/adbe8cfec590c9bc7a7d757396e81b30ebdb630a/client/cros/cellular/cell_tools.py

Project Member

Comment 8 by bugdroid1@chromium.org, Jan 23 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/b24e46adec3d3572ca8cf006270f436a0e61214a

commit b24e46adec3d3572ca8cf006270f436a0e61214a
Author: Ben Chan <benchan@chromium.org>
Date: Tue Jan 23 09:48:42 2018

cellular: add shill_context.AllowedTechnologiesContext

This CL adds shill_context.AllowedTechnologiesContext context manager,
which replaces the soon-to-be deprecated
cell_tools.OtherDeviceShutdownContext context manager.
AllowedTechnologiesContext uses shill_proxy.ShillProxy instead of the
deprecated flimflam.Flimflam API.

Like OtherDeviceShutdownContext, AllowedTechnologiesContext provides a
context that temporarily prohibits technologies, unless explicitly
allowed, to be enabled.

BUG= chromium:776078 
TEST=Run network3g tests on a DUT with a cellular modem.

Change-Id: I2900a0509a8fd311f7f6f8ca39bd49a3317ca9a0
Reviewed-on: https://chromium-review.googlesource.com/875555
Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com>
Tested-by: Ben Chan <benchan@chromium.org>
Reviewed-by: Eric Caruso <ejcaruso@chromium.org>

[modify] https://crrev.com/b24e46adec3d3572ca8cf006270f436a0e61214a/client/cros/networking/shill_proxy.py
[modify] https://crrev.com/b24e46adec3d3572ca8cf006270f436a0e61214a/client/cros/networking/shill_context.py

Project Member

Comment 9 by bugdroid1@chromium.org, Jan 23 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/fdbe7c76fb8334887fb3fb02fc9294b4574b7c88

commit fdbe7c76fb8334887fb3fb02fc9294b4574b7c88
Author: Ben Chan <benchan@chromium.org>
Date: Tue Jan 23 09:48:42 2018

cellular: migrate CellularTestEnvironment to fully use ShillProxy

This CL removes the last dependency of the deprecated flimflam.Flimflam
in CellularTestEnvironment by replacing the use of
cell_tools.OtherDeviceShutdownContext (which uses Flimflam) with
shill_context.AllowedTechnologiesContext (which uses ShillProxy).

BUG= chromium:776078 
TEST=Run network3g tests on a DUT with a cellular modem.

Change-Id: If1e33a0ca5753d46ad2f7db9dbf784711e1d680f
Reviewed-on: https://chromium-review.googlesource.com/875556
Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com>
Tested-by: Ben Chan <benchan@chromium.org>
Reviewed-by: Eric Caruso <ejcaruso@chromium.org>

[modify] https://crrev.com/fdbe7c76fb8334887fb3fb02fc9294b4574b7c88/client/cros/cellular/test_environment.py

Summary: Chrome OS: Migrate tests to use ShillProxy instead of legacy Flimflam (was: Chrome OS: Migrate network3g tests to use ShillProxy instead of legacy Flimflam)
Project Member

Comment 11 by bugdroid1@chromium.org, Jan 25 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/6987a52a0f03cae3baad455cf95db45f9915c71f

commit 6987a52a0f03cae3baad455cf95db45f9915c71f
Author: Ben Chan <benchan@chromium.org>
Date: Thu Jan 25 08:15:45 2018

Migrate power_Consumption to use WifiProxy instead of deprecated Flimflam.

Flimflam is deprecated and superseded by ShillProxy/WifiProxy.

BUG= chromium:776078 
TEST=Run power_Consumption test.

Change-Id: I1874d55055234092421790b9df5f086e1c7e3ea2
Reviewed-on: https://chromium-review.googlesource.com/884579
Commit-Ready: Ben Chan <benchan@chromium.org>
Tested-by: Ben Chan <benchan@chromium.org>
Reviewed-by: Todd Broch <tbroch@chromium.org>

[modify] https://crrev.com/6987a52a0f03cae3baad455cf95db45f9915c71f/client/site_tests/power_Consumption/power_Consumption.py

Project Member

Comment 12 by bugdroid1@chromium.org, Jan 25 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/d46cacdcb3367be62d1e1fb72b6390d660cea48a

commit d46cacdcb3367be62d1e1fb72b6390d660cea48a
Author: Ben Chan <benchan@chromium.org>
Date: Thu Jan 25 08:15:49 2018

Remove unnecessary import of flimflam_test_path in network_EthernetStressPlug.

BUG= chromium:776078 
TEST=Run network_EthernetStressPlug test.

Change-Id: I0230145f8e2cabe2b81e59b4248b91efc0470841
Reviewed-on: https://chromium-review.googlesource.com/884844
Commit-Ready: Ben Chan <benchan@chromium.org>
Tested-by: Ben Chan <benchan@chromium.org>
Reviewed-by: Eric Caruso <ejcaruso@chromium.org>

[modify] https://crrev.com/d46cacdcb3367be62d1e1fb72b6390d660cea48a/client/site_tests/network_EthernetStressPlug/network_EthernetStressPlug.py

Project Member

Comment 13 by bugdroid1@chromium.org, Jan 25 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/ccd04739e596a34a90a965667591fe4eaf58ec6a

commit ccd04739e596a34a90a965667591fe4eaf58ec6a
Author: Ben Chan <benchan@chromium.org>
Date: Thu Jan 25 10:43:20 2018

Copying routing.py from shill-test-scripts.

With the deprecation of flimflim.py from the shill-test-scripts package,
there is little value to import routing.py from there. Alos, routing.py
will likely be removed along with flimflam.py. By copying routing.py
from shill-test-scripts into autotest, we avoid the flimflam_test_path
import hack and one less dependency on shill-test-scripts.

BUG= chromium:776078 
BUG= chromium:805737 
TEST=Run cellular_Smoke which depends on network.py.

Change-Id: I26533104856f2d169151fafd68a8328c1f83e125
Reviewed-on: https://chromium-review.googlesource.com/884986
Commit-Ready: Ben Chan <benchan@chromium.org>
Tested-by: Ben Chan <benchan@chromium.org>
Reviewed-by: Ben Chan <benchan@chromium.org>

[add] https://crrev.com/ccd04739e596a34a90a965667591fe4eaf58ec6a/client/cros/routing.py
[modify] https://crrev.com/ccd04739e596a34a90a965667591fe4eaf58ec6a/client/cros/network.py

Cc: rpattumani@chromium.org
Status: Fixed (was: Started)

Sign in to add a comment