Merge HSTS for youtube.com to Chrome 63 |
|||||||
Issue descriptionRequesting a merge of https://chromium-review.googlesource.com/c/chromium/src/+/719412, along with two requisite disabled tests: - https://chromium-review.googlesource.com/c/chromium/src/+/706665 - https://chromium-review.googlesource.com/c/chromium/src/+/722448
,
Oct 19 2017
Going forward please add a merge request label to the bug, rather than create a separate bug and setting the title as 'merge request...' it's easier for the TPM to see the bug history and decide on merge. Thanks
,
Oct 19 2017
Your change meets the bar and is auto-approved for M63. Please go ahead and merge the CL to branch 3239 manually. Please contact milestone owner if you have questions. Owners: cmasso@(Android), cmasso@(iOS), gkihumba@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Oct 19 2017
Please merge your change to M63 branch 3239 before 4:00 PM PT today,Thursday if possible, so we can take it in for next dev release. Thank you.
,
Oct 20 2017
TEST= 1) Visit chrome://net-internals/#hsts 2) Under "Query HSTS/PKP domain", enter "youtube.com" and click "Query". 3) Verify that the page shows: Found: static_sts_domain: youtube.com static_upgrade_mode: FORCE_HTTPS static_sts_include_subdomains: true ...
,
Oct 20 2017
Verified this on Win7/64 bit, Mac OSX 10.12.6 & Ubuntu 14.04 - 64.0.3245.0 Seeing the following: Found: static_sts_domain: youtube.com static_upgrade_mode: FORCE_HTTPS static_sts_include_subdomains: true static_sts_observed: 1508389200 static_pkp_domain: youtube.com static_pkp_include_subdomains: true static_pkp_observed: 1508389200 static_spki_hashes: sha256/IPMbDAjLVSGntGO3WP53X/zilCVndez5YJ2+vJvhJsA=,sha256/7HIpactkIAq2Y49orFOOQKurWxmmSFZhBCoQYcRhJ3Y=,sha256/h6801m+z8v3zbgkRHpq6L29Esgfzhj89C1SyUCOQmqU=,sha256/iie1VXtL7HzAMF+/PVPR9xzT80kQxdZeJ+zduCB3uj0= dynamic_sts_domain: dynamic_upgrade_mode: UNKNOWN dynamic_sts_include_subdomains: dynamic_sts_observed: dynamic_sts_expiry: dynamic_pkp_domain: dynamic_pkp_include_subdomains: dynamic_pkp_observed: dynamic_pkp_expiry: dynamic_spki_hashes:
,
Oct 20 2017
Removing the Needs-TestConfirmation label as per # 6
,
Oct 20 2017
Thank you pucchakayala@. lgarron@, please merge your change to M63 branch 3239 before 5:00 PM PT today if possible so we can pick it up for next week last M63 dev release. Thank you.
,
Oct 23 2017
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible! If all merges have been completed, please remove any remaining Merge-Approved labels from this issue. Thanks for your time! To disable nags, add the Disable-Nags label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Oct 23 2017
,
Oct 23 2017
Requesting a double-check for Chrome 63. Thanks! |
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by lgar...@chromium.org
, Oct 18 2017Labels: Merge-Request-63 OS-Android OS-Chrome OS-iOS OS-Linux OS-Mac OS-Windows