New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 776029 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

EVE [BVT-CQ] platform_PartitionCheck test is failed 14 times.

Project Member Reported by abod...@chromium.org, Oct 18 2017

Issue description

Cc: ka...@chromium.org
Components: -Infra>Client>ChromeOS Tests
Labels: OS-Chrome
Passed on chromeos2-*
Failed on chromeos6-*

Kalin has suggested that the chromeos6 Eves have nvme memory, which could be the problem with this test.
Cc: gwendal@chromium.org dlaurie@chromium.org
+gwendal and dlaurie whom may own or know whom owns NVMe sysfs behavior...

This looks like a NVMe bug, I am not sure this is an actual functional failure, just the NVMe partition does not seem to expose a size in sysfs.

...
10/16 16:42:58.613 WARNI|              test:0616| The test failed with the following exception
Traceback (most recent call last):
  File "/usr/local/autotest/common_lib/test.py", line 610, in _exec
    _call_test_function(self.execute, *p_args, **p_dargs)
  File "/usr/local/autotest/common_lib/test.py", line 824, in _call_test_function
    raise error.UnhandledTestFail(e)
UnhandledTestFail: Unhandled IOError: [Errno 2] No such file or directory: '/sys/block/nvme0n1/nvme0n13/size'
Traceback (most recent call last):
  File "/usr/local/autotest/common_lib/test.py", line 818, in _call_test_function
    return func(*args, **dargs)
  File "/usr/local/autotest/common_lib/test.py", line 471, in execute
    dargs)
  File "/usr/local/autotest/common_lib/test.py", line 348, in _call_run_once_with_retry
    postprocess_profiled_run, args, dargs)
  File "/usr/local/autotest/common_lib/test.py", line 381, in _call_run_once
    self.run_once(*args, **dargs)
  File "/usr/local/autotest/tests/platform_PartitionCheck/platform_PartitionCheck.py", line 66, in run_once
    pblocks = self.get_partition_size(device, p)
  File "/usr/local/autotest/tests/platform_PartitionCheck/platform_PartitionCheck.py", line 50, in get_partition_size
    part_blocks = int(utils.read_one_line(part_file))
  File "/usr/local/autotest/common_lib/utils.py", line 351, in read_one_line
    return open(filename, 'r').readline().rstrip('\n')
IOError: [Errno 2] No such file or directory: '/sys/block/nvme0n1/nvme0n13/size'

10/16 16:42:58.615 DEBUG|              test:0621| Running cleanup for test.
...

It does seem to be able to pass on non NVMe systems.


Comment 3 by sontis@chromium.org, Oct 26 2017

IOError: [Errno 2] No such file or directory: '/sys/block/nvme0n1/nvme0n13/size'

There is no /sys/block/nvme0n1/nvme0n13 directory on the device.

It should be  /sys/block/nvme0n1/nvme0n1p3/size

Need to change platform_PartitionCheck.py script.
Owner: gwendal@chromium.org
Status: Assigned (was: Untriaged)
Project Member

Comment 5 by bugdroid1@chromium.org, Oct 31 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/427c7b23118bf30175ef14327459a4db0adc381c

commit 427c7b23118bf30175ef14327459a4db0adc381c
Author: Gwendal Grignou <gwendal@chromium.org>
Date: Tue Oct 31 06:21:31 2017

utils: Add partition concatenation routine.

Follow kernel convention and add 'p' if the block device ends with a digit.
Fixes platform_PartitionCheck test.
Follow same method for faft test.

BUG= chromium:776029 
TEST=unit test, test latform_PartitionCheck on NVMe.

Change-Id: I61f2f194e149634e132a4ad548335ea7c10d8366
Signed-off-by: Gwendal Grignou <gwendal@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/741483
Reviewed-by: Sridhar Sonti <sontis@google.com>
Reviewed-by: Wai-Hong Tam <waihong@google.com>

[modify] https://crrev.com/427c7b23118bf30175ef14327459a4db0adc381c/client/bin/unit_test.py
[modify] https://crrev.com/427c7b23118bf30175ef14327459a4db0adc381c/client/bin/utils.py
[add] https://crrev.com/427c7b23118bf30175ef14327459a4db0adc381c/client/bin/utils_unittest.py
[modify] https://crrev.com/427c7b23118bf30175ef14327459a4db0adc381c/client/site_tests/platform_PartitionCheck/platform_PartitionCheck.py
[modify] https://crrev.com/427c7b23118bf30175ef14327459a4db0adc381c/client/cros/faft/utils/os_interface.py

Status: Fixed (was: Assigned)

Comment 7 by dchan@chromium.org, Jan 22 2018

Status: archived (was: Fixed)

Comment 8 by dchan@chromium.org, Jan 23 2018

Status: Fixed (was: Archived)

Sign in to add a comment