New issue
Advanced search Search tips

Issue 776028 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner: ----
Closed: Oct 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

1% regression in system_health.memory_desktop at 507947:507991

Project Member Reported by chiniforooshan@chromium.org, Oct 18 2017

Issue description

See the link to graphs below.
 
Project Member

Comment 1 by 42576172...@developer.gserviceaccount.com, Oct 18 2017

All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=776028

(For debugging:) Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?sid=8095d54ce93a18403457cf1bc0bc94c2dbf2f24597bf9229c5fd392faa0e6bb0


Bot(s) for this bug's original alert(s):

chromium-rel-win10
Project Member

Comment 3 by 42576172...@developer.gserviceaccount.com, Oct 18 2017

Cc: hajimehoshi@chromium.org
Owner: hajimehoshi@chromium.org
Status: Assigned (was: Untriaged)

=== Auto-CCing suspected CL author hajimehoshi@chromium.org ===

Hi hajimehoshi@chromium.org, the bisect results pointed to your CL, please take a look at the
results.


=== BISECT JOB RESULTS ===
Perf regression found with culprit

Suspected Commit
  Author : Hajime Hoshi
  Commit : 64853efbe61349fa76a5403ff9fb448638ffb585
  Date   : Wed Oct 11 12:56:07 2017
  Subject: scheduler: Add enum base::Nestable

Bisect Details
  Configuration: winx64_10_perf_bisect
  Benchmark    : system_health.memory_desktop
  Metric       : memory:chrome:all_processes:reported_by_chrome:malloc:effective_size_avg/load_tools/load_tools_docs
  Change       : 1.05% | 19068617.5556 -> 19262918.0

Revision             Result                  N
chromium@507946      19068618 +- 200183      9       good
chromium@507958      19106161 +- 406694      14      good
chromium@507960      19093963 +- 477633      21      good
chromium@507961      19210899 +- 362606      14      bad       <--
chromium@507964      19196553 +- 352420      14      bad
chromium@507969      19206804 +- 365412      14      bad
chromium@507991      19262918 +- 120004      9       bad

Please refer to the following doc on diagnosing memory regressions:
  https://chromium.googlesource.com/chromium/src/+/master/docs/memory-infra/memory_benchmarks.md

To Run This Test
  src/tools/perf/run_benchmark -v --browser=release_x64 --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests --story-filter=load.tools.docs system_health.memory_desktop

More information on addressing performance regressions:
  http://g.co/ChromePerformanceRegressions

Debug information about this bisect:
  https://chromeperf.appspot.com/buildbucket_job_status/8965372179497910336


For feedback, file a bug with component Speed>Bisection
Owner: ----
Status: Untriaged (was: Assigned)
I don't think my CL is the culprit
Kicked off a bisect on a wider range, since the graph slopes upward a bit. But it does show a pretty clear 100kib regression on the blamed CL.
Project Member

Comment 7 by 42576172...@developer.gserviceaccount.com, Oct 19 2017


=== BISECT JOB RESULTS ===
Perf regression found but unable to narrow commit range

Build failures prevented the bisect from narrowing the range further.


Bisect Details
  Configuration: winx64_10_perf_bisect
  Benchmark    : system_health.memory_desktop
  Metric       : memory:chrome:all_processes:reported_by_chrome:malloc:effective_size_avg/load_tools/load_tools_docs
  Change       : 0.82% | 19026014.4286 -> 19181417.2143

Suspected Commit Range
  2 commits in range
  https://chromium.googlesource.com/chromium/src/+log/d80115000b019541e58a4d5ac4433870b22b247e..41cec074f9d741d8c76801779e821f07d36ca4ec


Revision             Result                  N
chromium@507597      19026014 +- 287022      14       good
chromium@507914      19041051 +- 321908      14       good
chromium@507925      19094565 +- 898575      21       good
chromium@507929      19054165 +- 221625      14       good
chromium@507930      ---                     ---      build failure
chromium@507931      19311498 +- 670320      6        bad
chromium@507935      19144127 +- 266005      14       bad
chromium@507955      19115690 +- 450634      14       bad
chromium@507994      19174313 +- 441462      14       bad
chromium@508074      19207399 +- 125981      6        bad
chromium@508230      19181417 +- 435344      14       bad

Please refer to the following doc on diagnosing memory regressions:
  https://chromium.googlesource.com/chromium/src/+/master/docs/memory-infra/memory_benchmarks.md

To Run This Test
  src/tools/perf/run_benchmark -v --browser=release_x64 --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests --story-filter=load.tools.docs system_health.memory_desktop

More information on addressing performance regressions:
  http://g.co/ChromePerformanceRegressions

Debug information about this bisect:
  https://chromeperf.appspot.com/buildbucket_job_status/8965303011783087712


For feedback, file a bug with component Speed>Bisection
Retrying with a narrow range around chromium@507930.
Project Member

Comment 10 by 42576172...@developer.gserviceaccount.com, Oct 19 2017


=== BISECT JOB RESULTS ===
NO Perf regression found

Bisect Details
  Configuration: winx64_10_perf_bisect
  Benchmark    : system_health.memory_desktop
  Metric       : memory:chrome:all_processes:reported_by_chrome:malloc:effective_size_avg/load_tools/load_tools_docs

Revision             Result                  N
chromium@507925      19127334 +- 561505      21      good
chromium@507935      19123229 +- 368605      21      bad

Please refer to the following doc on diagnosing memory regressions:
  https://chromium.googlesource.com/chromium/src/+/master/docs/memory-infra/memory_benchmarks.md

To Run This Test
  src/tools/perf/run_benchmark -v --browser=release_x64 --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests --story-filter=load.tools.docs system_health.memory_desktop

More information on addressing performance regressions:
  http://g.co/ChromePerformanceRegressions

Debug information about this bisect:
  https://chromeperf.appspot.com/buildbucket_job_status/8965282903416367664


For feedback, file a bug with component Speed>Bisection
Status: WontFix (was: Untriaged)
In all 3 bisect jobs the noise is more than the regression.

Sign in to add a comment