New issue
Advanced search Search tips

Issue 776023 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug

Blocked on:
issue 775932



Sign in to add a comment

security_AccountsBaseline: move to ImageTest

Project Member Reported by jorgelo@chromium.org, Oct 18 2017

Issue description

It doesn't need to be an Autotest since it tests something static about the image. ImageTest runs a lot faster.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 23 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/9d9a0061904437ae08637d854491de780b6e1dbe

commit 9d9a0061904437ae08637d854491de780b6e1dbe
Author: Jorge Lucangeli Obes <jorgelo@chromium.org>
Date: Mon Oct 23 18:12:21 2017

Add user/group test to ImageTest.

ImageTest runs a lot faster than Autotest tests, and testing users and
groups doesn't need to happen on a live system.

BUG= chromium:776023 
TEST=test_image <path_to_caroline_image> --board=caroline
TEST=test_image <path_to_lakitu_image> --board=lakitu
TEST=test_image <path_to_whirlwind_image> --board=whirlwind
TEST=veyron_rialto-paladin trybot.

Change-Id: I345afcca329bed489331df3221096d9305627320
Reviewed-on: https://chromium-review.googlesource.com/726188
Commit-Ready: Jorge Lucangeli Obes <jorgelo@chromium.org>
Tested-by: Jorge Lucangeli Obes <jorgelo@chromium.org>
Reviewed-by: Jorge Lucangeli Obes <jorgelo@chromium.org>

[add] https://crrev.com/9d9a0061904437ae08637d854491de780b6e1dbe/cros/test/usergroup_baseline.py
[modify] https://crrev.com/9d9a0061904437ae08637d854491de780b6e1dbe/cros/test/image_test.py

Project Member

Comment 2 by bugdroid1@chromium.org, Oct 24 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/395fc1e057439e9bb5b6397c1ff7b1cde00ba72b

commit 395fc1e057439e9bb5b6397c1ff7b1cde00ba72b
Author: Jorge Lucangeli Obes <jorgelo@chromium.org>
Date: Tue Oct 24 22:30:18 2017

security_AccountsBaseline: Move to perbuild suite.

As of
https://chromium-review.googlesource.com/c/chromiumos/chromite/+/726188
we have user/group testing on ImageTest. Move this test to the perbuild
suite to avoid blocking the CQ with two different tests for the same
check.

BUG= chromium:776023 
TEST=test_that suite:bvt-inline --pretend | grep AccountsBaseline
TEST=test_that suite:bvt-perbuild --pretend | grep AccountsBaseline

Change-Id: I39cf62ac4440b717d9e9bcbd740c40171c31ff9e
Reviewed-on: https://chromium-review.googlesource.com/735744
Commit-Ready: Jorge Lucangeli Obes <jorgelo@chromium.org>
Tested-by: Jorge Lucangeli Obes <jorgelo@chromium.org>
Reviewed-by: Ben Chan <benchan@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/395fc1e057439e9bb5b6397c1ff7b1cde00ba72b/client/site_tests/security_AccountsBaseline/control

Status: Fixed (was: Assigned)

Comment 4 by vapier@chromium.org, Oct 25 2017

is the plan to leave the autotest behind for a release or two and then drop it completely ?
Maybe not an entire release, but maybe a couple more weeks, yeah.
Removal tracked on  issue 778091 .
Project Member

Comment 7 by bugdroid1@chromium.org, Oct 26 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/cb216ebf4ebe733e9b5e48672ecec281ab3001be

commit cb216ebf4ebe733e9b5e48672ecec281ab3001be
Author: Mike Frysinger <vapier@chromium.org>
Date: Thu Oct 26 04:59:06 2017

image_test: fix error handling with new bad users

Looks like holdover from the autotest migration.
Traceback (most recent call last):
  File ".../chromite/cros/test/image_test.py", line 580, in TestUsers
    self._CheckFile('passwd')
  File ".../chromite/cros/test/image_test.py", line 561, in _CheckFile
    is_valid = validate_func(details)
  File ".../chromite/cros/test/image_test.py", line 403, in _validate_passwd
    entry[0], entry.home)
TypeError: 'Collection_UserEntry' object does not support indexing

BUG= chromium:776023 
TEST=precq passes

Change-Id: I32b085e802f8f09eede4dfee201fa688df1b8e71
Reviewed-on: https://chromium-review.googlesource.com/738280
Commit-Ready: Mike Frysinger <vapier@chromium.org>
Tested-by: Mike Frysinger <vapier@chromium.org>
Reviewed-by: Jorge Lucangeli Obes <jorgelo@chromium.org>

[modify] https://crrev.com/cb216ebf4ebe733e9b5e48672ecec281ab3001be/cros/test/image_test.py

Project Member

Comment 8 by bugdroid1@chromium.org, Nov 8 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/3faaec2404c60c515425c081d5a06080ce1cdb60

commit 3faaec2404c60c515425c081d5a06080ce1cdb60
Author: Jorge Lucangeli Obes <jorgelo@chromium.org>
Date: Wed Nov 08 11:12:28 2017

security_AccountsBaseline: Don't run on any suites.

The ImageTest user/group test seems to be working, I haven't been sent
death threats and there are no picket lines outside my office, so it
looks like we can deprecate AccountsBaseline.

BUG= chromium:776023 
TEST=test_that --pretend suite:bvt-perbuild | grep Accounts

Change-Id: I61db33c5e645943d19701642156a50ed0fa97c5d
Reviewed-on: https://chromium-review.googlesource.com/757089
Commit-Ready: Jorge Lucangeli Obes <jorgelo@chromium.org>
Tested-by: Jorge Lucangeli Obes <jorgelo@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/3faaec2404c60c515425c081d5a06080ce1cdb60/client/site_tests/security_AccountsBaseline/control

Project Member

Comment 9 by bugdroid1@chromium.org, Nov 8 2017

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chromeos/overlays/overlay-storm-private/+/9ecbcad2b2fdd213a5cb4ced555a10d95867ac32

commit 9ecbcad2b2fdd213a5cb4ced555a10d95867ac32
Author: Jorge Lucangeli Obes <jorgelo@chromium.org>
Date: Wed Nov 08 19:47:56 2017

Project Member

Comment 10 by bugdroid1@chromium.org, Nov 8 2017

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chromeos/overlays/overlay-lakitu-nc-private/+/a6edad38c8c8c4e63c38b78ab00642047145d5c2

commit a6edad38c8c8c4e63c38b78ab00642047145d5c2
Author: Jorge Lucangeli Obes <jorgelo@chromium.org>
Date: Wed Nov 08 19:47:57 2017

Project Member

Comment 11 by bugdroid1@chromium.org, Nov 8 2017

Project Member

Comment 12 by bugdroid1@chromium.org, Nov 8 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/board-overlays/+/c6d40496ddd94f229f45650da5e7e6609453d049

commit c6d40496ddd94f229f45650da5e7e6609453d049
Author: Jorge Lucangeli Obes <jorgelo@chromium.org>
Date: Wed Nov 08 19:47:56 2017

Remove security_AccountsBaseline USE flag.

The test is no longer run on any suites.

BUG= chromium:776023 
TEST=None

Change-Id: Idab857c40694c3d0137fd33b7a426a834ee8b889
Reviewed-on: https://chromium-review.googlesource.com/757192
Commit-Ready: Jorge Lucangeli Obes <jorgelo@chromium.org>
Tested-by: Jorge Lucangeli Obes <jorgelo@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/c6d40496ddd94f229f45650da5e7e6609453d049/project-mobbase/profiles/base/make.defaults

Project Member

Comment 13 by bugdroid1@chromium.org, Nov 8 2017

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chromeos/overlays/project-jetstream-private/+/83f7f34672f29d82fca441774f0d5b03ea3f42aa

commit 83f7f34672f29d82fca441774f0d5b03ea3f42aa
Author: Jorge Lucangeli Obes <jorgelo@chromium.org>
Date: Wed Nov 08 19:47:56 2017

Project Member

Comment 14 by bugdroid1@chromium.org, Nov 8 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/4c295fd009299ab5b0f2ecdb99cd8e9ee28a56cf

commit 4c295fd009299ab5b0f2ecdb99cd8e9ee28a56cf
Author: Jorge Lucangeli Obes <jorgelo@chromium.org>
Date: Wed Nov 08 23:10:14 2017

Don't install security_AccountsBaseline.

Superseded by an ImageTest.

BUG= chromium:776023 
TEST=None
CQ-DEPEND=CL:757089

Change-Id: I5d36db02b6511c54dfff373e21bc275ed609572f
Reviewed-on: https://chromium-review.googlesource.com/756870
Commit-Ready: Jorge Lucangeli Obes <jorgelo@chromium.org>
Tested-by: Jorge Lucangeli Obes <jorgelo@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/4c295fd009299ab5b0f2ecdb99cd8e9ee28a56cf/chromeos-base/autotest-tests-security/autotest-tests-security-9999.ebuild

Sign in to add a comment