New issue
Advanced search Search tips

Issue 776012 link

Starred by 3 users

Issue metadata

Status: Verified
Owner:
Closed: Oct 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug


Participants' hotlists:
Fixing-touch


Sign in to add a comment

Cros splitview - The indicator doesn't show correctly when in portrait mode

Project Member Reported by x...@chromium.org, Oct 18 2017

Issue description

Steps:
- Enter into tablet mode
- Rotate the screen to portrait mode
- Enter overview mode
- Tap on an overview window item

The indicator should show on top/bottom part of the screen, not left/right side of the screen.
 

Comment 1 by x...@chromium.org, Oct 18 2017

Description: Show this description
Project Member

Comment 2 by bugdroid1@chromium.org, Oct 25 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bc2e913bd7fbf429655bf3f950f33ddfd9a4437c

commit bc2e913bd7fbf429655bf3f950f33ddfd9a4437c
Author: Sammie Quon <sammiequon@google.com>
Date: Wed Oct 25 22:28:26 2017

splitview: Show splitview indicators correctly in portrait mode.

The indicators are now correctly placed on the top and bottom of the
screens when the device is in portrait mode.

Test: manual
Bug:  776012 
Change-Id: If7a83c24918dd57d079f0553b075817f75895aba
Reviewed-on: https://chromium-review.googlesource.com/736651
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Reviewed-by: Xiaoqian Dai <xdai@chromium.org>
Commit-Queue: Sammie Quon <sammiequon@chromium.org>
Cr-Commit-Position: refs/heads/master@{#511617}
[modify] https://crrev.com/bc2e913bd7fbf429655bf3f950f33ddfd9a4437c/ash/wm/overview/window_selector.cc
[modify] https://crrev.com/bc2e913bd7fbf429655bf3f950f33ddfd9a4437c/ash/wm/splitview/split_view_overview_overlay.cc
[modify] https://crrev.com/bc2e913bd7fbf429655bf3f950f33ddfd9a4437c/ash/wm/splitview/split_view_overview_overlay.h

Status: Fixed (was: Assigned)
Status: Verified (was: Fixed)
Device in portrait mode and selecting overview mode display, the app windows are displayed in portrait style (not like landscape style).
Verified on M64 dev build (10115.0.0, 64.0.3264.0).

Sign in to add a comment