Reconcile the multiple GLImageDXGI types |
||||||
Issue descriptionThere are several GLImageDXGI implementations. These should be merged and have more implementation sharing. In particular, the GLImageDXGIHandle name seems confusing (the type isn't really handle-specific, just the way it is initialized).
,
Oct 27 2017
Windows-specific cleanup opportunity.
,
Oct 29
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue. Sorry for the inconvenience if the bug really should have been left as Available. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Nov 2
zmo: Is this something we still want to do? Assigning to you for triage.
,
Nov 2
It seems the situation is still there. Maggie, can you evaluate the situation? It is a local cleanup request and may be good for code health.
,
Dec 12
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b8f360001c28e2065717f7fa72e2d722a4b31ed1 commit b8f360001c28e2065717f7fa72e2d722a4b31ed1 Author: Maggie Chen <magchen@chromium.org> Date: Wed Dec 12 01:48:13 2018 Reconcile the multiple GLImageDXGI types (1) Merge GLImageDXGIHandle into GLImageDXGI. For those three override functions BindTexImage(), GetInternalFormat() and ReleaseTexImage(), Check handle_ before continuing processing handle related code. Rename GLImageDXGIHandle::Initialize() to GLImageDXGI::InitializeHandle() (2) Merge GLImageDXGIBase into GLImageDXGI. Bug:776010 Change-Id: Id2906a4fcb19e4286c13f718ae1913e73994d303 Reviewed-on: https://chromium-review.googlesource.com/c/1361588 Commit-Queue: Maggie Chen <magchen@chromium.org> Reviewed-by: Zhenyao Mo <zmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#615770} [modify] https://crrev.com/b8f360001c28e2065717f7fa72e2d722a4b31ed1/gpu/ipc/service/direct_composition_surface_win.cc [modify] https://crrev.com/b8f360001c28e2065717f7fa72e2d722a4b31ed1/gpu/ipc/service/direct_composition_surface_win_unittest.cc [modify] https://crrev.com/b8f360001c28e2065717f7fa72e2d722a4b31ed1/gpu/ipc/service/gpu_memory_buffer_factory_dxgi.cc [modify] https://crrev.com/b8f360001c28e2065717f7fa72e2d722a4b31ed1/ui/gl/gl_image_dxgi.cc [modify] https://crrev.com/b8f360001c28e2065717f7fa72e2d722a4b31ed1/ui/gl/gl_image_dxgi.h [modify] https://crrev.com/b8f360001c28e2065717f7fa72e2d722a4b31ed1/ui/gl/gl_image_dxgi_unittest.cc
,
Dec 12
Thanks Maggie for cleaning this up! |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by dtapu...@chromium.org
, Oct 25 2017