Issue 776009 link

Starred by 0 users

Issue metadata

Status:	Fixed
Owner:	dgozman@chromium.org
Closed:	Feb 2018
Components:	Platform>DevTools
EstimatedDays:	----
NextAction:	----
OS:	----
Pri:	2
Type:	Bug

DevTools: move DevTools from IPC to Mojo

Project Member Reported by dgozman@chromium.org, Oct 18 2017

Issue description

This includes everything in devtools_messages.h.

Project Member

Comment 1 by bugdroid1@chromium.org, Oct 25 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/10252c138c60cf614ecd7e3bfa2971dc46c8b5f8

commit 10252c138c60cf614ecd7e3bfa2971dc46c8b5f8
Author: Dmitry Gozman <dgozman@chromium.org>
Date: Wed Oct 25 05:12:24 2017

[DevTools] Migrate DevToolsFrontendHost from IPC to Mojo

Bug:  776009 
Change-Id: I700fbc3a999a3d1cad84572619a250c40ac9314a
Reviewed-on: https://chromium-review.googlesource.com/726369
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#511376}
[modify] https://crrev.com/10252c138c60cf614ecd7e3bfa2971dc46c8b5f8/content/browser/devtools/devtools_frontend_host_impl.cc
[modify] https://crrev.com/10252c138c60cf614ecd7e3bfa2971dc46c8b5f8/content/browser/devtools/devtools_frontend_host_impl.h
[modify] https://crrev.com/10252c138c60cf614ecd7e3bfa2971dc46c8b5f8/content/common/BUILD.gn
[add] https://crrev.com/10252c138c60cf614ecd7e3bfa2971dc46c8b5f8/content/common/devtools.mojom
[modify] https://crrev.com/10252c138c60cf614ecd7e3bfa2971dc46c8b5f8/content/common/devtools_messages.h
[modify] https://crrev.com/10252c138c60cf614ecd7e3bfa2971dc46c8b5f8/content/renderer/BUILD.gn
[modify] https://crrev.com/10252c138c60cf614ecd7e3bfa2971dc46c8b5f8/content/renderer/devtools/devtools_agent.cc
[modify] https://crrev.com/10252c138c60cf614ecd7e3bfa2971dc46c8b5f8/content/renderer/devtools/devtools_agent.h
[delete] https://crrev.com/c489f2c7dca913aa85f6cd3a8d23419086c8df59/content/renderer/devtools/devtools_client.cc
[delete] https://crrev.com/c489f2c7dca913aa85f6cd3a8d23419086c8df59/content/renderer/devtools/devtools_client.h
[add] https://crrev.com/10252c138c60cf614ecd7e3bfa2971dc46c8b5f8/content/renderer/devtools/devtools_frontend_impl.cc
[add] https://crrev.com/10252c138c60cf614ecd7e3bfa2971dc46c8b5f8/content/renderer/devtools/devtools_frontend_impl.h
[modify] https://crrev.com/10252c138c60cf614ecd7e3bfa2971dc46c8b5f8/content/renderer/render_frame_impl.cc

Comment 2 by horo@chromium.org, Oct 25 2017

This change 10252c138c60cf614ecd7e3bfa2971dc46c8b5f8 introduced LayoutTest crashes in Debug build.

https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=webkit_tests&tests=inspector-protocol

Project Member

Comment 3 by bugdroid1@chromium.org, Oct 25 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dc2a455cdcd398559034bbd761deaab0be871b11

commit dc2a455cdcd398559034bbd761deaab0be871b11
Author: Vasilii Sukhanov <vasilii@chromium.org>
Date: Wed Oct 25 09:28:47 2017

Revert "[DevTools] Migrate DevToolsFrontendHost from IPC to Mojo"

This reverts commit 10252c138c60cf614ecd7e3bfa2971dc46c8b5f8.

Reason for revert: Massive failures of http/tests/inspector-protocol/network on different bots. E.g.
https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Linux%20Trusty%20ASAN/builds/6289
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20Trusty%20%28dbg%29/builds/6376

Original change's description:
> [DevTools] Migrate DevToolsFrontendHost from IPC to Mojo
> 
> Bug:  776009 
> Change-Id: I700fbc3a999a3d1cad84572619a250c40ac9314a
> Reviewed-on: https://chromium-review.googlesource.com/726369
> Reviewed-by: Daniel Cheng <dcheng@chromium.org>
> Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
> Reviewed-by: Kentaro Hara <haraken@chromium.org>
> Commit-Queue: Dmitry Gozman <dgozman@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#511376}

TBR=dgozman@chromium.org,dcheng@chromium.org,haraken@chromium.org,pfeldman@chromium.org

Change-Id: Ic24f4edf15da8ae6ce4cefa0db10e76ef9a5b46a
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  776009 
Reviewed-on: https://chromium-review.googlesource.com/738049
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#511406}
[modify] https://crrev.com/dc2a455cdcd398559034bbd761deaab0be871b11/content/browser/devtools/devtools_frontend_host_impl.cc
[modify] https://crrev.com/dc2a455cdcd398559034bbd761deaab0be871b11/content/browser/devtools/devtools_frontend_host_impl.h
[modify] https://crrev.com/dc2a455cdcd398559034bbd761deaab0be871b11/content/common/BUILD.gn
[delete] https://crrev.com/f4a81f61f3ddddfb36701a674d1d0ace4bd38e3c/content/common/devtools.mojom
[modify] https://crrev.com/dc2a455cdcd398559034bbd761deaab0be871b11/content/common/devtools_messages.h
[modify] https://crrev.com/dc2a455cdcd398559034bbd761deaab0be871b11/content/renderer/BUILD.gn
[modify] https://crrev.com/dc2a455cdcd398559034bbd761deaab0be871b11/content/renderer/devtools/devtools_agent.cc
[modify] https://crrev.com/dc2a455cdcd398559034bbd761deaab0be871b11/content/renderer/devtools/devtools_agent.h
[add] https://crrev.com/dc2a455cdcd398559034bbd761deaab0be871b11/content/renderer/devtools/devtools_client.cc
[add] https://crrev.com/dc2a455cdcd398559034bbd761deaab0be871b11/content/renderer/devtools/devtools_client.h
[delete] https://crrev.com/f4a81f61f3ddddfb36701a674d1d0ace4bd38e3c/content/renderer/devtools/devtools_frontend_impl.cc
[delete] https://crrev.com/f4a81f61f3ddddfb36701a674d1d0ace4bd38e3c/content/renderer/devtools/devtools_frontend_impl.h
[modify] https://crrev.com/dc2a455cdcd398559034bbd761deaab0be871b11/content/renderer/render_frame_impl.cc

Project Member

Comment 4 by bugdroid1@chromium.org, Oct 25 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7f95c8453a369c61e3c2bf23a7fb7c8ea60b1e6b

commit 7f95c8453a369c61e3c2bf23a7fb7c8ea60b1e6b
Author: Dmitry Gozman <dgozman@chromium.org>
Date: Wed Oct 25 22:13:00 2017

Reland "[DevTools] Migrate DevToolsFrontendHost from IPC to Mojo"

This is a reland of 10252c138c60cf614ecd7e3bfa2971dc46c8b5f8
Original change's description:
> [DevTools] Migrate DevToolsFrontendHost from IPC to Mojo
> 
> Bug:  776009 
> Change-Id: I700fbc3a999a3d1cad84572619a250c40ac9314a
> Reviewed-on: https://chromium-review.googlesource.com/726369
> Reviewed-by: Daniel Cheng <dcheng@chromium.org>
> Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
> Reviewed-by: Kentaro Hara <haraken@chromium.org>
> Commit-Queue: Dmitry Gozman <dgozman@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#511376}

TBR=pfeldman@chromium.org

Bug:  776009 
Change-Id: If68607acd73df7bdb9f264b117997283f945a5c8
Reviewed-on: https://chromium-review.googlesource.com/738219
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#511611}
[modify] https://crrev.com/7f95c8453a369c61e3c2bf23a7fb7c8ea60b1e6b/content/browser/devtools/devtools_frontend_host_impl.cc
[modify] https://crrev.com/7f95c8453a369c61e3c2bf23a7fb7c8ea60b1e6b/content/browser/devtools/devtools_frontend_host_impl.h
[modify] https://crrev.com/7f95c8453a369c61e3c2bf23a7fb7c8ea60b1e6b/content/common/BUILD.gn
[add] https://crrev.com/7f95c8453a369c61e3c2bf23a7fb7c8ea60b1e6b/content/common/devtools.mojom
[modify] https://crrev.com/7f95c8453a369c61e3c2bf23a7fb7c8ea60b1e6b/content/common/devtools_messages.h
[modify] https://crrev.com/7f95c8453a369c61e3c2bf23a7fb7c8ea60b1e6b/content/renderer/BUILD.gn
[modify] https://crrev.com/7f95c8453a369c61e3c2bf23a7fb7c8ea60b1e6b/content/renderer/devtools/devtools_agent.cc
[modify] https://crrev.com/7f95c8453a369c61e3c2bf23a7fb7c8ea60b1e6b/content/renderer/devtools/devtools_agent.h
[delete] https://crrev.com/3a39697331644a941b6501db7907c6942c7d8b3a/content/renderer/devtools/devtools_client.cc
[delete] https://crrev.com/3a39697331644a941b6501db7907c6942c7d8b3a/content/renderer/devtools/devtools_client.h
[add] https://crrev.com/7f95c8453a369c61e3c2bf23a7fb7c8ea60b1e6b/content/renderer/devtools/devtools_frontend_impl.cc
[add] https://crrev.com/7f95c8453a369c61e3c2bf23a7fb7c8ea60b1e6b/content/renderer/devtools/devtools_frontend_impl.h
[modify] https://crrev.com/7f95c8453a369c61e3c2bf23a7fb7c8ea60b1e6b/content/renderer/render_frame_impl.cc
[modify] https://crrev.com/7f95c8453a369c61e3c2bf23a7fb7c8ea60b1e6b/third_party/WebKit/Source/core/exported/WebDevToolsFrontendImpl.cpp

Project Member

Comment 5 by bugdroid1@chromium.org, Oct 26 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7a955d2eaaa66336268b5e91118cd812dc28664d

commit 7a955d2eaaa66336268b5e91118cd812dc28664d
Author: Dmitry Gozman <dgozman@chromium.org>
Date: Thu Oct 26 22:32:48 2017

[DevTools] Only recreate DevToolsFrontendHost if the frame has changed

We used to recreate DevToolsFrontendHost on any navigation and rely
on the fact that destroying old instance does not cleanup in the
renderer. This has changed with migration to mojo, where we do
properly cleanup.

Bug:  776009 ,  778525 
Change-Id: I23c8a9d959e92eae394ac5029a0ac1b160363654
Reviewed-on: https://chromium-review.googlesource.com/740087
Commit-Queue: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Andrey Kosyakov <caseq@chromium.org>
Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#511988}
[modify] https://crrev.com/7a955d2eaaa66336268b5e91118cd812dc28664d/chrome/browser/devtools/devtools_ui_bindings.cc

Project Member

Comment 6 by bugdroid1@chromium.org, Nov 9 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/98355925bbbf29eba6fd063ba330b96a7dc8504c

commit 98355925bbbf29eba6fd063ba330b96a7dc8504c
Author: Dmitry Gozman <dgozman@chromium.org>
Date: Thu Nov 09 16:49:38 2017

Expose associated interfaces in blink::InterfaceRegistry

This allows blink to register associated to frame interfaces. One
example would be DevToolsFrontend, which could be implemented
directly in blink, but must be associated for relative ordering
with navigations.

Bug:  776009 
Change-Id: I9657a8eb9ae758008f55e482dd91330e3b15a761
Reviewed-on: https://chromium-review.googlesource.com/728726
Commit-Queue: Dmitry Gozman <dgozman@chromium.org>
Reviewed-by: Ken Rockot <rockot@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#515182}
[modify] https://crrev.com/98355925bbbf29eba6fd063ba330b96a7dc8504c/content/common/associated_interface_registry_impl.cc
[modify] https://crrev.com/98355925bbbf29eba6fd063ba330b96a7dc8504c/content/common/associated_interface_registry_impl.h
[modify] https://crrev.com/98355925bbbf29eba6fd063ba330b96a7dc8504c/content/renderer/mojo/blink_interface_registry_impl.cc
[modify] https://crrev.com/98355925bbbf29eba6fd063ba330b96a7dc8504c/content/renderer/mojo/blink_interface_registry_impl.h
[modify] https://crrev.com/98355925bbbf29eba6fd063ba330b96a7dc8504c/content/renderer/render_frame_impl.cc
[modify] https://crrev.com/98355925bbbf29eba6fd063ba330b96a7dc8504c/content/renderer/render_thread_impl.cc
[modify] https://crrev.com/98355925bbbf29eba6fd063ba330b96a7dc8504c/third_party/WebKit/Source/platform/exported/InterfaceRegistry.cpp
[modify] https://crrev.com/98355925bbbf29eba6fd063ba330b96a7dc8504c/third_party/WebKit/public/platform/InterfaceRegistry.h

Project Member

Comment 7 by bugdroid1@chromium.org, Nov 14 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b42d3973aa4df943084346a023478032a48ab4f2

commit b42d3973aa4df943084346a023478032a48ab4f2
Author: Dmitry Gozman <dgozman@chromium.org>
Date: Tue Nov 14 04:38:19 2017

[DevTools] Move DevToolsFrontend implementation from content/renderer to blink

Bug:  776009 
Change-Id: I949313b261ae074844d1da349570e1e0a8e23744
Reviewed-on: https://chromium-review.googlesource.com/739746
Commit-Queue: Dmitry Gozman <dgozman@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516193}
[modify] https://crrev.com/b42d3973aa4df943084346a023478032a48ab4f2/content/browser/DEPS
[modify] https://crrev.com/b42d3973aa4df943084346a023478032a48ab4f2/content/browser/devtools/devtools_frontend_host_impl.cc
[modify] https://crrev.com/b42d3973aa4df943084346a023478032a48ab4f2/content/browser/devtools/devtools_frontend_host_impl.h
[modify] https://crrev.com/b42d3973aa4df943084346a023478032a48ab4f2/content/common/devtools.mojom
[modify] https://crrev.com/b42d3973aa4df943084346a023478032a48ab4f2/content/renderer/BUILD.gn
[delete] https://crrev.com/0ecd0c6269dc111247f6b3d678253e8c3bdd6480/content/renderer/devtools/devtools_frontend_impl.cc
[delete] https://crrev.com/0ecd0c6269dc111247f6b3d678253e8c3bdd6480/content/renderer/devtools/devtools_frontend_impl.h
[modify] https://crrev.com/b42d3973aa4df943084346a023478032a48ab4f2/content/renderer/render_frame_impl.cc
[modify] https://crrev.com/b42d3973aa4df943084346a023478032a48ab4f2/third_party/WebKit/Source/controller/BUILD.gn
[modify] https://crrev.com/b42d3973aa4df943084346a023478032a48ab4f2/third_party/WebKit/Source/controller/BlinkInitializer.cpp
[modify] https://crrev.com/b42d3973aa4df943084346a023478032a48ab4f2/third_party/WebKit/Source/controller/BlinkInitializer.h
[add] https://crrev.com/b42d3973aa4df943084346a023478032a48ab4f2/third_party/WebKit/Source/controller/DevToolsFrontendImpl.cpp
[add] https://crrev.com/b42d3973aa4df943084346a023478032a48ab4f2/third_party/WebKit/Source/controller/DevToolsFrontendImpl.h
[modify] https://crrev.com/b42d3973aa4df943084346a023478032a48ab4f2/third_party/WebKit/Source/core/CoreExport.h
[modify] https://crrev.com/b42d3973aa4df943084346a023478032a48ab4f2/third_party/WebKit/Source/core/exported/BUILD.gn
[modify] https://crrev.com/b42d3973aa4df943084346a023478032a48ab4f2/third_party/WebKit/Source/core/exported/LocalFrameClientImpl.cpp
[delete] https://crrev.com/0ecd0c6269dc111247f6b3d678253e8c3bdd6480/third_party/WebKit/Source/core/exported/WebDevToolsFrontendImpl.cpp
[delete] https://crrev.com/0ecd0c6269dc111247f6b3d678253e8c3bdd6480/third_party/WebKit/Source/core/exported/WebDevToolsFrontendImpl.h
[modify] https://crrev.com/b42d3973aa4df943084346a023478032a48ab4f2/third_party/WebKit/Source/core/frame/WebLocalFrameImpl.cpp
[modify] https://crrev.com/b42d3973aa4df943084346a023478032a48ab4f2/third_party/WebKit/Source/core/frame/WebLocalFrameImpl.h
[modify] https://crrev.com/b42d3973aa4df943084346a023478032a48ab4f2/third_party/WebKit/Source/core/inspector/DevToolsHost.cpp
[modify] https://crrev.com/b42d3973aa4df943084346a023478032a48ab4f2/third_party/WebKit/Source/core/inspector/DevToolsHost.h
[modify] https://crrev.com/b42d3973aa4df943084346a023478032a48ab4f2/third_party/WebKit/Source/core/inspector/InspectorFrontendClient.h
[modify] https://crrev.com/b42d3973aa4df943084346a023478032a48ab4f2/third_party/WebKit/Source/modules/ModulesInitializer.h
[modify] https://crrev.com/b42d3973aa4df943084346a023478032a48ab4f2/third_party/WebKit/public/BUILD.gn
[delete] https://crrev.com/0ecd0c6269dc111247f6b3d678253e8c3bdd6480/third_party/WebKit/public/web/WebDevToolsFrontend.h
[delete] https://crrev.com/0ecd0c6269dc111247f6b3d678253e8c3bdd6480/third_party/WebKit/public/web/WebDevToolsFrontendClient.h
[add] https://crrev.com/b42d3973aa4df943084346a023478032a48ab4f2/third_party/WebKit/public/web/devtools_frontend.mojom

Project Member

Comment 8 by bugdroid1@chromium.org, Nov 14 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ffe3596f7c133aee9d6534278899db104dc7c292

commit ffe3596f7c133aee9d6534278899db104dc7c292
Author: Dirk Pranke <dpranke@chromium.org>
Date: Tue Nov 14 05:38:15 2017

Revert "[DevTools] Move DevToolsFrontend implementation from content/renderer to blink"

This reverts commit b42d3973aa4df943084346a023478032a48ab4f2.

Reason for revert: Another export failure on the newly added MSVC debug bot win-msvc-dbg: https://build.chromium.org/p/chromium.win/builders/WinMSVC64%20%28dbg%29/builds/6 Sorry!

Original change's description:
> [DevTools] Move DevToolsFrontend implementation from content/renderer to blink
> 
> Bug:  776009 
> Change-Id: I949313b261ae074844d1da349570e1e0a8e23744
> Reviewed-on: https://chromium-review.googlesource.com/739746
> Commit-Queue: Dmitry Gozman <dgozman@chromium.org>
> Reviewed-by: Kentaro Hara <haraken@chromium.org>
> Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
> Reviewed-by: Daniel Cheng <dcheng@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#516193}

TBR=dgozman@chromium.org,dcheng@chromium.org,tasak@google.com,haraken@chromium.org,pfeldman@chromium.org

Change-Id: Iec60ab02cdb7d30e0862deada873359d28b6a1f0
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  776009 
Reviewed-on: https://chromium-review.googlesource.com/768547
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Dirk Pranke <dpranke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516200}
[modify] https://crrev.com/ffe3596f7c133aee9d6534278899db104dc7c292/content/browser/DEPS
[modify] https://crrev.com/ffe3596f7c133aee9d6534278899db104dc7c292/content/browser/devtools/devtools_frontend_host_impl.cc
[modify] https://crrev.com/ffe3596f7c133aee9d6534278899db104dc7c292/content/browser/devtools/devtools_frontend_host_impl.h
[modify] https://crrev.com/ffe3596f7c133aee9d6534278899db104dc7c292/content/common/devtools.mojom
[modify] https://crrev.com/ffe3596f7c133aee9d6534278899db104dc7c292/content/renderer/BUILD.gn
[add] https://crrev.com/ffe3596f7c133aee9d6534278899db104dc7c292/content/renderer/devtools/devtools_frontend_impl.cc
[add] https://crrev.com/ffe3596f7c133aee9d6534278899db104dc7c292/content/renderer/devtools/devtools_frontend_impl.h
[modify] https://crrev.com/ffe3596f7c133aee9d6534278899db104dc7c292/content/renderer/render_frame_impl.cc
[modify] https://crrev.com/ffe3596f7c133aee9d6534278899db104dc7c292/third_party/WebKit/Source/controller/BUILD.gn
[modify] https://crrev.com/ffe3596f7c133aee9d6534278899db104dc7c292/third_party/WebKit/Source/controller/BlinkInitializer.cpp
[modify] https://crrev.com/ffe3596f7c133aee9d6534278899db104dc7c292/third_party/WebKit/Source/controller/BlinkInitializer.h
[delete] https://crrev.com/68ecbdc5f3ce8557a26936f9a47062208f418ba9/third_party/WebKit/Source/controller/DevToolsFrontendImpl.cpp
[delete] https://crrev.com/68ecbdc5f3ce8557a26936f9a47062208f418ba9/third_party/WebKit/Source/controller/DevToolsFrontendImpl.h
[modify] https://crrev.com/ffe3596f7c133aee9d6534278899db104dc7c292/third_party/WebKit/Source/core/CoreExport.h
[modify] https://crrev.com/ffe3596f7c133aee9d6534278899db104dc7c292/third_party/WebKit/Source/core/exported/BUILD.gn
[modify] https://crrev.com/ffe3596f7c133aee9d6534278899db104dc7c292/third_party/WebKit/Source/core/exported/LocalFrameClientImpl.cpp
[add] https://crrev.com/ffe3596f7c133aee9d6534278899db104dc7c292/third_party/WebKit/Source/core/exported/WebDevToolsFrontendImpl.cpp
[add] https://crrev.com/ffe3596f7c133aee9d6534278899db104dc7c292/third_party/WebKit/Source/core/exported/WebDevToolsFrontendImpl.h
[modify] https://crrev.com/ffe3596f7c133aee9d6534278899db104dc7c292/third_party/WebKit/Source/core/frame/WebLocalFrameImpl.cpp
[modify] https://crrev.com/ffe3596f7c133aee9d6534278899db104dc7c292/third_party/WebKit/Source/core/frame/WebLocalFrameImpl.h
[modify] https://crrev.com/ffe3596f7c133aee9d6534278899db104dc7c292/third_party/WebKit/Source/core/inspector/DevToolsHost.cpp
[modify] https://crrev.com/ffe3596f7c133aee9d6534278899db104dc7c292/third_party/WebKit/Source/core/inspector/DevToolsHost.h
[modify] https://crrev.com/ffe3596f7c133aee9d6534278899db104dc7c292/third_party/WebKit/Source/core/inspector/InspectorFrontendClient.h
[modify] https://crrev.com/ffe3596f7c133aee9d6534278899db104dc7c292/third_party/WebKit/Source/modules/ModulesInitializer.h
[modify] https://crrev.com/ffe3596f7c133aee9d6534278899db104dc7c292/third_party/WebKit/public/BUILD.gn
[add] https://crrev.com/ffe3596f7c133aee9d6534278899db104dc7c292/third_party/WebKit/public/web/WebDevToolsFrontend.h
[add] https://crrev.com/ffe3596f7c133aee9d6534278899db104dc7c292/third_party/WebKit/public/web/WebDevToolsFrontendClient.h
[delete] https://crrev.com/68ecbdc5f3ce8557a26936f9a47062208f418ba9/third_party/WebKit/public/web/devtools_frontend.mojom

Project Member

Comment 9 by bugdroid1@chromium.org, Nov 15 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/92da1b776aa44a2a73d60d873c9f0bf45a639131

commit 92da1b776aa44a2a73d60d873c9f0bf45a639131
Author: Dmitry Gozman <dgozman@chromium.org>
Date: Wed Nov 15 22:23:51 2017

[DevTools] Annotate RequestNewWindow message with session_id

... to properly route the response back. This will be mandatory
after switching to Mojo (as this message will be session-scoped),
so we should prepare in advance.

TBR=pfeldman

Bug:  776009 
Change-Id: I17b771ebe4535504eb0ab5c26ba7240f3eb66e73
Reviewed-on: https://chromium-review.googlesource.com/772270
Commit-Queue: Dmitry Gozman <dgozman@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516859}
[modify] https://crrev.com/92da1b776aa44a2a73d60d873c9f0bf45a639131/content/browser/devtools/render_frame_devtools_agent_host.cc
[modify] https://crrev.com/92da1b776aa44a2a73d60d873c9f0bf45a639131/content/browser/devtools/render_frame_devtools_agent_host.h
[modify] https://crrev.com/92da1b776aa44a2a73d60d873c9f0bf45a639131/content/common/devtools_messages.h
[modify] https://crrev.com/92da1b776aa44a2a73d60d873c9f0bf45a639131/content/renderer/devtools/devtools_agent.cc
[modify] https://crrev.com/92da1b776aa44a2a73d60d873c9f0bf45a639131/content/renderer/devtools/devtools_agent.h
[modify] https://crrev.com/92da1b776aa44a2a73d60d873c9f0bf45a639131/third_party/WebKit/Source/core/exported/WebDevToolsAgentImpl.cpp
[modify] https://crrev.com/92da1b776aa44a2a73d60d873c9f0bf45a639131/third_party/WebKit/Source/core/exported/WebDevToolsAgentImpl.h
[modify] https://crrev.com/92da1b776aa44a2a73d60d873c9f0bf45a639131/third_party/WebKit/Source/core/inspector/InspectorPageAgent.cpp
[modify] https://crrev.com/92da1b776aa44a2a73d60d873c9f0bf45a639131/third_party/WebKit/Source/core/inspector/InspectorPageAgent.h
[modify] https://crrev.com/92da1b776aa44a2a73d60d873c9f0bf45a639131/third_party/WebKit/public/web/WebDevToolsAgent.h
[modify] https://crrev.com/92da1b776aa44a2a73d60d873c9f0bf45a639131/third_party/WebKit/public/web/WebDevToolsAgentClient.h

Project Member

Comment 10 by bugdroid1@chromium.org, Nov 15 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d19fe4ae5e66db17736f5f361d8ae77293a38365

commit d19fe4ae5e66db17736f5f361d8ae77293a38365
Author: Dmitry Gozman <dgozman@chromium.org>
Date: Wed Nov 15 22:29:37 2017

[DevTools] Decouple SendChunkedProtocolMessage between implementations

... in preparation for Mojo migration, which we'll do in stages.
Drive-by: refactored per caseq's suggestion and eliminated one
string copy by moving it around.

Bug:  776009 
Change-Id: I3281b0d6fa3000a5c73e688983f724fbe9d509b6
Reviewed-on: https://chromium-review.googlesource.com/772373
Commit-Queue: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Andrey Kosyakov <caseq@chromium.org>
Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516863}
[modify] https://crrev.com/d19fe4ae5e66db17736f5f361d8ae77293a38365/content/renderer/devtools/devtools_agent.cc
[modify] https://crrev.com/d19fe4ae5e66db17736f5f361d8ae77293a38365/content/renderer/devtools/devtools_agent.h
[modify] https://crrev.com/d19fe4ae5e66db17736f5f361d8ae77293a38365/content/renderer/service_worker/embedded_worker_devtools_agent.cc
[modify] https://crrev.com/d19fe4ae5e66db17736f5f361d8ae77293a38365/content/renderer/service_worker/embedded_worker_devtools_agent.h

Project Member

Comment 11 by bugdroid1@chromium.org, Nov 16 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e511b250c5542d23174635f5e1cb8ff812071d55

commit e511b250c5542d23174635f5e1cb8ff812071d55
Author: Dmitry Gozman <dgozman@chromium.org>
Date: Thu Nov 16 03:45:51 2017

[DevTools] Do not sniff FrameMsg_Navigate in DevToolsAgent

This will be impossible when switching to Mojo. Using a direct
call instead.

Bug:  776009 
Change-Id: I766e9d711cd1ac9f6aa7c0c08622930a493d5041
Reviewed-on: https://chromium-review.googlesource.com/772838
Commit-Queue: Dmitry Gozman <dgozman@chromium.org>
Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516972}
[modify] https://crrev.com/e511b250c5542d23174635f5e1cb8ff812071d55/content/renderer/devtools/devtools_agent.cc
[modify] https://crrev.com/e511b250c5542d23174635f5e1cb8ff812071d55/content/renderer/devtools/devtools_agent.h
[modify] https://crrev.com/e511b250c5542d23174635f5e1cb8ff812071d55/content/renderer/render_frame_impl.cc

Project Member

Comment 12 by bugdroid1@chromium.org, Nov 20 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dc7f3672754f4c758eab130200ef15ef3cef668b

commit dc7f3672754f4c758eab130200ef15ef3cef668b
Author: Dmitry Gozman <dgozman@chromium.org>
Date: Mon Nov 20 15:52:46 2017

[DevTools] Remove some usages of route_id for shared workers

This is a preparation step to migrate DevTools for shared workers to Mojo.
Drive-by: rewrite the test to use new DevToolsAgentHostObserver.

Bug:  776009 
Change-Id: Ia1f3f4952e8d8ac834a36f94c680cb81e7c50e0e
Reviewed-on: https://chromium-review.googlesource.com/777740
Commit-Queue: Dmitry Gozman <dgozman@chromium.org>
Reviewed-by: Alexei Filippov <alph@chromium.org>
Reviewed-by: Tsuyoshi Horo <horo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517832}
[modify] https://crrev.com/dc7f3672754f4c758eab130200ef15ef3cef668b/chrome/browser/devtools/devtools_sanity_browsertest.cc
[modify] https://crrev.com/dc7f3672754f4c758eab130200ef15ef3cef668b/chrome/browser/devtools/devtools_window.h
[modify] https://crrev.com/dc7f3672754f4c758eab130200ef15ef3cef668b/chrome/browser/devtools/devtools_window_testing.cc
[modify] https://crrev.com/dc7f3672754f4c758eab130200ef15ef3cef668b/chrome/browser/devtools/devtools_window_testing.h
[modify] https://crrev.com/dc7f3672754f4c758eab130200ef15ef3cef668b/content/browser/devtools/devtools_agent_host_impl.cc
[modify] https://crrev.com/dc7f3672754f4c758eab130200ef15ef3cef668b/content/browser/devtools/protocol/service_worker_handler.cc
[modify] https://crrev.com/dc7f3672754f4c758eab130200ef15ef3cef668b/content/browser/devtools/shared_worker_devtools_agent_host.cc
[modify] https://crrev.com/dc7f3672754f4c758eab130200ef15ef3cef668b/content/browser/shared_worker/shared_worker_service_impl.h
[modify] https://crrev.com/dc7f3672754f4c758eab130200ef15ef3cef668b/content/public/browser/devtools_agent_host.h
[modify] https://crrev.com/dc7f3672754f4c758eab130200ef15ef3cef668b/content/public/browser/worker_service.h

Project Member

Comment 13 by bugdroid1@chromium.org, Nov 20 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ff61d987f19dc0982aea3cbc4b858d40df2ab44d

commit ff61d987f19dc0982aea3cbc4b858d40df2ab44d
Author: Dmitry Gozman <dgozman@chromium.org>
Date: Mon Nov 20 20:09:59 2017

[DevTools] Remove more route_id usages for shared workers

This is a preparation step to migrate DevTools for shared workers to Mojo.

Bug:  776009 
Change-Id: I3960cb7ae593f5c46ef8b28b2c70b6b5d2a2e722
Reviewed-on: https://chromium-review.googlesource.com/777746
Commit-Queue: Dmitry Gozman <dgozman@chromium.org>
Reviewed-by: Alexei Filippov <alph@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517900}
[modify] https://crrev.com/ff61d987f19dc0982aea3cbc4b858d40df2ab44d/content/browser/devtools/protocol/service_worker_handler.cc
[modify] https://crrev.com/ff61d987f19dc0982aea3cbc4b858d40df2ab44d/content/browser/devtools/shared_worker_devtools_manager.cc
[modify] https://crrev.com/ff61d987f19dc0982aea3cbc4b858d40df2ab44d/content/browser/devtools/shared_worker_devtools_manager.h
[modify] https://crrev.com/ff61d987f19dc0982aea3cbc4b858d40df2ab44d/content/browser/devtools/shared_worker_devtools_manager_unittest.cc

Project Member

Comment 14 by bugdroid1@chromium.org, Nov 22 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/450e5167b5418bff2ac167d9dff8d2d7314ed268

commit 450e5167b5418bff2ac167d9dff8d2d7314ed268
Author: Dmitry Gozman <dgozman@chromium.org>
Date: Wed Nov 22 04:47:35 2017

[DevTools] Migrate DevToolsAgent from IPC to mojo

Introduced DevToolsSession interface on renderer side
(as opposite to passing session id everywhere), which works with
existing DevToolsSession on browser side.

To handle messages which can interrupt main thread on IO, we have
two sessions (one on UI thread, one on IO). See devtools.mojom for
thorough explanation.

This patch only affects render frames for now, with shared/service
workers using legacy IPC (to be converted later).

Bug:  776009 
Change-Id: I4d58382164d4e7f1e8a65316c7a6f7b8a7c5cf28
Reviewed-on: https://chromium-review.googlesource.com/737535
Commit-Queue: Dmitry Gozman <dgozman@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#518528}
[modify] https://crrev.com/450e5167b5418bff2ac167d9dff8d2d7314ed268/content/browser/devtools/devtools_agent_host_impl.cc
[modify] https://crrev.com/450e5167b5418bff2ac167d9dff8d2d7314ed268/content/browser/devtools/devtools_agent_host_impl.h
[modify] https://crrev.com/450e5167b5418bff2ac167d9dff8d2d7314ed268/content/browser/devtools/devtools_session.cc
[modify] https://crrev.com/450e5167b5418bff2ac167d9dff8d2d7314ed268/content/browser/devtools/devtools_session.h
[modify] https://crrev.com/450e5167b5418bff2ac167d9dff8d2d7314ed268/content/browser/devtools/render_frame_devtools_agent_host.cc
[modify] https://crrev.com/450e5167b5418bff2ac167d9dff8d2d7314ed268/content/browser/devtools/render_frame_devtools_agent_host.h
[modify] https://crrev.com/450e5167b5418bff2ac167d9dff8d2d7314ed268/content/common/devtools.mojom
[modify] https://crrev.com/450e5167b5418bff2ac167d9dff8d2d7314ed268/content/renderer/BUILD.gn
[modify] https://crrev.com/450e5167b5418bff2ac167d9dff8d2d7314ed268/content/renderer/devtools/devtools_agent.cc
[modify] https://crrev.com/450e5167b5418bff2ac167d9dff8d2d7314ed268/content/renderer/devtools/devtools_agent.h
[delete] https://crrev.com/675baeddc640f35516f2b57bd81521c659a34306/content/renderer/devtools/devtools_agent_filter.cc
[delete] https://crrev.com/675baeddc640f35516f2b57bd81521c659a34306/content/renderer/devtools/devtools_agent_filter.h
[modify] https://crrev.com/450e5167b5418bff2ac167d9dff8d2d7314ed268/content/renderer/render_frame_impl.cc
[modify] https://crrev.com/450e5167b5418bff2ac167d9dff8d2d7314ed268/content/renderer/render_thread_impl.cc
[modify] https://crrev.com/450e5167b5418bff2ac167d9dff8d2d7314ed268/content/renderer/render_thread_impl.h
[modify] https://crrev.com/450e5167b5418bff2ac167d9dff8d2d7314ed268/content/renderer/render_view_browsertest.cc
[modify] https://crrev.com/450e5167b5418bff2ac167d9dff8d2d7314ed268/content/renderer/service_worker/embedded_worker_devtools_agent.cc
[modify] https://crrev.com/450e5167b5418bff2ac167d9dff8d2d7314ed268/content/renderer/shared_worker/embedded_shared_worker_stub.cc
[modify] https://crrev.com/450e5167b5418bff2ac167d9dff8d2d7314ed268/third_party/WebKit/LayoutTests/http/tests/inspector-protocol/resources/inspector-protocol-test.js
[modify] https://crrev.com/450e5167b5418bff2ac167d9dff8d2d7314ed268/third_party/WebKit/Source/core/exported/WebDevToolsAgentImpl.cpp

Project Member

Comment 15 by bugdroid1@chromium.org, Dec 4 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0ea77a78397453ccb1c2662cc5338cdb23682d5a

commit 0ea77a78397453ccb1c2662cc5338cdb23682d5a
Author: Dmitry Gozman <dgozman@chromium.org>
Date: Mon Dec 04 05:52:27 2017

[DevTools] Switch shared worker inspection from routing id to SharedWorkerHost

This is a preparation to replace routing id + legacy IPC with Mojo interface
retrievable from SharedWorkerHost.

Temporarily duplicated some code from WorkerDevToolsAgentHost, which
makes it possible to migrate shared and service workers separately.

Removed a test for WORKER_STATE manipulations altogether with the state itself.

Bug:  776009 
Change-Id: Id884f4f5009eb70148251c94cae9629d5a1f6e8e
Reviewed-on: https://chromium-review.googlesource.com/783110
Commit-Queue: Dmitry Gozman <dgozman@chromium.org>
Reviewed-by: Tsuyoshi Horo <horo@chromium.org>
Reviewed-by: Alexei Filippov <alph@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521277}
[modify] https://crrev.com/0ea77a78397453ccb1c2662cc5338cdb23682d5a/content/browser/devtools/shared_worker_devtools_agent_host.cc
[modify] https://crrev.com/0ea77a78397453ccb1c2662cc5338cdb23682d5a/content/browser/devtools/shared_worker_devtools_agent_host.h
[modify] https://crrev.com/0ea77a78397453ccb1c2662cc5338cdb23682d5a/content/browser/devtools/shared_worker_devtools_manager.cc
[modify] https://crrev.com/0ea77a78397453ccb1c2662cc5338cdb23682d5a/content/browser/devtools/shared_worker_devtools_manager.h
[delete] https://crrev.com/63f56a146fbd26801b7d91fb2b7fe42c8ca42cc1/content/browser/devtools/shared_worker_devtools_manager_unittest.cc
[modify] https://crrev.com/0ea77a78397453ccb1c2662cc5338cdb23682d5a/content/browser/shared_worker/shared_worker_host.cc
[modify] https://crrev.com/0ea77a78397453ccb1c2662cc5338cdb23682d5a/content/browser/shared_worker/shared_worker_service_impl.cc
[modify] https://crrev.com/0ea77a78397453ccb1c2662cc5338cdb23682d5a/content/browser/shared_worker/shared_worker_service_impl.h
[modify] https://crrev.com/0ea77a78397453ccb1c2662cc5338cdb23682d5a/content/test/BUILD.gn

Project Member

Comment 16 by bugdroid1@chromium.org, Dec 4 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/be56c67c457dc4e733e5bd6d2bc715cadc1c6f78

commit be56c67c457dc4e733e5bd6d2bc715cadc1c6f78
Author: Ojan Vafai <ojan@chromium.org>
Date: Mon Dec 04 17:52:29 2017

Revert "[DevTools] Switch shared worker inspection from routing id to SharedWorkerHost"

This reverts commit 0ea77a78397453ccb1c2662cc5338cdb23682d5a.

Reason for revert: Caused crashing browser_tests. 

ExtensionApiTest.Debugger
ExtensionApiTestWithSwitch.ExtensionDebugger

https://ci.chromium.org/buildbot/chromium.win/Win7%20Tests%20%28dbg%29%281%29/64978

Original change's description:
> [DevTools] Switch shared worker inspection from routing id to SharedWorkerHost
> 
> This is a preparation to replace routing id + legacy IPC with Mojo interface
> retrievable from SharedWorkerHost.
> 
> Temporarily duplicated some code from WorkerDevToolsAgentHost, which
> makes it possible to migrate shared and service workers separately.
> 
> Removed a test for WORKER_STATE manipulations altogether with the state itself.
> 
> Bug:  776009 
> Change-Id: Id884f4f5009eb70148251c94cae9629d5a1f6e8e
> Reviewed-on: https://chromium-review.googlesource.com/783110
> Commit-Queue: Dmitry Gozman <dgozman@chromium.org>
> Reviewed-by: Tsuyoshi Horo <horo@chromium.org>
> Reviewed-by: Alexei Filippov <alph@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#521277}

TBR=dgozman@chromium.org,horo@chromium.org,alph@chromium.org

Change-Id: I263fe6e0f30e3c20fbb91e4a55797aadd9624775
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  776009 
Reviewed-on: https://chromium-review.googlesource.com/806814
Reviewed-by: Ojan Vafai <ojan@chromium.org>
Commit-Queue: Ojan Vafai <ojan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521381}
[modify] https://crrev.com/be56c67c457dc4e733e5bd6d2bc715cadc1c6f78/content/browser/devtools/shared_worker_devtools_agent_host.cc
[modify] https://crrev.com/be56c67c457dc4e733e5bd6d2bc715cadc1c6f78/content/browser/devtools/shared_worker_devtools_agent_host.h
[modify] https://crrev.com/be56c67c457dc4e733e5bd6d2bc715cadc1c6f78/content/browser/devtools/shared_worker_devtools_manager.cc
[modify] https://crrev.com/be56c67c457dc4e733e5bd6d2bc715cadc1c6f78/content/browser/devtools/shared_worker_devtools_manager.h
[add] https://crrev.com/be56c67c457dc4e733e5bd6d2bc715cadc1c6f78/content/browser/devtools/shared_worker_devtools_manager_unittest.cc
[modify] https://crrev.com/be56c67c457dc4e733e5bd6d2bc715cadc1c6f78/content/browser/shared_worker/shared_worker_host.cc
[modify] https://crrev.com/be56c67c457dc4e733e5bd6d2bc715cadc1c6f78/content/browser/shared_worker/shared_worker_service_impl.cc
[modify] https://crrev.com/be56c67c457dc4e733e5bd6d2bc715cadc1c6f78/content/browser/shared_worker/shared_worker_service_impl.h
[modify] https://crrev.com/be56c67c457dc4e733e5bd6d2bc715cadc1c6f78/content/test/BUILD.gn

Project Member

Comment 17 by bugdroid1@chromium.org, Dec 4 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5092d748623408480e407dd0c3ea70674330d0f0

commit 5092d748623408480e407dd0c3ea70674330d0f0
Author: Dmitry Gozman <dgozman@chromium.org>
Date: Mon Dec 04 23:27:32 2017

Reland "[DevTools] Move DevToolsFrontend implementation from content/renderer to blink"

This is a reland of b42d3973aa4df943084346a023478032a48ab4f2
Original change's description:
> [DevTools] Move DevToolsFrontend implementation from content/renderer to blink
>
> Bug:  776009 
> Change-Id: I949313b261ae074844d1da349570e1e0a8e23744
> Reviewed-on: https://chromium-review.googlesource.com/739746
> Commit-Queue: Dmitry Gozman <dgozman@chromium.org>
> Reviewed-by: Kentaro Hara <haraken@chromium.org>
> Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
> Reviewed-by: Daniel Cheng <dcheng@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#516193}

TBR=pfeldman

Bug:  776009 
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng
Change-Id: If426bbed212bc3a2f11af9fa0e019ef1dc53742d
Reviewed-on: https://chromium-review.googlesource.com/768433
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521509}
[modify] https://crrev.com/5092d748623408480e407dd0c3ea70674330d0f0/content/browser/DEPS
[modify] https://crrev.com/5092d748623408480e407dd0c3ea70674330d0f0/content/browser/devtools/devtools_frontend_host_impl.cc
[modify] https://crrev.com/5092d748623408480e407dd0c3ea70674330d0f0/content/browser/devtools/devtools_frontend_host_impl.h
[modify] https://crrev.com/5092d748623408480e407dd0c3ea70674330d0f0/content/common/devtools.mojom
[modify] https://crrev.com/5092d748623408480e407dd0c3ea70674330d0f0/content/renderer/BUILD.gn
[delete] https://crrev.com/f378a0d6495ad7f97a7cf5ad21ccaade641a4bdc/content/renderer/devtools/devtools_frontend_impl.cc
[delete] https://crrev.com/f378a0d6495ad7f97a7cf5ad21ccaade641a4bdc/content/renderer/devtools/devtools_frontend_impl.h
[modify] https://crrev.com/5092d748623408480e407dd0c3ea70674330d0f0/content/renderer/render_frame_impl.cc
[modify] https://crrev.com/5092d748623408480e407dd0c3ea70674330d0f0/third_party/WebKit/Source/controller/BUILD.gn
[modify] https://crrev.com/5092d748623408480e407dd0c3ea70674330d0f0/third_party/WebKit/Source/controller/BlinkInitializer.cpp
[modify] https://crrev.com/5092d748623408480e407dd0c3ea70674330d0f0/third_party/WebKit/Source/controller/BlinkInitializer.h
[add] https://crrev.com/5092d748623408480e407dd0c3ea70674330d0f0/third_party/WebKit/Source/controller/DevToolsFrontendImpl.cpp
[add] https://crrev.com/5092d748623408480e407dd0c3ea70674330d0f0/third_party/WebKit/Source/controller/DevToolsFrontendImpl.h
[modify] https://crrev.com/5092d748623408480e407dd0c3ea70674330d0f0/third_party/WebKit/Source/core/exported/BUILD.gn
[modify] https://crrev.com/5092d748623408480e407dd0c3ea70674330d0f0/third_party/WebKit/Source/core/exported/LocalFrameClientImpl.cpp
[delete] https://crrev.com/f378a0d6495ad7f97a7cf5ad21ccaade641a4bdc/third_party/WebKit/Source/core/exported/WebDevToolsFrontendImpl.cpp
[delete] https://crrev.com/f378a0d6495ad7f97a7cf5ad21ccaade641a4bdc/third_party/WebKit/Source/core/exported/WebDevToolsFrontendImpl.h
[modify] https://crrev.com/5092d748623408480e407dd0c3ea70674330d0f0/third_party/WebKit/Source/core/frame/WebLocalFrameImpl.cpp
[modify] https://crrev.com/5092d748623408480e407dd0c3ea70674330d0f0/third_party/WebKit/Source/core/frame/WebLocalFrameImpl.h
[modify] https://crrev.com/5092d748623408480e407dd0c3ea70674330d0f0/third_party/WebKit/Source/core/inspector/DevToolsHost.cpp
[modify] https://crrev.com/5092d748623408480e407dd0c3ea70674330d0f0/third_party/WebKit/Source/core/inspector/DevToolsHost.h
[modify] https://crrev.com/5092d748623408480e407dd0c3ea70674330d0f0/third_party/WebKit/Source/core/inspector/InspectorFrontendClient.h
[modify] https://crrev.com/5092d748623408480e407dd0c3ea70674330d0f0/third_party/WebKit/Source/modules/ModulesInitializer.h
[modify] https://crrev.com/5092d748623408480e407dd0c3ea70674330d0f0/third_party/WebKit/public/BUILD.gn
[modify] https://crrev.com/5092d748623408480e407dd0c3ea70674330d0f0/third_party/WebKit/public/platform/InterfaceRegistry.h
[delete] https://crrev.com/f378a0d6495ad7f97a7cf5ad21ccaade641a4bdc/third_party/WebKit/public/web/WebDevToolsFrontend.h
[delete] https://crrev.com/f378a0d6495ad7f97a7cf5ad21ccaade641a4bdc/third_party/WebKit/public/web/WebDevToolsFrontendClient.h
[add] https://crrev.com/5092d748623408480e407dd0c3ea70674330d0f0/third_party/WebKit/public/web/devtools_frontend.mojom

Project Member

Comment 18 by bugdroid1@chromium.org, Dec 5 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8d8c52b6bc87ced16d0833460e6f340d47c31953

commit 8d8c52b6bc87ced16d0833460e6f340d47c31953
Author: Dmitry Gozman <dgozman@chromium.org>
Date: Tue Dec 05 23:45:16 2017

Reland "[DevTools] Switch shared worker inspection from routing id to SharedWorkerHost"

This is a reland of 0ea77a78397453ccb1c2662cc5338cdb23682d5a
Original change's description:
> [DevTools] Switch shared worker inspection from routing id to SharedWorkerHost
>
> This is a preparation to replace routing id + legacy IPC with Mojo interface
> retrievable from SharedWorkerHost.
>
> Temporarily duplicated some code from WorkerDevToolsAgentHost, which
> makes it possible to migrate shared and service workers separately.
>
> Removed a test for WORKER_STATE manipulations altogether with the state itself.
>
> Bug:  776009 
> Change-Id: Id884f4f5009eb70148251c94cae9629d5a1f6e8e
> Reviewed-on: https://chromium-review.googlesource.com/783110
> Commit-Queue: Dmitry Gozman <dgozman@chromium.org>
> Reviewed-by: Tsuyoshi Horo <horo@chromium.org>
> Reviewed-by: Alexei Filippov <alph@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#521277}

TBR=alph@chromium.org, horo@chromium.org

Bug:  776009 
Change-Id: I0c0bbf56e5faf44fbf4cb7e12ea2b507c840fed2
Reviewed-on: https://chromium-review.googlesource.com/809466
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Reviewed-by: Tsuyoshi Horo <horo@chromium.org>
Commit-Queue: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521901}
[modify] https://crrev.com/8d8c52b6bc87ced16d0833460e6f340d47c31953/content/browser/devtools/shared_worker_devtools_agent_host.cc
[modify] https://crrev.com/8d8c52b6bc87ced16d0833460e6f340d47c31953/content/browser/devtools/shared_worker_devtools_agent_host.h
[modify] https://crrev.com/8d8c52b6bc87ced16d0833460e6f340d47c31953/content/browser/devtools/shared_worker_devtools_manager.cc
[modify] https://crrev.com/8d8c52b6bc87ced16d0833460e6f340d47c31953/content/browser/devtools/shared_worker_devtools_manager.h
[delete] https://crrev.com/d8d7471e05ba6777b1e78291eb00f548f7e9a28b/content/browser/devtools/shared_worker_devtools_manager_unittest.cc
[modify] https://crrev.com/8d8c52b6bc87ced16d0833460e6f340d47c31953/content/browser/shared_worker/shared_worker_host.cc
[modify] https://crrev.com/8d8c52b6bc87ced16d0833460e6f340d47c31953/content/browser/shared_worker/shared_worker_service_impl.cc
[modify] https://crrev.com/8d8c52b6bc87ced16d0833460e6f340d47c31953/content/browser/shared_worker/shared_worker_service_impl.h
[modify] https://crrev.com/8d8c52b6bc87ced16d0833460e6f340d47c31953/content/test/BUILD.gn

Project Member

Comment 19 by bugdroid1@chromium.org, Dec 15 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0688f63e2192f27b5ce05d7c1c7f9bada15b0a0e

commit 0688f63e2192f27b5ce05d7c1c7f9bada15b0a0e
Author: Dmitry Gozman <dgozman@chromium.org>
Date: Fri Dec 15 01:12:32 2017

[DevTools] Move WebKitClientMessageLoop to platform

This unblocks moving DevToolsAgent to blink.

Bug:  776009 
Change-Id: I65b30774d1057402de891acb3a5fec187b6eeee5
Reviewed-on: https://chromium-review.googlesource.com/827926
Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Commit-Queue: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524275}
[modify] https://crrev.com/0688f63e2192f27b5ce05d7c1c7f9bada15b0a0e/content/child/blink_platform_impl.cc
[modify] https://crrev.com/0688f63e2192f27b5ce05d7c1c7f9bada15b0a0e/content/child/blink_platform_impl.h
[modify] https://crrev.com/0688f63e2192f27b5ce05d7c1c7f9bada15b0a0e/content/renderer/devtools/devtools_agent.cc
[modify] https://crrev.com/0688f63e2192f27b5ce05d7c1c7f9bada15b0a0e/content/renderer/devtools/devtools_agent.h
[modify] https://crrev.com/0688f63e2192f27b5ce05d7c1c7f9bada15b0a0e/content/renderer/service_worker/service_worker_context_client.cc
[modify] https://crrev.com/0688f63e2192f27b5ce05d7c1c7f9bada15b0a0e/content/renderer/service_worker/service_worker_context_client.h
[modify] https://crrev.com/0688f63e2192f27b5ce05d7c1c7f9bada15b0a0e/content/renderer/shared_worker/embedded_shared_worker_stub.cc
[modify] https://crrev.com/0688f63e2192f27b5ce05d7c1c7f9bada15b0a0e/content/renderer/shared_worker/embedded_shared_worker_stub.h
[modify] https://crrev.com/0688f63e2192f27b5ce05d7c1c7f9bada15b0a0e/third_party/WebKit/Source/core/exported/WebDevToolsAgentImpl.cpp
[modify] https://crrev.com/0688f63e2192f27b5ce05d7c1c7f9bada15b0a0e/third_party/WebKit/Source/core/exported/WebSharedWorkerImpl.cpp
[modify] https://crrev.com/0688f63e2192f27b5ce05d7c1c7f9bada15b0a0e/third_party/WebKit/Source/core/exported/WebSharedWorkerImpl.h
[modify] https://crrev.com/0688f63e2192f27b5ce05d7c1c7f9bada15b0a0e/third_party/WebKit/Source/modules/exported/WebEmbeddedWorkerImpl.cpp
[modify] https://crrev.com/0688f63e2192f27b5ce05d7c1c7f9bada15b0a0e/third_party/WebKit/Source/modules/exported/WebEmbeddedWorkerImpl.h
[modify] https://crrev.com/0688f63e2192f27b5ce05d7c1c7f9bada15b0a0e/third_party/WebKit/public/platform/Platform.h
[modify] https://crrev.com/0688f63e2192f27b5ce05d7c1c7f9bada15b0a0e/third_party/WebKit/public/web/WebDevToolsAgentClient.h
[modify] https://crrev.com/0688f63e2192f27b5ce05d7c1c7f9bada15b0a0e/third_party/WebKit/public/web/WebSharedWorkerClient.h
[modify] https://crrev.com/0688f63e2192f27b5ce05d7c1c7f9bada15b0a0e/third_party/WebKit/public/web/modules/serviceworker/WebServiceWorkerContextClient.h

Project Member

Comment 20 by bugdroid1@chromium.org, Dec 15 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9f4c9f6d6770baf718ebc8568ffda75b77992b40

commit 9f4c9f6d6770baf718ebc8568ffda75b77992b40
Author: Dmitry Gozman <dgozman@chromium.org>
Date: Fri Dec 15 21:55:52 2017

[DevTools] Do not plumb TraceLog::SetEnabled through content

Blink can now do it directly, which unblocks moving DevToolsAgent
to blink.

Bug:  776009 
Change-Id: I4b1466005b10dd9969040803a9517e6dff18dc38
Reviewed-on: https://chromium-review.googlesource.com/827551
Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Commit-Queue: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524476}
[modify] https://crrev.com/9f4c9f6d6770baf718ebc8568ffda75b77992b40/content/renderer/devtools/devtools_agent.cc
[modify] https://crrev.com/9f4c9f6d6770baf718ebc8568ffda75b77992b40/content/renderer/devtools/devtools_agent.h
[modify] https://crrev.com/9f4c9f6d6770baf718ebc8568ffda75b77992b40/third_party/WebKit/Source/core/exported/WebDevToolsAgentImpl.cpp
[modify] https://crrev.com/9f4c9f6d6770baf718ebc8568ffda75b77992b40/third_party/WebKit/Source/core/exported/WebDevToolsAgentImpl.h
[modify] https://crrev.com/9f4c9f6d6770baf718ebc8568ffda75b77992b40/third_party/WebKit/Source/core/inspector/InspectorTracingAgent.cpp
[modify] https://crrev.com/9f4c9f6d6770baf718ebc8568ffda75b77992b40/third_party/WebKit/Source/core/inspector/InspectorTracingAgent.h
[modify] https://crrev.com/9f4c9f6d6770baf718ebc8568ffda75b77992b40/third_party/WebKit/Source/platform/instrumentation/BUILD.gn
[add] https://crrev.com/9f4c9f6d6770baf718ebc8568ffda75b77992b40/third_party/WebKit/Source/platform/instrumentation/tracing/TraceEvent.cpp
[modify] https://crrev.com/9f4c9f6d6770baf718ebc8568ffda75b77992b40/third_party/WebKit/Source/platform/instrumentation/tracing/TraceEvent.h
[modify] https://crrev.com/9f4c9f6d6770baf718ebc8568ffda75b77992b40/third_party/WebKit/public/web/WebDevToolsAgentClient.h

Project Member

Comment 21 by bugdroid1@chromium.org, Dec 15 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1f8089023f4d1a788242e6bd223716f84d04d4b9

commit 1f8089023f4d1a788242e6bd223716f84d04d4b9
Author: Dmitry Gozman <dgozman@chromium.org>
Date: Fri Dec 15 22:54:11 2017

Move manifest handling from DevToolsAgent to PageHandler

The API is now accessible from browser, so there is no need
for special handling in renderer.
This unblocks moving DevToolsAgent to blink.

Bug:  776009 
Change-Id: Ie2b96e2fa99a613cbc26ec6703afe7d940d3d3c8
Reviewed-on: https://chromium-review.googlesource.com/828292
Commit-Queue: Dmitry Gozman <dgozman@chromium.org>
Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524500}
[modify] https://crrev.com/1f8089023f4d1a788242e6bd223716f84d04d4b9/content/browser/devtools/protocol/page_handler.cc
[modify] https://crrev.com/1f8089023f4d1a788242e6bd223716f84d04d4b9/content/browser/devtools/protocol/page_handler.h
[modify] https://crrev.com/1f8089023f4d1a788242e6bd223716f84d04d4b9/content/browser/devtools/protocol_config.json
[modify] https://crrev.com/1f8089023f4d1a788242e6bd223716f84d04d4b9/content/browser/manifest/manifest_manager_host.cc
[modify] https://crrev.com/1f8089023f4d1a788242e6bd223716f84d04d4b9/content/browser/manifest/manifest_manager_host.h
[modify] https://crrev.com/1f8089023f4d1a788242e6bd223716f84d04d4b9/content/browser/web_contents/web_contents_impl.h
[modify] https://crrev.com/1f8089023f4d1a788242e6bd223716f84d04d4b9/content/renderer/devtools/devtools_agent.cc
[modify] https://crrev.com/1f8089023f4d1a788242e6bd223716f84d04d4b9/content/renderer/devtools/devtools_agent.h

Project Member

Comment 22 by bugdroid1@chromium.org, Dec 16 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c1910739a4e8bc7197c958e0c8eeef2d9767cb50

commit c1910739a4e8bc7197c958e0c8eeef2d9767cb50
Author: Dmitry Gozman <dgozman@chromium.org>
Date: Sat Dec 16 00:58:55 2017

[DevTools] Stop listening to WidgetWillClose

It was introduced to resume other pages in the same render process
when the page paused on breakpoint is closed.

This now works due to Mojo connection error handler triggering
detach automatically and unpausing as a result.

Removing content-specific code from DevToolsAgent unblocks
migrating it to blink.

Bug:  776009 
Change-Id: I20113df99a947eeaeabfb59886a07fc3f866ea27
Reviewed-on: https://chromium-review.googlesource.com/830977
Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Commit-Queue: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524541}
[modify] https://crrev.com/c1910739a4e8bc7197c958e0c8eeef2d9767cb50/content/renderer/devtools/devtools_agent.cc
[modify] https://crrev.com/c1910739a4e8bc7197c958e0c8eeef2d9767cb50/content/renderer/devtools/devtools_agent.h
[modify] https://crrev.com/c1910739a4e8bc7197c958e0c8eeef2d9767cb50/content/renderer/render_view_browsertest.cc
[add] https://crrev.com/c1910739a4e8bc7197c958e0c8eeef2d9767cb50/third_party/WebKit/LayoutTests/http/tests/inspector-protocol/target/resume-on-close-expected.txt
[add] https://crrev.com/c1910739a4e8bc7197c958e0c8eeef2d9767cb50/third_party/WebKit/LayoutTests/http/tests/inspector-protocol/target/resume-on-close.js

Project Member

Comment 23 by bugdroid1@chromium.org, Dec 16 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7c13674631f0a3ae331faceb6df9168afacf155d

commit 7c13674631f0a3ae331faceb6df9168afacf155d
Author: Dmitry Gozman <dgozman@chromium.org>
Date: Sat Dec 16 01:27:57 2017

Move DevToolsCPUThrottler to platform/scheduler

This unblocks moving DevToolsAgent to blink.

Bug:  776009 
Change-Id: Ie366481cc3913d864f773aa07007dd90aec0dc8d
Reviewed-on: https://chromium-review.googlesource.com/828145
Commit-Queue: Dmitry Gozman <dgozman@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Reviewed-by: Alexei Filippov <alph@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524554}
[modify] https://crrev.com/7c13674631f0a3ae331faceb6df9168afacf155d/content/renderer/BUILD.gn
[modify] https://crrev.com/7c13674631f0a3ae331faceb6df9168afacf155d/content/renderer/devtools/devtools_agent.cc
[modify] https://crrev.com/7c13674631f0a3ae331faceb6df9168afacf155d/content/renderer/devtools/devtools_agent.h
[delete] https://crrev.com/c2edeb5ec56ae4408928648bbb607679866add3c/content/renderer/devtools/devtools_cpu_throttler.h
[modify] https://crrev.com/7c13674631f0a3ae331faceb6df9168afacf155d/third_party/WebKit/Source/core/exported/WebDevToolsAgentImpl.cpp
[modify] https://crrev.com/7c13674631f0a3ae331faceb6df9168afacf155d/third_party/WebKit/Source/core/exported/WebDevToolsAgentImpl.h
[modify] https://crrev.com/7c13674631f0a3ae331faceb6df9168afacf155d/third_party/WebKit/Source/core/inspector/InspectorEmulationAgent.cpp
[modify] https://crrev.com/7c13674631f0a3ae331faceb6df9168afacf155d/third_party/WebKit/Source/core/inspector/InspectorEmulationAgent.h
[modify] https://crrev.com/7c13674631f0a3ae331faceb6df9168afacf155d/third_party/WebKit/Source/platform/scheduler/BUILD.gn
[modify] https://crrev.com/7c13674631f0a3ae331faceb6df9168afacf155d/third_party/WebKit/Source/platform/scheduler/DEPS
[rename] https://crrev.com/7c13674631f0a3ae331faceb6df9168afacf155d/third_party/WebKit/Source/platform/scheduler/util/thread_cpu_throttler.cc
[add] https://crrev.com/7c13674631f0a3ae331faceb6df9168afacf155d/third_party/WebKit/Source/platform/scheduler/util/thread_cpu_throttler.h
[modify] https://crrev.com/7c13674631f0a3ae331faceb6df9168afacf155d/third_party/WebKit/public/web/WebDevToolsAgentClient.h

Project Member

Comment 24 by bugdroid1@chromium.org, Dec 18 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a06d12feef1d6e0075f288703be623908dc391ad

commit a06d12feef1d6e0075f288703be623908dc391ad
Author: Dmitry Gozman <dgozman@chromium.org>
Date: Mon Dec 18 21:04:43 2017

[DevTools] Migrate DevToolsAgentTest to inspector-protocol

Since DevToolsAgent is going away, it's time to drop the tests.
Two tests already have coverage in v8-inspector, the rest are
migrated.

Bug:  776009 
Change-Id: Ide930e953b5063069e63ee0e3fef0c3c7e297d77
Reviewed-on: https://chromium-review.googlesource.com/832913
Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Commit-Queue: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524790}
[modify] https://crrev.com/a06d12feef1d6e0075f288703be623908dc391ad/content/renderer/devtools/devtools_agent.cc
[modify] https://crrev.com/a06d12feef1d6e0075f288703be623908dc391ad/content/renderer/devtools/devtools_agent.h
[modify] https://crrev.com/a06d12feef1d6e0075f288703be623908dc391ad/content/renderer/render_view_browsertest.cc
[add] https://crrev.com/a06d12feef1d6e0075f288703be623908dc391ad/third_party/WebKit/LayoutTests/inspector-protocol/page/call-frames-in-isolated-worlds-expected.txt
[add] https://crrev.com/a06d12feef1d6e0075f288703be623908dc391ad/third_party/WebKit/LayoutTests/inspector-protocol/page/call-frames-in-isolated-worlds.js
[add] https://crrev.com/a06d12feef1d6e0075f288703be623908dc391ad/third_party/WebKit/LayoutTests/inspector-protocol/page/window-open-expected.txt
[add] https://crrev.com/a06d12feef1d6e0075f288703be623908dc391ad/third_party/WebKit/LayoutTests/inspector-protocol/page/window-open.js
[add] https://crrev.com/a06d12feef1d6e0075f288703be623908dc391ad/third_party/WebKit/LayoutTests/inspector-protocol/runtime/runtime-enable-forces-contexts-expected.txt
[add] https://crrev.com/a06d12feef1d6e0075f288703be623908dc391ad/third_party/WebKit/LayoutTests/inspector-protocol/runtime/runtime-enable-forces-contexts.js
[modify] https://crrev.com/a06d12feef1d6e0075f288703be623908dc391ad/third_party/WebKit/Source/core/exported/WebDevToolsAgentImpl.cpp
[modify] https://crrev.com/a06d12feef1d6e0075f288703be623908dc391ad/third_party/WebKit/public/web/WebDevToolsAgentClient.h

Project Member

Comment 25 by bugdroid1@chromium.org, Dec 18 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f00fc33c52b5494a8bc25740bc2d7ae9e8538ea7

commit f00fc33c52b5494a8bc25740bc2d7ae9e8538ea7
Author: Dmitry Gozman <dgozman@chromium.org>
Date: Mon Dec 18 23:15:24 2017

[DevTools] Remove dependencies from content/ to DevToolsAgent

This unblocks moving DevToolsAgent to blink.

Some of them are outdated and not needed anymore.
One testing dependency is now exposed on WebLocalFrame (temporarily).

Bug:  776009 
Change-Id: I1a5ba4cbe82d23a388fe9c3142c9789dcd062e9e
Reviewed-on: https://chromium-review.googlesource.com/833306
Commit-Queue: Dmitry Gozman <dgozman@chromium.org>
Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524848}
[modify] https://crrev.com/f00fc33c52b5494a8bc25740bc2d7ae9e8538ea7/content/renderer/devtools/devtools_agent.cc
[modify] https://crrev.com/f00fc33c52b5494a8bc25740bc2d7ae9e8538ea7/content/renderer/devtools/devtools_agent.h
[modify] https://crrev.com/f00fc33c52b5494a8bc25740bc2d7ae9e8538ea7/content/renderer/render_frame_impl.cc
[modify] https://crrev.com/f00fc33c52b5494a8bc25740bc2d7ae9e8538ea7/third_party/WebKit/Source/core/exported/WebDevToolsAgentImpl.cpp
[modify] https://crrev.com/f00fc33c52b5494a8bc25740bc2d7ae9e8538ea7/third_party/WebKit/Source/core/exported/WebDevToolsAgentImpl.h
[modify] https://crrev.com/f00fc33c52b5494a8bc25740bc2d7ae9e8538ea7/third_party/WebKit/Source/core/frame/WebLocalFrameImpl.cpp
[modify] https://crrev.com/f00fc33c52b5494a8bc25740bc2d7ae9e8538ea7/third_party/WebKit/Source/core/frame/WebLocalFrameImpl.h
[modify] https://crrev.com/f00fc33c52b5494a8bc25740bc2d7ae9e8538ea7/third_party/WebKit/public/web/WebDevToolsAgent.h
[modify] https://crrev.com/f00fc33c52b5494a8bc25740bc2d7ae9e8538ea7/third_party/WebKit/public/web/WebLocalFrame.h

Project Member

Comment 26 by bugdroid1@chromium.org, Dec 20 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3955aeaced528704650850789e6fa9140aecdc1c

commit 3955aeaced528704650850789e6fa9140aecdc1c
Author: Dmitry Gozman <dgozman@chromium.org>
Date: Wed Dec 20 20:24:41 2017

[DevTools] Remove dependency on RenderWidget from DevToolsAgent

This unblocks moving DevToolsAgent to blink.

Bug:  776009 
Change-Id: I2df0db015603d6a6062f4e28eeec748067524a7f
Reviewed-on: https://chromium-review.googlesource.com/833032
Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Commit-Queue: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#525428}
[modify] https://crrev.com/3955aeaced528704650850789e6fa9140aecdc1c/content/renderer/devtools/devtools_agent.cc
[modify] https://crrev.com/3955aeaced528704650850789e6fa9140aecdc1c/third_party/WebKit/Source/core/exported/WebDevToolsAgentImpl.cpp

Project Member

Comment 27 by bugdroid1@chromium.org, Dec 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/be93b8051843e8df8eb930df31558e4ba66de5de

commit be93b8051843e8df8eb930df31558e4ba66de5de
Author: Dmitry Gozman <dgozman@chromium.org>
Date: Thu Dec 21 20:36:14 2017

[DevTools] Do not go through content when evaluating in inspector overlay

We can do it synchronously not leaving blink.
This unblocks moving DevToolsAgent to blink.

Bug:  776009 
Change-Id: I4c9fdff85e767c48431901049e5d2fd5e102f018
Reviewed-on: https://chromium-review.googlesource.com/837737
Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Commit-Queue: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#525792}
[modify] https://crrev.com/be93b8051843e8df8eb930df31558e4ba66de5de/content/shell/renderer/layout_test/blink_test_runner.cc
[modify] https://crrev.com/be93b8051843e8df8eb930df31558e4ba66de5de/content/shell/renderer/layout_test/blink_test_runner.h
[modify] https://crrev.com/be93b8051843e8df8eb930df31558e4ba66de5de/content/shell/test_runner/test_runner.cc
[modify] https://crrev.com/be93b8051843e8df8eb930df31558e4ba66de5de/content/shell/test_runner/test_runner.h
[modify] https://crrev.com/be93b8051843e8df8eb930df31558e4ba66de5de/content/shell/test_runner/web_test_delegate.h
[modify] https://crrev.com/be93b8051843e8df8eb930df31558e4ba66de5de/third_party/WebKit/Source/core/exported/LocalFrameClientImpl.cpp
[modify] https://crrev.com/be93b8051843e8df8eb930df31558e4ba66de5de/third_party/WebKit/Source/core/exported/LocalFrameClientImpl.h
[modify] https://crrev.com/be93b8051843e8df8eb930df31558e4ba66de5de/third_party/WebKit/Source/core/exported/WebDevToolsAgentImpl.cpp
[modify] https://crrev.com/be93b8051843e8df8eb930df31558e4ba66de5de/third_party/WebKit/Source/core/exported/WebDevToolsAgentImpl.h
[modify] https://crrev.com/be93b8051843e8df8eb930df31558e4ba66de5de/third_party/WebKit/Source/core/frame/LocalFrameClient.h
[modify] https://crrev.com/be93b8051843e8df8eb930df31558e4ba66de5de/third_party/WebKit/Source/core/loader/EmptyClients.h
[modify] https://crrev.com/be93b8051843e8df8eb930df31558e4ba66de5de/third_party/WebKit/Source/core/testing/Internals.cpp
[modify] https://crrev.com/be93b8051843e8df8eb930df31558e4ba66de5de/third_party/WebKit/Source/core/testing/Internals.h
[modify] https://crrev.com/be93b8051843e8df8eb930df31558e4ba66de5de/third_party/WebKit/Source/core/testing/Internals.idl
[modify] https://crrev.com/be93b8051843e8df8eb930df31558e4ba66de5de/third_party/WebKit/Source/devtools/front_end/test_runner/TestRunner.js
[modify] https://crrev.com/be93b8051843e8df8eb930df31558e4ba66de5de/third_party/WebKit/public/web/WebDevToolsAgent.h

Project Member

Comment 28 by bugdroid1@chromium.org, Dec 28 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/332ed9b38095394e776263798682a683910db172

commit 332ed9b38095394e776263798682a683910db172
Author: Dmitry Gozman <dgozman@chromium.org>
Date: Thu Dec 28 18:47:12 2017

[DevTools] Merge {Service,}WorkerDevToolsAgentHost

Drive-by:
- separate live_hosts_ from terminated_hosts_ to get manageable lifetime;
- unified instrumentation calls from service workers to devtools;
- cleaned up unused code.

Bug:  776009 
Change-Id: I6894985db45254db26331b5c0aac4a3718b9feb8
Reviewed-on: https://chromium-review.googlesource.com/845136
Commit-Queue: Dmitry Gozman <dgozman@chromium.org>
Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#526311}
[modify] https://crrev.com/332ed9b38095394e776263798682a683910db172/content/browser/BUILD.gn
[modify] https://crrev.com/332ed9b38095394e776263798682a683910db172/content/browser/devtools/protocol/network_handler.cc
[modify] https://crrev.com/332ed9b38095394e776263798682a683910db172/content/browser/devtools/protocol/network_handler.h
[modify] https://crrev.com/332ed9b38095394e776263798682a683910db172/content/browser/devtools/service_worker_devtools_agent_host.cc
[modify] https://crrev.com/332ed9b38095394e776263798682a683910db172/content/browser/devtools/service_worker_devtools_agent_host.h
[modify] https://crrev.com/332ed9b38095394e776263798682a683910db172/content/browser/devtools/service_worker_devtools_manager.cc
[modify] https://crrev.com/332ed9b38095394e776263798682a683910db172/content/browser/devtools/service_worker_devtools_manager.h
[delete] https://crrev.com/f7d23283ffc6976c677eef75d13022b1dc8aefb9/content/browser/devtools/worker_devtools_agent_host.cc
[delete] https://crrev.com/f7d23283ffc6976c677eef75d13022b1dc8aefb9/content/browser/devtools/worker_devtools_agent_host.h
[modify] https://crrev.com/332ed9b38095394e776263798682a683910db172/content/browser/service_worker/service_worker_fetch_dispatcher.cc

Project Member

Comment 29 by bugdroid1@chromium.org, Jan 3 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/57b92ce65dd6c04bf7849ccad3efcab19db1f368

commit 57b92ce65dd6c04bf7849ccad3efcab19db1f368
Author: Dmitry Gozman <dgozman@chromium.org>
Date: Wed Jan 03 01:53:27 2018

[DevTools] Move "auto open DevTools for popups" from protocol to embedder

This is an embedder feature, not the protocol one. As a side bonus,
this unblocks DevToolsAgent migration to blink.

Bug:  776009 
Change-Id: I5c8f18ec0d8f07a556a7630f0d534fbb779d7fdf
Reviewed-on: https://chromium-review.googlesource.com/837509
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Commit-Queue: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#526578}
[modify] https://crrev.com/57b92ce65dd6c04bf7849ccad3efcab19db1f368/chrome/browser/chrome_content_browser_client.cc
[modify] https://crrev.com/57b92ce65dd6c04bf7849ccad3efcab19db1f368/chrome/browser/devtools/devtools_embedder_message_dispatcher.cc
[modify] https://crrev.com/57b92ce65dd6c04bf7849ccad3efcab19db1f368/chrome/browser/devtools/devtools_embedder_message_dispatcher.h
[modify] https://crrev.com/57b92ce65dd6c04bf7849ccad3efcab19db1f368/chrome/browser/devtools/devtools_sanity_browsertest.cc
[modify] https://crrev.com/57b92ce65dd6c04bf7849ccad3efcab19db1f368/chrome/browser/devtools/devtools_ui_bindings.cc
[modify] https://crrev.com/57b92ce65dd6c04bf7849ccad3efcab19db1f368/chrome/browser/devtools/devtools_ui_bindings.h
[modify] https://crrev.com/57b92ce65dd6c04bf7849ccad3efcab19db1f368/chrome/browser/devtools/devtools_window.cc
[modify] https://crrev.com/57b92ce65dd6c04bf7849ccad3efcab19db1f368/chrome/browser/devtools/devtools_window.h
[modify] https://crrev.com/57b92ce65dd6c04bf7849ccad3efcab19db1f368/chrome/browser/devtools/devtools_window_testing.cc
[modify] https://crrev.com/57b92ce65dd6c04bf7849ccad3efcab19db1f368/chrome/browser/devtools/devtools_window_testing.h
[modify] https://crrev.com/57b92ce65dd6c04bf7849ccad3efcab19db1f368/content/browser/devtools/devtools_session.cc
[modify] https://crrev.com/57b92ce65dd6c04bf7849ccad3efcab19db1f368/content/browser/devtools/devtools_session.h
[modify] https://crrev.com/57b92ce65dd6c04bf7849ccad3efcab19db1f368/content/browser/devtools/render_frame_devtools_agent_host.cc
[modify] https://crrev.com/57b92ce65dd6c04bf7849ccad3efcab19db1f368/content/common/devtools.mojom
[modify] https://crrev.com/57b92ce65dd6c04bf7849ccad3efcab19db1f368/content/renderer/devtools/devtools_agent.cc
[modify] https://crrev.com/57b92ce65dd6c04bf7849ccad3efcab19db1f368/content/renderer/devtools/devtools_agent.h
[modify] https://crrev.com/57b92ce65dd6c04bf7849ccad3efcab19db1f368/third_party/WebKit/Source/core/exported/WebDevToolsAgentImpl.cpp
[modify] https://crrev.com/57b92ce65dd6c04bf7849ccad3efcab19db1f368/third_party/WebKit/Source/core/exported/WebDevToolsAgentImpl.h
[modify] https://crrev.com/57b92ce65dd6c04bf7849ccad3efcab19db1f368/third_party/WebKit/Source/core/inspector/InspectorPageAgent.cpp
[modify] https://crrev.com/57b92ce65dd6c04bf7849ccad3efcab19db1f368/third_party/WebKit/Source/core/inspector/InspectorPageAgent.h
[modify] https://crrev.com/57b92ce65dd6c04bf7849ccad3efcab19db1f368/third_party/WebKit/Source/core/inspector/browser_protocol.json
[modify] https://crrev.com/57b92ce65dd6c04bf7849ccad3efcab19db1f368/third_party/WebKit/Source/core/inspector/browser_protocol.pdl
[modify] https://crrev.com/57b92ce65dd6c04bf7849ccad3efcab19db1f368/third_party/WebKit/Source/core/page/CreateWindow.cpp
[modify] https://crrev.com/57b92ce65dd6c04bf7849ccad3efcab19db1f368/third_party/WebKit/Source/core/probe/CoreProbes.json5
[modify] https://crrev.com/57b92ce65dd6c04bf7849ccad3efcab19db1f368/third_party/WebKit/Source/core/probe/CoreProbes.pidl
[modify] https://crrev.com/57b92ce65dd6c04bf7849ccad3efcab19db1f368/third_party/WebKit/Source/devtools/front_end/Tests.js
[modify] https://crrev.com/57b92ce65dd6c04bf7849ccad3efcab19db1f368/third_party/WebKit/Source/devtools/front_end/devtools_compatibility.js
[modify] https://crrev.com/57b92ce65dd6c04bf7849ccad3efcab19db1f368/third_party/WebKit/Source/devtools/front_end/host/InspectorFrontendHost.js
[modify] https://crrev.com/57b92ce65dd6c04bf7849ccad3efcab19db1f368/third_party/WebKit/Source/devtools/front_end/host/InspectorFrontendHostAPI.js
[modify] https://crrev.com/57b92ce65dd6c04bf7849ccad3efcab19db1f368/third_party/WebKit/Source/devtools/front_end/main/Main.js
[modify] https://crrev.com/57b92ce65dd6c04bf7849ccad3efcab19db1f368/third_party/WebKit/public/web/WebDevToolsAgent.h
[modify] https://crrev.com/57b92ce65dd6c04bf7849ccad3efcab19db1f368/third_party/WebKit/public/web/WebDevToolsAgentClient.h

Project Member

Comment 30 by bugdroid1@chromium.org, Jan 9 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4ee6f3e8132b2bf4932fa79fc1285125c3635dec

commit 4ee6f3e8132b2bf4932fa79fc1285125c3635dec
Author: Dmitry Gozman <dgozman@chromium.org>
Date: Tue Jan 09 15:32:22 2018

[DevTools] Move DevToolsAgent to blink

WebDevToolsAgentImpl is now implementing mojom::DevToolsAgent interface.
Also added a typemap for gfx::Point to use it inside blink.

Bug:  776009 
Change-Id: Ie1d0140ab2cf013a80f14331f143803912f45d71
Reviewed-on: https://chromium-review.googlesource.com/838321
Commit-Queue: Dmitry Gozman <dgozman@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#528000}
[modify] https://crrev.com/4ee6f3e8132b2bf4932fa79fc1285125c3635dec/content/browser/DEPS
[modify] https://crrev.com/4ee6f3e8132b2bf4932fa79fc1285125c3635dec/content/browser/devtools/devtools_agent_host_impl.h
[modify] https://crrev.com/4ee6f3e8132b2bf4932fa79fc1285125c3635dec/content/browser/devtools/devtools_session.cc
[modify] https://crrev.com/4ee6f3e8132b2bf4932fa79fc1285125c3635dec/content/browser/devtools/devtools_session.h
[modify] https://crrev.com/4ee6f3e8132b2bf4932fa79fc1285125c3635dec/content/browser/devtools/render_frame_devtools_agent_host.h
[modify] https://crrev.com/4ee6f3e8132b2bf4932fa79fc1285125c3635dec/content/common/BUILD.gn
[modify] https://crrev.com/4ee6f3e8132b2bf4932fa79fc1285125c3635dec/content/renderer/BUILD.gn
[delete] https://crrev.com/f736f61c67e5d76e13a9545cfd5bed26e439e229/content/renderer/devtools/devtools_agent.cc
[delete] https://crrev.com/f736f61c67e5d76e13a9545cfd5bed26e439e229/content/renderer/devtools/devtools_agent.h
[modify] https://crrev.com/4ee6f3e8132b2bf4932fa79fc1285125c3635dec/content/renderer/render_frame_impl.cc
[modify] https://crrev.com/4ee6f3e8132b2bf4932fa79fc1285125c3635dec/content/renderer/render_frame_impl.h
[modify] https://crrev.com/4ee6f3e8132b2bf4932fa79fc1285125c3635dec/content/renderer/service_worker/embedded_worker_devtools_agent.cc
[modify] https://crrev.com/4ee6f3e8132b2bf4932fa79fc1285125c3635dec/content/shell/renderer/layout_test/blink_test_runner.cc
[modify] https://crrev.com/4ee6f3e8132b2bf4932fa79fc1285125c3635dec/third_party/WebKit/Source/core/exported/WebDevToolsAgentImpl.cpp
[modify] https://crrev.com/4ee6f3e8132b2bf4932fa79fc1285125c3635dec/third_party/WebKit/Source/core/exported/WebDevToolsAgentImpl.h
[modify] https://crrev.com/4ee6f3e8132b2bf4932fa79fc1285125c3635dec/third_party/WebKit/Source/core/exported/WebSharedWorkerImpl.cpp
[modify] https://crrev.com/4ee6f3e8132b2bf4932fa79fc1285125c3635dec/third_party/WebKit/Source/core/exported/WebSharedWorkerImpl.h
[modify] https://crrev.com/4ee6f3e8132b2bf4932fa79fc1285125c3635dec/third_party/WebKit/Source/core/exported/WorkerShadowPage.cpp
[modify] https://crrev.com/4ee6f3e8132b2bf4932fa79fc1285125c3635dec/third_party/WebKit/Source/core/exported/WorkerShadowPage.h
[modify] https://crrev.com/4ee6f3e8132b2bf4932fa79fc1285125c3635dec/third_party/WebKit/Source/core/frame/WebLocalFrameImpl.cpp
[modify] https://crrev.com/4ee6f3e8132b2bf4932fa79fc1285125c3635dec/third_party/WebKit/Source/core/frame/WebLocalFrameImpl.h
[modify] https://crrev.com/4ee6f3e8132b2bf4932fa79fc1285125c3635dec/third_party/WebKit/Source/modules/exported/WebEmbeddedWorkerImpl.cpp
[modify] https://crrev.com/4ee6f3e8132b2bf4932fa79fc1285125c3635dec/third_party/WebKit/Source/modules/exported/WebEmbeddedWorkerImpl.h
[modify] https://crrev.com/4ee6f3e8132b2bf4932fa79fc1285125c3635dec/third_party/WebKit/Source/platform/mojo/Geometry.typemap
[modify] https://crrev.com/4ee6f3e8132b2bf4932fa79fc1285125c3635dec/third_party/WebKit/Source/platform/mojo/GeometryStructTraits.cpp
[modify] https://crrev.com/4ee6f3e8132b2bf4932fa79fc1285125c3635dec/third_party/WebKit/Source/platform/mojo/GeometryStructTraits.h
[modify] https://crrev.com/4ee6f3e8132b2bf4932fa79fc1285125c3635dec/third_party/WebKit/Source/platform/mojo/GeometryStructTraitsTest.cpp
[modify] https://crrev.com/4ee6f3e8132b2bf4932fa79fc1285125c3635dec/third_party/WebKit/public/BUILD.gn
[delete] https://crrev.com/f736f61c67e5d76e13a9545cfd5bed26e439e229/third_party/WebKit/public/web/WebDevToolsAgent.h
[delete] https://crrev.com/f736f61c67e5d76e13a9545cfd5bed26e439e229/third_party/WebKit/public/web/WebDevToolsAgentClient.h
[modify] https://crrev.com/4ee6f3e8132b2bf4932fa79fc1285125c3635dec/third_party/WebKit/public/web/WebLocalFrame.h
[modify] https://crrev.com/4ee6f3e8132b2bf4932fa79fc1285125c3635dec/third_party/WebKit/public/web/WebSharedWorkerClient.h
[rename] https://crrev.com/4ee6f3e8132b2bf4932fa79fc1285125c3635dec/third_party/WebKit/public/web/devtools_agent.mojom
[modify] https://crrev.com/4ee6f3e8132b2bf4932fa79fc1285125c3635dec/third_party/WebKit/public/web/modules/serviceworker/WebServiceWorkerContextClient.h

Project Member

Comment 31 by bugdroid1@chromium.org, Jan 11 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7eea84d6f1536df242c794490b096783d812856e

commit 7eea84d6f1536df242c794490b096783d812856e
Author: Dmitry Gozman <dgozman@chromium.org>
Date: Thu Jan 11 20:08:31 2018

[DevTools] Move shared worker inspection to Mojo

WebLocalFrameImpl creates WebDevToolsAgentImpl lazily and allows
setting it externally. WorkerShadowPage in turn instantiates a
special WebDevToolsAgentImpl for workers and sets it to the main frame.

mojom::SharedWorker gets GetDevToolsAgent, which is plumbed around.

SharedWorkerDevToolsAgentHost does not use route_id, and instead uses
DevToolsAgent interface (similar to frame inspection). This makes it
possible to remove SharedWorkerDevToolsAgent and route_id from shared
workers altogether.

Bug:  776009 
Change-Id: Iedffbe0111a7b72a9bd457eaa18729f7def3130d
Reviewed-on: https://chromium-review.googlesource.com/854699
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Reviewed-by: Tsuyoshi Horo <horo@chromium.org>
Commit-Queue: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#528725}
[modify] https://crrev.com/7eea84d6f1536df242c794490b096783d812856e/content/browser/devtools/shared_worker_devtools_agent_host.cc
[modify] https://crrev.com/7eea84d6f1536df242c794490b096783d812856e/content/browser/devtools/shared_worker_devtools_agent_host.h
[modify] https://crrev.com/7eea84d6f1536df242c794490b096783d812856e/content/browser/shared_worker/shared_worker_host.cc
[modify] https://crrev.com/7eea84d6f1536df242c794490b096783d812856e/content/browser/shared_worker/shared_worker_host.h
[modify] https://crrev.com/7eea84d6f1536df242c794490b096783d812856e/content/browser/shared_worker/shared_worker_service_impl.cc
[modify] https://crrev.com/7eea84d6f1536df242c794490b096783d812856e/content/browser/shared_worker/shared_worker_service_impl_unittest.cc
[modify] https://crrev.com/7eea84d6f1536df242c794490b096783d812856e/content/common/service_worker/service_worker_provider_host_info.h
[modify] https://crrev.com/7eea84d6f1536df242c794490b096783d812856e/content/common/shared_worker/shared_worker.mojom
[modify] https://crrev.com/7eea84d6f1536df242c794490b096783d812856e/content/common/shared_worker/shared_worker_factory.mojom
[modify] https://crrev.com/7eea84d6f1536df242c794490b096783d812856e/content/renderer/BUILD.gn
[modify] https://crrev.com/7eea84d6f1536df242c794490b096783d812856e/content/renderer/service_worker/service_worker_network_provider.cc
[modify] https://crrev.com/7eea84d6f1536df242c794490b096783d812856e/content/renderer/service_worker/service_worker_network_provider.h
[modify] https://crrev.com/7eea84d6f1536df242c794490b096783d812856e/content/renderer/shared_worker/embedded_shared_worker_stub.cc
[modify] https://crrev.com/7eea84d6f1536df242c794490b096783d812856e/content/renderer/shared_worker/embedded_shared_worker_stub.h
[delete] https://crrev.com/5d2543a1086ba586a9d142caedf8fb4ef3739fb6/content/renderer/shared_worker/shared_worker_devtools_agent.cc
[delete] https://crrev.com/5d2543a1086ba586a9d142caedf8fb4ef3739fb6/content/renderer/shared_worker/shared_worker_devtools_agent.h
[modify] https://crrev.com/7eea84d6f1536df242c794490b096783d812856e/content/renderer/shared_worker/shared_worker_factory_impl.cc
[modify] https://crrev.com/7eea84d6f1536df242c794490b096783d812856e/content/renderer/shared_worker/shared_worker_factory_impl.h
[modify] https://crrev.com/7eea84d6f1536df242c794490b096783d812856e/third_party/WebKit/Source/core/exported/WebDevToolsAgentImpl.cpp
[modify] https://crrev.com/7eea84d6f1536df242c794490b096783d812856e/third_party/WebKit/Source/core/exported/WebDevToolsAgentImpl.h
[modify] https://crrev.com/7eea84d6f1536df242c794490b096783d812856e/third_party/WebKit/Source/core/exported/WebSharedWorkerImpl.cpp
[modify] https://crrev.com/7eea84d6f1536df242c794490b096783d812856e/third_party/WebKit/Source/core/exported/WebSharedWorkerImpl.h
[modify] https://crrev.com/7eea84d6f1536df242c794490b096783d812856e/third_party/WebKit/Source/core/exported/WorkerShadowPage.cpp
[modify] https://crrev.com/7eea84d6f1536df242c794490b096783d812856e/third_party/WebKit/Source/core/exported/WorkerShadowPage.h
[modify] https://crrev.com/7eea84d6f1536df242c794490b096783d812856e/third_party/WebKit/Source/core/frame/WebLocalFrameImpl.cpp
[modify] https://crrev.com/7eea84d6f1536df242c794490b096783d812856e/third_party/WebKit/Source/core/frame/WebLocalFrameImpl.h
[modify] https://crrev.com/7eea84d6f1536df242c794490b096783d812856e/third_party/WebKit/Source/modules/exported/WebEmbeddedWorkerImpl.cpp
[modify] https://crrev.com/7eea84d6f1536df242c794490b096783d812856e/third_party/WebKit/Source/modules/exported/WebEmbeddedWorkerImpl.h
[modify] https://crrev.com/7eea84d6f1536df242c794490b096783d812856e/third_party/WebKit/public/web/WebSharedWorker.h
[modify] https://crrev.com/7eea84d6f1536df242c794490b096783d812856e/third_party/WebKit/public/web/WebSharedWorkerClient.h

Project Member

Comment 32 by bugdroid1@chromium.org, Jan 13 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ca0961cb989b1157670d627165049d37e99df7fd

commit ca0961cb989b1157670d627165049d37e99df7fd
Author: Dmitry Gozman <dgozman@chromium.org>
Date: Sat Jan 13 18:38:45 2018

[DevTools] Simplify managing state in ServiceWorkerDevToolsAgentHost

Bug:  776009 
Change-Id: I43af9e59b836e97524f057e4b60559b239f254bc
Reviewed-on: https://chromium-review.googlesource.com/862989
Commit-Queue: Dmitry Gozman <dgozman@chromium.org>
Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#529176}
[modify] https://crrev.com/ca0961cb989b1157670d627165049d37e99df7fd/content/browser/devtools/protocol/target_auto_attacher.cc
[modify] https://crrev.com/ca0961cb989b1157670d627165049d37e99df7fd/content/browser/devtools/protocol/target_auto_attacher.h
[modify] https://crrev.com/ca0961cb989b1157670d627165049d37e99df7fd/content/browser/devtools/service_worker_devtools_agent_host.cc
[modify] https://crrev.com/ca0961cb989b1157670d627165049d37e99df7fd/content/browser/devtools/service_worker_devtools_agent_host.h
[modify] https://crrev.com/ca0961cb989b1157670d627165049d37e99df7fd/content/browser/devtools/service_worker_devtools_manager.cc
[modify] https://crrev.com/ca0961cb989b1157670d627165049d37e99df7fd/content/browser/devtools/service_worker_devtools_manager.h
[modify] https://crrev.com/ca0961cb989b1157670d627165049d37e99df7fd/content/browser/devtools/shared_worker_devtools_agent_host.cc
[modify] https://crrev.com/ca0961cb989b1157670d627165049d37e99df7fd/content/browser/devtools/shared_worker_devtools_agent_host.h
[modify] https://crrev.com/ca0961cb989b1157670d627165049d37e99df7fd/content/browser/devtools/shared_worker_devtools_manager.cc
[modify] https://crrev.com/ca0961cb989b1157670d627165049d37e99df7fd/content/browser/devtools/shared_worker_devtools_manager.h
[modify] https://crrev.com/ca0961cb989b1157670d627165049d37e99df7fd/third_party/WebKit/Source/core/exported/WebDevToolsAgentImpl.cpp
[modify] https://crrev.com/ca0961cb989b1157670d627165049d37e99df7fd/third_party/WebKit/Source/modules/exported/WebEmbeddedWorkerImpl.cpp

Project Member

Comment 33 by bugdroid1@chromium.org, Jan 18 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ca4539b4bbaaae51be95bd86a56e9a1c57e53da8

commit ca4539b4bbaaae51be95bd86a56e9a1c57e53da8
Author: Dmitry Gozman <dgozman@chromium.org>
Date: Thu Jan 18 00:06:23 2018

[DevTools] Migrate service worker inspection to Mojo

This follows the path of shared workers, exposing DevToolsAgent
interface for service workers and plumbing it around.

Bug:  776009 
Change-Id: I4fbbdc3c0035af9980a5b4d93da59a5c1ec05272
Reviewed-on: https://chromium-review.googlesource.com/858258
Commit-Queue: Dmitry Gozman <dgozman@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Tsuyoshi Horo <horo@chromium.org>
Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#529959}
[modify] https://crrev.com/ca4539b4bbaaae51be95bd86a56e9a1c57e53da8/content/browser/devtools/service_worker_devtools_agent_host.cc
[modify] https://crrev.com/ca4539b4bbaaae51be95bd86a56e9a1c57e53da8/content/browser/devtools/service_worker_devtools_agent_host.h
[modify] https://crrev.com/ca4539b4bbaaae51be95bd86a56e9a1c57e53da8/content/browser/devtools/service_worker_devtools_manager.cc
[modify] https://crrev.com/ca4539b4bbaaae51be95bd86a56e9a1c57e53da8/content/browser/devtools/service_worker_devtools_manager.h
[modify] https://crrev.com/ca4539b4bbaaae51be95bd86a56e9a1c57e53da8/content/browser/service_worker/embedded_worker_instance.cc
[modify] https://crrev.com/ca4539b4bbaaae51be95bd86a56e9a1c57e53da8/content/browser/service_worker/embedded_worker_test_helper.h
[modify] https://crrev.com/ca4539b4bbaaae51be95bd86a56e9a1c57e53da8/content/common/service_worker/embedded_worker.mojom
[modify] https://crrev.com/ca4539b4bbaaae51be95bd86a56e9a1c57e53da8/content/renderer/BUILD.gn
[delete] https://crrev.com/7a64fa42500c74c5f38f1f2f0deafe8c3c1887d0/content/renderer/service_worker/embedded_worker_devtools_agent.cc
[delete] https://crrev.com/7a64fa42500c74c5f38f1f2f0deafe8c3c1887d0/content/renderer/service_worker/embedded_worker_devtools_agent.h
[modify] https://crrev.com/ca4539b4bbaaae51be95bd86a56e9a1c57e53da8/content/renderer/service_worker/embedded_worker_instance_client_impl.cc
[modify] https://crrev.com/ca4539b4bbaaae51be95bd86a56e9a1c57e53da8/content/renderer/service_worker/embedded_worker_instance_client_impl.h
[modify] https://crrev.com/ca4539b4bbaaae51be95bd86a56e9a1c57e53da8/content/renderer/service_worker/service_worker_context_client.cc
[modify] https://crrev.com/ca4539b4bbaaae51be95bd86a56e9a1c57e53da8/content/renderer/service_worker/service_worker_context_client.h
[modify] https://crrev.com/ca4539b4bbaaae51be95bd86a56e9a1c57e53da8/third_party/WebKit/Source/core/exported/WebDevToolsAgentImpl.cpp
[modify] https://crrev.com/ca4539b4bbaaae51be95bd86a56e9a1c57e53da8/third_party/WebKit/Source/core/exported/WebDevToolsAgentImpl.h
[modify] https://crrev.com/ca4539b4bbaaae51be95bd86a56e9a1c57e53da8/third_party/WebKit/Source/core/exported/WebSharedWorkerImpl.cpp
[modify] https://crrev.com/ca4539b4bbaaae51be95bd86a56e9a1c57e53da8/third_party/WebKit/Source/core/exported/WebSharedWorkerImpl.h
[modify] https://crrev.com/ca4539b4bbaaae51be95bd86a56e9a1c57e53da8/third_party/WebKit/Source/core/exported/WorkerShadowPage.h
[modify] https://crrev.com/ca4539b4bbaaae51be95bd86a56e9a1c57e53da8/third_party/WebKit/Source/modules/exported/WebEmbeddedWorkerImpl.cpp
[modify] https://crrev.com/ca4539b4bbaaae51be95bd86a56e9a1c57e53da8/third_party/WebKit/Source/modules/exported/WebEmbeddedWorkerImpl.h
[modify] https://crrev.com/ca4539b4bbaaae51be95bd86a56e9a1c57e53da8/third_party/WebKit/public/web/WebEmbeddedWorker.h
[modify] https://crrev.com/ca4539b4bbaaae51be95bd86a56e9a1c57e53da8/third_party/WebKit/public/web/modules/serviceworker/WebServiceWorkerContextClient.h

Project Member

Comment 34 by bugdroid1@chromium.org, Jan 18 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/25f7db82cdb02353f31f49a1807bb1df5cbd33f8

commit 25f7db82cdb02353f31f49a1807bb1df5cbd33f8
Author: Dmitry Gozman <dgozman@chromium.org>
Date: Thu Jan 18 02:20:25 2018

[DevTools] Remove session_id in browser

This is now possible since we don't send it over IPC.

Bug:  776009 
Change-Id: I9dfa36dd461542c7699f776ecd33c8d3e890fb78
Reviewed-on: https://chromium-review.googlesource.com/866213
Commit-Queue: Dmitry Gozman <dgozman@chromium.org>
Reviewed-by: Alex Clarke <alexclarke@chromium.org>
Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#530018}
[modify] https://crrev.com/25f7db82cdb02353f31f49a1807bb1df5cbd33f8/chrome/browser/devtools/chrome_devtools_manager_delegate.cc
[modify] https://crrev.com/25f7db82cdb02353f31f49a1807bb1df5cbd33f8/chrome/browser/devtools/chrome_devtools_manager_delegate.h
[modify] https://crrev.com/25f7db82cdb02353f31f49a1807bb1df5cbd33f8/chrome/browser/devtools/chrome_devtools_session.cc
[modify] https://crrev.com/25f7db82cdb02353f31f49a1807bb1df5cbd33f8/chrome/browser/devtools/chrome_devtools_session.h
[modify] https://crrev.com/25f7db82cdb02353f31f49a1807bb1df5cbd33f8/content/browser/devtools/browser_devtools_agent_host.cc
[modify] https://crrev.com/25f7db82cdb02353f31f49a1807bb1df5cbd33f8/content/browser/devtools/browser_devtools_agent_host.h
[modify] https://crrev.com/25f7db82cdb02353f31f49a1807bb1df5cbd33f8/content/browser/devtools/devtools_agent_host_impl.cc
[modify] https://crrev.com/25f7db82cdb02353f31f49a1807bb1df5cbd33f8/content/browser/devtools/devtools_agent_host_impl.h
[modify] https://crrev.com/25f7db82cdb02353f31f49a1807bb1df5cbd33f8/content/browser/devtools/devtools_session.cc
[modify] https://crrev.com/25f7db82cdb02353f31f49a1807bb1df5cbd33f8/content/browser/devtools/devtools_session.h
[modify] https://crrev.com/25f7db82cdb02353f31f49a1807bb1df5cbd33f8/content/browser/devtools/forwarding_agent_host.cc
[modify] https://crrev.com/25f7db82cdb02353f31f49a1807bb1df5cbd33f8/content/browser/devtools/forwarding_agent_host.h
[modify] https://crrev.com/25f7db82cdb02353f31f49a1807bb1df5cbd33f8/content/browser/devtools/render_frame_devtools_agent_host.cc
[modify] https://crrev.com/25f7db82cdb02353f31f49a1807bb1df5cbd33f8/content/browser/devtools/render_frame_devtools_agent_host.h
[modify] https://crrev.com/25f7db82cdb02353f31f49a1807bb1df5cbd33f8/content/browser/devtools/service_worker_devtools_agent_host.cc
[modify] https://crrev.com/25f7db82cdb02353f31f49a1807bb1df5cbd33f8/content/browser/devtools/service_worker_devtools_agent_host.h
[modify] https://crrev.com/25f7db82cdb02353f31f49a1807bb1df5cbd33f8/content/browser/devtools/shared_worker_devtools_agent_host.cc
[modify] https://crrev.com/25f7db82cdb02353f31f49a1807bb1df5cbd33f8/content/browser/devtools/shared_worker_devtools_agent_host.h
[modify] https://crrev.com/25f7db82cdb02353f31f49a1807bb1df5cbd33f8/content/public/browser/devtools_agent_host.h
[modify] https://crrev.com/25f7db82cdb02353f31f49a1807bb1df5cbd33f8/content/public/browser/devtools_manager_delegate.cc
[modify] https://crrev.com/25f7db82cdb02353f31f49a1807bb1df5cbd33f8/content/public/browser/devtools_manager_delegate.h
[modify] https://crrev.com/25f7db82cdb02353f31f49a1807bb1df5cbd33f8/headless/lib/browser/headless_devtools_manager_delegate.cc
[modify] https://crrev.com/25f7db82cdb02353f31f49a1807bb1df5cbd33f8/headless/lib/browser/headless_devtools_manager_delegate.h
[modify] https://crrev.com/25f7db82cdb02353f31f49a1807bb1df5cbd33f8/headless/lib/browser/headless_web_contents_impl.cc
[modify] https://crrev.com/25f7db82cdb02353f31f49a1807bb1df5cbd33f8/headless/lib/browser/headless_web_contents_impl.h

Project Member

Comment 35 by bugdroid1@chromium.org, Jan 18 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ce66ffd5325f41ec2ed4fa22dc83aa61737e7831

commit ce66ffd5325f41ec2ed4fa22dc83aa61737e7831
Author: Dmitry Gozman <dgozman@chromium.org>
Date: Thu Jan 18 03:34:17 2018

[DevTools] Remove session_id from WebDevToolsAgentImpl

State related to the session moved to WebDevToolsAgentImpl::Session.

Bug:  776009 
Change-Id: Idb596a0258f93911c4544dabd1395dd0c5e3e56a
Reviewed-on: https://chromium-review.googlesource.com/868327
Commit-Queue: Dmitry Gozman <dgozman@chromium.org>
Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#530042}
[modify] https://crrev.com/ce66ffd5325f41ec2ed4fa22dc83aa61737e7831/third_party/WebKit/Source/core/exported/WebDevToolsAgentImpl.cpp
[modify] https://crrev.com/ce66ffd5325f41ec2ed4fa22dc83aa61737e7831/third_party/WebKit/Source/core/exported/WebDevToolsAgentImpl.h
[modify] https://crrev.com/ce66ffd5325f41ec2ed4fa22dc83aa61737e7831/third_party/WebKit/Source/core/inspector/InspectorSession.h

Project Member

Comment 36 by bugdroid1@chromium.org, Jan 18 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/75e645430f04b58c5b87306b6d2ffcff01653210

commit 75e645430f04b58c5b87306b6d2ffcff01653210
Author: Dmitry Gozman <dgozman@chromium.org>
Date: Thu Jan 18 13:59:32 2018

[DevTools] Rename GetDevToolsAgent to BindDevToolsAgent

Because it actually binds a request.

TBR=dcheng@chromium.org

Bug:  776009 
Change-Id: I97545fdd979cbdaf6105c4a85931da0edcf9cf5f
Reviewed-on: https://chromium-review.googlesource.com/872216
Commit-Queue: Dmitry Gozman <dgozman@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#530133}
[modify] https://crrev.com/75e645430f04b58c5b87306b6d2ffcff01653210/content/browser/devtools/shared_worker_devtools_agent_host.cc
[modify] https://crrev.com/75e645430f04b58c5b87306b6d2ffcff01653210/content/browser/service_worker/embedded_worker_instance.cc
[modify] https://crrev.com/75e645430f04b58c5b87306b6d2ffcff01653210/content/browser/service_worker/embedded_worker_test_helper.h
[modify] https://crrev.com/75e645430f04b58c5b87306b6d2ffcff01653210/content/browser/shared_worker/shared_worker_host.cc
[modify] https://crrev.com/75e645430f04b58c5b87306b6d2ffcff01653210/content/browser/shared_worker/shared_worker_host.h
[modify] https://crrev.com/75e645430f04b58c5b87306b6d2ffcff01653210/content/browser/shared_worker/shared_worker_service_impl_unittest.cc
[modify] https://crrev.com/75e645430f04b58c5b87306b6d2ffcff01653210/content/common/service_worker/embedded_worker.mojom
[modify] https://crrev.com/75e645430f04b58c5b87306b6d2ffcff01653210/content/common/shared_worker/shared_worker.mojom
[modify] https://crrev.com/75e645430f04b58c5b87306b6d2ffcff01653210/content/renderer/service_worker/embedded_worker_instance_client_impl.cc
[modify] https://crrev.com/75e645430f04b58c5b87306b6d2ffcff01653210/content/renderer/service_worker/embedded_worker_instance_client_impl.h
[modify] https://crrev.com/75e645430f04b58c5b87306b6d2ffcff01653210/content/renderer/shared_worker/embedded_shared_worker_stub.cc
[modify] https://crrev.com/75e645430f04b58c5b87306b6d2ffcff01653210/content/renderer/shared_worker/embedded_shared_worker_stub.h
[modify] https://crrev.com/75e645430f04b58c5b87306b6d2ffcff01653210/third_party/WebKit/Source/core/exported/WebSharedWorkerImpl.cpp
[modify] https://crrev.com/75e645430f04b58c5b87306b6d2ffcff01653210/third_party/WebKit/Source/core/exported/WebSharedWorkerImpl.h
[modify] https://crrev.com/75e645430f04b58c5b87306b6d2ffcff01653210/third_party/WebKit/Source/core/exported/WorkerShadowPage.cpp
[modify] https://crrev.com/75e645430f04b58c5b87306b6d2ffcff01653210/third_party/WebKit/Source/core/exported/WorkerShadowPage.h
[modify] https://crrev.com/75e645430f04b58c5b87306b6d2ffcff01653210/third_party/WebKit/Source/modules/exported/WebEmbeddedWorkerImpl.cpp
[modify] https://crrev.com/75e645430f04b58c5b87306b6d2ffcff01653210/third_party/WebKit/Source/modules/exported/WebEmbeddedWorkerImpl.h
[modify] https://crrev.com/75e645430f04b58c5b87306b6d2ffcff01653210/third_party/WebKit/public/web/WebEmbeddedWorker.h
[modify] https://crrev.com/75e645430f04b58c5b87306b6d2ffcff01653210/third_party/WebKit/public/web/WebSharedWorker.h

Project Member

Comment 37 by bugdroid1@chromium.org, Jan 18 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/face84b9e33b74eee0eb7263d4e5b5c34b32ff72

commit face84b9e33b74eee0eb7263d4e5b5c34b32ff72
Author: Dmitry Gozman <dgozman@chromium.org>
Date: Thu Jan 18 15:38:02 2018

[DevTools] Remove devtools_messages.h

All DevTools messages have switched to Mojo.

Bug:  776009 
Change-Id: I003ec93d17b03b37ac786c182979e4a2d55e4c84
Reviewed-on: https://chromium-review.googlesource.com/857957
Commit-Queue: Dmitry Gozman <dgozman@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#530146}
[modify] https://crrev.com/face84b9e33b74eee0eb7263d4e5b5c34b32ff72/content/browser/devtools/devtools_agent_host_impl.h
[modify] https://crrev.com/face84b9e33b74eee0eb7263d4e5b5c34b32ff72/content/browser/devtools/devtools_session.cc
[modify] https://crrev.com/face84b9e33b74eee0eb7263d4e5b5c34b32ff72/content/browser/devtools/devtools_session.h
[modify] https://crrev.com/face84b9e33b74eee0eb7263d4e5b5c34b32ff72/content/browser/web_contents/web_contents_android.cc
[modify] https://crrev.com/face84b9e33b74eee0eb7263d4e5b5c34b32ff72/content/common/BUILD.gn
[modify] https://crrev.com/face84b9e33b74eee0eb7263d4e5b5c34b32ff72/content/common/content_message_generator.h
[delete] https://crrev.com/7f3272e5f3164004365e4b435485d7e15067e0ac/content/common/devtools_messages.h
[modify] https://crrev.com/face84b9e33b74eee0eb7263d4e5b5c34b32ff72/content/renderer/service_worker/service_worker_context_client.cc
[modify] https://crrev.com/face84b9e33b74eee0eb7263d4e5b5c34b32ff72/ipc/ipc_message_start.h

Project Member

Comment 38 by bugdroid1@chromium.org, Jan 22 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/11473ab0085c51e624218df1e8d89dea73ac349d

commit 11473ab0085c51e624218df1e8d89dea73ac349d
Author: Dmitry Gozman <dgozman@chromium.org>
Date: Mon Jan 22 22:47:07 2018

[DevTools] Cleanup DevToolsSession

This patch moves message handling logic to DevToolsSession,
removes duplicated logic from several DevToolsAgentHost implementations
and hides multiple public methods exposed by the session.

Bug:  776009 
Change-Id: Id38a2bc2fa24591c04d9f1b0400fa522dd54d329
Reviewed-on: https://chromium-review.googlesource.com/875141
Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Commit-Queue: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#531027}
[modify] https://crrev.com/11473ab0085c51e624218df1e8d89dea73ac349d/content/browser/devtools/browser_devtools_agent_host.cc
[modify] https://crrev.com/11473ab0085c51e624218df1e8d89dea73ac349d/content/browser/devtools/browser_devtools_agent_host.h
[modify] https://crrev.com/11473ab0085c51e624218df1e8d89dea73ac349d/content/browser/devtools/devtools_agent_host_impl.cc
[modify] https://crrev.com/11473ab0085c51e624218df1e8d89dea73ac349d/content/browser/devtools/devtools_agent_host_impl.h
[modify] https://crrev.com/11473ab0085c51e624218df1e8d89dea73ac349d/content/browser/devtools/devtools_session.cc
[modify] https://crrev.com/11473ab0085c51e624218df1e8d89dea73ac349d/content/browser/devtools/devtools_session.h
[modify] https://crrev.com/11473ab0085c51e624218df1e8d89dea73ac349d/content/browser/devtools/forwarding_agent_host.cc
[modify] https://crrev.com/11473ab0085c51e624218df1e8d89dea73ac349d/content/browser/devtools/forwarding_agent_host.h
[modify] https://crrev.com/11473ab0085c51e624218df1e8d89dea73ac349d/content/browser/devtools/render_frame_devtools_agent_host.cc
[modify] https://crrev.com/11473ab0085c51e624218df1e8d89dea73ac349d/content/browser/devtools/render_frame_devtools_agent_host.h
[modify] https://crrev.com/11473ab0085c51e624218df1e8d89dea73ac349d/content/browser/devtools/service_worker_devtools_agent_host.cc
[modify] https://crrev.com/11473ab0085c51e624218df1e8d89dea73ac349d/content/browser/devtools/service_worker_devtools_agent_host.h
[modify] https://crrev.com/11473ab0085c51e624218df1e8d89dea73ac349d/content/browser/devtools/shared_worker_devtools_agent_host.cc
[modify] https://crrev.com/11473ab0085c51e624218df1e8d89dea73ac349d/content/browser/devtools/shared_worker_devtools_agent_host.h
[modify] https://crrev.com/11473ab0085c51e624218df1e8d89dea73ac349d/third_party/WebKit/Source/core/exported/WebDevToolsAgentImpl.cpp
[modify] https://crrev.com/11473ab0085c51e624218df1e8d89dea73ac349d/third_party/WebKit/Source/core/inspector/InspectorSession.cpp
[modify] https://crrev.com/11473ab0085c51e624218df1e8d89dea73ac349d/third_party/WebKit/Source/core/inspector/InspectorSession.h
[modify] https://crrev.com/11473ab0085c51e624218df1e8d89dea73ac349d/third_party/WebKit/Source/core/inspector/WorkerInspectorController.cpp

Project Member

Comment 39 by bugdroid1@chromium.org, Jan 24 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/02db93bf97c1dd68a7b17f1114d56f5fc7848e30

commit 02db93bf97c1dd68a7b17f1114d56f5fc7848e30
Author: Dmitry Gozman <dgozman@chromium.org>
Date: Wed Jan 24 03:48:22 2018

[DevTools] Make ForwardingAgentHost not use DevToolsSession

It just proxies to the delegate anyway.

Bug:  776009 
Change-Id: Ib08d4a7a9258906bab8b52ee828837f168cd7926
Reviewed-on: https://chromium-review.googlesource.com/882284
Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Commit-Queue: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#531420}
[modify] https://crrev.com/02db93bf97c1dd68a7b17f1114d56f5fc7848e30/content/browser/devtools/devtools_agent_host_impl.cc
[modify] https://crrev.com/02db93bf97c1dd68a7b17f1114d56f5fc7848e30/content/browser/devtools/devtools_agent_host_impl.h
[modify] https://crrev.com/02db93bf97c1dd68a7b17f1114d56f5fc7848e30/content/browser/devtools/devtools_session.h
[modify] https://crrev.com/02db93bf97c1dd68a7b17f1114d56f5fc7848e30/content/browser/devtools/forwarding_agent_host.cc
[modify] https://crrev.com/02db93bf97c1dd68a7b17f1114d56f5fc7848e30/content/browser/devtools/forwarding_agent_host.h

Project Member

Comment 40 by bugdroid1@chromium.org, Jan 31 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c3d46ef6a22445b9cc2e00ff33f9f98e08811677

commit c3d46ef6a22445b9cc2e00ff33f9f98e08811677
Author: Dmitry Gozman <dgozman@chromium.org>
Date: Wed Jan 31 03:15:38 2018

Introduce mojo_base.mojom.BigString

BigString uses BigBuffer internally to accomodate
large strings.

It maps to std::string and WTF::String and internally
converts data to UTF8 similary to regular string.

Bug:  776009 
Change-Id: I05547f6f55f0a20dafd6a3d99e26b5cc2cbe2eed
Reviewed-on: https://chromium-review.googlesource.com/891980
Commit-Queue: Dmitry Gozman <dgozman@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Ken Rockot <rockot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#533182}
[modify] https://crrev.com/c3d46ef6a22445b9cc2e00ff33f9f98e08811677/content/public/common/BUILD.gn
[modify] https://crrev.com/c3d46ef6a22445b9cc2e00ff33f9f98e08811677/mojo/public/cpp/base/BUILD.gn
[modify] https://crrev.com/c3d46ef6a22445b9cc2e00ff33f9f98e08811677/mojo/public/cpp/base/OWNERS
[add] https://crrev.com/c3d46ef6a22445b9cc2e00ff33f9f98e08811677/mojo/public/cpp/base/big_string.typemap
[add] https://crrev.com/c3d46ef6a22445b9cc2e00ff33f9f98e08811677/mojo/public/cpp/base/big_string_mojom_traits.cc
[add] https://crrev.com/c3d46ef6a22445b9cc2e00ff33f9f98e08811677/mojo/public/cpp/base/big_string_mojom_traits.h
[add] https://crrev.com/c3d46ef6a22445b9cc2e00ff33f9f98e08811677/mojo/public/cpp/base/big_string_unittest.cc
[modify] https://crrev.com/c3d46ef6a22445b9cc2e00ff33f9f98e08811677/mojo/public/cpp/base/typemaps.gni
[modify] https://crrev.com/c3d46ef6a22445b9cc2e00ff33f9f98e08811677/mojo/public/mojom/base/BUILD.gn
[add] https://crrev.com/c3d46ef6a22445b9cc2e00ff33f9f98e08811677/mojo/public/mojom/base/big_string.mojom
[modify] https://crrev.com/c3d46ef6a22445b9cc2e00ff33f9f98e08811677/third_party/WebKit/Source/platform/BUILD.gn
[add] https://crrev.com/c3d46ef6a22445b9cc2e00ff33f9f98e08811677/third_party/WebKit/Source/platform/mojo/BigString.typemap
[add] https://crrev.com/c3d46ef6a22445b9cc2e00ff33f9f98e08811677/third_party/WebKit/Source/platform/mojo/BigStringMojomTraits.cpp
[add] https://crrev.com/c3d46ef6a22445b9cc2e00ff33f9f98e08811677/third_party/WebKit/Source/platform/mojo/BigStringMojomTraits.h
[add] https://crrev.com/c3d46ef6a22445b9cc2e00ff33f9f98e08811677/third_party/WebKit/Source/platform/mojo/BigStringMojomTraitsTest.cpp
[modify] https://crrev.com/c3d46ef6a22445b9cc2e00ff33f9f98e08811677/third_party/WebKit/Source/platform/mojo/DEPS
[modify] https://crrev.com/c3d46ef6a22445b9cc2e00ff33f9f98e08811677/third_party/WebKit/Source/platform/mojo/OWNERS
[modify] https://crrev.com/c3d46ef6a22445b9cc2e00ff33f9f98e08811677/third_party/WebKit/Source/platform/mojo/blink_typemaps.gni

Project Member

Comment 41 by bugdroid1@chromium.org, Jan 31 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4ac95514bd5a05db7de233d3c8d085dedb5507d4

commit 4ac95514bd5a05db7de233d3c8d085dedb5507d4
Author: Dmitry Gozman <dgozman@chromium.org>
Date: Wed Jan 31 18:19:59 2018

[DevTools] Use BigString for protocol responses

We can get rid of our custom chunking.

Bug:  776009 
Change-Id: Ib5ffe7ce1e4e1b6758a5963c68fc0eedb9af8e41
Reviewed-on: https://chromium-review.googlesource.com/869191
Commit-Queue: Dmitry Gozman <dgozman@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#533333}
[modify] https://crrev.com/4ac95514bd5a05db7de233d3c8d085dedb5507d4/content/browser/devtools/devtools_session.cc
[modify] https://crrev.com/4ac95514bd5a05db7de233d3c8d085dedb5507d4/content/browser/devtools/devtools_session.h
[modify] https://crrev.com/4ac95514bd5a05db7de233d3c8d085dedb5507d4/third_party/WebKit/Source/core/exported/WebDevToolsAgentImpl.cpp
[modify] https://crrev.com/4ac95514bd5a05db7de233d3c8d085dedb5507d4/third_party/WebKit/public/web/devtools_agent.mojom

Project Member

Comment 42 by bugdroid1@chromium.org, Feb 6 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bef6f2e11041eeb6cdc6e931b7471f5f50b2a195

commit bef6f2e11041eeb6cdc6e931b7471f5f50b2a195
Author: Dmitry Gozman <dgozman@chromium.org>
Date: Tue Feb 06 06:57:49 2018

[DevTools] Split DispatchProtocoMessage into response and notification

This is a follow up to https://chromium-review.googlesource.com/869191.

Bug:  776009 
Change-Id: I6a150ad9ee794b1322168b63c921fa7f2bac9bec
Reviewed-on: https://chromium-review.googlesource.com/896578
Commit-Queue: Dmitry Gozman <dgozman@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#534649}
[modify] https://crrev.com/bef6f2e11041eeb6cdc6e931b7471f5f50b2a195/content/browser/devtools/devtools_session.cc
[modify] https://crrev.com/bef6f2e11041eeb6cdc6e931b7471f5f50b2a195/content/browser/devtools/devtools_session.h
[modify] https://crrev.com/bef6f2e11041eeb6cdc6e931b7471f5f50b2a195/third_party/WebKit/Source/core/exported/WebDevToolsAgentImpl.cpp
[modify] https://crrev.com/bef6f2e11041eeb6cdc6e931b7471f5f50b2a195/third_party/WebKit/Source/core/inspector/InspectorSession.cpp
[modify] https://crrev.com/bef6f2e11041eeb6cdc6e931b7471f5f50b2a195/third_party/WebKit/Source/core/inspector/InspectorSession.h
[modify] https://crrev.com/bef6f2e11041eeb6cdc6e931b7471f5f50b2a195/third_party/WebKit/Source/core/inspector/WorkerInspectorController.cpp
[modify] https://crrev.com/bef6f2e11041eeb6cdc6e931b7471f5f50b2a195/third_party/WebKit/Source/core/inspector/WorkerInspectorController.h
[modify] https://crrev.com/bef6f2e11041eeb6cdc6e931b7471f5f50b2a195/third_party/WebKit/public/web/devtools_agent.mojom

Comment 43 by dgozman@chromium.org, Feb 6 2018

Status: Fixed (was: Assigned)

And, this is finally done!

►

Issue 776009 link

Issue metadata

DevTools: move DevTools from IPC to Mojo

Issue description

Comment 1 by bugdroid1@chromium.org, Oct 25 2017

Comment 1 Deleted

Comment 2 by horo@chromium.org, Oct 25 2017

Comment 2 Deleted

Comment 3 by bugdroid1@chromium.org, Oct 25 2017

Comment 3 Deleted

Comment 4 by bugdroid1@chromium.org, Oct 25 2017

Comment 4 Deleted

Comment 5 by bugdroid1@chromium.org, Oct 26 2017

Comment 5 Deleted

Comment 6 by bugdroid1@chromium.org, Nov 9 2017

Comment 6 Deleted

Comment 7 by bugdroid1@chromium.org, Nov 14 2017

Comment 7 Deleted

Comment 8 by bugdroid1@chromium.org, Nov 14 2017

Comment 8 Deleted

Comment 9 by bugdroid1@chromium.org, Nov 15 2017

Comment 9 Deleted

Comment 10 by bugdroid1@chromium.org, Nov 15 2017

Comment 10 Deleted

Comment 11 by bugdroid1@chromium.org, Nov 16 2017

Comment 11 Deleted

Comment 12 by bugdroid1@chromium.org, Nov 20 2017

Comment 12 Deleted

Comment 13 by bugdroid1@chromium.org, Nov 20 2017

Comment 13 Deleted

Comment 14 by bugdroid1@chromium.org, Nov 22 2017

Comment 14 Deleted

Comment 15 by bugdroid1@chromium.org, Dec 4 2017

Comment 15 Deleted

Comment 16 by bugdroid1@chromium.org, Dec 4 2017

Comment 16 Deleted

Comment 17 by bugdroid1@chromium.org, Dec 4 2017

Comment 17 Deleted

Comment 18 by bugdroid1@chromium.org, Dec 5 2017

Comment 18 Deleted

Comment 19 by bugdroid1@chromium.org, Dec 15 2017

Comment 19 Deleted

Comment 20 by bugdroid1@chromium.org, Dec 15 2017

Comment 20 Deleted

Comment 21 by bugdroid1@chromium.org, Dec 15 2017

Comment 21 Deleted

Comment 22 by bugdroid1@chromium.org, Dec 16 2017

Comment 22 Deleted

Comment 23 by bugdroid1@chromium.org, Dec 16 2017

Comment 23 Deleted

Comment 24 by bugdroid1@chromium.org, Dec 18 2017

Comment 24 Deleted

Comment 25 by bugdroid1@chromium.org, Dec 18 2017

Comment 25 Deleted

Comment 26 by bugdroid1@chromium.org, Dec 20 2017

Comment 26 Deleted

Comment 27 by bugdroid1@chromium.org, Dec 21 2017

Comment 27 Deleted

Comment 28 by bugdroid1@chromium.org, Dec 28 2017

Comment 28 Deleted

Comment 29 by bugdroid1@chromium.org, Jan 3 2018

Comment 29 Deleted

Comment 30 by bugdroid1@chromium.org, Jan 9 2018

Comment 30 Deleted

Comment 31 by bugdroid1@chromium.org, Jan 11 2018

Comment 31 Deleted

Comment 32 by bugdroid1@chromium.org, Jan 13 2018

Comment 32 Deleted

Comment 33 by bugdroid1@chromium.org, Jan 18 2018

Comment 33 Deleted

Comment 34 by bugdroid1@chromium.org, Jan 18 2018

Comment 34 Deleted

Comment 35 by bugdroid1@chromium.org, Jan 18 2018

Comment 35 Deleted

Comment 36 by bugdroid1@chromium.org, Jan 18 2018

Comment 36 Deleted

Comment 37 by bugdroid1@chromium.org, Jan 18 2018

Comment 37 Deleted

Comment 38 by bugdroid1@chromium.org, Jan 22 2018

Comment 38 Deleted