New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 776006 link

Starred by 1 user
Status: Fixed
Owner:
█ juliatut...@chromium.org
Last visit > 30 days ago
Closed: Oct 2017
Cc:
█ dcreager@google.com
█ cbentzel@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac
Pri: 2
Type: Bug



Sign in to add a comment

Domain Reliability: check Background Sync permission before uploading

Project Member Reported by juliatut...@chromium.org, Oct 18 2017 
In preparation for configuring a few third party origins in Domain Reliability as a prototype for what will be possible with Network Error Logging, we need to give users a way to opt out of those origins sending traffic while their tabs are closed.

Therefore, I implemented https://chromium-review.googlesource.com/c/chromium/src/+/705754, which checks the Background Sync permission before starting an upload. We'd like to merge it into 63, hence this bug.

Comment 1 by juliatut...@chromium.org, Oct 18 2017

Labels: Merge-Request-63 OS-Android OS-Chrome OS-Linux OS-Mac OS-Windows
And requesting the merge -- I didn't see any relevant crashes from yesterday's canary.
Project Member

Comment 2 by sheriffbot@chromium.org, Oct 19 2017

Labels: -Merge-Request-63 Hotlist-Merge-Approved Merge-Approved-63
Your change meets the bar and is auto-approved for M63. Please go ahead and merge the CL to branch 3239 manually. Please contact milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), gkihumba@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 3 by bugdroid1@chromium.org, Oct 19 2017

Labels: -merge-approved-63 merge-merged-3239
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/47223c17e8cb124367f41cd8316f9ad67070342f

commit 47223c17e8cb124367f41cd8316f9ad67070342f
Author: Julia Tuttle <juliatuttle@chromium.org>
Date: Thu Oct 19 18:13:42 2017

Domain Reliability: Plumb into background sync.

Give users a knob to disable Domain Reliability uploads per-origin.

TBR=juliatuttle@chromium.org

(cherry picked from commit 30b16965a74f0df42d6a5b3d19041fb799515a7e)

Change-Id: If8b36470b142f7b308048025efaf43e83a54c80d
Reviewed-on: https://chromium-review.googlesource.com/705754
Commit-Queue: Julia Tuttle <juliatuttle@chromium.org>
Reviewed-by: Asanka Herath <asanka@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Reviewed-by: Nasko Oskov <nasko@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Reviewed-by: Martin Šrámek <msramek@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#509151}
Bug:  776006 
Reviewed-on: https://chromium-review.googlesource.com/728358
Reviewed-by: Julia Tuttle <juliatuttle@chromium.org>
Cr-Commit-Position: refs/branch-heads/3239@{#76}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}
[modify] https://crrev.com/47223c17e8cb124367f41cd8316f9ad67070342f/chrome/browser/browsing_data/chrome_browsing_data_remover_delegate_unittest.cc
[modify] https://crrev.com/47223c17e8cb124367f41cd8316f9ad67070342f/chrome/browser/domain_reliability/service_factory.cc
[modify] https://crrev.com/47223c17e8cb124367f41cd8316f9ad67070342f/chrome/browser/profiles/profile_impl.cc
[modify] https://crrev.com/47223c17e8cb124367f41cd8316f9ad67070342f/components/domain_reliability/BUILD.gn
[modify] https://crrev.com/47223c17e8cb124367f41cd8316f9ad67070342f/components/domain_reliability/DEPS
[modify] https://crrev.com/47223c17e8cb124367f41cd8316f9ad67070342f/components/domain_reliability/context.cc
[modify] https://crrev.com/47223c17e8cb124367f41cd8316f9ad67070342f/components/domain_reliability/context.h
[modify] https://crrev.com/47223c17e8cb124367f41cd8316f9ad67070342f/components/domain_reliability/context_unittest.cc
[modify] https://crrev.com/47223c17e8cb124367f41cd8316f9ad67070342f/components/domain_reliability/monitor.cc
[modify] https://crrev.com/47223c17e8cb124367f41cd8316f9ad67070342f/components/domain_reliability/monitor.h
[modify] https://crrev.com/47223c17e8cb124367f41cd8316f9ad67070342f/components/domain_reliability/monitor_unittest.cc
[modify] https://crrev.com/47223c17e8cb124367f41cd8316f9ad67070342f/components/domain_reliability/service.cc
[modify] https://crrev.com/47223c17e8cb124367f41cd8316f9ad67070342f/components/domain_reliability/service.h
[add] https://crrev.com/47223c17e8cb124367f41cd8316f9ad67070342f/components/domain_reliability/service_unittest.cc
[modify] https://crrev.com/47223c17e8cb124367f41cd8316f9ad67070342f/components/domain_reliability/test_util.cc
[modify] https://crrev.com/47223c17e8cb124367f41cd8316f9ad67070342f/components/domain_reliability/test_util.h
[modify] https://crrev.com/47223c17e8cb124367f41cd8316f9ad67070342f/components/domain_reliability/uploader.cc
[modify] https://crrev.com/47223c17e8cb124367f41cd8316f9ad67070342f/components/domain_reliability/uploader.h
[modify] https://crrev.com/47223c17e8cb124367f41cd8316f9ad67070342f/components/domain_reliability/uploader_unittest.cc
►

Sign in to add a comment